[GitHub] carbondata issue #2136: [CARBONDATA-2307] Fix OOM issue when using DataFrame...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2136
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3679/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4908/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[anubhav100]

Github user anubhav100 commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
retest this please




---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[anubhav100]

Github user anubhav100 commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
retest this please


---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3683/



---

[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2147
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4907/



---

[GitHub] carbondata issue #2146: [CARBONDATA-2321] Fix for selection of partion colum...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2146
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4905/



---

[GitHub] carbondata issue #2134: [CARBONDATA-2310] Refactored code to improve Distrib...

[manishgupta88]

Github user manishgupta88 commented on the issue:

https://github.com/apache/carbondata/pull/2134
  
@dhatchayani ...Merged to 1.3 branch, kindly raise the PR for master


---

[GitHub] carbondata issue #2134: [CARBONDATA-2310] Refactored code to improve Distrib...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2134
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3687/



---

[GitHub] carbondata issue #2134: [CARBONDATA-2310] Refactored code to improve Distrib...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2134
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4903/



---

[GitHub] carbondata pull request #2073: [CARBONDATA-2260] CarbonThriftServer should s...

[xubo245]

Github user xubo245 closed the pull request at:

https://github.com/apache/carbondata/pull/2073


---

[GitHub] carbondata issue #2138: [CARBONDATA-2230][Documentation]add documentation fo...

[akashrn5]

Github user akashrn5 commented on the issue:

https://github.com/apache/carbondata/pull/2138
  
retest this please


---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3688/



---

[jira] [Created] (CARBONDATA-2328) Fixed Table Alias Issue in Pre Aggregate

[kumar vishal (JIRA)]

kumar vishal created CARBONDATA-2328:


 Summary: Fixed Table Alias Issue in Pre Aggregate
 Key: CARBONDATA-2328
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2328
 Project: CarbonData
  Issue Type: Bug
Reporter: kumar vishal
Assignee: kumar vishal


*Issue:* Query with table alias is not fetching data from pre-aggregate 

*Problem:* when table has alias all the attribute reference's  qualifiers will 
have alias name, but as data map is created without alias so expression 
comparison is failing.

*Solution*: While comparing alias remove qualifiers and then compare expressions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata pull request #2153: [CARBONDATA-2328][PreAggregate] Fixed table W...

[kumarvishal09]

GitHub user kumarvishal09 opened a pull request:

https://github.com/apache/carbondata/pull/2153

[CARBONDATA-2328][PreAggregate] Fixed table With alias Issue

Issue: Query with table alias is not fetching data from pre-aggregate 

Problem: when table has alias all the attribute reference's  qualifiers 
will have alias name, but as data map is created without alias so expression 
comparison is failing.

Solution: While comparing alias remove qualifiers and then compare 
expressions

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Added UT
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kumarvishal09/incubator-carbondata 
master_PreAggStreamingFix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2153.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2153


commit 82dedc7f47a181b04e231a40d1391642481457e1
Author: kumarvishal 
Date:   2018-04-09T11:23:04Z

Fixed PreAgg streaming query issue




---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[anubhav100]

Github user anubhav100 commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
retest his please


---

[GitHub] carbondata issue #2134: [CARBONDATA-2310] Refactored code to improve Distrib...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2134
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3680/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[anubhav100]

Github user anubhav100 commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
retest this please


---

[GitHub] carbondata issue #2143: [CARBONDATA-2317] Concurrent datamap with same name ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2143
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4909/



---

[GitHub] carbondata issue #2134: [CARBONDATA-2310] Refactored code to improve Distrib...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2134
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4910/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4368/



---

[GitHub] carbondata issue #2146: [CARBONDATA-2321] Fix for selection of partion colum...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2146
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3682/



---

[GitHub] carbondata issue #2136: [CARBONDATA-2307] Fix OOM issue when using DataFrame...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2136
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4902/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4900/



---

[GitHub] carbondata issue #2136: [CARBONDATA-2307] Fix OOM issue when using DataFrame...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2136
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4369/



---

[GitHub] carbondata issue #2134: [CARBONDATA-2310] Refactored code to improve Distrib...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2134
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4370/



---

[GitHub] carbondata issue #2134: [CARBONDATA-2310] Refactored code to improve Distrib...

[manishgupta88]

Github user manishgupta88 commented on the issue:

https://github.com/apache/carbondata/pull/2134
  
LGTM


---

[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2147
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3684/



---

[GitHub] carbondata issue #2143: [CARBONDATA-2317] Concurrent datamap with same name ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2143
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3686/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3685/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[anubhav100]

Github user anubhav100 commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
@chenliang613 please review this pr


---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3677/



---

[jira] [Created] (CARBONDATA-2327) invalid schema name _system shows when executed show schemas in presto

[anubhav tarar (JIRA)]

anubhav tarar created CARBONDATA-2327:
-

 Summary: invalid schema name  _system shows when executed show 
schemas in presto
 Key: CARBONDATA-2327
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2327
 Project: CarbonData
  Issue Type: Bug
  Components: presto-integration
Affects Versions: 1.4.0
Reporter: anubhav tarar


presto> show schemas;
 Schema 

 _system 
 default 
 information_schema 
(3 rows)

Query 20180410_101915_00010_sidw4, FINISHED, 1 node
Splits: 18 total, 18 done (100.00%)
0:00 [3 rows, 47B] [25 rows/s, 395B/s]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4371/



---

[jira] [Assigned] (CARBONDATA-2155) IS NULL not working correctly on string datatype with dictionary_include in presto integration

[anubhav tarar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

anubhav tarar reassigned CARBONDATA-2155:
-

Assignee: anubhav tarar

> IS NULL not working correctly on string datatype with dictionary_include in 
> presto integration
> --
>
> Key: CARBONDATA-2155
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2155
> Project: CarbonData
>  Issue Type: Bug
>  Components: presto-integration
>Affects Versions: 1.3.0
> Environment: Spark-2.1
> Presto 0.187
>Reporter: Sangeeta Gulia
>Assignee: anubhav tarar
>Priority: Minor
> Attachments: lineitem.csv
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
> Steps to reproduce:
> 1) Create table on carbondata and load data to it.
> create table if not exists lineitem_carbon1(
> L_SHIPDATE date,
> L_SHIPMODE string,
> L_SHIPINSTRUCT string,
> L_RETURNFLAG string,
> L_RECEIPTDATE date,
> L_ORDERKEY string,
> L_PARTKEY string,
> L_SUPPKEY   string,
> L_LINENUMBER int,
> L_QUANTITY double,
> L_EXTENDEDPRICE double,
> L_DISCOUNT double,
> L_TAX double,
> L_LINESTATUS string,
> L_COMMITDATE date,
> L_COMMENT  string
> ) STORED BY 'carbondata'
> TBLPROPERTIES 
> ('DICTIONARY_INCLUDE'='L_SHIPMODE,L_SHIPINSTRUCT,L_RETURNFLAG,L_LINESTATUS', 
> 'table_blocksize'='300', 'no_inverted_index'='L_ORDERKEY, L_PARTKEY, 
> L_SUPPKEY, L_COMMENT');
> load data inpath 
> "hdfs://localhost:54310/user/hduser/input-files/lineitem.csv" into table 
> lineitem_carbon1 options('DATEFORMAT' = 
> '-MM-dd','DELIMITER'='|','FILEHEADER'='L_ORDERKEY,L_PARTKEY,L_SUPPKEY,L_LINENUMBER,L_QUANTITY,L_EXTENDEDPRICE,L_DISCOUNT,L_TAX,L_RETURNFLAG,L_LINESTATUS,L_SHIPDATE,L_COMMITDATE,L_RECEIPTDATE,L_SHIPINSTRUCT,L_SHIPMODE,L_COMMENT','BAD_RECORDS_LOGGER_ENABLE'='true',
>  'BAD_RECORDS_ACTION'='FORCE');
> 1: jdbc:hive2://localhost:1> select l_shipmode from lineitem_carbon1 
> where l_shipmode is NULL;
> +-+--+
> | l_shipmode |
> +-+--+
> | NULL |
> +-+–+
> 2) Access the same table from presto-cli and try to run select query form 
> there:
> presto:performance> select l_shipmode from lineitem_carbon1 where l_shipmode 
> is NULL;
>  l_shipmode 
> 
> (0 rows)
>  Expected Result: It should be same as result from carbon.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2147
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3689/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4911/



---

[GitHub] carbondata issue #2138: [CARBONDATA-2230][Documentation]add documentation fo...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2138
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4913/



---

[GitHub] carbondata issue #2134: [CARBONDATA-2310] Refactored code to improve Distrib...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2134
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4376/



---

[GitHub] carbondata issue #2113: [WIP][LUCENE_DATAMAP]load issue in lucene datamap, m...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2113
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3700/



---

[GitHub] carbondata issue #2127: [CARBONDATA-2301][SDK] CarbonStore interface and two...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2127
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4919/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[anubhav100]

Github user anubhav100 commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
retest this please


---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4373/



---

[GitHub] carbondata issue #2149: [CARBONDATA-2325]Page level uncompress and Improve q...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2149
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3694/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3693/



---

[GitHub] carbondata issue #2066: [CARBONDATA-2257] Added SDV test cases for Partition...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2066
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4914/



---

[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2147
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3697/



---

[GitHub] carbondata issue #2141: [CARBONDATA-2313] Fixed SDK writer issues and added ...

[ajantha-bhat]

Github user ajantha-bhat commented on the issue:

https://github.com/apache/carbondata/pull/2141
  
retest this please


---

[GitHub] carbondata issue #2146: [CARBONDATA-2321] Fix for selection of partion colum...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2146
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4372/



---

[GitHub] carbondata issue #2139: [CARBONDATA-2267] [Presto] Support Reading CarbonDat...

[anubhav100]

Github user anubhav100 commented on the issue:

https://github.com/apache/carbondata/pull/2139
  
@chenliang613


---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4916/



---

[GitHub] carbondata issue #2153: [CARBONDATA-2328][PreAggregate] Fixed table With ali...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2153
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3692/



---

[GitHub] carbondata pull request #2154: [WIP] Non Serializable extra info in session ...

[KanakaKumar]

GitHub user KanakaKumar opened a pull request:

https://github.com/apache/carbondata/pull/2154

[WIP] Non Serializable extra info in session is overwritten from stale 
thread

Problem:
 1. Non Serializable extra info is copied from thread which causes 
stale data from old session when the thread is reused by spark.
 2. CarboSessionInfo clone is not copying Non serializable info to 
new object which can damage session level values if local query thread updates 
values.

Solution: Remove logic to copy Non Serializable extra info and fix clone 
logic

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 No
 - [ ] Any backward compatibility impacted?
 No
 - [ ] Document update required?
No
 - [ ] Testing done
Tested in local cluster   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
NA


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/KanakaKumar/carbondata master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2154.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2154


commit 1cfabf53226ddfe1143359de24ddbbc75cdf396b
Author: KanakaKumar 
Date:   2018-04-10T14:12:30Z

Problem: 1. Non Serializable extra info is copied from thread which causes 
stale data from old session when the thread is reused by spark.
 2. CarboSessionInfo clone is not copying Non serializable info to 
new object which can damage session level values if local query thread updates 
values.

Solution: Remove logic to copy Non Serializable extra info and fix clone 
logic




---

[GitHub] carbondata issue #2127: [CARBONDATA-2301][SDK] CarbonStore interface and two...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2127
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3699/



---

[GitHub] carbondata issue #2143: [CARBONDATA-2317] Concurrent datamap with same name ...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2143
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4375/



---

[jira] [Created] (CARBONDATA-2329) Non Serializable extra info in session is overwritten by values from thread

[Kanaka Kumar Avvaru (JIRA)]

Kanaka Kumar Avvaru created CARBONDATA-2329:
---

 Summary: Non Serializable extra info in session is overwritten by 
values from thread
 Key: CARBONDATA-2329
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2329
 Project: CarbonData
  Issue Type: Bug
  Components: core, spark-integration
Affects Versions: 1.3.0
Reporter: Kanaka Kumar Avvaru
Assignee: Kanaka Kumar Avvaru


1. Non Serializable extra info is copied from thread which causes stale data 
from old session when the thread is reused by spark.
 2. CarboSessionInfo clone is not copying Non serializable info to new object 
which can damage session level values if local query thread updates values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2147
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4912/



---

[GitHub] carbondata issue #2066: [CARBONDATA-2257] Added SDV test cases for Partition...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2066
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3691/



---

[GitHub] carbondata issue #2149: [CARBONDATA-2325]Page level uncompress and Improve q...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2149
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4917/



---

[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2147
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4918/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[anubhav100]

Github user anubhav100 commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
retest this please




---

[GitHub] carbondata issue #2138: [CARBONDATA-2230][Documentation]add documentation fo...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2138
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3690/



---

[GitHub] carbondata issue #2153: [CARBONDATA-2328][PreAggregate] Fixed table With ali...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2153
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4915/



---

[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2147
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4374/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3696/



---

[GitHub] carbondata issue #2113: [WIP][LUCENE_DATAMAP]load issue in lucene datamap, m...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2113
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3705/



---

[GitHub] carbondata issue #2141: [CARBONDATA-2313] Fixed SDK writer issues and added ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2141
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3704/



---

[GitHub] carbondata issue #2153: [CARBONDATA-2328][PreAggregate] Fixed table With ali...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2153
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4920/



---

[GitHub] carbondata issue #2113: [WIP][LUCENE_DATAMAP]load issue in lucene datamap, m...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2113
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3706/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4377/



---

[GitHub] carbondata issue #2152: [CARBONDATA-2155][CARBONDATA-2152] [Presto] Fixed IS...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2152
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4921/



---

[GitHub] carbondata issue #2154: [CARBONDATA-2329] Non Serializable extra info in ses...

[KanakaKumar]

Github user KanakaKumar commented on the issue:

https://github.com/apache/carbondata/pull/2154
  
retest this please


---

[GitHub] carbondata issue #2153: [CARBONDATA-2328][PreAggregate] Fixed table With ali...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2153
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4381/



---

[GitHub] carbondata issue #2141: [CARBONDATA-2313] Fixed SDK writer issues and added ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2141
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4925/



---

[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2147
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4382/



---

[GitHub] carbondata issue #2154: [CARBONDATA-2329] Non Serializable extra info in ses...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2154
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3707/



---

[jira] [Created] (CARBONDATA-2331) DataMapStoreManager#getDataMap shouldn't lock on interned String

[Ted Yu (JIRA)]

Ted Yu created CARBONDATA-2331:
--

 Summary: DataMapStoreManager#getDataMap shouldn't lock on interned 
String
 Key: CARBONDATA-2331
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2331
 Project: CarbonData
  Issue Type: Bug
Reporter: Ted Yu


{code}
  synchronized (tableUniqueName.intern()) {
{code}
Please see the 'Noncompliant Code Example (Interned String Object)' section 
under:
https://wiki.sei.cmu.edu/confluence/display/java/LCK01-J.+Do+not+synchronize+on+objects+that+may+be+reused



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata issue #2113: [WIP][LUCENE_DATAMAP]load issue in lucene datamap, m...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2113
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3708/



---

[GitHub] carbondata issue #2154: [CARBONDATA-2329] Non Serializable extra info in ses...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2154
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4928/



---

[GitHub] carbondata issue #2154: [CARBONDATA-2329] Non Serializable extra info in ses...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2154
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4924/



---

[GitHub] carbondata issue #2113: [WIP][LUCENE_DATAMAP]load issue in lucene datamap, m...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2113
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4926/



---

[jira] [Created] (CARBONDATA-2330) DataInputStream should be closed in finally block in SegmentIndexFileStore#readIndexFile

[Ted Yu (JIRA)]

Ted Yu created CARBONDATA-2330:
--

 Summary: DataInputStream should be closed in finally block in 
SegmentIndexFileStore#readIndexFile
 Key: CARBONDATA-2330
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2330
 Project: CarbonData
  Issue Type: Bug
Reporter: Ted Yu


{code}
DataInputStream dataInputStream =
FileFactory.getDataInputStream(indexFilePath, 
FileFactory.getFileType(indexFilePath));
byte[] bytes = new byte[(int) indexFile.getSize()];
dataInputStream.readFully(bytes);
...
dataInputStream.close();
{code}
The close call should be placed inside finally block.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata issue #2154: [CARBONDATA-2329] Non Serializable extra info in ses...

[KanakaKumar]

Github user KanakaKumar commented on the issue:

https://github.com/apache/carbondata/pull/2154
  
retest this please


---

[jira] [Created] (CARBONDATA-2332) Potentially overflowing expression in UnsafeFixLengthColumnPage

[Ted Yu (JIRA)]

Ted Yu created CARBONDATA-2332:
--

 Summary: Potentially overflowing expression in 
UnsafeFixLengthColumnPage
 Key: CARBONDATA-2332
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2332
 Project: CarbonData
  Issue Type: Bug
Reporter: Ted Yu


Here is one example from getFloatPage :
{code}
for (int i = 0; i < data.length; i++) {
  long offset = i << floatBits;
{code}
The shift expression with type "int" (32 bits, signed) is evaluated using 
32-bit arithmetic.
But the variable offset is of type long.

There are a few other shift expressions of this nature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata issue #2149: [CARBONDATA-2325]Page level uncompress and Improve q...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2149
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4383/



---

[GitHub] carbondata issue #2153: [CARBONDATA-2328][PreAggregate] Fixed table With ali...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2153
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3701/



---

[GitHub] carbondata issue #2066: [CARBONDATA-2257] Added SDV test cases for Partition...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2066
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4379/



---

[GitHub] carbondata issue #2154: [CARBONDATA-2329] Non Serializable extra info in ses...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2154
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3703/



---

[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2147
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4378/



---

[GitHub] carbondata issue #2113: [WIP][LUCENE_DATAMAP]load issue in lucene datamap, m...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2113
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4923/



---

[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2147
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4922/



---

[GitHub] carbondata issue #2066: [CARBONDATA-2257] Added SDV test cases for Partition...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2066
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4380/



---

[GitHub] carbondata issue #2153: [CARBONDATA-2328][PreAggregate] Fixed table With ali...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2153
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4387/



---

[GitHub] carbondata issue #2141: [CARBONDATA-2313] Fixed SDK writer issues and added ...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2141
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4388/



---

[GitHub] carbondata pull request #2139: [CARBONDATA-2267] [Presto] Support Reading Ca...

[chenliang613]

Github user chenliang613 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2139#discussion_r180553823
  
--- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java
 ---
@@ -69,6 +72,13 @@
 
   private static Map filterMap = new HashMap<>();
 
+  private final static String HIVE_DEFAULT_DYNAMIC_PARTITION = 
"__HIVE_DEFAULT_PARTITION__";
--- End diff --

can you explain, why need to add "HIVE_DEFAULT_DYNAMIC_PARTITION" ? what 
purpose?
if (value == null) {
filter.add(carbonDataColumnHandle.getColumnName() + "=" + 
HIVE_DEFAULT_DYNAMIC_PARTITION);


---

[GitHub] carbondata issue #2127: [CARBONDATA-2301][SDK] CarbonStore interface and two...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2127
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4384/



---

[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2147
  
SDV Build Success , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4385/



---

[GitHub] carbondata issue #2113: [WIP][LUCENE_DATAMAP]load issue in lucene datamap, m...

[ravipesala]

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2113
  
SDV Build Fail , Please check CI 
http://144.76.159.231:8080/job/ApacheSDVTests/4386/



---

[GitHub] carbondata issue #2154: [CARBONDATA-2329] Non Serializable extra info in ses...

[CarbonDataQA]

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2154
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3709/



---

[GitHub] carbondata pull request #2139: [CARBONDATA-2267] [Presto] Support Reading Ca...

[chenliang613]

Github user chenliang613 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2139#discussion_r180554217
  
--- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/PrestoFilterUtil.java
 ---
@@ -69,6 +72,13 @@
 
   private static Map filterMap = new HashMap<>();
 
+  private final static String HIVE_DEFAULT_DYNAMIC_PARTITION = 
"__HIVE_DEFAULT_PARTITION__";
+  private final static String PARTITION_VALUE_WILDCARD = "";
--- End diff --

Why need to add "wildcard" for partition filter?


---