[GitHub] carbondata issue #2730: [WIP] Performance improvements for Fileformat and Pr...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2730
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8651/



---


[GitHub] carbondata issue #2730: [WIP] Performance improvements for Fileformat and Pr...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2730
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/581/



---


[GitHub] carbondata issue #2730: [WIP] Performance improvements for Fileformat and Pr...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2730
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/402/



---


[GitHub] carbondata issue #2730: [WIP] Performance improvements for Fileformat and Pr...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2730
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8650/



---


[GitHub] carbondata issue #2730: [WIP] Performance improvements for Fileformat and Pr...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2730
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/580/



---


[GitHub] carbondata pull request #2748: [CARBONDATA-2959] Added validations for TABLE...

2018-09-21 Thread ravipesala
Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2748#discussion_r219658382
  
--- Diff: 
integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonSparkDataSourceUtil.scala
 ---
@@ -269,4 +273,99 @@ object CarbonSparkDataSourceUtil {
 }
 model
   }
+
+  def validateTableOptions(options: Map[String, String], schema: Schema): 
Unit = {
+
+if (options.contains(CarbonCommonConstants.DICTIONARY_EXCLUDE)) {
--- End diff --

NO need of this validation. it does not support here. Please remove. 


---


[GitHub] carbondata issue #2736: [CARBONDATA-2947] Adaptive encoding support for time...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2736
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8649/



---


[GitHub] carbondata issue #2745: [CARBONDATA-2958] Compaction with CarbonProperty 'ca...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2745
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/578/



---


[GitHub] carbondata issue #2736: [CARBONDATA-2947] Adaptive encoding support for time...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2736
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/579/



---


[GitHub] carbondata issue #2745: [CARBONDATA-2958] Compaction with CarbonProperty 'ca...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2745
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8648/



---


[GitHub] carbondata issue #2749: [WIP] simplify SDK API interfaces

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2749
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/577/



---


[GitHub] carbondata issue #2736: [CARBONDATA-2947] Adaptive encoding support for time...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2736
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/401/



---


[GitHub] carbondata issue #2749: [WIP] simplify SDK API interfaces

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2749
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8647/



---


[GitHub] carbondata issue #2745: [CARBONDATA-2958] Compaction with CarbonProperty 'ca...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2745
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/400/



---


[jira] [Resolved] (CARBONDATA-2950) Alter table add columns fails for hive table in carbon session for spark version above 2.1

2018-09-21 Thread kumar vishal (JIRA)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

kumar vishal resolved CARBONDATA-2950.
--
Resolution: Fixed

> Alter table add columns fails for hive table in carbon session for spark 
> version above 2.1
> --
>
> Key: CARBONDATA-2950
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2950
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Akash R Nilugal
>Assignee: Akash R Nilugal
>Priority: Minor
>  Time Spent: 3.5h
>  Remaining Estimate: 0h
>
> spark does not support add columns in spark-2.1, but it is supported in 2.2 
> and above
> when add column is fired for hive table in carbon session, for spark -version 
> above 2.1, it throws error as unsupported operation on hive table



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata pull request #2735: [CARBONDATA-2950]alter add column of hive tab...

2018-09-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2735


---


[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

2018-09-21 Thread kumarvishal09
Github user kumarvishal09 commented on the issue:

https://github.com/apache/carbondata/pull/2735
  
LGTM


---


[GitHub] carbondata issue #2745: [CARBONDATA-2958] Compaction with CarbonProperty 'ca...

2018-09-21 Thread Indhumathi27
Github user Indhumathi27 commented on the issue:

https://github.com/apache/carbondata/pull/2745
  
Retest this please


---


[GitHub] carbondata issue #2749: [WIP] simplify SDK API interfaces

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2749
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/399/



---


[GitHub] carbondata pull request #2749: [WIP] simplify SDK API interfaces

2018-09-21 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request:

https://github.com/apache/carbondata/pull/2749

[WIP] simplify SDK API interfaces

[WIP] simplify SDK API interfaces
Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ajantha-bhat/carbondata sdk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2749.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2749


commit b56a71146cc865bb37b3a140f5328639d069ac6c
Author: ajantha-bhat 
Date:   2018-09-21T11:02:56Z

remove AK SK

commit b44b76b100fe90282b9470f63149549b42c3c89e
Author: ajantha-bhat 
Date:   2018-09-21T12:24:34Z

withHadoopconf and withThreads

commit d565845a38af9fbfaa08acf9063427a00aa9ba0b
Author: ajantha-bhat 
Date:   2018-09-21T15:31:59Z

build API changes




---


[GitHub] carbondata pull request #2739: [CARBONDATA-2954]Fix error when create extern...

2018-09-21 Thread ajantha-bhat
Github user ajantha-bhat commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2739#discussion_r219531131
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -2226,7 +2226,11 @@ public static String 
getFilePathExternalFilePath(String path, Configuration conf
   if 
(dataFile.getName().endsWith(CarbonCommonConstants.FACT_FILE_EXT)) {
 return dataFile.getAbsolutePath();
   } else if (dataFile.isDirectory()) {
-return getFilePathExternalFilePath(dataFile.getAbsolutePath(), 
configuration);
+if (getFilePathExternalFilePath(dataFile.getAbsolutePath(), 
configuration) == null) {
--- End diff --

Please  add/modify existing test case to handle this scenario

Also please test query with an empty folder. we have other places in the 
code where we recursively read.
Review and handle if a problem exists in that flow.

example:
CarbonTable.getFirstIndexFile --> also has same issue


 


---


[GitHub] carbondata issue #2748: [CARBONDATA-2959] Added validations for TABLE OPTION...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2748
  
Can one of the admins verify this patch?


---


[GitHub] carbondata pull request #2748: [CARBONDATA-2959] Added validations for TABLE...

2018-09-21 Thread NamanRastogi
GitHub user NamanRastogi opened a pull request:

https://github.com/apache/carbondata/pull/2748

[CARBONDATA-2959] Added validations for TABLE OPTIONS

create table validations are added for table OPTIONS while table is created 
using:
```
CREATE TABLE  (  )
USING carbon
OPTIONS (  )
```
As the validations cannot be done at the table creation, it has to be done 
while loading data.

Validations are done for LONG_STRING_COLUMNS, DICTIONARY_INCLUDE, 
DICTIONARY_EXCLUDE, and NO_INVERTED_INDEX

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [x] Testing done
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/NamanRastogi/carbondata b06

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2748.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2748


commit 477e6faaaf619645b5ff6cf66a09926dd6eb
Author: Naman Rastogi 
Date:   2018-09-21T14:49:00Z

Added validation for 'LONG_STRING_COLUMNS' while using 'USING CARBON' to 
create table




---


[GitHub] carbondata issue #2745: [CARBONDATA-2958] Compaction with CarbonProperty 'ca...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2745
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8646/



---


[GitHub] carbondata issue #2745: [CARBONDATA-2958] Compaction with CarbonProperty 'ca...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2745
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/576/



---


[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2735
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/575/



---


[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2735
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8645/



---


[GitHub] carbondata issue #2738: [CARBONDATA-2952] Provide c++ interface for SDK Carb...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2738
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/573/



---


[GitHub] carbondata issue #2738: [CARBONDATA-2952] Provide c++ interface for SDK Carb...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2738
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8643/



---


[GitHub] carbondata issue #2747: [CARBONDATA-2960] SDK Reader fix with projection col...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2747
  
Can one of the admins verify this patch?


---


[GitHub] carbondata pull request #2747: [CARBONDATA-2960] SDK Reader fix with project...

2018-09-21 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request:

https://github.com/apache/carbondata/pull/2747

[CARBONDATA-2960] SDK Reader fix with projection columns

SDK Reader was not working when all projection columns were given.
Added exception for Complex child projections too.

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [x] Testing done
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/manishnalla1994/carbondata reader_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2747.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2747


commit 1c458df5ca3c274a3028bc8263c9b2758588c4e6
Author: Manish Nalla 
Date:   2018-09-21T13:54:01Z

SDK Reader with Default Projection

commit b684ab22d42d749364de8a46317b4c43a2d67d2c
Author: Manish Nalla 
Date:   2018-09-21T14:05:38Z

SDK Reader with Default Projection(1)




---


[GitHub] carbondata issue #2745: [CARBONDATA-2958] Compaction with CarbonProperty 'ca...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2745
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/398/



---


[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2735
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/397/



---


[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

2018-09-21 Thread kumarvishal09
Github user kumarvishal09 commented on the issue:

https://github.com/apache/carbondata/pull/2735
  
retest this please


---


[GitHub] carbondata pull request #2745: [CARBONDATA-2958] Compaction with CarbonPrope...

2018-09-21 Thread kumarvishal09
Github user kumarvishal09 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2745#discussion_r219496698
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/dimension/v3/CompressedDimensionChunkFileBasedReaderV3.java
 ---
@@ -289,6 +289,10 @@ private DimensionColumnPage 
decodeDimensionLegacy(DimensionRawColumnChunk rawCol
 int[] rlePage;
 int[] invertedIndexes = new int[0];
 int[] invertedIndexesReverse = new int[0];
+if (compressor == null) {
--- End diff --

Move this logic to 
CompressedDimChunkFileBasedPageLevelReaderV3.decodeColumnPage please refer 
CompressedDimensionChunkFileBasedReaderV3 .decodeColumnPage 


---


[jira] [Resolved] (CARBONDATA-2953) Dataload fails when sort column is given, and query returns null value from another session

2018-09-21 Thread kumar vishal (JIRA)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

kumar vishal resolved CARBONDATA-2953.
--
Resolution: Fixed

> Dataload fails when sort column is given, and query returns null value from 
> another session
> ---
>
> Key: CARBONDATA-2953
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2953
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Akash R Nilugal
>Assignee: Akash R Nilugal
>Priority: Minor
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> # when dataload is done with sort columns, it fails with following exeptions
> java.lang.ClassCastException: java.lang.Integer cannot be cast to [B
>  at 
> org.apache.carbondata.processing.sort.sortdata.IntermediateSortTempRowComparator.compare(IntermediateSortTempRowComparator.java:71)
>  at 
> org.apache.carbondata.processing.loading.sort.unsafe.holder.UnsafeInmemoryHolder.compareTo(UnsafeInmemoryHolder.java:71)
>  at 
> org.apache.carbondata.processing.loading.sort.unsafe.holder.UnsafeInmemoryHolder.compareTo(UnsafeInmemoryHolder.java:26)
>  at java.util.PriorityQueue.siftUpComparable(PriorityQueue.java:656)
>  at java.util.PriorityQueue.siftUp(PriorityQueue.java:647)
>  at java.util.PriorityQueue.offer(PriorityQueue.java:344)
>  at java.util.PriorityQueue.add(PriorityQueue.java:321)
>  at 
> org.apache.carbondata.processing.loading.sort.unsafe.merger.UnsafeSingleThreadFinalSortFilesMerger.startSorting(UnsafeSingleThreadFinalSortFilesMerger.java:129)
>  at 
> org.apache.carbondata.processing.loading.sort.unsafe.merger.UnsafeSingleThreadFinalSortFilesMerger.startFinalMerge(UnsafeSingleThreadFinalSortFilesMerger.java:94)
>  at 
> org.apache.carbondata.processing.loading.sort.impl.UnsafeParallelReadMergeSorterImpl.sort(UnsafeParallelReadMergeSorterImpl.java:110)
>  at 
> org.apache.carbondata.processing.loading.steps.SortProcessorStepImpl.execute(SortProcessorStepImpl.java:55)
>  at 
> org.apache.carbondata.processing.loading.steps.DataWriterProcessorStepImpl.execute(DataWriterProcessorStepImpl.java:112)
>  at 
> org.apache.carbondata.processing.loading.DataLoadExecutor.execute(DataLoadExecutor.java:51)
>  at 
> org.apache.carbondata.spark.rdd.NewCarbonDataLoadRDD$$anon$1.(NewCarbonDataLoadRDD.scala:212)
>  at 
> org.apache.carbondata.spark.rdd.NewCarbonDataLoadRDD.internalCompute(NewCarbonDataLoadRDD.scala:188)
>  at org.apache.carbondata.spark.rdd.CarbonRDD.compute(CarbonRDD.scala:78)
>  at org.apache.spark.rdd.RDD.computeOrReadCheckpoint(RDD.scala:324)
>  # when two sessions are running in parallel, the follow below steps in 
> session1
>  ## drop table
>  ## create table
>  ## load data to table
>  # follow below step in session2
>  ## query on table(select * from table limit 1), then the query returns null 
> result instead for proper result



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2746
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/574/



---


[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2746
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8644/



---


[GitHub] carbondata pull request #2743: [CARBONDATA-2953]fixed dataload failure with ...

2018-09-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2743


---


[GitHub] carbondata issue #2746: [Compatibility] fix legacy store compatibility issue

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2746
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/396/



---


[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

2018-09-21 Thread kumarvishal09
Github user kumarvishal09 commented on the issue:

https://github.com/apache/carbondata/pull/2743
  
LGTM


---


[GitHub] carbondata pull request #2746: [Compatibility] fix legacy store compatibilit...

2018-09-21 Thread kunal642
GitHub user kunal642 opened a pull request:

https://github.com/apache/carbondata/pull/2746

[Compatibility] fix legacy store compatibility issue

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kunal642/carbondata compatibility_fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2746.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2746


commit b0c42a913cda322d079f4206a81ff2443fdcaec0
Author: kunal642 
Date:   2018-09-21T13:13:22Z

fix legacy store compatibility issue




---


[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2726
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/572/



---


[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2735
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8641/



---


[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2726
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8642/



---


[jira] [Updated] (CARBONDATA-2959) Validation required when Long_string_columns are included for some TBL properties

2018-09-21 Thread Naman Rastogi (JIRA)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naman Rastogi updated CARBONDATA-2959:
--
Description: 
Validation required when LONG_STRING_COLUMNS are included in some TBL 
properties like

DICTIONARY_INCLUDE, DICTIONARY_EXCLUDE, NO_INVERTED_INDEX and scenarios when 
duplicate columns, invalid columns and partition column are provided in 
long_string_columns while creating a table.

  was:
:Validation required when Long_string_columns are included in some TBL 
properties like dictionary_include,dictionary_exclude,no_inverted_index and 
scenarios when duplicate columns,invalid columns and partition column are 
provided in long_string_columns while creating table
【Precondition] :NA
【Test step】: 
CREATE TABLE lsc1(id int, name string, description string,address string, note 
string) using carbon options('long_string_columns'='note,note');

 CREATE TABLE lsc2(id int, name string, description string,address string, note 
string) using carbon options('long_string_columns'='');

CREATE TABLE lsc3(id int, name string, description string,address string, note 
string) using carbon options('long_string_columns'='abc');

CREATE TABLE lsc4(id int, name string, description string,address string, note 
string) using carbon options('long_string_columns'='id');

CREATE TABLE lsc5(id int, name string, description string,address string, note 
string) using carbon 
options('dictionary_include'='note','long_string_columns'='note,description');

CREATE TABLE lsc6(id int, name string, description string,address string, note 
string) using carbon 
options('dictionary_exclude'='note','long_string_columns'='note,description');

CREATE TABLE lsc8(id int, name string, description string,address string, note 
string) using carbon 
options('no_inverted_index'='note','long_string_columns'='note,description');

CREATE TABLE lcs9(id int,name string, description string,address string,note 
string) using carbon options('long_string_columns'='note,description') 
partitioned by (note);


> Validation required when Long_string_columns are included for some TBL 
> properties
> -
>
> Key: CARBONDATA-2959
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2959
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: Naman Rastogi
>Assignee: Naman Rastogi
>Priority: Minor
>
> Validation required when LONG_STRING_COLUMNS are included in some TBL 
> properties like
> DICTIONARY_INCLUDE, DICTIONARY_EXCLUDE, NO_INVERTED_INDEX and scenarios when 
> duplicate columns, invalid columns and partition column are provided in 
> long_string_columns while creating a table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (CARBONDATA-2959) Validation required when Long_string_columns are included for some TBL properties

2018-09-21 Thread Naman Rastogi (JIRA)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naman Rastogi updated CARBONDATA-2959:
--
Description: Validation required when LONG_STRING_COLUMNS are included in 
some TBL properties like DICTIONARY_INCLUDE, DICTIONARY_EXCLUDE, 
NO_INVERTED_INDEX and scenarios when duplicate columns, invalid columns and 
partition column are provided in long_string_columns while creating a table.  
(was: Validation required when LONG_STRING_COLUMNS are included in some TBL 
properties like

DICTIONARY_INCLUDE, DICTIONARY_EXCLUDE, NO_INVERTED_INDEX and scenarios when 
duplicate columns, invalid columns and partition column are provided in 
long_string_columns while creating a table.)

> Validation required when Long_string_columns are included for some TBL 
> properties
> -
>
> Key: CARBONDATA-2959
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2959
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: Naman Rastogi
>Assignee: Naman Rastogi
>Priority: Minor
>
> Validation required when LONG_STRING_COLUMNS are included in some TBL 
> properties like DICTIONARY_INCLUDE, DICTIONARY_EXCLUDE, NO_INVERTED_INDEX and 
> scenarios when duplicate columns, invalid columns and partition column are 
> provided in long_string_columns while creating a table.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (CARBONDATA-2959) Validation required when Long_string_columns are included for some TBL properties

2018-09-21 Thread Naman Rastogi (JIRA)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Naman Rastogi reassigned CARBONDATA-2959:
-

Assignee: Naman Rastogi

> Validation required when Long_string_columns are included for some TBL 
> properties
> -
>
> Key: CARBONDATA-2959
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2959
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: Naman Rastogi
>Assignee: Naman Rastogi
>Priority: Minor
>
> :Validation required when Long_string_columns are included in some TBL 
> properties like dictionary_include,dictionary_exclude,no_inverted_index and 
> scenarios when duplicate columns,invalid columns and partition column are 
> provided in long_string_columns while creating table
> 【Precondition] :NA
> 【Test step】: 
> CREATE TABLE lsc1(id int, name string, description string,address string, 
> note string) using carbon options('long_string_columns'='note,note');
>  CREATE TABLE lsc2(id int, name string, description string,address string, 
> note string) using carbon options('long_string_columns'='');
> CREATE TABLE lsc3(id int, name string, description string,address string, 
> note string) using carbon options('long_string_columns'='abc');
> CREATE TABLE lsc4(id int, name string, description string,address string, 
> note string) using carbon options('long_string_columns'='id');
> CREATE TABLE lsc5(id int, name string, description string,address string, 
> note string) using carbon 
> options('dictionary_include'='note','long_string_columns'='note,description');
> CREATE TABLE lsc6(id int, name string, description string,address string, 
> note string) using carbon 
> options('dictionary_exclude'='note','long_string_columns'='note,description');
> CREATE TABLE lsc8(id int, name string, description string,address string, 
> note string) using carbon 
> options('no_inverted_index'='note','long_string_columns'='note,description');
> CREATE TABLE lcs9(id int,name string, description string,address string,note 
> string) using carbon options('long_string_columns'='note,description') 
> partitioned by (note);



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata issue #2738: [CARBONDATA-2952] Provide c++ interface for SDK Carb...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2738
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/395/



---


[jira] [Created] (CARBONDATA-2960) SDK reader not working without projection columns

2018-09-21 Thread MANISH NALLA (JIRA)
MANISH NALLA created CARBONDATA-2960:


 Summary: SDK reader not working without projection columns
 Key: CARBONDATA-2960
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2960
 Project: CarbonData
  Issue Type: Improvement
Reporter: MANISH NALLA
Assignee: MANISH NALLA






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2735
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/571/



---


[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2743
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/570/



---


[jira] [Created] (CARBONDATA-2959) Validation required when Long_string_columns are included for some TBL properties

2018-09-21 Thread Naman Rastogi (JIRA)
Naman Rastogi created CARBONDATA-2959:
-

 Summary: Validation required when Long_string_columns are included 
for some TBL properties
 Key: CARBONDATA-2959
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2959
 Project: CarbonData
  Issue Type: Improvement
Reporter: Naman Rastogi


:Validation required when Long_string_columns are included in some TBL 
properties like dictionary_include,dictionary_exclude,no_inverted_index and 
scenarios when duplicate columns,invalid columns and partition column are 
provided in long_string_columns while creating table
【Precondition] :NA
【Test step】: 
CREATE TABLE lsc1(id int, name string, description string,address string, note 
string) using carbon options('long_string_columns'='note,note');

 CREATE TABLE lsc2(id int, name string, description string,address string, note 
string) using carbon options('long_string_columns'='');

CREATE TABLE lsc3(id int, name string, description string,address string, note 
string) using carbon options('long_string_columns'='abc');

CREATE TABLE lsc4(id int, name string, description string,address string, note 
string) using carbon options('long_string_columns'='id');

CREATE TABLE lsc5(id int, name string, description string,address string, note 
string) using carbon 
options('dictionary_include'='note','long_string_columns'='note,description');

CREATE TABLE lsc6(id int, name string, description string,address string, note 
string) using carbon 
options('dictionary_exclude'='note','long_string_columns'='note,description');

CREATE TABLE lsc8(id int, name string, description string,address string, note 
string) using carbon 
options('no_inverted_index'='note','long_string_columns'='note,description');

CREATE TABLE lcs9(id int,name string, description string,address string,note 
string) using carbon options('long_string_columns'='note,description') 
partitioned by (note);



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2743
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8640/



---


[jira] [Resolved] (CARBONDATA-2948) Support Float and Byte Datatypes for SDK and DataSource

2018-09-21 Thread Ravindra Pesala (JIRA)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravindra Pesala resolved CARBONDATA-2948.
-
   Resolution: Fixed
Fix Version/s: 1.5.0

> Support Float and Byte Datatypes for SDK and DataSource
> ---
>
> Key: CARBONDATA-2948
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2948
> Project: CarbonData
>  Issue Type: Improvement
>Reporter: Kunal Kapoor
>Assignee: Kunal Kapoor
>Priority: Major
> Fix For: 1.5.0
>
>  Time Spent: 3h
>  Remaining Estimate: 0h
>
> Currently float is supported by internally storing the data as double and 
> changing the data type to Double. This poses some problems while using 
> SparkCarbonFileFormat for reading the float type data.
> Internally as the data type is changed from Float to Double therefore the 
> data is retrieved as a Double page instead of float. 
> If the user tried to create a table using file format by specifying the 
> datatype as float for any column then the query will fail. User is 
> *restricted to use double to retrieve the data.*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata pull request #2726: [CARBONDATA-2948] Float and Byte DataType sup...

2018-09-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2726


---


[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support

2018-09-21 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2726
  
LGTM


---


[GitHub] carbondata issue #2729: [WIP]Store optimization

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2729
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/568/



---


[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2735
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/394/



---


[GitHub] carbondata issue #2736: [CARBONDATA-2947] Adaptive encoding support for time...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2736
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/567/



---


[GitHub] carbondata issue #2729: [WIP]Store optimization

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2729
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8638/



---


[GitHub] carbondata issue #2736: [CARBONDATA-2947] Adaptive encoding support for time...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2736
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8637/



---


[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2743
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/392/



---


[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2726
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/393/



---


[GitHub] carbondata issue #2745: [CARBONDATA-2958] Compaction with CarbonProperty 'ca...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2745
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8636/



---


[GitHub] carbondata issue #2745: [CARBONDATA-2958] Compaction with CarbonProperty 'ca...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2745
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/566/



---


[GitHub] carbondata issue #2735: [CARBONDATA-2950]alter add column of hive table fail...

2018-09-21 Thread kumarvishal09
Github user kumarvishal09 commented on the issue:

https://github.com/apache/carbondata/pull/2735
  
retest this please


---


[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support

2018-09-21 Thread ravipesala
Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/2726
  
retest this please


---


[GitHub] carbondata pull request #2737: [HOTFIX] Correct metrics and avoid twice read...

2018-09-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2737


---


[GitHub] carbondata issue #2729: [WIP]Store optimization

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2729
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/390/



---


[GitHub] carbondata issue #2737: [HOTFIX] Correct metrics and avoid twice read when p...

2018-09-21 Thread kumarvishal09
Github user kumarvishal09 commented on the issue:

https://github.com/apache/carbondata/pull/2737
  
LGTM


---


[GitHub] carbondata issue #2744: [CARBONDATA-2957][doc] update doc for supporting com...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2744
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/565/



---


[GitHub] carbondata issue #2736: [CARBONDATA-2947] Adaptive encoding support for time...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2736
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/389/



---


[GitHub] carbondata issue #2744: [CARBONDATA-2957][doc] update doc for supporting com...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2744
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8635/



---


[GitHub] carbondata issue #2736: [CARBONDATA-2947] Adaptive encoding support for time...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2736
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/564/



---


[GitHub] carbondata issue #2736: [CARBONDATA-2947] Adaptive encoding support for time...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2736
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8634/



---


[GitHub] carbondata issue #2745: [CARBONDATA-2958] Compaction with CarbonProperty 'ca...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2745
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/388/



---


[GitHub] carbondata pull request #2745: [CARBONDATA-2958] Compaction with CarbonPrope...

2018-09-21 Thread Indhumathi27
GitHub user Indhumathi27 opened a pull request:

https://github.com/apache/carbondata/pull/2745

[CARBONDATA-2958] Compaction with CarbonProperty 
'carbon.enable.page.level.reader.in.compaction' enabled fails as Compressor is 
null

**Problem:**
When CarbonProperty 'carbon.enable.page.level.reader.in.compaction' is 
enabled, compaction fails throwing Null Pointer Exception as compressor is Null
**Solution:**
Set compressor from pageMetaData
 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [x] Testing done
Test case added
  
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Indhumathi27/carbondata page_compaction

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2745.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2745


commit 1c0a6fc8435c582cefa00bcd8d6979e89f1d886d
Author: Indhumathi27 
Date:   2018-09-21T09:54:39Z

[CARBONDATA-2958] Compaction with CarbonProperty 
'carbon.enable.page.level.reader.in.compaction' enabled fails as Compressor is 
null




---


[jira] [Updated] (CARBONDATA-2958) Compaction with CarbonProperty 'carbon.enable.page.level.reader.in.compaction' enabled fails as Compressor is null

2018-09-21 Thread Indhumathi Muthumurugesh (JIRA)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Indhumathi Muthumurugesh updated CARBONDATA-2958:
-
Summary: Compaction with CarbonProperty 
'carbon.enable.page.level.reader.in.compaction' enabled fails as Compressor is 
null  (was: Compaction with CarbonProperty 
'carbon.enable.page.level.reader.in.compaction' enabled fails as Compressor is 
null fails)

> Compaction with CarbonProperty 
> 'carbon.enable.page.level.reader.in.compaction' enabled fails as Compressor 
> is null
> --
>
> Key: CARBONDATA-2958
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2958
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Indhumathi Muthumurugesh
>Assignee: Indhumathi Muthumurugesh
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (CARBONDATA-2958) Compaction with CarbonProperty 'carbon.enable.page.level.reader.in.compaction' enabled fails as Compressor is null fails

2018-09-21 Thread Indhumathi Muthumurugesh (JIRA)
Indhumathi Muthumurugesh created CARBONDATA-2958:


 Summary: Compaction with CarbonProperty 
'carbon.enable.page.level.reader.in.compaction' enabled fails as Compressor is 
null fails
 Key: CARBONDATA-2958
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2958
 Project: CarbonData
  Issue Type: Bug
Reporter: Indhumathi Muthumurugesh
Assignee: Indhumathi Muthumurugesh






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata pull request #2699: [WIP] Refactor Index Generatorcode

2018-09-21 Thread kumarvishal09
Github user kumarvishal09 closed the pull request at:

https://github.com/apache/carbondata/pull/2699


---


[GitHub] carbondata issue #2744: [CARBONDATA-2957][doc] update doc for supporting com...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2744
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/387/



---


[GitHub] carbondata issue #2736: [CARBONDATA-2947] Adaptive encoding support for time...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2736
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/386/



---


[GitHub] carbondata pull request #2744: [CARBONDATA-2957][doc] update doc for support...

2018-09-21 Thread xuchuanyin
GitHub user xuchuanyin opened a pull request:

https://github.com/apache/carbondata/pull/2744

[CARBONDATA-2957][doc] update doc for supporting compressor in table 
property

add doc for supporting compressor in table property

Be sure to do all of the following checklist to help us incorporate 
your contribution quickly and easily:

 - [ ] Any interfaces changed?
 
 - [ ] Any backward compatibility impacted?
 
 - [ ] Document update required?

 - [ ] Testing done
Please provide details on 
- Whether new unit test cases have been added or why no new tests 
are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance 
test report.
- Any additional information to help reviewers in testing this 
change.
   
 - [ ] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xuchuanyin/carbondata 0921_zstd_doc

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2744


commit e419e34204b2a265d16c56263a263525ee5418e6
Author: xuchuanyin 
Date:   2018-09-21T09:06:48Z

update doc for supporting compressor in table property

add doc for supporting compressor in table property




---


[jira] [Created] (CARBONDATA-2957) update document about zstd support in carbondata

2018-09-21 Thread xuchuanyin (JIRA)
xuchuanyin created CARBONDATA-2957:
--

 Summary: update document about zstd support in carbondata
 Key: CARBONDATA-2957
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2957
 Project: CarbonData
  Issue Type: Sub-task
Reporter: xuchuanyin






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata issue #2729: [WIP]Store optimization

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2729
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/563/



---


[GitHub] carbondata issue #2729: [WIP]Store optimization

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2729
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8633/



---


[GitHub] carbondata issue #2742: [CARBONDATA-2956] CarbonReader support use configura...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2742
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/562/



---


[GitHub] carbondata issue #2742: [CARBONDATA-2956] CarbonReader support use configura...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2742
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8632/



---


[jira] [Resolved] (CARBONDATA-2955) bug for legacy store and compaction with zstd compressor and adaptiveDeltaIntegralCodec

2018-09-21 Thread Jacky Li (JIRA)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacky Li resolved CARBONDATA-2955.
--
   Resolution: Fixed
Fix Version/s: 1.5.0

> bug for legacy store and compaction with zstd compressor and 
> adaptiveDeltaIntegralCodec
> ---
>
> Key: CARBONDATA-2955
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2955
> Project: CarbonData
>  Issue Type: Bug
>Reporter: xuchuanyin
>Assignee: xuchuanyin
>Priority: Major
> Fix For: 1.5.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> if table is configured with zstd compressor, compaction will fail if we use 
> adaptiveDeltaIntegralCodec;



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] carbondata pull request #2741: [CARBONDATA-2955] Fix bugs in adaptive delta ...

2018-09-21 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2741


---


[GitHub] carbondata issue #2741: [CARBONDATA-2955] Fix bugs in adaptive delta integra...

2018-09-21 Thread jackylk
Github user jackylk commented on the issue:

https://github.com/apache/carbondata/pull/2741
  
LGTM


---


[GitHub] carbondata issue #2729: [WIP]Store optimization

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2729
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/385/



---


[GitHub] carbondata issue #2739: [CARBONDATA-2954]Fix error when create external tabl...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2739
  
Build Success with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/561/



---


[GitHub] carbondata issue #2739: [CARBONDATA-2954]Fix error when create external tabl...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2739
  
Build Success with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8631/



---


[GitHub] carbondata issue #2742: [CARBONDATA-2956] CarbonReader support use configura...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2742
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/384/



---


[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2743
  
Build Failed with Spark 2.2.1, Please check CI 
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/560/



---


[GitHub] carbondata issue #2743: [CARBONDATA-2953]fixed dataload failure with sort co...

2018-09-21 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2743
  
Build Failed  with Spark 2.3.1, Please check CI 
http://136.243.101.176:8080/job/carbondataprbuilder2.3/8630/



---


[GitHub] carbondata issue #2726: [CARBONDATA-2948] Float and Byte DataType support

2018-09-21 Thread kunal642
Github user kunal642 commented on the issue:

https://github.com/apache/carbondata/pull/2726
  
@ravipesala Build is success


---