[GitHub] [carbondata] vikramahuja1001 commented on pull request #4050: [CARBONDATA-4080] Wrong results for select count on invalid segments

vikramahuja1001 commented on pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742371418 @akkio-97 , please add a test case for partition table as well This is an automated message from the

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add s

vikramahuja1001 commented on a change in pull request #4048: URL: https://github.com/apache/carbondata/pull/4048#discussion_r539984002 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/addsegment/AddSegmentTestCase.scala ## @@ -962,6 +962,88

[GitHub] [carbondata] vikramahuja1001 opened a new pull request #4051: [WIP] Only consider .segment files for stale segments

vikramahuja1001 opened a new pull request #4051: URL: https://github.com/apache/carbondata/pull/4051 ### Why is this PR needed? While getting stale segment, we do a list files and take all the files, if there is any folder/file other than .segment file, it will lead to further issues

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add s

vikramahuja1001 commented on a change in pull request #4048: URL: https://github.com/apache/carbondata/pull/4048#discussion_r539979370 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java ## @@ -1125,19 +1125,21 @@ public static void

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add s

vikramahuja1001 commented on a change in pull request #4048: URL: https://github.com/apache/carbondata/pull/4048#discussion_r539982572 ## File path: core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ## @@ -597,6 +599,27 @@ public static String

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add s

vikramahuja1001 commented on a change in pull request #4048: URL: https://github.com/apache/carbondata/pull/4048#discussion_r539983758 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/addsegment/AddSegmentTestCase.scala ## @@ -962,6 +962,88

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4050: [WIP] select count marked for delete segments

akkio-97 commented on a change in pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#discussion_r539955200 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/segmentreading/TestSegmentReading.scala ## @@ -420,4 +421,40 @@

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add s

vikramahuja1001 commented on a change in pull request #4048: URL: https://github.com/apache/carbondata/pull/4048#discussion_r539984002 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/addsegment/AddSegmentTestCase.scala ## @@ -962,6 +962,88

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4047: [CARBONDATA-4078] Add external segment and query with index server fails

vikramahuja1001 commented on a change in pull request #4047: URL: https://github.com/apache/carbondata/pull/4047#discussion_r539988131 ## File path: core/src/main/java/org/apache/carbondata/core/index/IndexUtil.java ## @@ -290,6 +291,9 @@ private static FileInputFormat

[jira] [Created] (CARBONDATA-4080) Wrong results for select count on invalid segments

Akshay created CARBONDATA-4080: -- Summary: Wrong results for select count on invalid segments Key: CARBONDATA-4080 URL: https://issues.apache.org/jira/browse/CARBONDATA-4080 Project: CarbonData

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add s

vikramahuja1001 commented on a change in pull request #4048: URL: https://github.com/apache/carbondata/pull/4048#discussion_r539979831 ## File path: core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java ## @@ -184,11 +184,7 @@ private static boolean

[GitHub] [carbondata] vikramahuja1001 commented on a change in pull request #4048: [CARBONDATA-4072] Clean files command is not deleting .segment files for the segments added through alter table add s

vikramahuja1001 commented on a change in pull request #4048: URL: https://github.com/apache/carbondata/pull/4048#discussion_r539985886 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/addsegment/AddSegmentTestCase.scala ## @@ -962,6 +962,88

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4050: [CARBONDATA-4080] Wrong results for select count on invalid segments

Indhumathi27 commented on a change in pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#discussion_r540006038 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/segmentreading/TestSegmentReading.scala ## @@ -420,4

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [CARBONDATA-4080] Wrong results for select count on invalid segments

CarbonDataQA2 commented on pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742407711 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3374/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

CarbonDataQA2 commented on pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#issuecomment-742439871 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5138/

[jira] [Created] (CARBONDATA-4081) Clean files considering files apart from .segment files while cleaning stale segments and moving them to trash

Vikram Ahuja created CARBONDATA-4081: Summary: Clean files considering files apart from .segment files while cleaning stale segments and moving them to trash Key: CARBONDATA-4081 URL:

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [CARBONDATA-4080] Wrong results for select count on invalid segments

CarbonDataQA2 commented on pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742523658 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5142/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

CarbonDataQA2 commented on pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#issuecomment-742503455 Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5141/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

CarbonDataQA2 commented on pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#issuecomment-742504077 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3379/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

CarbonDataQA2 commented on pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#issuecomment-742580666 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5143/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

CarbonDataQA2 commented on pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#issuecomment-742581030 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3381/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [CARBONDATA-4080] Wrong results for select count on invalid segments

CarbonDataQA2 commented on pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742406446 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5136/

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

nihal0107 commented on a change in pull request #4042: URL: https://github.com/apache/carbondata/pull/4042#discussion_r540031120 ## File path: integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala ## @@ -450,14 +451,27 @@ object AlterTableUtil {

[GitHub] [carbondata] akkio-97 commented on pull request #4050: [CARBONDATA-4080] Wrong results for select count on invalid segments

akkio-97 commented on pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742420618 > @akkio-97 , please add a test case for partition table as well done This is an automated message

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4037: [CARBONDATA-4070] [CARBONDATA-4059] Fixed SI issues and improved FT.

CarbonDataQA2 commented on pull request #4037: URL: https://github.com/apache/carbondata/pull/4037#issuecomment-742442058 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3376/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

CarbonDataQA2 commented on pull request #4042: URL: https://github.com/apache/carbondata/pull/4042#issuecomment-74246 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5139/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [CARBONDATA-4080] Wrong results for select count on invalid segments

CarbonDataQA2 commented on pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742470938 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5140/

[GitHub] [carbondata] akkio-97 commented on pull request #4050: [CARBONDATA-4080] Wrong results for select count on invalid segments

akkio-97 commented on pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742476298 > > @akashrn5 Please check whether this fix will be ok for SI and MV. > > for SI , better to have a test case and for MV during query if set segments is done, then it

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4051: [WIP] Only consider .segment files for stale segments

CarbonDataQA2 commented on pull request #4051: URL: https://github.com/apache/carbondata/pull/4051#issuecomment-742453013 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3375/

[GitHub] [carbondata] akashrn5 commented on pull request #4050: [CARBONDATA-4080] Wrong results for select count on invalid segments

akashrn5 commented on pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742404913 > @akashrn5 Please check whether this fix will be ok for SI and MV. for SI , better to have a test case and for MV during query if set segments is done, then it will

[GitHub] [carbondata] nihal0107 commented on a change in pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

nihal0107 commented on a change in pull request #4042: URL: https://github.com/apache/carbondata/pull/4042#discussion_r540031235 ## File path: integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala ## @@ -916,6 +930,19 @@ object AlterTableUtil {

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4050: [CARBONDATA-4080] Wrong results for select count on invalid segments

akkio-97 commented on a change in pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#discussion_r540038288 ## File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/segmentreading/TestSegmentReading.scala ## @@ -420,4 +421,69 @@

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4051: [WIP] Only consider .segment files for stale segments

CarbonDataQA2 commented on pull request #4051: URL: https://github.com/apache/carbondata/pull/4051#issuecomment-742442851 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5137/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4042: [CARBONDATA-4069] [CARBONDATA-4068] handled set streaming and long string for SI table or table having SI.

CarbonDataQA2 commented on pull request #4042: URL: https://github.com/apache/carbondata/pull/4042#issuecomment-742468704 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3377/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4050: [CARBONDATA-4080] Wrong results for select count on invalid segments

CarbonDataQA2 commented on pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#issuecomment-742529889 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3380/

[GitHub] [carbondata] Karan980 opened a new pull request #4052: [WIP] UT Improvement for load/compaction

Karan980 opened a new pull request #4052: URL: https://github.com/apache/carbondata/pull/4052 ### Why is this PR needed? ### What changes were proposed in this PR? ### Does this PR introduce any user interface change? - No - Yes. (please explain the

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4052: [WIP] UT Improvement for load/compaction

CarbonDataQA2 commented on pull request #4052: URL: https://github.com/apache/carbondata/pull/4052#issuecomment-742773432 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5144/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4052: [WIP] UT Improvement for load/compaction

CarbonDataQA2 commented on pull request #4052: URL: https://github.com/apache/carbondata/pull/4052#issuecomment-742774157 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3382/

[jira] [Created] (CARBONDATA-4082) When a segment is added to a carbon table by alter table add segment query and that segment also have a deleteDelta file present in it then on querying the carbon ta

Karan created CARBONDATA-4082: - Summary: When a segment is added to a carbon table by alter table add segment query and that segment also have a deleteDelta file present in it then on querying the carbon table the deleted rows are coming in the

[GitHub] [carbondata] kunal642 commented on pull request #4050: [CARBONDATA-4080] Wrong results for select count on invalid segments

kunal642 commented on pull request #4050: URL: https://github.com/apache/carbondata/pull/4050#issuecomment-743011865 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] QiangCai commented on pull request #4029: [HOTFIX] Refact Carbon Util

QiangCai commented on pull request #4029: URL: https://github.com/apache/carbondata/pull/4029#issuecomment-742909031 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [carbondata] QiangCai commented on pull request #4051: [CARBONDATA-4081] In Clean files operation, only consider ".segment" files in the segments folder for cleaning stale segments

QiangCai commented on pull request #4051: URL: https://github.com/apache/carbondata/pull/4051#issuecomment-742907587 can you add a test case for fault testing? This is an automated message from the Apache Git Service. To

[GitHub] [carbondata] asfgit closed pull request #4029: [HOTFIX] Refact Carbon Util

asfgit closed pull request #4029: URL: https://github.com/apache/carbondata/pull/4029 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go