vikramahuja1001 commented on a change in pull request #4048:
URL: https://github.com/apache/carbondata/pull/4048#discussion_r539983758



##########
File path: 
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/addsegment/AddSegmentTestCase.scala
##########
@@ -962,6 +962,88 @@ class AddSegmentTestCase extends QueryTest with 
BeforeAndAfterAll {
     sql(s"drop table $tableName")
   }
 

Review comment:
       I don't understand why these test cases cannot be added in the 
testCleanFilesCommand cases. You can any necessary function that you want to 
use there. Also please merge these 2 test cases into 1. And also Include 
Inprogress segment also.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to