[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

2018-02-16 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1972#discussion_r168714751 --- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/InputProcessorStepForPartitionImpl.java --- @@ -0,0 +1,251 @@

[GitHub] carbondata issue #1980: [CARBONDATA-2103]optimize show tables for filtering ...

2018-02-16 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1980 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3753/ ---

[GitHub] carbondata issue #1980: [CARBONDATA-2103]optimize show tables for filtering ...

2018-02-16 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1980 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2513/ ---

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

2018-02-16 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1972#discussion_r168705495 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala --- @@ -592,41 +666,12

[GitHub] carbondata issue #1980: [CARBONDATA-2103]optimize show tables for filtering ...

2018-02-16 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1980 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3752/ ---

[GitHub] carbondata issue #1980: [CARBONDATA-2103]optimize show tables for filtering ...

2018-02-16 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/1980 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2512/ ---

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

2018-02-16 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1972#discussion_r168700461 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala --- @@ -544,17 +547,76

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

2018-02-16 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1972#discussion_r168677068 --- Diff: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java --- @@ -104,6 +104,38 @@ public static Object

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

2018-02-16 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1972#discussion_r168699514 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala --- @@ -676,6 +734,48

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

2018-02-16 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1972#discussion_r168677700 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonOutputCommitter.java --- @@ -122,7 +119,11 @@ public

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

2018-02-16 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1972#discussion_r168416054 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/SafeDecimalColumnPage.java --- @@ -217,6 +217,6 @@ public void

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

2018-02-16 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1972#discussion_r168700095 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonLoadDataCommand.scala --- @@ -676,6 +734,48

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

2018-02-16 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1972#discussion_r168696420 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDropPartitionRDD.scala --- @@ -59,10 +61,12 @@ class

[GitHub] carbondata pull request #1972: [CARBONDATA-2168] Support global sort for sta...

2018-02-16 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/1972#discussion_r168702275 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/PartitionMapFileStore.java --- @@ -279,18 +279,20 @@ public boolean