[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r189423352 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DistributableDataMapFormat.java --- @@ -158,7 +166,11 @@ public float getProgress()

[GitHub] carbondata pull request #2316: [WIP] Removed method to accept carbon schema ...

2018-05-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2316#discussion_r189423162 --- Diff: examples/spark2/src/main/java/org/apache/carbondata/examples/sdk/CarbonReaderExample.java --- @@ -44,11 +44,10 @@ public static void

[GitHub] carbondata pull request #2318: [CARBONDATA-2491] Fix the error when reader r...

2018-05-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2318#discussion_r189423096 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java --- @@ -267,6 +267,8 @@ public TableDataMap

[GitHub] carbondata pull request #2318: [CARBONDATA-2491] Fix the error when reader r...

2018-05-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2318#discussion_r189422955 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/AvroCarbonWriterTest.java --- @@ -29,16 +29,27 @@ import

[jira] [Resolved] (CARBONDATA-2413) After running CarbonWriter, there is null directory about datamap

2018-05-18 Thread Ravindra Pesala (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ravindra Pesala resolved CARBONDATA-2413. - Resolution: Fixed Fix Version/s: 1.4.0 > After running CarbonWriter,

[GitHub] carbondata pull request #2215: [CARBONDATA-2206]add documentation for lucene...

2018-05-18 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2215#discussion_r189422398 --- Diff: docs/datamap/lucene-datamap-guide.md --- @@ -0,0 +1,133 @@ +# CarbonData Lucene DataMap (Alpha feature in 1.4.0) + +*

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2246 ---

[GitHub] carbondata issue #2246: [CARBONDATA-2413] After running CarbonWriter, there ...

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2246 LGTM ---

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-18 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r189422726 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java --- @@ -103,7 +103,7 @@ public

[GitHub] carbondata pull request #2182: [CARBONDATA-2354] fixed streaming example

2018-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2182 ---

[GitHub] carbondata pull request #2320: [Documentation] Editorial review comment fixe...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2320#discussion_r189422348 --- Diff: docs/data-management-on-carbondata.md --- @@ -39,7 +39,7 @@ This tutorial is going to introduce all commands and data operations on CarbonDa

[jira] [Created] (CARBONDATA-2495) Add document for bloomfilter datamap

2018-05-18 Thread xuchuanyin (JIRA)
xuchuanyin created CARBONDATA-2495: -- Summary: Add document for bloomfilter datamap Key: CARBONDATA-2495 URL: https://issues.apache.org/jira/browse/CARBONDATA-2495 Project: CarbonData Issue

[GitHub] carbondata pull request #2215: [CARBONDATA-2206]add documentation for lucene...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2215#discussion_r189421956 --- Diff: docs/datamap/lucene-datamap-guide.md --- @@ -0,0 +1,133 @@ +# CarbonData Lucene DataMap (Alpha feature in 1.4.0) + +* [DataMap

[GitHub] carbondata pull request #2215: [CARBONDATA-2206]add documentation for lucene...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2215#discussion_r189421681 --- Diff: docs/datamap/lucene-datamap-guide.md --- @@ -0,0 +1,133 @@ +# CarbonData Lucene DataMap (Alpha feature in 1.4.0) + +* [DataMap

[GitHub] carbondata issue #2265: Added Performance Optimization for Presto by using M...

2018-05-18 Thread chenliang613
Github user chenliang613 commented on the issue: https://github.com/apache/carbondata/pull/2265 please solve the conflict ---

[GitHub] carbondata pull request #2215: [CARBONDATA-2206]add documentation for lucene...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2215#discussion_r189421639 --- Diff: docs/datamap/lucene-datamap-guide.md --- @@ -0,0 +1,133 @@ +# CarbonData Lucene DataMap (Alpha feature in 1.4.0) + +* [DataMap

[GitHub] carbondata pull request #2215: [CARBONDATA-2206]add documentation for lucene...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2215#discussion_r189421589 --- Diff: docs/datamap/lucene-datamap-guide.md --- @@ -0,0 +1,133 @@ +# CarbonData Lucene DataMap (Alpha feature in 1.4.0) + +* [DataMap

[GitHub] carbondata pull request #2311: [CARBONDATA-2487] Block filters for lucene wi...

2018-05-18 Thread Indhumathi27
Github user Indhumathi27 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2311#discussion_r189421516 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala --- @@ -479,6 +479,24 @@

[GitHub] carbondata pull request #2215: [CARBONDATA-2206]add documentation for lucene...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2215#discussion_r189421502 --- Diff: docs/datamap/lucene-datamap-guide.md --- @@ -0,0 +1,133 @@ +# CarbonData Lucene DataMap (Alpha feature in 1.4.0) + +* [DataMap

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r189421336 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java --- @@ -103,7 +103,7 @@ public

[GitHub] carbondata pull request #2318: [CARBONDATA-2491] Fix the error when reader r...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2318#discussion_r189421188 --- Diff: store/sdk/src/test/java/org/apache/carbondata/sdk/file/AvroCarbonWriterTest.java --- @@ -29,16 +29,27 @@ import

[GitHub] carbondata pull request #2318: [CARBONDATA-2491] Fix the error when reader r...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2318#discussion_r189421068 --- Diff: core/src/main/java/org/apache/carbondata/core/datamap/DataMapStoreManager.java --- @@ -267,6 +267,8 @@ public TableDataMap

[GitHub] carbondata pull request #2275: [CARBONDATA-2494] Fix lucene datasize and per...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2275#discussion_r189420105 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapWriter.java --- @@ -175,52 +206,39 @@ public void

[GitHub] carbondata pull request #2275: [CARBONDATA-2494] Fix lucene datasize and per...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2275#discussion_r189420060 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapFactoryBase.java --- @@ -107,13 +138,39 @@ public

[GitHub] carbondata pull request #2275: [CARBONDATA-2494] Fix lucene datasize and per...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2275#discussion_r189419987 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapWriter.java --- @@ -84,20 +91,61 @@ public

[GitHub] carbondata pull request #2275: [CARBONDATA-2494] Fix lucene datasize and per...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2275#discussion_r189419824 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapWriter.java --- @@ -242,73 +260,220 @@ private boolean

[GitHub] carbondata pull request #2275: [CARBONDATA-2494] Fix lucene datasize and per...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2275#discussion_r189419746 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMap.java --- @@ -212,69 +228,58 @@ private int

[GitHub] carbondata pull request #2311: [CARBONDATA-2487] Block filters for lucene wi...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2311#discussion_r189417704 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala --- @@ -479,6 +479,24 @@

[GitHub] carbondata pull request #2311: [CARBONDATA-2487] Block filters for lucene wi...

2018-05-18 Thread jackylk
Github user jackylk commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2311#discussion_r189417575 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonLateDecodeStrategy.scala --- @@ -479,6 +479,24 @@

[jira] [Resolved] (CARBONDATA-2480) Search mode RuntimeException: Error while resolving filter expression

2018-05-18 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-2480. -- Resolution: Fixed Fix Version/s: 1.4.0 > Search mode RuntimeException: Error while

[GitHub] carbondata pull request #2309: [HOTFIX] [CARBONDATA-2480] Search mode Runtim...

2018-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2309 ---

[jira] [Resolved] (CARBONDATA-2476) Fix bug in bloom datamap cache

2018-05-18 Thread Jacky Li (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Li resolved CARBONDATA-2476. -- Resolution: Fixed Fix Version/s: 1.4.0 > Fix bug in bloom datamap cache >

[GitHub] carbondata pull request #2303: [CARBONDATA-2476][DataMap] Fix bug in bloom d...

2018-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2303 ---

[GitHub] carbondata issue #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2313 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5001/ ---

[GitHub] carbondata issue #2181: [CARBONDATA-2355] Support run SQL on carbondata file...

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2181 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5000/ ---

[GitHub] carbondata issue #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2313 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4820/ ---

[GitHub] carbondata issue #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2313 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5978/ ---

[GitHub] carbondata issue #2322: [CARBONDATA-2472] Fixed:Refactor NonTransactional ta...

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2322 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4999/ ---

[GitHub] carbondata issue #2322: [CARBONDATA-2472] Fixed:Refactor NonTransactional ta...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2322 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5976/ ---

[GitHub] carbondata issue #2181: [CARBONDATA-2355] Support run SQL on carbondata file...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2181 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4819/ ---

[GitHub] carbondata issue #2181: [CARBONDATA-2355] Support run SQL on carbondata file...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2181 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5977/ ---

[GitHub] carbondata issue #2322: [CARBONDATA-2472] Fixed:Refactor NonTransactional ta...

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2322 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4998/ ---

[GitHub] carbondata issue #2318: [CARBONDATA-2491] Fix the error when reader read twi...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2318 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4818/ ---

[GitHub] carbondata issue #2322: [CARBONDATA-2472] Fixed:Refactor NonTransactional ta...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2322 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4817/ ---

[GitHub] carbondata issue #2322: [CARBONDATA-2472] Fixed:Refactor NonTransactional ta...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2322 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5972/ ---

[GitHub] carbondata issue #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2313 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4997/ ---

[GitHub] carbondata issue #2321: [WIP]clean and close datamap writers on any task fai...

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2321 SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4996/ ---

[GitHub] carbondata pull request #2246: [CARBONDATA-2413] After running CarbonWriter,...

2018-05-18 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2246#discussion_r189318314 --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/DiskBasedDMSchemaStorageProvider.java --- @@ -103,7 +103,7 @@ public

[GitHub] carbondata issue #2322: [CARBONDATA-2472] Fixed:Refactor NonTransactional ta...

2018-05-18 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2322 retest this please ---

[GitHub] carbondata issue #2318: [CARBONDATA-2491] Fix the error when reader read twi...

2018-05-18 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/2318 retest this please ---

[GitHub] carbondata issue #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2313 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5974/ ---

[GitHub] carbondata issue #2321: [WIP]clean and close datamap writers on any task fai...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2321 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5973/ ---

[GitHub] carbondata issue #2269: [CARBONDATA-2433][LUCENE]close the lucene index read...

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2269 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4995/ ---

[GitHub] carbondata issue #2269: [CARBONDATA-2433][LUCENE]close the lucene index read...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2269 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5971/ ---

[GitHub] carbondata issue #2311: [CARBONDATA-2487] Block filters for lucene with more...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2311 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5970/ ---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2320 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4994/ ---

[GitHub] carbondata issue #2322: [CARBONDATA-2472] Fixed:Refactor NonTransactional ta...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2322 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4816/ ---

[jira] [Commented] (CARBONDATA-2340) load数据超过32000byte

2018-05-18 Thread xuchuanyin (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16480730#comment-16480730 ] xuchuanyin commented on CARBONDATA-2340: [~niaoshu] What do you mean by saying 'hive

[GitHub] carbondata issue #2319: [CARBONDATA-2493] DataType.equals() failes for compl...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2319 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5969/ ---

[GitHub] carbondata issue #2215: [CARBONDATA-2206]add documentation for lucene datama...

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2215 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4993/ ---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2320 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5968/ ---

[GitHub] carbondata issue #2322: [CARBONDATA-2472] Fixed:Refactor NonTransactional ta...

2018-05-18 Thread ajantha-bhat
Github user ajantha-bhat commented on the issue: https://github.com/apache/carbondata/pull/2322 @gvramana : please review. ---

[GitHub] carbondata pull request #2322: [CARBONDATA-2472] Fixed:Refactor NonTransacti...

2018-05-18 Thread ajantha-bhat
GitHub user ajantha-bhat opened a pull request: https://github.com/apache/carbondata/pull/2322 [CARBONDATA-2472] Fixed:Refactor NonTransactional table code for Index file IO performance [CARBONDATA-2472] Fixed:Refactor NonTransactional table code for Index file IO performance

[GitHub] carbondata issue #2215: [CARBONDATA-2206]add documentation for lucene datama...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2215 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5967/ ---

[GitHub] carbondata issue #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2313 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4815/ ---

[GitHub] carbondata issue #2321: [WIP]clean and close datamap writers on any task fai...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2321 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4814/ ---

[GitHub] carbondata issue #2319: [CARBONDATA-2493] DataType.equals() failes for compl...

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2319 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4992/ ---

[GitHub] carbondata pull request #2321: [WIP]clean and close datamap writers on any t...

2018-05-18 Thread akashrn5
GitHub user akashrn5 opened a pull request: https://github.com/apache/carbondata/pull/2321 [WIP]clean and close datamap writers on any task failure during load Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: -

[GitHub] carbondata pull request #2269: [CARBONDATA-2433][LUCENE]close the lucene ind...

2018-05-18 Thread akashrn5
Github user akashrn5 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2269#discussion_r189267374 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/api/DistributableDataMapFormat.java --- @@ -100,14 +103,18 @@ private static

[GitHub] carbondata issue #2269: [CARBONDATA-2433][LUCENE]close the lucene index read...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2269 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4813/ ---

[GitHub] carbondata issue #2311: [CARBONDATA-2487] Block filters for lucene with more...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2311 Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4812/ ---

[GitHub] carbondata issue #2311: [CARBONDATA-2487] Block filters for lucene with more...

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2311 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4991/ ---

[GitHub] carbondata issue #2311: [CARBONDATA-2487] Block filters for lucene with more...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2311 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5965/ ---

[GitHub] carbondata issue #2319: [CARBONDATA-2493] DataType.equals() failes for compl...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2319 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5966/ ---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2320 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4811/ ---

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189249739 --- Diff: store/search/src/main/java/org/apache/carbondata/store/worker/SearchRequestHandler.java --- @@ -100,8 +100,9 @@ public ShutdownResponse

[GitHub] carbondata issue #2215: [CARBONDATA-2206]add documentation for lucene datama...

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2215 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4990/ ---

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189249203 --- Diff: store/sdk/src/main/java/org/apache/carbondata/store/LocalCarbonStore.java --- @@ -102,6 +107,11 @@ while

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189248204 --- Diff: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonLocalInputSplit.java --- @@ -115,23 +115,26 @@ public void

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189247616 --- Diff: integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java --- @@ -77,13 +77,15 @@ private static void

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189247073 --- Diff: core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentUpdateStatusManager.java --- @@ -348,32 +348,37 @@ public boolean

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189247138 --- Diff: integration/spark2/src/main/java/org/apache/carbondata/spark/vectorreader/VectorizedCarbonRecordReader.java --- @@ -144,14 +145,10 @@

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189246968 --- Diff: core/src/main/java/org/apache/carbondata/core/util/AbstractDataFileFooterConverter.java --- @@ -60,7 +60,11 @@ */

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189246946 --- Diff: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelRangeGrtThanFiterExecuterImpl.java --- @@ -98,9 +98,11 @@

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189246927 --- Diff: core/src/main/java/org/apache/carbondata/core/reader/CarbonDictionaryMetadataReaderImpl.java --- @@ -128,6 +131,9 @@ public

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189246882 --- Diff: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java --- @@ -282,12 +282,15 @@ private

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189246901 --- Diff: core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java --- @@ -152,14 +152,15 @@ public synchronized boolean

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189246763 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/compression/SnappyCompressor.java --- @@ -135,52 +136,52 @@ public String

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189246853 --- Diff: core/src/main/java/org/apache/carbondata/core/dictionary/generator/IncrementalColumnDictionaryGenerator.java --- @@ -89,15 +89,19 @@

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189246720 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/reader/measure/AbstractMeasureChunkReaderV2V3Format.java --- @@ -103,11

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread sraghunandan
Github user sraghunandan commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189246746 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/safe/SafeVariableLengthDimensionDataChunkStore.java --- @@

[GitHub] carbondata issue #2215: [CARBONDATA-2206]add documentation for lucene datama...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2215 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5964/ ---

[GitHub] carbondata issue #2318: [CARBONDATA-2491] Fix the error when reader read twi...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2318 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5963/ ---

[GitHub] carbondata issue #2311: [CARBONDATA-2487] Block filters for lucene with more...

2018-05-18 Thread Indhumathi27
Github user Indhumathi27 commented on the issue: https://github.com/apache/carbondata/pull/2311 Retest this please ---

[GitHub] carbondata issue #2215: [CARBONDATA-2206]add documentation for lucene datama...

2018-05-18 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2215 SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4989/ ---

[GitHub] carbondata issue #2320: [Documentation] Editorial review comment fixed

2018-05-18 Thread kunal642
Github user kunal642 commented on the issue: https://github.com/apache/carbondata/pull/2320 LGTM ---

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189239307 --- Diff: store/search/src/main/java/org/apache/carbondata/store/worker/SearchRequestHandler.java --- @@ -100,8 +100,9 @@ public ShutdownResponse

[GitHub] carbondata pull request #2313: [CARBONDATA-2489] Coverity scan fixes

2018-05-18 Thread gvramana
Github user gvramana commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2313#discussion_r189239156 --- Diff: store/sdk/src/main/java/org/apache/carbondata/store/LocalCarbonStore.java --- @@ -102,6 +107,11 @@ while

[GitHub] carbondata pull request #2320: [Documentation] Editorial review comment fixe...

2018-05-18 Thread sgururajshetty
GitHub user sgururajshetty opened a pull request: https://github.com/apache/carbondata/pull/2320 [Documentation] Editorial review comment fixed Editorial review comment fixed You can merge this pull request into a Git repository by running: $ git pull

[GitHub] carbondata issue #2318: [CARBONDATA-2491] Fix the error when reader read twi...

2018-05-18 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2318 Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4805/ ---

  1   2   >