marchpure commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700490385
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
akashrn5 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700489664
> please check mail list:
>
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Parallel-compaction-and-update-td100338.html
>
> How
Zhangshunyu commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700485310
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
[
https://issues.apache.org/jira/browse/CARBONDATA-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akshay updated CARBONDATA-3830:
---
Description:
This feature is to enable Presto to read complex columns from carbon file.
Complex
[
https://issues.apache.org/jira/browse/CARBONDATA-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Akshay updated CARBONDATA-3830:
---
Description:
This feature is to enable Presto to read complex columns from carbon file.
Complex
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700451914
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2521/
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700440309
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4266/
-
vikramahuja1001 commented on pull request #3952:
URL: https://github.com/apache/carbondata/pull/3952#issuecomment-700432240
retest this please
This is an automated message from the Apache Git Service.
To respond to the messag
marchpure commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700407129
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, ple
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700406306
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4265/
-
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700405441
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2520/
QiangCai edited a comment on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700373270
please check mail list:
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Parallel-compaction-and-update-td100338.html
How
QiangCai commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700373270
please check mail list:
http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/DISCUSSION-Parallel-compaction-and-update-td100338.html
How do you
Kejian-Li removed a comment on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700366456
@ajantha-bhat @akashrn5 please help review this PR
This is an automated message from the Apache Git
marchpure commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r496323043
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
##
Klaus-xjp commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r496322133
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
##
Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700366456
@ajantha-bhat @akashrn5 please help review this PR
This is an automated message from the Apache Git Service
VenuReddy2103 commented on a change in pull request #3953:
URL: https://github.com/apache/carbondata/pull/3953#discussion_r496212659
##
File path:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecutorImpl.java
##
@@ -106,6 +108,11 @@
*/
VenuReddy2103 commented on a change in pull request #3953:
URL: https://github.com/apache/carbondata/pull/3953#discussion_r496212659
##
File path:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/RowLevelFilterExecutorImpl.java
##
@@ -106,6 +108,11 @@
*/
CarbonDataQA1 commented on pull request #3963:
URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700226423
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4264/
-
CarbonDataQA1 commented on pull request #3963:
URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700223919
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2519/
CarbonDataQA1 commented on pull request #3789:
URL: https://github.com/apache/carbondata/pull/3789#issuecomment-700218552
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4263/
-
CarbonDataQA1 commented on pull request #3789:
URL: https://github.com/apache/carbondata/pull/3789#issuecomment-700208844
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2518/
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700202083
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4262/
-
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700181171
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2517/
CarbonDataQA1 commented on pull request #3962:
URL: https://github.com/apache/carbondata/pull/3962#issuecomment-700169378
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2514/
CarbonDataQA1 commented on pull request #3962:
URL: https://github.com/apache/carbondata/pull/3962#issuecomment-700164625
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4259/
-
CarbonDataQA1 commented on pull request #3961:
URL: https://github.com/apache/carbondata/pull/3961#issuecomment-700164154
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700160169
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4258/
-
CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700157254
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2513/
CarbonDataQA1 commented on pull request #3963:
URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700142851
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4261/
-
CarbonDataQA1 commented on pull request #3963:
URL: https://github.com/apache/carbondata/pull/3963#issuecomment-700143229
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2516/
marchpure commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-700109547
> if alter column change nothing, the command should return directly without
execution.
I have modified code according to you suggestion.
--
CarbonDataQA1 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700098125
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2512/
CarbonDataQA1 commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-700093868
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4256/
-
akashrn5 opened a new pull request #3963:
URL: https://github.com/apache/carbondata/pull/3963
### Why is this PR needed?
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the cha
akashrn5 opened a new pull request #3962:
URL: https://github.com/apache/carbondata/pull/3962
### Why is this PR needed?
### What changes were proposed in this PR?
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the cha
akashrn5 opened a new pull request #3961:
URL: https://github.com/apache/carbondata/pull/3961
Fix cdc merge when there are multiple bucket and join columns and AND or OR
join expressions
### Why is this PR needed?
### What changes were proposed in this PR?
Klaus-xjp commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700055644
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700054701
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4255/
-
CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-700050277
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2510/
CarbonDataQA1 commented on pull request #3789:
URL: https://github.com/apache/carbondata/pull/3789#issuecomment-700045581
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2509/
CarbonDataQA1 commented on pull request #3789:
URL: https://github.com/apache/carbondata/pull/3789#issuecomment-700044480
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4254/
-
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495781902
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonCreateMVCommand.scala
##
@@ -192,9 +192,10 @@ case
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495781902
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonCreateMVCommand.scala
##
@@ -192,9 +192,10 @@ case
CarbonDataQA1 commented on pull request #419:
URL: https://github.com/apache/carbondata/pull/419#issuecomment-63862
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2511/
--
[
https://issues.apache.org/jira/browse/CARBONDATA-4011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ajantha Bhat resolved CARBONDATA-4011.
--
Fix Version/s: 2.1.0
Resolution: Fixed
> drop index table is failed with ta
asfgit closed pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ajantha-bhat commented on pull request #3957:
URL: https://github.com/apache/carbondata/pull/3957#issuecomment-699985962
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Klaus-xjp commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-699980681
retest this please
This is an automated message from the Apache Git Service.
To respond to the mess
Klaus-xjp commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r495774296
##
File path:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AbstractDFSCarbonFile.java
##
@@ -419,6 +419,24 @@ public boolean c
Klaus-xjp commented on pull request #3789:
URL: https://github.com/apache/carbondata/pull/3789#issuecomment-699975470
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, ple
[
https://issues.apache.org/jira/browse/CARBONDATA-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chetan Bhat closed CARBONDATA-4013.
---
Resolution: Invalid
https://issues.apache.org/jira/browse/CARBONDATA-3365
*Stage2:*
De
CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-699938521
Build Failed with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4253/
-
CarbonDataQA1 commented on pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#issuecomment-699935155
Build Failed with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2508/
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699883892
Build Success with Spark 2.4.5, Please check CI
http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2507/
CarbonDataQA1 commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699879852
Build Success with Spark 2.3.4, Please check CI
http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4252/
-
QiangCai commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699879164
if alter column change nothing, the command should return directly without
execution.
This is an automated
Kejian-Li commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699871798
> better to focus on the topic in this PR.
Got it, I will follow your suggestion
This is an automate
Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495781902
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonCreateMVCommand.scala
##
@@ -192,9 +192,10 @@ case
marchpure commented on pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#issuecomment-699854890
> 1. do we support alter column without any change?
> 2. how to remove comment from column
1. now, we support alter column without any change.
2. now. we don't s
QiangCai commented on pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#issuecomment-699851048
better to focus on the topic in this PR.
This is an automated message from the Apache Git Service.
To respon
QiangCai commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495757998
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/view/CarbonCreateMVCommand.scala
##
@@ -192,9 +192,10 @@ case c
Kejian-Li commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r495732821
##
File path:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
##
@@ -421,6 +421,12 @@ public boolean createN
Kejian-Li commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r495732821
##
File path:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/LocalCarbonFile.java
##
@@ -421,6 +421,12 @@ public boolean createN
Kejian-Li commented on a change in pull request #3945:
URL: https://github.com/apache/carbondata/pull/3945#discussion_r495732383
##
File path:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AbstractDFSCarbonFile.java
##
@@ -419,6 +419,24 @@ public boolean c
marchpure commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r495732016
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchemaCommon.scala
##
@@ -169,7 +169,8 @@ case clas
marchpure commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r495732160
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/DDLHelper.scala
##
@@ -230,14 +231,22 @@ object DDLHelper {
marchpure commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r495731759
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableColRenameDataTypeChangeCommand.scala
##
marchpure commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r495730277
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/catalyst/CarbonParserUtil.scala
##
@@ -1135,11 +1135,7 @@ object CarbonParserUti
marchpure commented on a change in pull request #3960:
URL: https://github.com/apache/carbondata/pull/3960#discussion_r495730277
##
File path:
integration/spark/src/main/scala/org/apache/spark/sql/catalyst/CarbonParserUtil.scala
##
@@ -1135,11 +1135,7 @@ object CarbonParserUti
71 matches
Mail list logo