[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

CarbonDataQA2 commented on pull request #4034: URL: https://github.com/apache/carbondata/pull/4034#issuecomment-770174545 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5383/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4034: [CARBONDATA-4091] support prestosql 333 integartion with carbon

CarbonDataQA2 commented on pull request #4034: URL: https://github.com/apache/carbondata/pull/4034#issuecomment-770174374 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3623/

[GitHub] [carbondata] asfgit closed pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

asfgit closed pull request #4074: URL: https://github.com/apache/carbondata/pull/4074 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Resolved] (CARBONDATA-4109) Improve carbondata coverage for presto-integration code

[ https://issues.apache.org/jira/browse/CARBONDATA-4109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-4109. -- Fix Version/s: 2.2.0 Resolution: Fixed > Improve carbondata coverage for pr

[jira] [Created] (CARBONDATA-4115) Return and show segment ID after successful load and insert, including patitioned table and normal table .

lihongzhao created CARBONDATA-4115: -- Summary: Return and show segment ID after successful load and insert, including patitioned table and normal table . Key: CARBONDATA-4115 URL: https://issues.apache.org/jira/br

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

akkio-97 commented on a change in pull request #4074: URL: https://github.com/apache/carbondata/pull/4074#discussion_r567001931 ## File path: integration/spark/src/test/scala/org/apache/carbondata/integration/spark/testsuite/dataload/SparkStoreCreatorForPresto.scala ## @@ -365

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

akkio-97 commented on a change in pull request #4074: URL: https://github.com/apache/carbondata/pull/4074#discussion_r567001721 ## File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestUsingSparkStore.scala ## @@ -20,14 +20,15 @@ p

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

CarbonDataQA2 commented on pull request #4074: URL: https://github.com/apache/carbondata/pull/4074#issuecomment-769951980 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5382/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

CarbonDataQA2 commented on pull request #4074: URL: https://github.com/apache/carbondata/pull/4074#issuecomment-769941718 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3622/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

CarbonDataQA2 commented on pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#issuecomment-769939912 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3621/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

CarbonDataQA2 commented on pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#issuecomment-769939153 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5381/ -

[GitHub] [carbondata] ajantha-bhat commented on pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

ajantha-bhat commented on pull request #4074: URL: https://github.com/apache/carbondata/pull/4074#issuecomment-769926506 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] Karan980 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

Karan980 commented on pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#issuecomment-769884076 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

CarbonDataQA2 commented on pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#issuecomment-769878179 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5380/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

CarbonDataQA2 commented on pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#issuecomment-769874496 Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3620/

[GitHub] [carbondata] ajantha-bhat commented on pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

ajantha-bhat commented on pull request #4074: URL: https://github.com/apache/carbondata/pull/4074#issuecomment-769848180 @akkio-97 : Please rebase the PR This is an automated message from the Apache Git Service. To respond to

[jira] [Resolved] (CARBONDATA-4104) Vector filling for Primitive decimal type needs to be handled

[ https://issues.apache.org/jira/browse/CARBONDATA-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ajantha Bhat resolved CARBONDATA-4104. -- Fix Version/s: 2.2.0 Resolution: Fixed > Vector filling for Primitive decim

[GitHub] [carbondata] asfgit closed pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

asfgit closed pull request #4073: URL: https://github.com/apache/carbondata/pull/4073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [carbondata] VenuReddy2103 commented on pull request #4078: [CARBONDATA-4075] Using withEvents instead of fireEvent

VenuReddy2103 commented on pull request #4078: URL: https://github.com/apache/carbondata/pull/4078#issuecomment-769842827 We still seem to have few more pre and post events being fired in conventional way. Yet to change them too ? --

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

CarbonDataQA2 commented on pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#issuecomment-769838251 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3619/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

CarbonDataQA2 commented on pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#issuecomment-769837818 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5379/ -

[GitHub] [carbondata] Karan980 commented on pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

Karan980 commented on pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#issuecomment-769821724 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [carbondata] Karan980 commented on a change in pull request #4070: [CARBONDATA-4082] Fix alter table add segment query on adding a segment having delete delta files.

Karan980 commented on a change in pull request #4070: URL: https://github.com/apache/carbondata/pull/4070#discussion_r566840116 ## File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala ## @@ -294,6 +297,49 @@ c

[GitHub] [carbondata] ajantha-bhat commented on pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

ajantha-bhat commented on pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#issuecomment-769791390 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

ajantha-bhat commented on a change in pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#discussion_r566804833 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalConverterFactory.java ## @@ -327,25 +287,28 @@ public BigDec

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

VenuReddy2103 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r566795460 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/DropTableTest.scala ## @@ -88,4 +90,16 @

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

ajantha-bhat commented on a change in pull request #4074: URL: https://github.com/apache/carbondata/pull/4074#discussion_r566783697 ## File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestUsingSparkStore.scala ## @@ -20,14 +20,15

[GitHub] [carbondata] ajantha-bhat removed a comment on pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

ajantha-bhat removed a comment on pull request #4074: URL: https://github.com/apache/carbondata/pull/4074#issuecomment-769764455 LGTM This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

ajantha-bhat commented on a change in pull request #4074: URL: https://github.com/apache/carbondata/pull/4074#discussion_r566782786 ## File path: integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestUsingSparkStore.scala ## @@ -20,14 +20,15

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

ajantha-bhat commented on a change in pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#discussion_r566780442 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalConverterFactory.java ## @@ -110,8 +110,8 @@ public BigDecim

[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

ajantha-bhat commented on a change in pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#discussion_r566778045 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalConverterFactory.java ## @@ -327,25 +287,28 @@ public BigDec

[GitHub] [carbondata] ajantha-bhat commented on pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

ajantha-bhat commented on pull request #4074: URL: https://github.com/apache/carbondata/pull/4074#issuecomment-769764455 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

VenuReddy2103 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r566752898 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestCarbonInternalMetastore.scala ## @@

[GitHub] [carbondata] akkio-97 commented on a change in pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

akkio-97 commented on a change in pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#discussion_r566734422 ## File path: core/src/main/java/org/apache/carbondata/core/metadata/datatype/DecimalConverterFactory.java ## @@ -324,33 +311,6 @@ public BigDecimal

[GitHub] [carbondata] akkio-97 closed pull request #4082: dummy PR

akkio-97 closed pull request #4082: URL: https://github.com/apache/carbondata/pull/4082 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4085: [CARBONDATA-4114] Handled empty result for select query result with load command

CarbonDataQA2 commented on pull request #4085: URL: https://github.com/apache/carbondata/pull/4085#issuecomment-769720591 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3618/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4085: [CARBONDATA-4114] Handled empty result for select query result with load command

CarbonDataQA2 commented on pull request #4085: URL: https://github.com/apache/carbondata/pull/4085#issuecomment-769719015 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5378/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

CarbonDataQA2 commented on pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#issuecomment-769715382 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3616/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-769714541 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5377/ -

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4076: [CARBONDATA-4107] Added related MV tables Map to fact table and added lock while touchMDTFile

CarbonDataQA2 commented on pull request #4076: URL: https://github.com/apache/carbondata/pull/4076#issuecomment-769713990 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3617/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4073: [CARBONDATA-4104] Vector filling for complex decimal type needs to be handled

CarbonDataQA2 commented on pull request #4073: URL: https://github.com/apache/carbondata/pull/4073#issuecomment-769709334 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5376/ -

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

Indhumathi27 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r566686354 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestSIWithSecondaryIndex.scala ## @@ -577

[GitHub] [carbondata] Indhumathi27 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

Indhumathi27 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r566685541 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestSIWithSecondaryIndex.scala ## @@ -577

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

VenuReddy2103 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r566680396 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestSIWithSecondaryIndex.scala ## @@ -57

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

CarbonDataQA2 commented on pull request #4074: URL: https://github.com/apache/carbondata/pull/4074#issuecomment-769676243 Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12444/job/ApacheCarbon_PR_Builder_2.4.5/3615/

[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4074: [CARBONDATA-4109] Improve carbondata coverage for presto-integration code

CarbonDataQA2 commented on pull request #4074: URL: https://github.com/apache/carbondata/pull/4074#issuecomment-769673025 Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12444/job/ApacheCarbonPRBuilder2.3/5375/ -

[jira] [Created] (CARBONDATA-4114) Select query is returning empty result when carbon.read.partition.hive.direct = false

Nihal kumar ojha created CARBONDATA-4114: Summary: Select query is returning empty result when carbon.read.partition.hive.direct = false Key: CARBONDATA-4114 URL: https://issues.apache.org/jira/browse/CARB

[GitHub] [carbondata] nihal0107 opened a new pull request #4085: Handled empty result for select query result with load command

nihal0107 opened a new pull request #4085: URL: https://github.com/apache/carbondata/pull/4085 ### Why is this PR needed? Currently when `carbon.read.partition.hive.direct = false` then select query with load command for the CSV file which contain multiple rows is returning empty resu

[GitHub] [carbondata] VenuReddy2103 commented on a change in pull request #4071: [CARBONDATA-4102] Added UT and FT to improve coverage of SI module.

VenuReddy2103 commented on a change in pull request #4071: URL: https://github.com/apache/carbondata/pull/4071#discussion_r566641195 ## File path: index/secondary-index/src/test/scala/org/apache/carbondata/spark/testsuite/secondaryindex/TestCreateIndexWithLoadAndCompaction.scala #