Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/3044
@akashrn5 This document doesn't mention about comment of âalter table
column renameâ.Is document missing this point?And Spark 2.1 version couldn't
support comment when alter table
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/3044
@akashrn5 Yeah,for example
ALTER TABLE [db_name.]table_name CHANGE old_col_name new_col_name
column_data_type comment ' '
Spark 2.1 couldn't support column coment
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/2969
@xubo245 @zzcclp @xuchuanyin I have already fixed hive integration bug
based on HiveExample.Please review these updates.
---
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/2969
@xubo245 @zzcclp @xuchuanyin I have already fixed hive integration bug
based on HiveExample.Please review these updates.
---
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r243259047
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -85,25 +82,35 @@ object HiveExample
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r243258830
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -49,17 +49,19 @@ object HiveExample
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r243259131
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -85,25 +82,35 @@ object HiveExample
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r243259414
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -22,52 +22,49 @@ import java.sql
Github user SteNicholas closed the pull request at:
https://github.com/apache/carbondata/pull/2969
---
GitHub user SteNicholas opened a pull request:
https://github.com/apache/carbondata/pull/3012
[CARBONDATA-3127]Fix the HiveExample & TestCarbonSerde exception
[CARBONDATA-3127]Hive module test case has been commented off,can' t run.
This pull request fix TestCarbonSerde
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3012#discussion_r243478043
--- Diff: examples/spark2/pom.xml ---
@@ -78,7 +83,12 @@
org.apache.httpcomponents
httpclient
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3012#discussion_r243478610
--- Diff:
examples/spark2/src/test/scala/org/apache/carbondata/examplesCI/RunExamples.scala
---
@@ -19,12 +19,12 @@ package
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/3004
@ravipesala This pull request doesn't work in #3012 .HiveExample run
exception through your changes.But this update does work in beeline.Therefore
will you check the cause of HiveExample
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3012#discussion_r243478363
--- Diff: examples/spark2/pom.xml ---
@@ -78,7 +83,12 @@
org.apache.httpcomponents
httpclient
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3012#discussion_r243478424
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/HiveExample.scala
---
@@ -30,44 +33,38 @@ object HiveExample
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/3004
@jackylk OK.I'd like to refactory on carbondata-hive module based on
@ravipesala update.
---
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/2969
@xubo245 Please review this request again include improvement of the
comments referred by @xuchuanyin .
---
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/2969
@xubo245 @zzcclp @xuchuanyin I have already fixed hive integration bug
based on HiveExample.Please review these updates.
---
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/3004
@ravipesala Could I refactor the current Hive integration code with you?
---
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/2954
@ravipesala @jackylk please review this, thanks.
---
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/2954
@chenliang613 Okay
---
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/2954
@chenliang613 @xubo245 I have already squash all commits to one
commit.Please review again.Thank you.
---
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r238089109
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerde.java
---
@@ -1,133 +1,133 @@
-///*
-// * Licensed
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/2969
@xubo245 @zzcclp Please review the small update.
---
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/2969
@zzcclp Please review this update;
---
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r238089149
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerde.java
---
@@ -1,133 +1,133 @@
-///*
-// * Licensed
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r238089137
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerde.java
---
@@ -1,133 +1,133 @@
-///*
-// * Licensed
GitHub user SteNicholas opened a pull request:
https://github.com/apache/carbondata/pull/2969
[CARBONDATA-3127]Fix the TestCarbonSerde exception
[CARBONDATA-3127]Hive module test case has been commented off,can' t run.
This pull request fix TestCarbonSerde test case exception
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r240113381
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r240113830
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r240114104
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r240113918
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/2969
@xuchuanyin @xubo245 Please review this request include improvement of the
comments referred by @xuchuanyin .
---
Github user SteNicholas closed the pull request at:
https://github.com/apache/carbondata/pull/2954
---
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r238936639
--- Diff:
integration/hive/src/test/java/org/apache/carbondata/hive/TestCarbonSerDe.java
---
@@ -0,0 +1,133 @@
+/*
+ * Licensed
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/2969
@zzcclp Please review this update.
---
GitHub user SteNicholas opened a pull request:
https://github.com/apache/carbondata/pull/2954
[CARBONDATA-3128]HiveExample has some exception
[CARBONDATA-3128]HiveExample has some exception
This pull request fix HiveExample exception with different spark
versions.When through
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r236551091
--- Diff: pom.xml ---
@@ -100,7 +100,6 @@
processing
hadoop
integration/spark-common
-integration/spark
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r236550005
--- Diff: pom.xml ---
@@ -545,16 +557,14 @@
spark-2.2
-
--- End diff --
Because
Github user SteNicholas commented on the issue:
https://github.com/apache/carbondata/pull/2954
Add RunHiveExample into CI test.
---
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r236627192
--- Diff:
integration/hive/src/test/scala/org/apache/carbondata/hiveexampleCI/RunHiveExample.scala
---
@@ -0,0 +1,51 @@
+/*
+ * Licensed
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2954#discussion_r236660688
--- Diff:
integration/hive/src/test/scala/org/apache/carbondata/hiveexampleCI/RunHiveExample.scala
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242814739
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -43,28 +43,25 @@ object HiveExample
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242815245
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -193,5 +196,4 @@ object HiveExample
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242815115
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -85,19 +82,25 @@ object HiveExample
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242815339
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
---
@@ -106,9 +107,17 @@ private static
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242815829
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -31,7 +31,7 @@ object HiveExample
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242814939
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -43,28 +43,25 @@ object HiveExample
Github user SteNicholas commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242815043
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -85,19 +82,25 @@ object HiveExample
49 matches
Mail list logo
