Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131063435
--- Diff: conf/carbon.properties.template ---
@@ -42,6 +42,9 @@ carbon.enableXXHash=true
#carbon.max.level.cache.size=-1
#enable prefetch
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131063552
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonPartitionExample.scala
---
@@ -101,17 +126,40 @@ object
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131063903
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -107,6 +107,7 @@
// comma separated list of input
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131067233
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/spliter/CarbonDataSpliterUtil.java
---
@@ -0,0 +1,40 @@
+/*
+ * Licensed
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131067032
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
---
@@ -321,6 +321,84 @@ private AbsoluteTableIdentifier
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r131067082
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonTableInputFormat.java
---
@@ -321,6 +321,84 @@ private AbsoluteTableIdentifier
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1192
Hi @ravipesala , please help review and merge PR1228 first and then retest
this PR. thank you~!
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user lionelcao opened a pull request:
https://github.com/apache/carbondata/pull/1228
[CARBONDATA-1357] fix convert bug
fix byte[] to string convert bug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lionelcao/carbondata
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1228
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1228
No failures found.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1192
PR1228 is merged, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1254#discussion_r133364318
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/timestamp/DateDirectDictionaryGenerator.java
---
@@ -154,14
GitHub user lionelcao opened a pull request:
https://github.com/apache/carbondata/pull/1173
[CARBONDATA-1209] add partitionId in show partition result
add partitionId in show partition result
change example to avoid truncate of result.
You can merge this pull request into a Git
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126328264
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/partition/RangeIntervalPartitioner.java
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126328243
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/partition/RangeIntervalPartitioner.java
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126328220
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/partition/RangeIntervalPartitioner.java
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126328139
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -188,7 +189,7 @@ object CommonUtil
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126328252
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/partition/RangeIntervalPartitioner.java
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126328234
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/partition/RangeIntervalPartitioner.java
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126328284
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java
---
@@ -264,4 +265,81 @@ public static BitSet
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126328012
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/partition/RangeIntervalPartitioner.java
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126327975
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/partition/RangeIntervalPartitioner.java
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126328001
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/partition/RangeIntervalPartitioner.java
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126327993
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/partition/RangeIntervalPartitioner.java
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126327873
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java
---
@@ -264,4 +265,81 @@ public static BitSet
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126327928
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/partition/RangeIntervalPartitioner.java
---
@@ -0,0 +1,206 @@
+/*
+ * Licensed
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126327814
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java
---
@@ -264,4 +265,81 @@ public static BitSet
GitHub user lionelcao opened a pull request:
https://github.com/apache/carbondata/pull/1180
fix comparator bug
fix comparator bug:
java.lang.String can not be cast to [B
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user lionelcao closed the pull request at:
https://github.com/apache/carbondata/pull/1180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user lionelcao opened a pull request:
https://github.com/apache/carbondata/pull/1183
[CARBONDATA-1312] fix list partition compare issue
need to convert string to bytes in list partition comparator
You can merge this pull request into a Git repository by running:
$ git
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1183#discussion_r128708018
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestQueryForPartitionTable.scala
---
@@ -77,8
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1183#discussion_r128707984
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java
---
@@ -63,6 +64,9 @@ public static BitSet
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1173#discussion_r128711561
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -585,38 +585,44 @@ object CommonUtil
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r129515426
--- Diff: conf/carbon.properties.template ---
@@ -42,6 +42,9 @@ carbon.enableXXHash=true
#carbon.max.level.cache.size=-1
#enable prefetch
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1192
# Feature Description
This feature is to support ADD & SPLIT partition function on CarbonData.
# Scope
Support range partition and list partition table
# Syntax Exa
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r129514953
--- Diff:
integration/spark-common-test/src/test/resources/partition_data.csv ---
@@ -0,0 +1,27 @@
+id,vin,logdate,phonenumber,country,area
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r129516143
--- Diff:
integration/spark-common-test/src/test/resources/partition_data.csv ---
@@ -0,0 +1,27 @@
+id,vin,logdate,phonenumber,country,area
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r129583064
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java
---
@@ -65,6 +65,31 @@ public PartitionInfo(List
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r129744678
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -308,6 +308,10 @@
@CarbonProperty
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r129740890
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonPartitionExample.scala
---
@@ -101,17 +126,40 @@ object
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1173#discussion_r128408941
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestShowPartitions.scala
---
@@ -146,31
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1173#discussion_r128408816
--- Diff:
examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonPartitionExample.scala
---
@@ -121,18 +121,18 @@ object
GitHub user lionelcao opened a pull request:
https://github.com/apache/carbondata/pull/1119
[CarbonData-1205] change default partition id from Max to 0
It's a preparation PR for later alter table partition PR.
1. change default partition id from Max to 0
2. remove some
GitHub user lionelcao opened a pull request:
https://github.com/apache/carbondata/pull/1125
[CarbonData-1250] change default partition id & Add TaskId group in
partitionInfo
This PR change the default partition id from Max to 0 and add taskId
management related code to sup
Github user lionelcao closed the pull request at:
https://github.com/apache/carbondata/pull/1119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1125#discussion_r125301950
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
---
@@ -219,6 +219,10
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1125#discussion_r125304887
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/partition/PartitionFilterUtil.java
---
@@ -229,35 +229,37 @@ public static
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1125#discussion_r125301153
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
---
@@ -219,6 +219,10
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1125#discussion_r126062042
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java
---
@@ -43,13 +44,30 @@
private List<L
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1125#discussion_r126062119
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java
---
@@ -43,13 +44,30 @@
private List<L
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1105#discussion_r126057425
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/partition/RangeIntervalPartition.java
---
@@ -0,0 +1,50
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1125#discussion_r126061892
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -417,18 +441,26 @@ protected Expression
GitHub user lionelcao opened a pull request:
https://github.com/apache/carbondata/pull/1216
[CARBONDATA-1344] Remove useless variables
remove aggTables & aggTableName
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lione
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r130504413
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/CarbonInputFormat.java ---
@@ -440,9 +510,17 @@ protected Expression getFilterPredicates
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r130506012
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/path/CarbonTablePath.java ---
@@ -303,6 +303,20 @@ public String getCarbonIndexFilePath
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r130506636
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java
---
@@ -65,6 +65,31 @@ public PartitionInfo(List
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1192#discussion_r130505076
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java
---
@@ -65,6 +65,31 @@ public PartitionInfo(List
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/983#discussion_r119335023
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -169,7 +169,7 @@ object CommonUtil
Github user lionelcao closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/882
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/882#discussion_r114960569
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala
---
@@ -347,43 +356,65
Github user lionelcao closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/876
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lionelcao closed the pull request at:
https://github.com/apache/carbondata/pull/661
---
GitHub user lionelcao opened a pull request:
https://github.com/apache/carbondata/pull/1369
[CARBONDATA-1448] fix partitionInfo null issue in CarbonTableInputFormat
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lionelcao
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1336
LGTM
---
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1259#discussion_r139330679
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/PartitionInfo.java
---
@@ -17,17 +17,21 @@
package
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1317
Refer to below guidance for illustration of drop partition function:
https://github.com/apache/carbondata/blob/master/docs/partition-guide.md#drop-a-partition
---
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1394
LGTM
---
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1380
retest this please
---
GitHub user lionelcao opened a pull request:
https://github.com/apache/carbondata/pull/1276
[CARBONDATA-1401] fix duplicate issue in ListInfo
add validation for listInfo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lionelcao
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1276#discussion_r135380693
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -369,6 +369,14 @@ object CommonUtil
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1258#discussion_r135380833
--- Diff: docs/partition-guide.md ---
@@ -0,0 +1,124 @@
+
+
+### CarbonData Partition Table Guidance
+This guidance illustrates how
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1258#discussion_r135381322
--- Diff: docs/partition-guide.md ---
@@ -0,0 +1,124 @@
+
+
+### CarbonData Partition Table Guidance
+This guidance illustrates how
GitHub user lionelcao opened a pull request:
https://github.com/apache/carbondata/pull/1317
[CARBONDATA-1316] drop partition
Drop partition function
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lionelcao/carbondata
Github user lionelcao closed the pull request at:
https://github.com/apache/carbondata/pull/1276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1422
LGTM
---
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1658
Hi, For hash partition we only need to show number of partitions. Why need
to show the ids?
---
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1661#discussion_r157131588
--- Diff:
integration/spark-common/src/main/scala/org/apache/spark/util/PartitionUtils.scala
---
@@ -113,7 +113,8 @@ object PartitionUtils
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1658
Hi @SangeetaGulia ,
look into the first image in the jira, under the highlighted text, we said
the alter partition operation is not supported for hash partition table. So we
don't show
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1452
LGTM
---
Github user lionelcao closed the pull request at:
https://github.com/apache/carbondata/pull/716
---
Github user lionelcao commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1452#discussion_r147917263
--- Diff:
integration/spark2/src/test/scala/org/apache/carbondata/spark/testsuite/partition/TestAlterPartitionTable.scala
---
@@ -779,6 +779,23
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1434
@chenliang613 Please help review.
---
Github user lionelcao commented on the issue:
https://github.com/apache/carbondata/pull/1434
LGTM
---
83 matches
Mail list logo
