Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1574#discussion_r153428387
--- Diff:
integration/spark-common-cluster-test/src/test/scala/org/apache/carbondata/cluster/sdv/generated/AlterTableTestCase.scala
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1562#discussion_r153195294
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/LoadTableCommand.scala
---
@@ -139,6 +140,15
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1563
Apart from 1 comment given, LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1563#discussion_r153193171
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonSessionState.scala
---
@@ -146,22 +149,31 @@ class
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1562
Apart from 1 comment given, LGTM
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1562#discussion_r153192273
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/LoadTableCommand.scala
---
@@ -139,6 +140,15
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1560
LGMT
---
Github user manishgupta88 closed the pull request at:
https://github.com/apache/carbondata/pull/1416
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1416
Code already merged as part of PR #1473
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1416#discussion_r146236785
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/events/Events.scala ---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1416
@jackylk ..This PR will provide an event listener interface using which you
can register the events based on the need of your operations. For example
before dropping a table you need
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1395
[CARBONDATA-1533] Fixed decimal data load fail issue and restricted max
characters per column
1. Fixed data load failure when both precision and data falls in integer
range for decimal
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1378
[CARBONDATA-1509] Fixed bug for maintaining compatibility of decimal type
with older releases of Carbondata
In old Carbondata releases, precision and scale is not stored for decimal
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1368
retest this please
---
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1373
LGTM
---
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1368
[CARBONDATA-1486] Fixed issue of table status updation on insert overwrite
failure and exception thrown while deletion of stale folders
Issues Fixed as part of this PR:
1. Fixed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1352#discussion_r139074844
--- Diff:
core/src/main/java/org/apache/carbondata/core/streaming/CarbonStreamingCommitInfo.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1297#discussion_r138941702
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/UnsafeDecimalColumnPage.java
---
@@ -0,0 +1,274
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1297#discussion_r138941633
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
@@ -22,21 +22,48 @@
import
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1297#discussion_r138941549
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
@@ -22,21 +22,48 @@
import
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1297
@jackylk ..handled review comments
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1297#discussion_r136260340
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/SafeFixLengthColumnPage.java
---
@@ -165,9 +165,28 @@ public double
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1297
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r135974069
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryMessage.java
---
@@ -112,20 +110,12 @@ private
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1297
[WIP] Added a value based compression for decimal data type when decimal is
stored as Int or Long
Added a value based compression for decimal data type when decimal is
stored as Int
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1213
Already merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user manishgupta88 closed the pull request at:
https://github.com/apache/carbondata/pull/1213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1213
[WIP] Fixed bugs for spark conf property and debugging in windows
Fixes include:
1. In spark 2, spark conf once set in spark context cannot be modified with
the same context again
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1191
[WIP] Fixed high priority findbug issues in the code
Fixed high priority findbug issues in the code
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1187
[WIP] Modified code to support concurrent data load
Modified code to support concurrent data load. Changes done
1. Removed meta.lock file
2. Modified code to add for the new load
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1166#discussion_r127131222
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonGlobalDictionaryRDD.scala
---
@@ -83,7 +84,12 @@ case
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1166#discussion_r127131068
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1308,6 +1308,11 @@
public static
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1147
[WIP][CARBONDATA-1277] Dictionary generation failure if there is failure in
closing output steam in HDFS
Analysis: If there is any failure while closing the output stream of
dictionary
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124217843
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/steps/DataWriterProcessorStepImpl.java
---
@@ -83,10 +87,20
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124217603
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/converter/impl/DictionaryFieldConverterImpl.java
---
@@ -80,11
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124217513
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/newflow/AbstractDataLoadProcessorStep.java
---
@@ -95,6 +96,18 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124216697
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java
---
@@ -141,11 +147,12 @@ public
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124216604
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -358,7 +358,17 @@ case class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124215370
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -358,7 +358,17 @@ case class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124214779
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -640,7 +640,16 @@ object
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124213355
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -1099,15 +1099,18 @@ object
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124213243
--- Diff:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
---
@@ -808,10 +808,10 @@ object
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124213032
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/GlobalDictionaryUtil.scala
---
@@ -867,6 +868,11 @@ object
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124212817
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonGlobalDictionaryRDD.scala
---
@@ -442,7 +456,15 @@ class
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124194927
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/CarbonSessionExample.scala
---
@@ -51,7 +51,7 @@ object
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124194537
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java
---
@@ -146,21 +147,31 @@ public void shutdown
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124194437
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/server/DictionaryServer.java
---
@@ -146,21 +147,31 @@ public void shutdown
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124192252
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/key/DictionaryMessage.java
---
@@ -55,6 +60,10 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124189008
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/ServerDictionaryGenerator.java
---
@@ -64,24 +66,34 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124188911
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/ServerDictionaryGenerator.java
---
@@ -64,24 +66,34 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124188774
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/ServerDictionaryGenerator.java
---
@@ -64,24 +66,34 @@ public void
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124188599
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/ServerDictionaryGenerator.java
---
@@ -40,21 +42,21
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1097#discussion_r124188452
--- Diff:
core/src/main/java/org/apache/carbondata/core/dictionary/generator/ServerDictionaryGenerator.java
---
@@ -40,21 +42,21
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1032#discussion_r124182621
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -288,6 +297,69 @@ object CommonUtil
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1080
[CARBONDATA-1217] Failure in data load when we first load the bad record
and then valid record and bad record action is set to Fail
Problem: Failure in data load when we first load
Github user manishgupta88 closed the pull request at:
https://github.com/apache/carbondata/pull/1032
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user manishgupta88 reopened a pull request:
https://github.com/apache/carbondata/pull/1032
[CARBONDATA-1149] Fixed range info overlapping values issue
Fixed range info overlapping values issue. Added data type based validation
for sorting range info values for checking
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/1074
@jackylk ...handled review comment...please check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1074
[CARBONDATA-1212] Memory leak in case of compaction when unsafe is true
Problem: Memory leak in case of compaction when unsafe is true
Analysis: In case of compaction
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/1032
[WIP] Fixed range info overlapping values issue
Fixed range info overlapping values issue. Added data type based validation
for sorting range info values for checking if there are any
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1023#discussion_r121863383
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -179,6 +193,68 @@ object CommonUtil
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1023#discussion_r121855817
--- Diff:
integration/spark-common/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
---
@@ -179,6 +193,68 @@ object CommonUtil
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/996
[WIP] Executor lost failure in case of data load failure due to bad records
Problem: Executor lost failure in case of data load failure due to bad
records
Analysis: In case when
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/978#discussion_r119785140
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
---
@@ -488,13 +488,19 @@ private
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/981#discussion_r119526605
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/executer/ExcludeFilterExecuterImpl.java
---
@@ -35,14 +33,19
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/983
[CARBONDATA-1113] Added validation for partition columns
Add various validation to partition columns like:-
1. Partition columns cannot be drop using alter command
2. Range
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/970
[CARBONDATA-1104] Query failure while using unsafe for query execution
numeric data type column specified as sort column
Problem: Query failure while using unsafe for query execution
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/952
[CARBONDATA-1094] Wrong results returned by the query in case inverted
index is not created on a column
Problem: Wrong results returned by the query in case inverted index is not
created
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/922
[CARBONDATA-1062] Data load fails if a column specified as sort column is
of numeric data type
Problem: If a numeric data type column is specified as sort column and if
it contains non
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/904
[CARBONDATA-1045] Mismatch in message display with insert and load
operation on failure due to bad records in update operation
Problem: When bad records action is set to fail and any IUD
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/841#discussion_r113147895
--- Diff:
integration/spark2/src/test/scala/org/apache/spark/carbondata/restructure/rowreader/AddColumnTestCases.scala
---
@@ -207,6
701 - 771 of 771 matches
Mail list logo
