[GitHub] [carbondata] Karan980 commented on a change in pull request #3946: [CARBONDATA-4002] Fix removal of columns from table schema.

2020-09-22 Thread GitBox 


Karan980 commented on a change in pull request #3946:
URL: https://github.com/apache/carbondata/pull/3946#discussion_r493224739



##
File path: 
integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##
@@ -442,7 +442,11 @@ object AlterTableUtil {
 // update schema for long string columns
 updateSchemaForLongStringColumns(thriftTable, longStringColumns.get)
   } else if (propKeys.exists(_.equalsIgnoreCase("long_string_columns") && 
!set)) {
-updateSchemaForLongStringColumns(thriftTable, "")
+val varcharColumns = 
carbonTable.getTableInfo.getFactTable.getListOfColumns.asScala.toList

Review comment:
   Done

##
File path: 
integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##
@@ -442,7 +442,11 @@ object AlterTableUtil {
 // update schema for long string columns
 updateSchemaForLongStringColumns(thriftTable, longStringColumns.get)
   } else if (propKeys.exists(_.equalsIgnoreCase("long_string_columns") && 
!set)) {
-updateSchemaForLongStringColumns(thriftTable, "")
+val varcharColumns = 
carbonTable.getTableInfo.getFactTable.getListOfColumns.asScala.toList

Review comment:
   Done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Karan980 commented on a change in pull request #3946: [CARBONDATA-4002] Fix removal of columns from table schema.

2020-09-22 Thread GitBox 


Karan980 commented on a change in pull request #3946:
URL: https://github.com/apache/carbondata/pull/3946#discussion_r492735831



##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala
##
@@ -434,6 +437,24 @@ class VarcharDataTypesBasicTestCase extends QueryTest with 
BeforeAndAfterEach wi
 
 sql("DROP TABLE IF EXISTS varchar_complex_table")
   }
+
+  test("check new columns after modifying schema through alter table queries") 
{
+sql(
+  s"""
+ | CREATE TABLE if not exists $longStringTable(

Review comment:
   Done

##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala
##
@@ -434,6 +437,24 @@ class VarcharDataTypesBasicTestCase extends QueryTest with 
BeforeAndAfterEach wi
 
 sql("DROP TABLE IF EXISTS varchar_complex_table")
   }
+
+  test("check new columns after modifying schema through alter table queries") 
{
+sql(
+  s"""
+ | CREATE TABLE if not exists $longStringTable(
+ | id INT, name STRING, description STRING, address STRING, note STRING
+ | ) STORED AS carbondata
+ | TBLPROPERTIES('sort_columns'='id,name')
+ |""".
+stripMargin)

Review comment:
   Done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [carbondata] Karan980 commented on a change in pull request #3946: [CARBONDATA-4002] Fix removal of columns from table schema.

2020-09-22 Thread GitBox 


Karan980 commented on a change in pull request #3946:
URL: https://github.com/apache/carbondata/pull/3946#discussion_r492735831



##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala
##
@@ -434,6 +437,24 @@ class VarcharDataTypesBasicTestCase extends QueryTest with 
BeforeAndAfterEach wi
 
 sql("DROP TABLE IF EXISTS varchar_complex_table")
   }
+
+  test("check new columns after modifying schema through alter table queries") 
{
+sql(
+  s"""
+ | CREATE TABLE if not exists $longStringTable(

Review comment:
   Done

##
File path: 
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/longstring/VarcharDataTypesBasicTestCase.scala
##
@@ -434,6 +437,24 @@ class VarcharDataTypesBasicTestCase extends QueryTest with 
BeforeAndAfterEach wi
 
 sql("DROP TABLE IF EXISTS varchar_complex_table")
   }
+
+  test("check new columns after modifying schema through alter table queries") 
{
+sql(
+  s"""
+ | CREATE TABLE if not exists $longStringTable(
+ | id INT, name STRING, description STRING, address STRING, note STRING
+ | ) STORED AS carbondata
+ | TBLPROPERTIES('sort_columns'='id,name')
+ |""".
+stripMargin)

Review comment:
   Done





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org