[GitHub] carbondata pull request #2503: [CARBONDATA-2734] Update is not working on th...
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2503 ---
[GitHub] carbondata pull request #2503: [CARBONDATA-2734] Update is not working on th...
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2503#discussion_r204272253
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -3235,4 +3235,17 @@ public boolean accept(CarbonFile file) {
int version = fileHeader.getVersion();
return ColumnarFormatVersion.valueOf((short)version);
}
+
+ /**
+ * Check whether it is standard table means tablepath has
Fact/Part0/Segment_ tail present with
+ * all carbon files. In other cases carbon files present directly under
tablepath or
+ * tablepath/partition folder
+ * TODO Read segment file and corresponding index file to get the
correct carbondata file instead
+ * of using this way.
+ * @param table
+ * @return
+ */
+ public static boolean isStandardCarbonTable(CarbonTable table) {
+return !(table.isSupportFlatFolder() || table.isHivePartitionTable());
--- End diff --
ok
---
[GitHub] carbondata pull request #2503: [CARBONDATA-2734] Update is not working on th...
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2503#discussion_r204213984
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -3235,4 +3235,17 @@ public boolean accept(CarbonFile file) {
int version = fileHeader.getVersion();
return ColumnarFormatVersion.valueOf((short)version);
}
+
+ /**
+ * Check whether it is standard table means tablepath has
Fact/Part0/Segment_ tail present with
+ * all carbon files. In other cases carbon files present directly under
tablepath or
+ * tablepath/partition folder
+ * TODO Read segment file and corresponding index file to get the
correct carbondata file instead
+ * of using this way.
+ * @param table
+ * @return
+ */
+ public static boolean isStandardCarbonTable(CarbonTable table) {
+return !(table.isSupportFlatFolder() || table.isHivePartitionTable());
--- End diff --
This check is not valid here as some places they are explicitly checking
it.
---
[GitHub] carbondata pull request #2503: [CARBONDATA-2734] Update is not working on th...
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2503#discussion_r204202741
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonUtil.java ---
@@ -3235,4 +3235,17 @@ public boolean accept(CarbonFile file) {
int version = fileHeader.getVersion();
return ColumnarFormatVersion.valueOf((short)version);
}
+
+ /**
+ * Check whether it is standard table means tablepath has
Fact/Part0/Segment_ tail present with
+ * all carbon files. In other cases carbon files present directly under
tablepath or
+ * tablepath/partition folder
+ * TODO Read segment file and corresponding index file to get the
correct carbondata file instead
+ * of using this way.
+ * @param table
+ * @return
+ */
+ public static boolean isStandardCarbonTable(CarbonTable table) {
+return !(table.isSupportFlatFolder() || table.isHivePartitionTable());
--- End diff --
Please add a check for sdk case also
CarbonTable.isTransactionalTable()
---
[GitHub] carbondata pull request #2503: [CARBONDATA-2734] Update is not working on th...
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2503#discussion_r202945784
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/DeleteExecution.scala
---
@@ -134,7 +134,7 @@ object DeleteExecution {
groupedRows.toIterator,
timestamp,
rowCountDetailsVO,
- carbonTable.isHivePartitionTable)
+ segmentFile)
--- End diff --
Ok, But passed Segment
---
[GitHub] carbondata pull request #2503: [CARBONDATA-2734] Update is not working on th...
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2503#discussion_r202508061
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/DeleteExecution.scala
---
@@ -134,7 +134,7 @@ object DeleteExecution {
groupedRows.toIterator,
timestamp,
rowCountDetailsVO,
- carbonTable.isHivePartitionTable)
+ segmentFile)
--- End diff --
Is it better to pass SegmentStatus instead of string, to have better
encapsulation
---
[GitHub] carbondata pull request #2503: [CARBONDATA-2734] Update is not working on th...
GitHub user ravipesala opened a pull request: https://github.com/apache/carbondata/pull/2503 [CARBONDATA-2734] Update is not working on the table which has segmentfile present It reverts to the PR https://github.com/apache/carbondata/pull/2385 It fixes the IUD on the flat folder. Be sure to do all of the following checklist to help us incorporate your contribution quickly and easily: - [ ] Any interfaces changed? - [ ] Any backward compatibility impacted? - [ ] Document update required? - [ ] Testing done Please provide details on - Whether new unit test cases have been added or why no new tests are required? - How it is tested? Please attach test report. - Is it a performance related change? Please attach the performance test report. - Any additional information to help reviewers in testing this change. - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ravipesala/incubator-carbondata flat-folder-update-issue Alternatively you can review and apply these changes as the patch at: https://github.com/apache/carbondata/pull/2503.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2503 commit caf2304736741748e6ba896d5ba29333ee95defc Author: ravipesala Date: 2018-07-13T07:45:15Z Update is not working on the table which has segmentfile present ---
