[GitHub] carbondata pull request #2540: [CARBONDATA-2649] Handled executor min/max pr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2540


---

[GitHub] carbondata pull request #2540: [CARBONDATA-2649] Handled executor min/max pr...

[manishgupta88]

Github user manishgupta88 commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2540#discussion_r204682071
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/blocklet/BlockletInfo.java
 ---
@@ -221,7 +223,30 @@ public void setNumberOfPages(int numberOfPages) {
   output.writeInt(measureChunksLength.get(i));
 }
 writeChunkInfoForOlderVersions(output);
+serializeMinMaxValues(output);
+  }
 
+  /**
+   * serialize min max values
+   *
+   * @param output
+   * @throws IOException
+   */
+  private void serializeMinMaxValues(DataOutput output) throws IOException 
{
--- End diff --

ok..I will remove serialization of min/max and read footer using 
useMinMaxForPruning flag


---

[GitHub] carbondata pull request #2540: [CARBONDATA-2649] Handled executor min/max pr...

[ravipesala]

Github user ravipesala commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2540#discussion_r204630970
  
--- Diff: 
core/src/main/java/org/apache/carbondata/core/metadata/blocklet/BlockletInfo.java
 ---
@@ -221,7 +223,30 @@ public void setNumberOfPages(int numberOfPages) {
   output.writeInt(measureChunksLength.get(i));
 }
 writeChunkInfoForOlderVersions(output);
+serializeMinMaxValues(output);
+  }
 
+  /**
+   * serialize min max values
+   *
+   * @param output
+   * @throws IOException
+   */
+  private void serializeMinMaxValues(DataOutput output) throws IOException 
{
--- End diff --

I don't think it is required to serailaize the min/max from driver. if 
columns are not cached then read footer from executor side.


---