[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-26 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r212832743 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonCreateTableCommand.scala --- @@ -49,6 +49,8 @@ case

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-24 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r212535141 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonConfiguration.java --- @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-24 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r212534871 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java --- @@ -43,12 +46,6 @@ */ private static

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r211931833 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -435,14 +436,16 @@ class

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r211930856 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/rdd/CarbonScanRDD.scala --- @@ -435,14 +436,16 @@ class

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r211928521 --- Diff: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala --- @@ -64,6 +65,7 @@

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r211927982 --- Diff:

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-22 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r211922952 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java --- @@ -407,7 +407,7 @@ private void validateLockType() {

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-09 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r208935162 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonConfiguration.java --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

[GitHub] carbondata pull request #2623: [CARBONDATA-2844] add sk ak to file factory o...

2018-08-09 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2623#discussion_r208933428 --- Diff: core/src/main/java/org/apache/carbondata/core/util/CarbonConfiguration.java --- @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache