Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2829
---
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r228124274
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -371,8 +381,14 @@ public CarbonWriter build() throws
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r228124241
--- Diff: format/src/main/thrift/carbondata.thrift ---
@@ -206,6 +206,7 @@ struct FileFooter3{
4: optional list blocklet_info_list3; //
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r228124157
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/CarbonDataLoadConfiguration.java
---
@@ -460,4 +464,20 @@ public String
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r228123974
--- Diff:
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r228124063
--- Diff:
integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/SparkCarbonDataSourceTest.scala
---
@@ -984,7 +984,7
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r228124017
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
---
@@
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r228123905
--- Diff: format/src/main/thrift/carbondata.thrift ---
@@ -206,6 +206,8 @@ struct FileFooter3{
4: optional list blocklet_info_list3; //
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r228034556
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1845,6 +1845,21 @@
public static final
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r227679135
--- Diff: format/src/main/thrift/carbondata.thrift ---
@@ -206,6 +206,7 @@ struct FileFooter3{
4: optional list blocklet_info_list3; //
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r227678463
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -1845,6 +1845,21 @@
public static final int
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r226979070
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -76,6 +81,19 @@ public static Schema
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r226722751
--- Diff: format/src/main/thrift/carbondata.thrift ---
@@ -206,6 +206,7 @@ struct FileFooter3{
4: optional list blocklet_info_list3; //
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r226546096
--- Diff: format/src/main/thrift/carbondata.thrift ---
@@ -206,6 +206,7 @@ struct FileFooter3{
4: optional list blocklet_info_list3; //
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r226233891
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -76,6 +80,17 @@ public static Schema
Github user akashrn5 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r226229213
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/CarbonDataLoadConfiguration.java
---
@@ -460,4 +464,20 @@ public String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r226220780
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -76,6 +80,17 @@ public static Schema
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r226219943
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/CarbonDataLoadConfiguration.java
---
@@ -460,4 +464,20 @@ public String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r226219753
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/CarbonDataLoadConfiguration.java
---
@@ -460,4 +464,20 @@ public String
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r226219429
--- Diff:
integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/SparkCarbonDataSourceTest.scala
---
@@ -984,7 +984,7
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r226219140
--- Diff:
integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestNonTransactionalCarbonTable.scala
---
@@
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r226218950
--- Diff:
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2829#discussion_r226218717
--- Diff: format/src/main/thrift/carbondata.thrift ---
@@ -206,6 +206,8 @@ struct FileFooter3{
4: optional list blocklet_info_list3; //
GitHub user akashrn5 opened a pull request:
https://github.com/apache/carbondata/pull/2829
[CARBONDATA-3025]add more metadata in carbon file footer
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any
24 matches
Mail list logo
