[GitHub] carbondata pull request #2897: [CARBONDATA-3080] Supporting local dictionary...

2018-12-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/2897 ---

[GitHub] carbondata pull request #2897: [CARBONDATA-3080] Supporting local dictionary...

2018-12-24 Thread BJangir
Github user BJangir commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2897#discussion_r243812841 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java --- @@ -68,6 +67,10 @@ private

[GitHub] carbondata pull request #2897: [CARBONDATA-3080] Supporting local dictionary...

2018-12-24 Thread BJangir
Github user BJangir commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2897#discussion_r243812352 --- Diff: core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java --- @@ -173,6 +174,7 @@ public synchronized void

[GitHub] carbondata pull request #2897: [CARBONDATA-3080] Supporting local dictionary...

2018-12-24 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2897#discussion_r243810091 --- Diff: hadoop/src/main/java/org/apache/carbondata/hadoop/util/CarbonVectorizedRecordReader.java --- @@ -68,6 +67,10 @@ private

[GitHub] carbondata pull request #2897: [CARBONDATA-3080] Supporting local dictionary...

2018-12-24 Thread ravipesala
Github user ravipesala commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2897#discussion_r243810009 --- Diff: core/src/main/java/org/apache/carbondata/core/memory/UnsafeMemoryManager.java --- @@ -173,6 +174,7 @@ public synchronized void

[GitHub] carbondata pull request #2897: [CARBONDATA-3080] Supporting local dictionary...

2018-12-18 Thread BJangir
Github user BJangir commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2897#discussion_r242629291 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java --- @@ -94,10 +93,9 @@ public

[GitHub] carbondata pull request #2897: [CARBONDATA-3080] Supporting local dictionary...

2018-12-17 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/2897#discussion_r242423291 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/impl/LocalDictDimensionDataChunkStore.java --- @@ -94,10 +93,9 @@