[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-27 Thread manishnalla1994
Github user manishnalla1994 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3022#discussion_r244118775 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java --- @@ -356,9 +359,20 @@ public

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-26 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3022#discussion_r244085418 --- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/complexType/TestCompactionComplexType.scala

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-26 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3022#discussion_r244086878 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -699,4 +701,33 @@ public static

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-26 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3022#discussion_r244086110 --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerModel.java --- @@ -356,9 +359,20 @@ public static

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-26 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3022#discussion_r244087077 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -699,4 +701,33 @@ public static

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-26 Thread manishgupta88
Github user manishgupta88 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3022#discussion_r244086909 --- Diff: processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java --- @@ -699,4 +701,33 @@ public static

[GitHub] carbondata pull request #3022: [CARBONDATA-3196] Fixed Compaction for Comple...

2018-12-24 Thread manishnalla1994
GitHub user manishnalla1994 opened a pull request: https://github.com/apache/carbondata/pull/3022 [CARBONDATA-3196] Fixed Compaction for Complex types with Dictionary Include Problem: Compaction Failing for Complex datatypes with Dictionary Include as KeyGenenrator was not being