[jira] [Commented] (CLOUDSTACK-10352) XenServer: Support online storage migration from non-managed to managed storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459405#comment-16459405 ] ASF GitHub Bot commented on CLOUDSTACK-10352: - mike-tutkowski commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-385585217 I doubt this Jenkins error has anything to do this with PR: --- T E S T S --- Running common.ClientTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.408 sec - in common.ClientTest Running rdpclient.MockServerTest Error in mock server: Received fatal alert: handshake_failure javax.net.ssl.SSLHandshakeException: Received fatal alert: handshake_failure at sun.security.ssl.Alerts.getSSLException(Alerts.java:192) at sun.security.ssl.Alerts.getSSLException(Alerts.java:154) at sun.security.ssl.SSLSocketImpl.recvAlert(SSLSocketImpl.java:2038) at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java:1135) at sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1385) at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1413) at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1397) at streamer.debug.MockServer.run(MockServer.java:122) at java.lang.Thread.run(Thread.java:748) Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.56 sec <<< FAILURE! - in rdpclient.MockServerTest testIsMockServerCanUpgradeConnectionToSsl(rdpclient.MockServerTest) Time elapsed: 0.556 sec <<< ERROR! javax.net.ssl.SSLHandshakeException: No appropriate protocol (protocol is disabled or cipher suites are inappropriate) at sun.security.ssl.Handshaker.activate(Handshaker.java:529) at sun.security.ssl.SSLSocketImpl.kickstartHandshake(SSLSocketImpl.java:1492) at sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSocketImpl.java:1361) at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1413) at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:1397) at rdpclient.MockServerTest.testIsMockServerCanUpgradeConnectionToSsl(MockServerTest.java:166) Running streamer.ByteBufferTest Tests run: 400, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.092 sec - in streamer.ByteBufferTest Running streamer.BaseElementTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.024 sec - in streamer.BaseElementTest Results : Tests in error: MockServerTest.testIsMockServerCanUpgradeConnectionToSsl:166 » SSLHandshake No... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer: Support online storage migration from non-managed to managed > storage > --- > > Key: CLOUDSTACK-10352 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10352 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server, XenServer > Environment: XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski >Priority: Major > Fix For: 4.12.0.0 > > > Allow a user to online migrate a volume from non-managed storage to managed > storage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459372#comment-16459372 ] ASF GitHub Bot commented on CLOUDSTACK-9114: blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385577308 Trillian test result (tid-2553) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53363 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2508-t2553-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_network.py Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 63 look OK, 4 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_reboot_router | `Failure` | 478.10 | test_network.py test_02_vpc_privategw_static_routes | `Failure` | 202.70 | test_privategw_acl.py test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 207.98 | test_privategw_acl.py test_04_rvpc_privategw_static_routes | `Failure` | 597.12 | test_privategw_acl.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 402.71 | test_routers_network_ops.py test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 749.84 | test_routers_network_ops.py test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 760.36 | test_routers_network_ops.py test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 2.26 | test_host_maintenance.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > restartnetwork with cleanup should not update/restart both routers at once > -- > > Key: CLOUDSTACK-9114 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou >Priority: Major > > for now, restartnetwork with cleanup will stop both RVRs at first, then start > two new RVRs. > to reduce the downtime of network, we'd better restart the RVRs one by one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10352) XenServer: Support online storage migration from non-managed to managed storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459148#comment-16459148 ] ASF GitHub Bot commented on CLOUDSTACK-10352: - mike-tutkowski commented on issue #2502: [CLOUDSTACK-10352] XenServer: Support online migration of a virtual disk from non-managed to managed storage URL: https://github.com/apache/cloudstack/pull/2502#issuecomment-385543312 Whoops, I meant @borisstoyanov had approved it. :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > XenServer: Support online storage migration from non-managed to managed > storage > --- > > Key: CLOUDSTACK-10352 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10352 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server, XenServer > Environment: XenServer >Reporter: Mike Tutkowski >Assignee: Mike Tutkowski >Priority: Major > Fix For: 4.12.0.0 > > > Allow a user to online migrate a volume from non-managed storage to managed > storage. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9781) ACS records ID in events tables instead of UUID.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458969#comment-16458969 ] ASF GitHub Bot commented on CLOUDSTACK-9781: blueorangutan commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID. URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-385510218 Trillian test result (tid-2554) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 30007 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1940-t2554-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_certauthority_root.py Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_usage.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 62 look OK, 5 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_extract_template | `Failure` | 128.35 | test_templates.py ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py test_01_secured_vm_migration | `Error` | 36.36 | test_vm_life_cycle.py test_02_not_secured_vm_migration | `Error` | 37.39 | test_vm_life_cycle.py test_03_secured_to_nonsecured_vm_migration | `Error` | 36.35 | test_vm_life_cycle.py test_04_nonsecured_to_secured_vm_migration | `Error` | 37.38 | test_vm_life_cycle.py test_06_download_detached_volume | `Failure` | 143.82 | test_volumes.py test_11_migrate_volume_and_change_offering | `Error` | 128.66 | test_volumes.py test_hostha_enable_ha_when_host_in_maintenance | `Error` | 3.44 | test_hostha_kvm.py This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS records ID in events tables instead of UUID. > > > Key: CLOUDSTACK-9781 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9781 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Jayant Patil >Priority: Major > > ISSUE > = > Wrong presentation of volume id in ACS events. > While creating a snapshot, only volume ID is mentioned in the events. For > example, “Scheduled async job for creating snapshot for volume Id:270". On > looking into the notification, user is not able to identify the volume. So > modified event description with UUID. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458627#comment-16458627 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - blueorangutan commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385414697 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10223) Snapshots are not getting deleted when domain is deleted
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458626#comment-16458626 ] ASF GitHub Bot commented on CLOUDSTACK-10223: - DaanHoogland commented on issue #2399: CLOUDSTACK-10223 delete snapshots when deleting domain URL: https://github.com/apache/cloudstack/pull/2399#issuecomment-385414441 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Snapshots are not getting deleted when domain is deleted > > > Key: CLOUDSTACK-10223 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10223 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Sowjanya_Patha >Priority: Minor > > After domain deletion, snapshot taken by the domain remains undeleted. > Steps to reproduce: > --- > 1. Create a test domain > 2. Create test account with admin privileges. > 3. Login as "test" acoount. > 4. Create 3 instances - few having root disk and rest with root and data > disks both. > 5. For 2 instances take snapshots of root and data disks > 6. Expunge above instances from ACP UI. > 7. Make sure that those vm's should not be shown in ACP UI. > 8. Login as root user again > 9. Delete the test account > 10. Delete the test domain > Snapshots taken for root volume in step 5 are not deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9781) ACS records ID in events tables instead of UUID.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458481#comment-16458481 ] ASF GitHub Bot commented on CLOUDSTACK-9781: blueorangutan commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID. URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-385368281 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS records ID in events tables instead of UUID. > > > Key: CLOUDSTACK-9781 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9781 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Jayant Patil >Priority: Major > > ISSUE > = > Wrong presentation of volume id in ACS events. > While creating a snapshot, only volume ID is mentioned in the events. For > example, “Scheduled async job for creating snapshot for volume Id:270". On > looking into the notification, user is not able to identify the volume. So > modified event description with UUID. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9781) ACS records ID in events tables instead of UUID.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458479#comment-16458479 ] ASF GitHub Bot commented on CLOUDSTACK-9781: rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID. URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-385368045 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS records ID in events tables instead of UUID. > > > Key: CLOUDSTACK-9781 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9781 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Jayant Patil >Priority: Major > > ISSUE > = > Wrong presentation of volume id in ACS events. > While creating a snapshot, only volume ID is mentioned in the events. For > example, “Scheduled async job for creating snapshot for volume Id:270". On > looking into the notification, user is not able to identify the volume. So > modified event description with UUID. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9781) ACS records ID in events tables instead of UUID.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458476#comment-16458476 ] ASF GitHub Bot commented on CLOUDSTACK-9781: blueorangutan commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID. URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-385367618 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1982 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS records ID in events tables instead of UUID. > > > Key: CLOUDSTACK-9781 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9781 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Jayant Patil >Priority: Major > > ISSUE > = > Wrong presentation of volume id in ACS events. > While creating a snapshot, only volume ID is mentioned in the events. For > example, “Scheduled async job for creating snapshot for volume Id:270". On > looking into the notification, user is not able to identify the volume. So > modified event description with UUID. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9781) ACS records ID in events tables instead of UUID.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458463#comment-16458463 ] ASF GitHub Bot commented on CLOUDSTACK-9781: blueorangutan commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID. URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-385362623 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS records ID in events tables instead of UUID. > > > Key: CLOUDSTACK-9781 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9781 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Jayant Patil >Priority: Major > > ISSUE > = > Wrong presentation of volume id in ACS events. > While creating a snapshot, only volume ID is mentioned in the events. For > example, “Scheduled async job for creating snapshot for volume Id:270". On > looking into the notification, user is not able to identify the volume. So > modified event description with UUID. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9781) ACS records ID in events tables instead of UUID.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458460#comment-16458460 ] ASF GitHub Bot commented on CLOUDSTACK-9781: rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID. URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-385362461 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS records ID in events tables instead of UUID. > > > Key: CLOUDSTACK-9781 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9781 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Jayant Patil >Priority: Major > > ISSUE > = > Wrong presentation of volume id in ACS events. > While creating a snapshot, only volume ID is mentioned in the events. For > example, “Scheduled async job for creating snapshot for volume Id:270". On > looking into the notification, user is not able to identify the volume. So > modified event description with UUID. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9781) ACS records ID in events tables instead of UUID.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458457#comment-16458457 ] ASF GitHub Bot commented on CLOUDSTACK-9781: rafaelweingartner commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID. URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-385360526 In my opinion we can proceed with the merge. @syed inquiries were already addressed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS records ID in events tables instead of UUID. > > > Key: CLOUDSTACK-9781 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9781 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Jayant Patil >Priority: Major > > ISSUE > = > Wrong presentation of volume id in ACS events. > While creating a snapshot, only volume ID is mentioned in the events. For > example, “Scheduled async job for creating snapshot for volume Id:270". On > looking into the notification, user is not able to identify the volume. So > modified event description with UUID. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458445#comment-16458445 ] ASF GitHub Bot commented on CLOUDSTACK-9114: blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385358428 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > restartnetwork with cleanup should not update/restart both routers at once > -- > > Key: CLOUDSTACK-9114 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou >Priority: Major > > for now, restartnetwork with cleanup will stop both RVRs at first, then start > two new RVRs. > to reduce the downtime of network, we'd better restart the RVRs one by one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458444#comment-16458444 ] ASF GitHub Bot commented on CLOUDSTACK-9114: rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385358311 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > restartnetwork with cleanup should not update/restart both routers at once > -- > > Key: CLOUDSTACK-9114 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou >Priority: Major > > for now, restartnetwork with cleanup will stop both RVRs at first, then start > two new RVRs. > to reduce the downtime of network, we'd better restart the RVRs one by one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458443#comment-16458443 ] ASF GitHub Bot commented on CLOUDSTACK-9114: rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385358259 @ustcweizhou @resmo @DaanHoogland @rafaelweingartner @wido @nitin-maharana @nvazquez @NuxRo this is ready for review, please help review and test. Packages of this PR are mirrored here: https://lab.yadav.cloud/testing/vr-downtime I'll open up test/stabilization fixes in a separate FR for 4.11 branch. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > restartnetwork with cleanup should not update/restart both routers at once > -- > > Key: CLOUDSTACK-9114 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou >Priority: Major > > for now, restartnetwork with cleanup will stop both RVRs at first, then start > two new RVRs. > to reduce the downtime of network, we'd better restart the RVRs one by one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10290) Config drive - only supported for secondary storage
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458440#comment-16458440 ] ASF GitHub Bot commented on CLOUDSTACK-10290: - DaanHoogland opened a new pull request #2614: WIP perform config drive creation on primary storage (CLOUDSTACK-10290) URL: https://github.com/apache/cloudstack/pull/2614 ## Description The present configdrive generation happens on secondary storage, which is also used in public facing functionality. For those that wnat it can be processed on primary storage. This will be optional for now as using localstorage will complicate things when migrating. First phase is factoring out the config drive creation code into a separate project (done) next it will be made available to the host agent (KVM only) finally the decision to look for a primary storage to do the processing on will be implemented on the basis of a global setting. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [x] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [x] Cleanup (Code refactoring and cleanup, that may add test cases) ## GitHub Issue/PRs ## Screenshots (if appropriate): ## How Has This Been Tested? this is tested manually in a kvm env with a custom network offering that has everything in the VR except userdata ## Checklist: - [ ] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document. - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. Testing - [ ] I have added tests to cover my changes. - [?] All relevant new and existing integration tests have passed. - [ ] A full integration testsuite with all test that can run on my environment has passed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Config drive - only supported for secondary storage > --- > > Key: CLOUDSTACK-10290 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10290 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Affects Versions: 4.11.0.0 >Reporter: Rohit Yadav >Assignee: Daan Hoogland >Priority: Major > > Userdata disk looks like this: > > > file='/mnt/eba12ff3-c3a6-394a-bf0f-23291f1f6266/configdrive.iso'/> > > > > > > > Mount is: > root# df /mnt/eba12ff3-c3a6-394a-bf0f-23291f1f6266 > Filesystem 1K-blocks > Used Available Use% Mounted on > some-nfs-server.com:/nfs/secondary/ConfigDrive/i-2-24-VM 66391040 2973696 > 63417344 5% /mnt/eba12ff3-c3a6-394a-bf0f-23291f1f6266 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458439#comment-16458439
]
ASF GitHub Bot commented on CLOUDSTACK-9114:
rafaelweingartner commented on a change in pull request #2508: CLOUDSTACK-9114:
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r184948864
##
File path: server/src/com/cloud/network/vpc/VpcManagerImpl.java
##
@@ -1508,19 +1519,33 @@ public boolean restartVpc(final long vpcId, final
boolean cleanUp, final boolean
// Change the VPC in order to get it updated after the end of
// the restart procedure.
-_vpcDao.update(vpc.getId(), entity);
+if (_vpcDao.update(vpc.getId(), entity)) {
+vpc = entity;
+}
// If the offering and redundant column are changing, force the
// clean up.
forceCleanup = true;
}
if (forceCleanup) {
Review comment:
Yes it is, if you consider only the body of the IF, but the method is
already quite big. The more we extract, the more unit tests we enable.
Moreover, it becomes easier to read the code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> restartnetwork with cleanup should not update/restart both routers at once
> --
>
> Key: CLOUDSTACK-9114
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>Priority: Major
>
> for now, restartnetwork with cleanup will stop both RVRs at first, then start
> two new RVRs.
> to reduce the downtime of network, we'd better restart the RVRs one by one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458438#comment-16458438
]
ASF GitHub Bot commented on CLOUDSTACK-9114:
rafaelweingartner commented on a change in pull request #2508: CLOUDSTACK-9114:
Reduce VR downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r184948864
##
File path: server/src/com/cloud/network/vpc/VpcManagerImpl.java
##
@@ -1508,19 +1519,33 @@ public boolean restartVpc(final long vpcId, final
boolean cleanUp, final boolean
// Change the VPC in order to get it updated after the end of
// the restart procedure.
-_vpcDao.update(vpc.getId(), entity);
+if (_vpcDao.update(vpc.getId(), entity)) {
+vpc = entity;
+}
// If the offering and redundant column are changing, force the
// clean up.
forceCleanup = true;
}
if (forceCleanup) {
Review comment:
Yes it is, if you consider only the body of the IF, but eh method is already
quite big. The more we extract, the more unit tests we enable. Moreover, it
becomes easier to read the code.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> restartnetwork with cleanup should not update/restart both routers at once
> --
>
> Key: CLOUDSTACK-9114
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>Priority: Major
>
> for now, restartnetwork with cleanup will stop both RVRs at first, then start
> two new RVRs.
> to reduce the downtime of network, we'd better restart the RVRs one by one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458431#comment-16458431 ] ASF GitHub Bot commented on CLOUDSTACK-9114: blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385353120 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1981 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > restartnetwork with cleanup should not update/restart both routers at once > -- > > Key: CLOUDSTACK-9114 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou >Priority: Major > > for now, restartnetwork with cleanup will stop both RVRs at first, then start > two new RVRs. > to reduce the downtime of network, we'd better restart the RVRs one by one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458417#comment-16458417 ] ASF GitHub Bot commented on CLOUDSTACK-9114: blueorangutan commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385347107 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > restartnetwork with cleanup should not update/restart both routers at once > -- > > Key: CLOUDSTACK-9114 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou >Priority: Major > > for now, restartnetwork with cleanup will stop both RVRs at first, then start > two new RVRs. > to reduce the downtime of network, we'd better restart the RVRs one by one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458416#comment-16458416 ] ASF GitHub Bot commented on CLOUDSTACK-9114: rhtyd commented on issue #2508: CLOUDSTACK-9114: Reduce VR downtime during network restart URL: https://github.com/apache/cloudstack/pull/2508#issuecomment-385347017 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > restartnetwork with cleanup should not update/restart both routers at once > -- > > Key: CLOUDSTACK-9114 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Wei Zhou >Assignee: Wei Zhou >Priority: Major > > for now, restartnetwork with cleanup will stop both RVRs at first, then start > two new RVRs. > to reduce the downtime of network, we'd better restart the RVRs one by one. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458415#comment-16458415
]
ASF GitHub Bot commented on CLOUDSTACK-9114:
rhtyd commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR
downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r184940056
##
File path: systemvm/debian/opt/cloud/bin/configure.py
##
@@ -957,6 +957,7 @@ def process(self):
acls.process()
acls = CsAcl('firewallrules', self.config)
+acls.flushAllowAllEgressRules()
Review comment:
FYI - this fixes the issue of egress traffic failure on network start.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> restartnetwork with cleanup should not update/restart both routers at once
> --
>
> Key: CLOUDSTACK-9114
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>Priority: Major
>
> for now, restartnetwork with cleanup will stop both RVRs at first, then start
> two new RVRs.
> to reduce the downtime of network, we'd better restart the RVRs one by one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9114) restartnetwork with cleanup should not update/restart both routers at once
[
https://issues.apache.org/jira/browse/CLOUDSTACK-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458414#comment-16458414
]
ASF GitHub Bot commented on CLOUDSTACK-9114:
rhtyd commented on a change in pull request #2508: CLOUDSTACK-9114: Reduce VR
downtime during network restart
URL: https://github.com/apache/cloudstack/pull/2508#discussion_r184939883
##
File path: server/src/com/cloud/network/vpc/VpcManagerImpl.java
##
@@ -1508,19 +1519,33 @@ public boolean restartVpc(final long vpcId, final
boolean cleanUp, final boolean
// Change the VPC in order to get it updated after the end of
// the restart procedure.
-_vpcDao.update(vpc.getId(), entity);
+if (_vpcDao.update(vpc.getId(), entity)) {
+vpc = entity;
+}
// If the offering and redundant column are changing, force the
// clean up.
forceCleanup = true;
}
if (forceCleanup) {
Review comment:
The body of IF is rather small already?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> restartnetwork with cleanup should not update/restart both routers at once
> --
>
> Key: CLOUDSTACK-9114
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9114
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: Wei Zhou
>Assignee: Wei Zhou
>Priority: Major
>
> for now, restartnetwork with cleanup will stop both RVRs at first, then start
> two new RVRs.
> to reduce the downtime of network, we'd better restart the RVRs one by one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-9781) ACS records ID in events tables instead of UUID.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-9781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458376#comment-16458376 ] ASF GitHub Bot commented on CLOUDSTACK-9781: rhtyd commented on issue #1940: CLOUDSTACK-9781:ACS records ID in events tables instead of UUID. URL: https://github.com/apache/cloudstack/pull/1940#issuecomment-385328743 It's also a good idea to start a conversation on dev/user ML about this change. This PR has been blocked for months now, if @syed does not reply by end of this month I'm okay to merge this based on other reviewer's comments and test results on the PR. Thoughts - @DaanHoogland @rafaelweingartner @borisstoyanov ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ACS records ID in events tables instead of UUID. > > > Key: CLOUDSTACK-9781 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9781 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Jayant Patil >Priority: Major > > ISSUE > = > Wrong presentation of volume id in ACS events. > While creating a snapshot, only volume ID is mentioned in the events. For > example, “Scheduled async job for creating snapshot for volume Id:270". On > looking into the notification, user is not able to identify the volume. So > modified event description with UUID. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10360) Inconsistent method name
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458373#comment-16458373
]
ASF GitHub Bot commented on CLOUDSTACK-10360:
-
rhtyd closed pull request #2598: CLOUDSTACK-10360: Change the method name.
URL: https://github.com/apache/cloudstack/pull/2598
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java
b/framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java
index 1734b98757b..2ace24dce5a 100644
---
a/framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java
+++
b/framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java
@@ -152,7 +152,7 @@ public T valueIn(Long id) {
return value();
}
-String value = s_depot != null ?
s_depot.scoped(this).getConfigValue(id, this) : null;
+String value = s_depot != null ?
s_depot.findScopedConfigStorage(this).getConfigValue(id, this) : null;
if (value == null) {
return value();
} else {
diff --git
a/framework/config/src/main/java/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
b/framework/config/src/main/java/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
index 6a85b90b70d..bb49ce1042f 100644
---
a/framework/config/src/main/java/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
+++
b/framework/config/src/main/java/org/apache/cloudstack/framework/config/impl/ConfigDepotImpl.java
@@ -166,7 +166,7 @@ public ConfigurationDao global() {
return _configDao;
}
-public ScopedConfigStorage scoped(ConfigKey config) {
+public ScopedConfigStorage findScopedConfigStorage(ConfigKey config) {
for (ScopedConfigStorage storage : _scopedStorages) {
if (storage.getScope() == config.scope()) {
return storage;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method name
>
>
> Key: CLOUDSTACK-10360
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10360
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> The following method is named as "scoped" that seems to whether the variable
> config is scoped in _scopedStorages or not.
> Actually, the method tries to find a storage of which scope equals to the
> scope of config.
> So that, the method name "findStorage" should be more clear than "scoped".
> {code:java}
> public ScopedConfigStorage scoped(ConfigKey config) {
> for (ScopedConfigStorage storage : _scopedStorages) {
> if (storage.getScope() == config.scope()) {
> return storage;
> }
> }
> throw new CloudRuntimeException("Unable to find config storage for
> this scope: " + config.scope() + " for " + config.key());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10360) Inconsistent method name
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458374#comment-16458374
]
ASF subversion and git services commented on CLOUDSTACK-10360:
--
Commit 93509a431cde8452037e79f7b85584a2a3c025df in cloudstack's branch
refs/heads/master from [~BruceKuiLIU]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=93509a4 ]
CLOUDSTACK-10360: Change the method name. (#2598)
The method is named as "scoped" that seems to whether the variable config is
scoped in _scopedStorages or not. Actually, the method tries to find a storage
of which scope equals to the scope of config. So that, the method name
"findStorage" should be more clear than "scoped".
> Inconsistent method name
>
>
> Key: CLOUDSTACK-10360
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10360
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> The following method is named as "scoped" that seems to whether the variable
> config is scoped in _scopedStorages or not.
> Actually, the method tries to find a storage of which scope equals to the
> scope of config.
> So that, the method name "findStorage" should be more clear than "scoped".
> {code:java}
> public ScopedConfigStorage scoped(ConfigKey config) {
> for (ScopedConfigStorage storage : _scopedStorages) {
> if (storage.getScope() == config.scope()) {
> return storage;
> }
> }
> throw new CloudRuntimeException("Unable to find config storage for
> this scope: " + config.scope() + " for " + config.key());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10360) Inconsistent method name
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458372#comment-16458372
]
ASF GitHub Bot commented on CLOUDSTACK-10360:
-
rhtyd commented on issue #2598: CLOUDSTACK-10360: Change the method name.
URL: https://github.com/apache/cloudstack/pull/2598#issuecomment-385327981
We can merge this since it's a cosmetic fix - name change refactoring, no
effective code change. I'll merge this based on code reviews and Travis passing.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Inconsistent method name
>
>
> Key: CLOUDSTACK-10360
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10360
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
>Reporter: KuiLIU
>Priority: Major
>
> The following method is named as "scoped" that seems to whether the variable
> config is scoped in _scopedStorages or not.
> Actually, the method tries to find a storage of which scope equals to the
> scope of config.
> So that, the method name "findStorage" should be more clear than "scoped".
> {code:java}
> public ScopedConfigStorage scoped(ConfigKey config) {
> for (ScopedConfigStorage storage : _scopedStorages) {
> if (storage.getScope() == config.scope()) {
> return storage;
> }
> }
> throw new CloudRuntimeException("Unable to find config storage for
> this scope: " + config.scope() + " for " + config.key());
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-8609) [VMware] VM is not accessible after a migration across clusters.
[ https://issues.apache.org/jira/browse/CLOUDSTACK-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458371#comment-16458371 ] ASF GitHub Bot commented on CLOUDSTACK-8609: rhtyd commented on issue #2091: CLOUDSTACK-8609: [VMware] VM is not accessible after migration across clusters URL: https://github.com/apache/cloudstack/pull/2091#issuecomment-385327709 @resmo I'll inform that PR author, ultimately it will depend on how responsive the PR author is and if we're able to test,review,merge this PR before 4.11.1 RC1. You may also re-open the PR in case you would like to pursue with this PR yourself. @sureshanaparti can you re-base the PR against 4.11, fix conflicts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [VMware] VM is not accessible after a migration across clusters. > > > Key: CLOUDSTACK-8609 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8609 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) >Reporter: Likitha Shetty >Assignee: Suresh Kumar Anaparti >Priority: Major > Fix For: Future > > > +Steps to reproduce+ > 1. Deploy a VMware zone with 2 clusters (a host each, H1 and H2) and one > zone-wide primary storage spanning the two clusters. > 2. Deploy a VM (VM1) on one of the hosts (H1). > 3. Stop VM1. > 4. Make the host that contains the VM unsuitable for further VM deployments > - host runs out of capacity (cpu/memory) > - host has maximum VMs deployed on it > 5. Start VM1. > 6. VM will be powered on H2 but will not be accessible because the .vmx and > other VM files associated with the VM have been deleted. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
