[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-05-09 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468642#comment-16468642
 ] 

ASF subversion and git services commented on CLOUDSTACK-10147:
--

Commit 4534cefa40cf9b4d11402bff86c4484292fa660d in cloudstack's branch 
refs/heads/master from [~rohithsharma]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=4534cef ]

backports for 4.11.1 from master (#2621)

* CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's. Added code 
to skip disabled clusters when selecting a host (#2442)

(cherry picked from commit c3488a51db4bce4ec32c09e6fef78193d360cf3f)
Signed-off-by: Rohit Yadav 

* CLOUDSTACK-10318: Bug on sorting ACL rules list in chrome (#2478)

(cherry picked from commit 4412563f19ec8b808fe4c79e2baf658507a84873)
Signed-off-by: Rohit Yadav 

* CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if 
hypervisor is not KVM.

Signed-off-by: Rohit Yadav 

* CLOUDSTACK-10221: Allow IPv6 when creating a Basic Network (#2397)

Since CloudStack 4.10 Basic Networking supports IPv6 and thus
should be allowed to be specified when creating a network.

Signed-off-by: Wido den Hollander 
(cherry picked from commit 9733a10ecda5f1af0f2c0fa863fc976a3e710946)
Signed-off-by: Rohit Yadav 

* CLOUDSTACK-10214: Unable to remove local primary storage (#2390)

Allow admins to remove primary storage pool.
Cherry-picked from eba2e1d8a1ce4e86b4df144db03e96739da455e5

Signed-off-by: Rohit Yadav 

* dateutil: constistency of tzdate input and output (#2392)

Signed-off-by: Yoan Blanc 
Signed-off-by: Daan Hoogland 
(cherry picked from commit 2ad520282319da9a03061b8c744e51a4ffdf94a2)
Signed-off-by: Rohit Yadav 

* CLOUDSTACK-10054:Volume download times out in 3600 seconds (#2244)

(cherry picked from commit bb607d07a97476dc4fb934b3d75df6affba47086)
Signed-off-by: Rohit Yadav 

* When creating a new account (via domain admin) it is possible to select “root 
admin” as the role for the new user (#2606)

* create account with domain admin showing 'root admin' role

Domain admins should not be able to assign the role of root admin to new users. 
Therefore, the role ‘root admin’ (or any other of the same type) should not be 
visible to domain admins.

* License and formatting

* Break long sentence into multiple lines

* Fix wording of method 'getCurrentAccount'

* fix typo in variable name

* [CLOUDSTACK-10259] Missing float part of secondary storage data in 
listAccounts

* [CLOUDSTACK-9338] ACS not accounting resources of VMs with custom service 
offering

ACS is accounting the resources properly when deploying VMs with custom service 
offerings. However, there are other methods (such as updateResourceCount) that 
do not execute the resource accounting properly, and these methods update the 
resource count for an account in the database. Therefore, if a user deploys VMs 
with custom service offerings, and later this user calls the 
“updateResourceCount” method, it (the method) will only account for VMs with 
normal service offerings, and update this as the number of resources used by 
the account. This will result in a smaller number of resources to be accounted 
for the given account than the real used value. The problem becomes worse 
because if the user starts to delete these VMs, it is possible to reach 
negative values of resources allocated (breaking all of the resource limiting 
for accounts). This is a very serious attack vector for public cloud providers!

* [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type” 
(#2404)

* [CLOUDSTACK-10230] User is able to change to “Guest OS type” that has been 
removed

Users are able to change the OS type of VMs to “Guest OS type” that has been 
removed. This becomes a security issue when we try to force users to use HVM 
VMs (Meltdown/Spectre thing). A removed “guest os type” should not be usable by 
any users in the cloud.

* Remove trailing lines that are breaking build due to checkstyle compliance

* Remove unused imports

* fix classes that were in the wrong folder structure

* Updates to capacity management


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-05-09 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468622#comment-16468622
 ] 

ASF subversion and git services commented on CLOUDSTACK-10147:
--

Commit 4534cefa40cf9b4d11402bff86c4484292fa660d in cloudstack's branch 
refs/heads/4.11 from [~rohithsharma]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=4534cef ]

backports for 4.11.1 from master (#2621)

* CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's. Added code 
to skip disabled clusters when selecting a host (#2442)

(cherry picked from commit c3488a51db4bce4ec32c09e6fef78193d360cf3f)
Signed-off-by: Rohit Yadav 

* CLOUDSTACK-10318: Bug on sorting ACL rules list in chrome (#2478)

(cherry picked from commit 4412563f19ec8b808fe4c79e2baf658507a84873)
Signed-off-by: Rohit Yadav 

* CLOUDSTACK-10284:Creating a snapshot from VM Snapshot generates error if 
hypervisor is not KVM.

Signed-off-by: Rohit Yadav 

* CLOUDSTACK-10221: Allow IPv6 when creating a Basic Network (#2397)

Since CloudStack 4.10 Basic Networking supports IPv6 and thus
should be allowed to be specified when creating a network.

Signed-off-by: Wido den Hollander 
(cherry picked from commit 9733a10ecda5f1af0f2c0fa863fc976a3e710946)
Signed-off-by: Rohit Yadav 

* CLOUDSTACK-10214: Unable to remove local primary storage (#2390)

Allow admins to remove primary storage pool.
Cherry-picked from eba2e1d8a1ce4e86b4df144db03e96739da455e5

Signed-off-by: Rohit Yadav 

* dateutil: constistency of tzdate input and output (#2392)

Signed-off-by: Yoan Blanc 
Signed-off-by: Daan Hoogland 
(cherry picked from commit 2ad520282319da9a03061b8c744e51a4ffdf94a2)
Signed-off-by: Rohit Yadav 

* CLOUDSTACK-10054:Volume download times out in 3600 seconds (#2244)

(cherry picked from commit bb607d07a97476dc4fb934b3d75df6affba47086)
Signed-off-by: Rohit Yadav 

* When creating a new account (via domain admin) it is possible to select “root 
admin” as the role for the new user (#2606)

* create account with domain admin showing 'root admin' role

Domain admins should not be able to assign the role of root admin to new users. 
Therefore, the role ‘root admin’ (or any other of the same type) should not be 
visible to domain admins.

* License and formatting

* Break long sentence into multiple lines

* Fix wording of method 'getCurrentAccount'

* fix typo in variable name

* [CLOUDSTACK-10259] Missing float part of secondary storage data in 
listAccounts

* [CLOUDSTACK-9338] ACS not accounting resources of VMs with custom service 
offering

ACS is accounting the resources properly when deploying VMs with custom service 
offerings. However, there are other methods (such as updateResourceCount) that 
do not execute the resource accounting properly, and these methods update the 
resource count for an account in the database. Therefore, if a user deploys VMs 
with custom service offerings, and later this user calls the 
“updateResourceCount” method, it (the method) will only account for VMs with 
normal service offerings, and update this as the number of resources used by 
the account. This will result in a smaller number of resources to be accounted 
for the given account than the real used value. The problem becomes worse 
because if the user starts to delete these VMs, it is possible to reach 
negative values of resources allocated (breaking all of the resource limiting 
for accounts). This is a very serious attack vector for public cloud providers!

* [CLOUDSTACK-10230] User should not be able to use removed “Guest OS type” 
(#2404)

* [CLOUDSTACK-10230] User is able to change to “Guest OS type” that has been 
removed

Users are able to change the OS type of VMs to “Guest OS type” that has been 
removed. This becomes a security issue when we try to force users to use HVM 
VMs (Meltdown/Spectre thing). A removed “guest os type” should not be usable by 
any users in the cloud.

* Remove trailing lines that are breaking build due to checkstyle compliance

* Remove unused imports

* fix classes that were in the wrong folder structure

* Updates to capacity management


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397293#comment-16397293
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

DaanHoogland commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-37273
 
 
   Hihi, mister Writer pulled into the discussion here once again ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
> Fix For: 4.12
>
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397258#comment-16397258
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

glennwagner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-372739879
 
 
   LGTM , Thanks guys for the work.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
> Fix For: 4.12
>
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397204#comment-16397204
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

rafaelweingartner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-372728437
 
 
   I will merge then. Thanks @DaanHoogland, @borisroman and @houthuis 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-03-13 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397206#comment-16397206
 ] 

ASF subversion and git services commented on CLOUDSTACK-10147:
--

Commit c3488a51db4bce4ec32c09e6fef78193d360cf3f in cloudstack's branch 
refs/heads/master from [~hholtzhausen]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=c3488a5 ]

CLOUDSTACK-10147 Disabled Xenserver Cluster can still deploy VM's. Added code 
to skip disabled clusters when selecting a host (#2442)



> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397205#comment-16397205
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

rafaelweingartner closed pull request #2442: CLOUDSTACK-10147 Disabled 
Xenserver Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java 
b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
index cc244ce41ba..5d8ad0a7051 100644
--- a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
+++ b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
@@ -1040,6 +1040,11 @@ private DeployDestination 
checkClustersforDestination(List clusterList, Vi
 for (Long clusterId : clusterList) {
 ClusterVO clusterVO = _clusterDao.findById(clusterId);
 
+if (clusterVO.getAllocationState() == 
Grouping.AllocationState.Disabled) {
+s_logger.debug("Cannot deploy in disabled cluster " + 
clusterId + ", skipping this cluster");
+avoid.addCluster(clusterVO.getId());
+}
+
 if (clusterVO.getHypervisorType() != 
vmProfile.getHypervisorType()) {
 s_logger.debug("Cluster: " + clusterId + " has HyperVisorType 
that does not match the VM, skipping this cluster");
 avoid.addCluster(clusterVO.getId());


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397200#comment-16397200
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

DaanHoogland commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-372727944
 
 
   @houthuis @rafaelweingartner I am fine with this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-03-13 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396997#comment-16396997
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

rafaelweingartner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-372679976
 
 
   @DaanHoogland are you ok with this one?
   The tests passed, and everything seems to be fine. The contributor is not 
responding our inquiries.  
   I am willing to merge it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370040#comment-16370040
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

rafaelweingartner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-366973883
 
 
   @borisstoyanov and @DaanHoogland I asked about the use of disabled clusters 
by root admins, because when I was working on PR #2315 people told me to use 
disabled hosts when there was no enabled ones to execute some storage related 
commands. 
   
   I personally agree with you two that when something is disabled, it should 
not be used at all, but as long as we are already doing this for some other 
features, I think it would be interesting to allow a similar behavior here, at 
least for root admins.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361370#comment-16361370
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

DaanHoogland commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-365043745
 
 
   @houthuis did you ask the submitter (of CLOUDSTACK-10147) about the validity 
of the functionality?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361310#comment-16361310
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

blueorangutan commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-365032026
 
 
   Trillian test result (tid-2252)
   Environment: xenserver-65sp1 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 36354 seconds
   Marvin logs: 
https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2442-t2252-xenserver-65sp1.zip
   Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py
   Smoke tests completed. 67 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360429#comment-16360429
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

blueorangutan commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-364855206
 
 
   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + xenserver-65sp1) 
has been kicked to run smoke tests


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360428#comment-16360428
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

borisstoyanov commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-364855183
 
 
   @blueorangutan test centos7 xenserver-65sp1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-12 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360418#comment-16360418
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

blueorangutan commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-364854142
 
 
   Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1706


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360395#comment-16360395
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

blueorangutan commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-364848222
 
 
   @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-11 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360393#comment-16360393
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

borisstoyanov commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-364848073
 
 
   @blueorangutan package


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350060#comment-16350060
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442
 
 
   ENVIRONMENT 
   = 
   XenServer Version : 6.2 , 7
   
   ISSUE 
   == 
   Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
still active
   
   Repro. steps followed 
   == 
   Disabled Cluster from UI. 
   Deploy a new VM
   
   Expected Behavior 
   ===
   After disabling the cluster , the hosts should be disabled. and no VM's can 
be deployed
   
   Note:
   it's the same results for XenServer or simulator, can't deploy on disabled 
hosts, but can deploy on disabled cluster
   
   Solution:
   
   Added a check to skip disabled clusters when selecting a host to deploy on.
   Deploying on a disabled cluster will now result in a 
InsufficientServerCapacityException, if no enabled clusters are found.
   
   i didn't want to propagate disabling a cluster down to the hosts, because 
then you would have to enable all the hosts again when you enable the cluster, 
and we won't know which hosts should be left in a disabled state


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350034#comment-16350034
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster 
can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java 
b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
index cc244ce41ba..5d8ad0a7051 100644
--- a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
+++ b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
@@ -1040,6 +1040,11 @@ private DeployDestination 
checkClustersforDestination(List clusterList, Vi
 for (Long clusterId : clusterList) {
 ClusterVO clusterVO = _clusterDao.findById(clusterId);
 
+if (clusterVO.getAllocationState() == 
Grouping.AllocationState.Disabled) {
+s_logger.debug("Cannot deploy in disabled cluster " + 
clusterId + ", skipping this cluster");
+avoid.addCluster(clusterVO.getId());
+}
+
 if (clusterVO.getHypervisorType() != 
vmProfile.getHypervisorType()) {
 s_logger.debug("Cluster: " + clusterId + " has HyperVisorType 
that does not match the VM, skipping this cluster");
 avoid.addCluster(clusterVO.getId());


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350016#comment-16350016
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster 
can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java 
b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
index cc244ce41ba..5d8ad0a7051 100644
--- a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
+++ b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
@@ -1040,6 +1040,11 @@ private DeployDestination 
checkClustersforDestination(List clusterList, Vi
 for (Long clusterId : clusterList) {
 ClusterVO clusterVO = _clusterDao.findById(clusterId);
 
+if (clusterVO.getAllocationState() == 
Grouping.AllocationState.Disabled) {
+s_logger.debug("Cannot deploy in disabled cluster " + 
clusterId + ", skipping this cluster");
+avoid.addCluster(clusterVO.getId());
+}
+
 if (clusterVO.getHypervisorType() != 
vmProfile.getHypervisorType()) {
 s_logger.debug("Cluster: " + clusterId + " has HyperVisorType 
that does not match the VM, skipping this cluster");
 avoid.addCluster(clusterVO.getId());


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350017#comment-16350017
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442
 
 
   ENVIRONMENT 
   = 
   XenServer Version : 6.2 , 7
   
   ISSUE 
   == 
   Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
still active
   
   Repro. steps followed 
   == 
   Disabled Cluster from UI. 
   Deploy a new VM
   
   Expected Behavior 
   ===
   After disabling the cluster , the hosts should be disabled. and no VM's can 
be deployed
   
   Note:
   it's the same results for XenServer or simulator, can't deploy on disabled 
hosts, but can deploy on disabled cluster
   
   Solution:
   
   Added a check to skip disabled clusters when selecting a host to deploy on.
   Deploying on a disabled cluster will now result in a 
InsufficientServerCapacityException, if no enabled clusters are found.
   
   i didn't want to propagate disabling a cluster down to the hosts, because 
then you would have to enable all the hosts again when you enable the cluster, 
and we won't know which hosts should be left in a disabled state


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350009#comment-16350009
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

houthuis closed pull request #2442: CLOUDSTACK-10147 Disabled Xenserver Cluster 
can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java 
b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
index cc244ce41ba..5d8ad0a7051 100644
--- a/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
+++ b/server/src/main/java/com/cloud/deploy/DeploymentPlanningManagerImpl.java
@@ -1040,6 +1040,11 @@ private DeployDestination 
checkClustersforDestination(List clusterList, Vi
 for (Long clusterId : clusterList) {
 ClusterVO clusterVO = _clusterDao.findById(clusterId);
 
+if (clusterVO.getAllocationState() == 
Grouping.AllocationState.Disabled) {
+s_logger.debug("Cannot deploy in disabled cluster " + 
clusterId + ", skipping this cluster");
+avoid.addCluster(clusterVO.getId());
+}
+
 if (clusterVO.getHypervisorType() != 
vmProfile.getHypervisorType()) {
 s_logger.debug("Cluster: " + clusterId + " has HyperVisorType 
that does not match the VM, skipping this cluster");
 avoid.addCluster(clusterVO.getId());


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-02 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350010#comment-16350010
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

houthuis opened a new pull request #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442
 
 
   ENVIRONMENT 
   = 
   XenServer Version : 6.2 , 7
   
   ISSUE 
   == 
   Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
still active
   
   Repro. steps followed 
   == 
   Disabled Cluster from UI. 
   Deploy a new VM
   
   Expected Behavior 
   ===
   After disabling the cluster , the hosts should be disabled. and no VM's can 
be deployed
   
   Note:
   it's the same results for XenServer or simulator, can't deploy on disabled 
hosts, but can deploy on disabled cluster
   
   Solution:
   
   Added a check to skip disabled clusters when selecting a host to deploy on.
   Deploying on a disabled cluster will now result in a 
InsufficientServerCapacityException, if no enabled clusters are found.
   
   i didn't want to propagate disabling a cluster down to the hosts, because 
then you would have to enable all the hosts again when you enable the cluster, 
and we won't know which hosts should be left in a disabled state


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348474#comment-16348474
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

DaanHoogland commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-362242075
 
 
   So let's take it up with the ticket submitter, @houthuis 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348469#comment-16348469
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

rafaelweingartner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-362241268
 
 
   I never used tags this way... but then you need to have tags on all of your 
service offerings, right?
   And then you need to remove the tags of hosts the you want to isolate. Or 
maybe custom service offerings to system administrators with tags that are not 
used by service offerings of end users...
   
   BTW: for me, this is indifferent, I am not an admin, I only wanted to lift 
this question to see your feedback.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348466#comment-16348466
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

DaanHoogland commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-362240521
 
 
   but that's what tags are for aren't they?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348457#comment-16348457
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

rafaelweingartner commented on issue #2442: CLOUDSTACK-10147 Disabled Xenserver 
Cluster can still deploy VM's
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-362240019
 
 
   The first instinct is to say yes... However, can't this help administrators 
while debugging problems? I mean, otherwise they need to enable a host/cluster 
to test something, which will enable these resources for end users.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348451#comment-16348451
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

DaanHoogland commented on issue #2442: CLOUDSTACK-10147
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-362239425
 
 
   @rafaelweingartner isn't the point of disabling that no new deployments 
happen on that host?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348440#comment-16348440
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

rafaelweingartner commented on issue #2442: CLOUDSTACK-10147
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-362237523
 
 
   I think I did not express my self properly... I meant, do we want to block 
root admins to deploy VMs on disabled clusters/hosts? It feels that they should 
be able to do so (for testing purposes for instance).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348439#comment-16348439
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

houthuis commented on issue #2442: CLOUDSTACK-10147
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-362237163
 
 
   @rafaelweingartner no not on disabled hosts, but i was able to reproduce on 
disabled clusters


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348434#comment-16348434
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

rafaelweingartner commented on issue #2442: CLOUDSTACK-10147
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-362236381
 
 
   @houthuis thanks for the contributions. However, I have a doubt here...
   Not even root administrators can deploy VMs on disabled clusters/hosts?
   
   BTW: can you update the title of the PR with your issue description as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348431#comment-16348431
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

rafaelweingartner commented on issue #2442: CLOUDSTACK-10147
URL: https://github.com/apache/cloudstack/pull/2442#issuecomment-362236381
 
 
   @houthuis thanks for the contributions. However, I have a doubt here...
   Not even root administrators can deploy VMs on disabled clusters/hosts?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (CLOUDSTACK-10147) Disabled Xenserver cluster can still deploy VMs

2018-02-01 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-10147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16348425#comment-16348425
 ] 

ASF GitHub Bot commented on CLOUDSTACK-10147:
-

houthuis opened a new pull request #2442: CLOUDSTACK-10147
URL: https://github.com/apache/cloudstack/pull/2442
 
 
   ENVIRONMENT 
   = 
   XenServer Version : 6.2 , 7
   
   ISSUE 
   == 
   Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
still active
   
   Repro. steps followed 
   == 
   Disabled Cluster from UI. 
   Deploy a new VM
   
   Expected Behavior 
   ===
   After disabling the cluster , the hosts should be disabled. and no VM's can 
be deployed
   
   Solution:
   
   Added a check to skip disabled clusters when selecting a host to deploy on.
   Deploying on a disabled cluster will now result in a 
InsufficientServerCapacityException, if no enabled clusters are found.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Disabled Xenserver cluster can still deploy VMs 
> 
>
> Key: CLOUDSTACK-10147
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10147
> Project: CloudStack
>  Issue Type: Bug
>  Security Level: Public(Anyone can view this level - this is the 
> default.) 
>  Components: Management Server, UI
>Affects Versions: 4.10.0.0, 4.9.2.0
> Environment: Xenserver 6.2, 7
>Reporter: Glenn Wagner
>Assignee: Henko Holtzhausen
>Priority: Major
>
> ENVIRONMENT 
> = 
> XenServer Version : 6.2 , 7
> ISSUE 
> == 
> Disabled Xenserver Cluster can still deploy VM's , hosts in the cluster are 
> still active  
> Repro. steps followed 
> == 
> Disabled Cluster from UI. 
> Deploy a new VM 
> Expected Behavior 
> ===
> After disabling the cluster , the hosts should be disabled. and no VM's can 
> be deployed 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)