[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482288#comment-16482288 ] ASF subversion and git services commented on CLOUDSTACK-10309: -- Commit f23278a4381d57ac167835d2ff625dc4d61978fd in cloudstack's branch refs/heads/master from [~slair1] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=f23278a ] CLOUDSTACK-10309: Add option on if to VM HA power-on a OOB-shut-off-VM (#2473) When a user shuts down their VM from the guest OS (and VM HA is enabled), the VM just powers itself back on. Our environment is on KVM hosts. CloudStack does not know the difference between a VM failing or being shutdown from within the guest OS. This is a major pain point for all our users - especially since they don't pay for VMs when they are shutoff. It is not intuitive for end-users to understand why they can't shutdown VMs from within the guest OS. Especially when they all come from (non-cloudstack) VMware and Hyper-V environments where this is not an issue. However, if a host fails, we need VM HA to still work. This PR that creates a configuration option "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a VM shutdown out-of-band, but the host it was on is still online, then it won't power the VM back on. The logic is that since the host is online, it was most likely shutdown from the guest OS. For when a host actually fails, standard VM HA logic takes over and powers on VMs (if they have VM HA enabled) if the host they were on fails. If that "ha.vm.restart.hostup" option is true (the default to match current functionality), it works like always, and even in-guest shutdowns of VMs causes CloudStack to power back on the VM. > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482267#comment-16482267
]
ASF GitHub Bot commented on CLOUDSTACK-10309:
-
rhtyd closed pull request #2473: CLOUDSTACK-10309 Add option on if to VM HA
power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
index f5bdf38740f..6fdd09865da 100644
--- a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
+++ b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -359,6 +359,9 @@ public void setHostAllocators(final List
hostAllocators) {
Integer.class, "vm.job.report.interval", "60",
"Interval to send application level pings to make sure the
connection is still working", false);
+static final ConfigKey HaVmRestartHostUp = new
ConfigKey("Advanced", Boolean.class, "ha.vm.restart.hostup", "true",
+"If an out-of-band stop of a VM is detected and its host is up,
then power on the VM", true);
+
ScheduledExecutorService _executor = null;
protected long _nodeId;
@@ -3708,7 +3711,7 @@ public String getConfigComponentName() {
public ConfigKey[] getConfigKeys() {
return new ConfigKey[] {ClusterDeltaSyncInterval, StartRetry,
VmDestroyForcestop, VmOpCancelInterval, VmOpCleanupInterval, VmOpCleanupWait,
VmOpLockStateRetry,
-VmOpWaitInterval, ExecuteInSequence, VmJobCheckInterval,
VmJobTimeout, VmJobStateReportInterval, VmConfigDriveLabel};
+VmOpWaitInterval, ExecuteInSequence, VmJobCheckInterval,
VmJobTimeout, VmJobStateReportInterval, VmConfigDriveLabel, HaVmRestartHostUp};
}
public List getStoragePoolAllocators() {
@@ -3853,7 +3856,7 @@ private void
handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
case Stopped:
case Migrating:
s_logger.info("VM " + vm.getInstanceName() + " is at " +
vm.getState() + " and we received a power-off report while there is no pending
jobs on it");
-if(vm.isHaEnabled() && vm.getState() == State.Running &&
vm.getHypervisorType() != HypervisorType.VMware && vm.getHypervisorType() !=
HypervisorType.Hyperv) {
+if(vm.isHaEnabled() && vm.getState() == State.Running &&
HaVmRestartHostUp.value() && vm.getHypervisorType() != HypervisorType.VMware &&
vm.getHypervisorType() != HypervisorType.Hyperv) {
s_logger.info("Detected out-of-band stop of a HA enabled VM "
+ vm.getInstanceName() + ", will schedule restart");
if(!_haMgr.hasPendingHaWork(vm.getId())) {
_haMgr.scheduleRestart(vm, true);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> VMs with HA enabled, power back on if shutdown from guest OS
>
>
> Key: CLOUDSTACK-10309
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.9.0, 4.10.0.0
> Environment: KVM
>Reporter: Sean Lair
>Priority: Minor
>
> When a user shuts down their VM from the guest OS (and VM HA is enabled), the
> VM just powers itself back on. Our environment is on KVM hosts.
> CloudStack does not know the difference between a VM failing or being
> shutdown from within the guest OS.
> This is a major pain point for all our users - especially since they don't
> pay for VMs when they are shutoff. It is not intuitive for end-users to
> understand why they can't shutdown VMs from within the guest OS. Especially
> when they all come from (non-cloudstack) VMware and Hyper-V environments
> where this is not an issue.
> However, if a host fails, we need VM HA to still work.
> This Issue is being tied to a new PR that creates a configuration option
> "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a
> VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then
> it won't power it back on. The logic
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482268#comment-16482268 ] ASF subversion and git services commented on CLOUDSTACK-10309: -- Commit f23278a4381d57ac167835d2ff625dc4d61978fd in cloudstack's branch refs/heads/4.11 from [~slair1] [ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=f23278a ] CLOUDSTACK-10309: Add option on if to VM HA power-on a OOB-shut-off-VM (#2473) When a user shuts down their VM from the guest OS (and VM HA is enabled), the VM just powers itself back on. Our environment is on KVM hosts. CloudStack does not know the difference between a VM failing or being shutdown from within the guest OS. This is a major pain point for all our users - especially since they don't pay for VMs when they are shutoff. It is not intuitive for end-users to understand why they can't shutdown VMs from within the guest OS. Especially when they all come from (non-cloudstack) VMware and Hyper-V environments where this is not an issue. However, if a host fails, we need VM HA to still work. This PR that creates a configuration option "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a VM shutdown out-of-band, but the host it was on is still online, then it won't power the VM back on. The logic is that since the host is online, it was most likely shutdown from the guest OS. For when a host actually fails, standard VM HA logic takes over and powers on VMs (if they have VM HA enabled) if the host they were on fails. If that "ha.vm.restart.hostup" option is true (the default to match current functionality), it works like always, and even in-guest shutdowns of VMs causes CloudStack to power back on the VM. > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482266#comment-16482266 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - rhtyd commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-390578738 Test and code LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461985#comment-16461985 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-386201594 @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461982#comment-16461982 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - borisstoyanov commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-386201460 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461261#comment-16461261 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-386040632 Trillian test result (tid-2574) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 21986 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2473-t2574-kvm-centos7.zip Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py Intermitten failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py Intermitten failure detected: /marvin/tests/smoke/test_router_dhcphosts.py Intermitten failure detected: /marvin/tests/smoke/test_router_dns.py Intermitten failure detected: /marvin/tests/smoke/test_router_dnsservice.py Intermitten failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py Intermitten failure detected: /marvin/tests/smoke/test_routers.py Intermitten failure detected: /marvin/tests/smoke/test_secondary_storage.py Intermitten failure detected: /marvin/tests/smoke/test_service_offerings.py Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py Intermitten failure detected: /marvin/tests/smoke/test_templates.py Intermitten failure detected: /marvin/tests/smoke/test_usage.py Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py Intermitten failure detected: /marvin/tests/smoke/test_vm_snapshots.py Intermitten failure detected: /marvin/tests/smoke/test_volumes.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py Smoke tests completed. 45 look OK, 22 have error(s) Only failed tests results shown below: Test | Result | Time (s) | Test File --- | --- | --- | --- test_04_rvpc_privategw_static_routes | `Error` | 474.81 | test_privategw_acl.py ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py ContextSuite context=TestVmSnapshot>:setup | `Error` | 0.05 | test_vm_snapshots.py ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.12 | test_routers_network_ops.py test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.12 | test_routers_network_ops.py ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.26 | test_routers_network_ops.py ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py test_01_sys_vm_start | `Failure` | 0.08 | test_secondary_storage.py test_02_sys_template_ready | `Failure` | 0.06 | test_secondary_storage.py ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.13 | test_service_offerings.py ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py test_02_list_cpvm_vm | `Failure` | 0.03 | test_ssvm.py test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py test_04_cpvm_internals | `Failure` | 0.03 | test_ssvm.py test_05_stop_ssvm | `Failure` | 0.02 | test_ssvm.py test_06_stop_cpvm | `Failure` | 0.02 | test_ssvm.py test_07_reboot_ssvm | `Failure` | 0.02 | test_ssvm.py test_08_reboot_cpvm | `Failure` | 0.03 | test_ssvm.py test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py test_10_destroy_cpvm | `Failure` | 0.02 | test_ssvm.py test_02_create_template_with_checksum_sha1 | `Error` | 65.32 | test_templates.py
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460876#comment-16460876 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - rhtyd commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385942294 Okay @rafaelweingartner I'll merge after smoketests are back. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460842#comment-16460842 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385934377 I do believe it needs code extraction and unit tests, but you want to merge it. Let's proceed and merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460801#comment-16460801 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385926883 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460800#comment-16460800 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - rhtyd commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385926721 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460771#comment-16460771 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385918272 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1991 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460741#comment-16460741 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - rhtyd commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385910875 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460742#comment-16460742 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385910924 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460700#comment-16460700 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385901746 Packaging result: ✔centos6 ✖centos7 ✖debian. JID-1990 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460669#comment-16460669 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - DaanHoogland commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385894396 @rhtyd @rafaelweingartner , i just revisited the code and stand by my the lgtm. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460642#comment-16460642
]
ASF GitHub Bot commented on CLOUDSTACK-10309:
-
rhtyd closed pull request #2473: CLOUDSTACK-10309 Add option on if to VM HA
power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
index f5bdf38740f..6fdd09865da 100644
--- a/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
+++ b/engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
@@ -359,6 +359,9 @@ public void setHostAllocators(final List
hostAllocators) {
Integer.class, "vm.job.report.interval", "60",
"Interval to send application level pings to make sure the
connection is still working", false);
+static final ConfigKey HaVmRestartHostUp = new
ConfigKey("Advanced", Boolean.class, "ha.vm.restart.hostup", "true",
+"If an out-of-band stop of a VM is detected and its host is up,
then power on the VM", true);
+
ScheduledExecutorService _executor = null;
protected long _nodeId;
@@ -3708,7 +3711,7 @@ public String getConfigComponentName() {
public ConfigKey[] getConfigKeys() {
return new ConfigKey[] {ClusterDeltaSyncInterval, StartRetry,
VmDestroyForcestop, VmOpCancelInterval, VmOpCleanupInterval, VmOpCleanupWait,
VmOpLockStateRetry,
-VmOpWaitInterval, ExecuteInSequence, VmJobCheckInterval,
VmJobTimeout, VmJobStateReportInterval, VmConfigDriveLabel};
+VmOpWaitInterval, ExecuteInSequence, VmJobCheckInterval,
VmJobTimeout, VmJobStateReportInterval, VmConfigDriveLabel, HaVmRestartHostUp};
}
public List getStoragePoolAllocators() {
@@ -3853,7 +3856,7 @@ private void
handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
case Stopped:
case Migrating:
s_logger.info("VM " + vm.getInstanceName() + " is at " +
vm.getState() + " and we received a power-off report while there is no pending
jobs on it");
-if(vm.isHaEnabled() && vm.getState() == State.Running &&
vm.getHypervisorType() != HypervisorType.VMware && vm.getHypervisorType() !=
HypervisorType.Hyperv) {
+if(vm.isHaEnabled() && vm.getState() == State.Running &&
HaVmRestartHostUp.value() && vm.getHypervisorType() != HypervisorType.VMware &&
vm.getHypervisorType() != HypervisorType.Hyperv) {
s_logger.info("Detected out-of-band stop of a HA enabled VM "
+ vm.getInstanceName() + ", will schedule restart");
if(!_haMgr.hasPendingHaWork(vm.getId())) {
_haMgr.scheduleRestart(vm, true);
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> VMs with HA enabled, power back on if shutdown from guest OS
>
>
> Key: CLOUDSTACK-10309
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.9.0, 4.10.0.0
> Environment: KVM
>Reporter: Sean Lair
>Priority: Minor
>
> When a user shuts down their VM from the guest OS (and VM HA is enabled), the
> VM just powers itself back on. Our environment is on KVM hosts.
> CloudStack does not know the difference between a VM failing or being
> shutdown from within the guest OS.
> This is a major pain point for all our users - especially since they don't
> pay for VMs when they are shutoff. It is not intuitive for end-users to
> understand why they can't shutdown VMs from within the guest OS. Especially
> when they all come from (non-cloudstack) VMware and Hyper-V environments
> where this is not an issue.
> However, if a host fails, we need VM HA to still work.
> This Issue is being tied to a new PR that creates a configuration option
> "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a
> VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then
> it won't power it back on. The logic
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460646#comment-16460646 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - blueorangutan commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385892533 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460643#comment-16460643 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - Slair1 opened a new pull request #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473 When a user shuts down their VM from the guest OS (and VM HA is enabled), the VM just powers itself back on. Our environment is on KVM hosts. CloudStack does not know the difference between a VM failing or being shutdown from within the guest OS. This is a major pain point for all our users - especially since they don't pay for VMs when they are shutoff. It is not intuitive for end-users to understand why they can't shutdown VMs from within the guest OS. Especially when they all come from (non-cloudstack) VMware and Hyper-V environments where this is not an issue. However, if a host fails, we need VM HA to still work. This PR that creates a configuration option "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a VM shutdown out-of-band, but the host it was on is still *online*, then it won't power the VM back on. The logic is that since the host is online, it was most likely shutdown from the guest OS. For when a host actually fails, standard VM HA logic takes over and powers on VMs (if they have VM HA enabled) if the host they were on fails. If that "ha.vm.restart.hostup" option is true (the default to match current functionality), it works like always, and even in-guest shutdowns of VMs causes CloudStack to power back on the VM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460645#comment-16460645 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - rhtyd commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385892299 FYI - I've changed PR's base branch to validate change from Travis, and trillian. Once this is tested and is okay we can move it back to 4.9 branch. @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460640#comment-16460640 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - rhtyd commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-385892046 LGTM, @DaanHoogland @rafaelweingartner are we okay on the changes and to accept without any test? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397557#comment-16397557 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-372797423 I actually meant unit tests. I think they would fit better the method extraction. They would also be easier to develop. Once you get to create them, if you are unsure how to proceed, just ping me. I can help you. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397551#comment-16397551 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - Slair1 commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-372796545 I've never created a Marvin Test before, but can look at test_vm_life_cycle.py to try and figure it out This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397548#comment-16397548
]
ASF GitHub Bot commented on CLOUDSTACK-10309:
-
Slair1 commented on a change in pull request #2473: CLOUDSTACK-10309 Add option
on if to VM HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#discussion_r174262477
##
File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
##
@@ -3853,7 +3856,7 @@ private void
handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
case Stopped:
case Migrating:
s_logger.info("VM " + vm.getInstanceName() + " is at " +
vm.getState() + " and we received a power-off report while there is no pending
jobs on it");
-if(vm.isHaEnabled() && vm.getState() == State.Running &&
vm.getHypervisorType() != HypervisorType.VMware && vm.getHypervisorType() !=
HypervisorType.Hyperv) {
+if(vm.isHaEnabled() && vm.getState() == State.Running &&
HaVmRestartHostUp.value() && vm.getHypervisorType() != HypervisorType.VMware &&
vm.getHypervisorType() != HypervisorType.Hyperv) {
Review comment:
Yea, that sounds like a good idea, i am booked up here for a while, but it
sounds like a good idea
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> VMs with HA enabled, power back on if shutdown from guest OS
>
>
> Key: CLOUDSTACK-10309
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.9.0, 4.10.0.0
> Environment: KVM
>Reporter: Sean Lair
>Priority: Minor
>
> When a user shuts down their VM from the guest OS (and VM HA is enabled), the
> VM just powers itself back on. Our environment is on KVM hosts.
> CloudStack does not know the difference between a VM failing or being
> shutdown from within the guest OS.
> This is a major pain point for all our users - especially since they don't
> pay for VMs when they are shutoff. It is not intuitive for end-users to
> understand why they can't shutdown VMs from within the guest OS. Especially
> when they all come from (non-cloudstack) VMware and Hyper-V environments
> where this is not an issue.
> However, if a host fails, we need VM HA to still work.
> This Issue is being tied to a new PR that creates a configuration option
> "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a
> VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then
> it won't power it back on. The logic is that since the host is online, it
> was most likely shutdown from the guest OS.
> For when a host actually fails, standard VM HA logic takes over and powers on
> VMs (with VM HA enabled) if the host they were on fails.
> If that "ha.vm.restart.hostup" option is true (the default to match current
> functionality), it works like always, and even in-guest shutdowns of VMs
> causes CloudStack to power back on the VM.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397232#comment-16397232 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - rafaelweingartner commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-372734014 It is ok the code as is. However, it might have been interesting to see the feedback of the author. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397225#comment-16397225 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - DaanHoogland commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-372732335 @Slair1 @rafaelweingartner , can you come to agreement (maybe Rafael's sugestion here or in a separate PR?) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392925#comment-16392925 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - wido commented on issue #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473#issuecomment-371825388 Nice PR! I agree with @rafaelweingartner and @DaanHoogland , but I can live without that. But yes, a method would make testing easier. LGTM based on code This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385091#comment-16385091
]
ASF GitHub Bot commented on CLOUDSTACK-10309:
-
rafaelweingartner commented on a change in pull request #2473: CLOUDSTACK-10309
Add option on if to VM HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#discussion_r172047261
##
File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
##
@@ -3853,7 +3856,7 @@ private void
handlePowerOffReportWithNoPendingJobsOnVM(final VMInstanceVO vm) {
case Stopped:
case Migrating:
s_logger.info("VM " + vm.getInstanceName() + " is at " +
vm.getState() + " and we received a power-off report while there is no pending
jobs on it");
-if(vm.isHaEnabled() && vm.getState() == State.Running &&
vm.getHypervisorType() != HypervisorType.VMware && vm.getHypervisorType() !=
HypervisorType.Hyperv) {
+if(vm.isHaEnabled() && vm.getState() == State.Running &&
HaVmRestartHostUp.value() && vm.getHypervisorType() != HypervisorType.VMware &&
vm.getHypervisorType() != HypervisorType.Hyperv) {
Review comment:
@Slair1 would you mind extracting these conditions to a method (e.g.
`shouldRestartVirtualMachine`)? With your addition the if condition will have 5
elements, which is a lot. Extracting this bit to a method enabled documentation
and unit test cases for these different cases.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> VMs with HA enabled, power back on if shutdown from guest OS
>
>
> Key: CLOUDSTACK-10309
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.9.0, 4.10.0.0
> Environment: KVM
>Reporter: Sean Lair
>Priority: Minor
>
> When a user shuts down their VM from the guest OS (and VM HA is enabled), the
> VM just powers itself back on. Our environment is on KVM hosts.
> CloudStack does not know the difference between a VM failing or being
> shutdown from within the guest OS.
> This is a major pain point for all our users - especially since they don't
> pay for VMs when they are shutoff. It is not intuitive for end-users to
> understand why they can't shutdown VMs from within the guest OS. Especially
> when they all come from (non-cloudstack) VMware and Hyper-V environments
> where this is not an issue.
> However, if a host fails, we need VM HA to still work.
> This Issue is being tied to a new PR that creates a configuration option
> "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a
> VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then
> it won't power it back on. The logic is that since the host is online, it
> was most likely shutdown from the guest OS.
> For when a host actually fails, standard VM HA logic takes over and powers on
> VMs (with VM HA enabled) if the host they were on fails.
> If that "ha.vm.restart.hostup" option is true (the default to match current
> functionality), it works like always, and even in-guest shutdowns of VMs
> causes CloudStack to power back on the VM.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384906#comment-16384906
]
ASF GitHub Bot commented on CLOUDSTACK-10309:
-
Slair1 commented on a change in pull request #2473: CLOUDSTACK-10309 Add option
on if to VM HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#discussion_r172031673
##
File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
##
@@ -359,6 +359,9 @@ public void setHostAllocators(final List
hostAllocators) {
Integer.class, "vm.job.report.interval", "60",
"Interval to send application level pings to make sure the
connection is still working", false);
+static final ConfigKey HaVmRestartHostUp = new
ConfigKey("Advanced", Boolean.class, "ha.vm.restart.hostup", "true",
Review comment:
fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> VMs with HA enabled, power back on if shutdown from guest OS
>
>
> Key: CLOUDSTACK-10309
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.9.0, 4.10.0.0
> Environment: KVM
>Reporter: Sean Lair
>Priority: Minor
>
> When a user shuts down their VM from the guest OS (and VM HA is enabled), the
> VM just powers itself back on. Our environment is on KVM hosts.
> CloudStack does not know the difference between a VM failing or being
> shutdown from within the guest OS.
> This is a major pain point for all our users - especially since they don't
> pay for VMs when they are shutoff. It is not intuitive for end-users to
> understand why they can't shutdown VMs from within the guest OS. Especially
> when they all come from (non-cloudstack) VMware and Hyper-V environments
> where this is not an issue.
> However, if a host fails, we need VM HA to still work.
> This Issue is being tied to a new PR that creates a configuration option
> "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a
> VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then
> it won't power it back on. The logic is that since the host is online, it
> was most likely shutdown from the guest OS.
> For when a host actually fails, standard VM HA logic takes over and powers on
> VMs (with VM HA enabled) if the host they were on fails.
> If that "ha.vm.restart.hostup" option is true (the default to match current
> functionality), it works like always, and even in-guest shutdowns of VMs
> causes CloudStack to power back on the VM.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383368#comment-16383368
]
ASF GitHub Bot commented on CLOUDSTACK-10309:
-
Slair1 commented on a change in pull request #2473: CLOUDSTACK-10309 Add option
on if to VM HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#discussion_r171792251
##
File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
##
@@ -359,6 +359,9 @@ public void setHostAllocators(final List
hostAllocators) {
Integer.class, "vm.job.report.interval", "60",
"Interval to send application level pings to make sure the
connection is still working", false);
+static final ConfigKey HaVmRestartHostUp = new
ConfigKey("Advanced", Boolean.class, "ha.vm.restart.hostup", "true",
Review comment:
Agreed, not sure how that got missed here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> VMs with HA enabled, power back on if shutdown from guest OS
>
>
> Key: CLOUDSTACK-10309
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.9.0, 4.10.0.0
> Environment: KVM
>Reporter: Sean Lair
>Priority: Minor
>
> When a user shuts down their VM from the guest OS (and VM HA is enabled), the
> VM just powers itself back on. Our environment is on KVM hosts.
> CloudStack does not know the difference between a VM failing or being
> shutdown from within the guest OS.
> This is a major pain point for all our users - especially since they don't
> pay for VMs when they are shutoff. It is not intuitive for end-users to
> understand why they can't shutdown VMs from within the guest OS. Especially
> when they all come from (non-cloudstack) VMware and Hyper-V environments
> where this is not an issue.
> However, if a host fails, we need VM HA to still work.
> This Issue is being tied to a new PR that creates a configuration option
> "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a
> VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then
> it won't power it back on. The logic is that since the host is online, it
> was most likely shutdown from the guest OS.
> For when a host actually fails, standard VM HA logic takes over and powers on
> VMs (with VM HA enabled) if the host they were on fails.
> If that "ha.vm.restart.hostup" option is true (the default to match current
> functionality), it works like always, and even in-guest shutdowns of VMs
> causes CloudStack to power back on the VM.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[
https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383357#comment-16383357
]
ASF GitHub Bot commented on CLOUDSTACK-10309:
-
DaanHoogland commented on a change in pull request #2473: CLOUDSTACK-10309 Add
option on if to VM HA power-on a OOB-shut-off-VM
URL: https://github.com/apache/cloudstack/pull/2473#discussion_r171790758
##
File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
##
@@ -359,6 +359,9 @@ public void setHostAllocators(final List
hostAllocators) {
Integer.class, "vm.job.report.interval", "60",
"Interval to send application level pings to make sure the
connection is still working", false);
+static final ConfigKey HaVmRestartHostUp = new
ConfigKey("Advanced", Boolean.class, "ha.vm.restart.hostup", "true",
Review comment:
I would expect to see the new ConfigKey be added to the return of
getConfigKeys()
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> VMs with HA enabled, power back on if shutdown from guest OS
>
>
> Key: CLOUDSTACK-10309
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: Management Server
>Affects Versions: 4.9.0, 4.10.0.0
> Environment: KVM
>Reporter: Sean Lair
>Priority: Minor
>
> When a user shuts down their VM from the guest OS (and VM HA is enabled), the
> VM just powers itself back on. Our environment is on KVM hosts.
> CloudStack does not know the difference between a VM failing or being
> shutdown from within the guest OS.
> This is a major pain point for all our users - especially since they don't
> pay for VMs when they are shutoff. It is not intuitive for end-users to
> understand why they can't shutdown VMs from within the guest OS. Especially
> when they all come from (non-cloudstack) VMware and Hyper-V environments
> where this is not an issue.
> However, if a host fails, we need VM HA to still work.
> This Issue is being tied to a new PR that creates a configuration option
> "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a
> VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then
> it won't power it back on. The logic is that since the host is online, it
> was most likely shutdown from the guest OS.
> For when a host actually fails, standard VM HA logic takes over and powers on
> VMs (with VM HA enabled) if the host they were on fails.
> If that "ha.vm.restart.hostup" option is true (the default to match current
> functionality), it works like always, and even in-guest shutdowns of VMs
> causes CloudStack to power back on the VM.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CLOUDSTACK-10309) VMs with HA enabled, power back on if shutdown from guest OS
[ https://issues.apache.org/jira/browse/CLOUDSTACK-10309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382644#comment-16382644 ] ASF GitHub Bot commented on CLOUDSTACK-10309: - Slair1 opened a new pull request #2473: CLOUDSTACK-10309 Add option on if to VM HA power-on a OOB-shut-off-VM URL: https://github.com/apache/cloudstack/pull/2473 When a user shuts down their VM from the guest OS (and VM HA is enabled), the VM just powers itself back on. Our environment is on KVM hosts. CloudStack does not know the difference between a VM failing or being shutdown from within the guest OS. This is a major pain point for all our users - especially since they don't pay for VMs when they are shutoff. It is not intuitive for end-users to understand why they can't shutdown VMs from within the guest OS. Especially when they all come from (non-cloudstack) VMware and Hyper-V environments where this is not an issue. However, if a host fails, we need VM HA to still work. This PR that creates a configuration option "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a VM shutdown out-of-band, but the host it was on is still *online*, then it won't power the VM back on. The logic is that since the host is online, it was most likely shutdown from the guest OS. For when a host actually fails, standard VM HA logic takes over and powers on VMs (if they have VM HA enabled) if the host they were on fails. If that "ha.vm.restart.hostup" option is true (the default to match current functionality), it works like always, and even in-guest shutdowns of VMs causes CloudStack to power back on the VM. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > VMs with HA enabled, power back on if shutdown from guest OS > > > Key: CLOUDSTACK-10309 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10309 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Management Server >Affects Versions: 4.9.0, 4.10.0.0 > Environment: KVM >Reporter: Sean Lair >Priority: Minor > > When a user shuts down their VM from the guest OS (and VM HA is enabled), the > VM just powers itself back on. Our environment is on KVM hosts. > CloudStack does not know the difference between a VM failing or being > shutdown from within the guest OS. > This is a major pain point for all our users - especially since they don't > pay for VMs when they are shutoff. It is not intuitive for end-users to > understand why they can't shutdown VMs from within the guest OS. Especially > when they all come from (non-cloudstack) VMware and Hyper-V environments > where this is not an issue. > However, if a host fails, we need VM HA to still work. > This Issue is being tied to a new PR that creates a configuration option > "ha.vm.restart.hostup". With this option set to false, if CloudStack sees a > VM shutdown out-of-band, +*but the host it was on is still* *onlin*e+, then > it won't power it back on. The logic is that since the host is online, it > was most likely shutdown from the guest OS. > For when a host actually fails, standard VM HA logic takes over and powers on > VMs (with VM HA enabled) if the host they were on fails. > If that "ha.vm.restart.hostup" option is true (the default to match current > functionality), it works like always, and even in-guest shutdowns of VMs > causes CloudStack to power back on the VM. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
