[jira] [Work logged] (LANG-1410) StringsUtil.isBlank check null first

2018-12-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1410?focusedWorklogId=176393=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-176393 ] ASF GitHub Bot logged work on LANG-1410: Author: ASF GitHub Bot

[GitHub] rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-17 Thread GitBox
rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242423165 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[jira] [Work logged] (LANG-1410) StringsUtil.isBlank check null first

2018-12-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1410?focusedWorklogId=176379=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-176379 ] ASF GitHub Bot logged work on LANG-1410: Author: ASF GitHub Bot

[GitHub] rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-17 Thread GitBox
rosti-il commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242420905 ## File path:

[GitHub] MarkDacek commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value

2018-12-17 Thread GitBox
MarkDacek commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value URL: https://github.com/apache/commons-lang/pull/362#issuecomment-448013754 Can you think of any kind of use-case where a String over two-billion characters long is created, such that all

[GitHub] Turan91 commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value

2018-12-17 Thread GitBox
Turan91 commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value URL: https://github.com/apache/commons-lang/pull/362#issuecomment-448012492 It is convention for exception messages to provide the user with information on the cause of failure. In the same

[jira] [Work logged] (LANG-1410) StringsUtil.isBlank check null first

2018-12-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1410?focusedWorklogId=176260=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-176260 ] ASF GitHub Bot logged work on LANG-1410: Author: ASF GitHub Bot

[GitHub] MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-17 Thread GitBox
MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242326701 ## File path:

[GitHub] MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests

2018-12-17 Thread GitBox
MarkDacek commented on a change in pull request #392: LANG-1410: eliminate one unnecessary local int variable and add more tests URL: https://github.com/apache/commons-lang/pull/392#discussion_r242326099 ## File path: src/main/java/org/apache/commons/lang3/StringUtils.java

[jira] [Work logged] (LANG-1410) StringsUtil.isBlank check null first

2018-12-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1410?focusedWorklogId=176258=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-176258 ] ASF GitHub Bot logged work on LANG-1410: Author: ASF GitHub Bot

[GitHub] MarkDacek commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value

2018-12-17 Thread GitBox
MarkDacek commented on issue #362: Add a check to StringUtils.repeat() for large length repeat value URL: https://github.com/apache/commons-lang/pull/362#issuecomment-448005772 Other thing of note: I don't think that providing the length in the exception is terribly useful, as the

[GitHub] MarkDacek commented on issue #391: Adding junits for JsonToStringStyle

2018-12-17 Thread GitBox
MarkDacek commented on issue #391: Adding junits for JsonToStringStyle URL: https://github.com/apache/commons-lang/pull/391#issuecomment-448004147 Can you make your arrays in the new test cases final? Also perhaps avoid using the **new** keyword when you don't need memory allocated at that

[jira] [Resolved] (JEXL-281) MethodExecutor incorrectly tests for empty parameters list

2018-12-17 Thread Henri Biestro (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro resolved JEXL-281. Resolution: Fixed Fix Version/s: 3.2 - releases notes and changes revision :

[jira] [Commented] (JEXL-281) MethodExecutor incorrectly tests for empty parameters list

2018-12-17 Thread Henri Biestro (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723065#comment-16723065 ] Henri Biestro commented on JEXL-281: Refined logic in MethodKey.isVarArgs avoiding costly class

[jira] [Updated] (JEXL-281) MethodExecutor incorrectly tests for empty parameters list

2018-12-17 Thread Henri Biestro (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henri Biestro updated JEXL-281: --- Assignee: Henri Biestro > MethodExecutor incorrectly tests for empty parameters list >

[jira] [Updated] (GEOMETRY-36) Package "o.a.c.geometry.euclidean.threed.rotation"

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-36?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated GEOMETRY-36: --- Labels: design documentation (was: ) Description: There is no equivalent in package

[jira] [Created] (GEOMETRY-36) z

2018-12-17 Thread Gilles (JIRA)
Gilles created GEOMETRY-36: -- Summary: z Key: GEOMETRY-36 URL: https://issues.apache.org/jira/browse/GEOMETRY-36 Project: Apache Commons Geometry Issue Type: Task Components: Euclidean 3D

[jira] [Created] (GEOMETRY-35) Use "PlaneAngle" from "Commons Numbers"

2018-12-17 Thread Gilles (JIRA)
Gilles created GEOMETRY-35: -- Summary: Use "PlaneAngle" from "Commons Numbers" Key: GEOMETRY-35 URL: https://issues.apache.org/jira/browse/GEOMETRY-35 Project: Apache Commons Geometry Issue Type:

[jira] [Updated] (GEOMETRY-25) Class "Geometry"

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-25?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated GEOMETRY-25: --- Fix Version/s: 1.0 > Class "Geometry" > > > Key: GEOMETRY-25 >

[jira] [Resolved] (GEOMETRY-14) AffineTransform?D Classes

2018-12-17 Thread Matt Juntunen (JIRA)
[ https://issues.apache.org/jira/browse/GEOMETRY-14?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Juntunen resolved GEOMETRY-14. --- Resolution: Done > AffineTransform?D Classes > - > >

[jira] [Resolved] (NUMBERS-83) Replace usage of methods deprecated in Java 9

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-83?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-83. --- Resolution: Fixed commit d0cff0d8f2a249e6c87df323fe635386749f62f4 > Replace usage of methods deprecated in

[jira] [Resolved] (NUMBERS-76) Make "Quaternion" a ValJO

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-76. --- Resolution: Done > Make "Quaternion" a ValJO > - > > Key: NUMBERS-76

[jira] [Updated] (NUMBERS-76) Make "Quaternion" a ValJO

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated NUMBERS-76: -- Description: https://blog.joda.org/2014/03/valjos-value-java-objects.html > Make "Quaternion" a ValJO >

[jira] [Resolved] (NUMBERS-42) Factory methods

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-42?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-42. --- Resolution: Done > Factory methods > --- > > Key: NUMBERS-42 >

[jira] [Resolved] (NUMBERS-56) Wrong dimension check?

2018-12-17 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/NUMBERS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles resolved NUMBERS-56. --- Resolution: Fixed > Wrong dimension check? > -- > > Key: NUMBERS-56 >

[jira] [Commented] (JEXL-283) JexlEngine parse an expression in wrong way.It seems like create a SimpleNode in the ASTJexlScript

2018-12-17 Thread zhuliang (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722834#comment-16722834 ] zhuliang commented on JEXL-283: --- I know 2.0.1 library is out of date now,but i don‘t know how this happend.

[jira] [Issue Comment Deleted] (JEXL-283) JexlEngine parse an expression in wrong way.It seems like create a SimpleNode in the ASTJexlScript

2018-12-17 Thread zhuliang (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuliang updated JEXL-283: -- Comment: was deleted (was: aa) > JexlEngine parse an expression in wrong way.It seems like create a SimpleNode

[jira] [Commented] (JEXL-283) JexlEngine parse an expression in wrong way.It seems like create a SimpleNode in the ASTJexlScript

2018-12-17 Thread zhuliang (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722828#comment-16722828 ] zhuliang commented on JEXL-283: --- aa > JexlEngine parse an expression in wrong way.It seems like create a

[jira] [Commented] (FILEUPLOAD-279) CVE-2016-1000031 - Apache Commons FileUpload DiskFileItem File Manipulation Remote Code Execution

2018-12-17 Thread Bernd Eckenfels (JIRA)
[ https://issues.apache.org/jira/browse/FILEUPLOAD-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722825#comment-16722825 ] Bernd Eckenfels commented on FILEUPLOAD-279: Snapshots are not released and therefore

[jira] [Commented] (JEXL-283) JexlEngine parse an expression in wrong way.It seems like create a SimpleNode in the ASTJexlScript

2018-12-17 Thread Dmitri Blinov (JIRA)
[ https://issues.apache.org/jira/browse/JEXL-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722819#comment-16722819 ] Dmitri Blinov commented on JEXL-283: The 2.0.1 library is realy outdated now. Please try to use 2.1.1