[jira] [Updated] (COLLECTIONS-714) PatriciaTrie ignores trailing null characters in keys

2019-04-30 Thread Rohan Padhye (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohan Padhye updated COLLECTIONS-714: - Description: In Java, strings are not null terminated. The string "x" (of length =

[jira] [Updated] (COLLECTIONS-714) PatriciaTrie ignores trailing null characters in keys

2019-04-30 Thread Rohan Padhye (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohan Padhye updated COLLECTIONS-714: - Description: In Java, strings are not null terminated. The string "x" (of length =

[jira] [Updated] (COLLECTIONS-714) PatriciaTrie ignores trailing null characters in keys

2019-04-30 Thread Rohan Padhye (JIRA)
[ https://issues.apache.org/jira/browse/COLLECTIONS-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohan Padhye updated COLLECTIONS-714: - Description: In Java, strings are not null terminated. The string "x" (of length =

[jira] [Created] (COLLECTIONS-714) PatriciaTrie ignores trailing null characters in keys

2019-04-30 Thread Rohan Padhye (JIRA)
Rohan Padhye created COLLECTIONS-714: Summary: PatriciaTrie ignores trailing null characters in keys Key: COLLECTIONS-714 URL: https://issues.apache.org/jira/browse/COLLECTIONS-714 Project:

[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x

2019-04-30 Thread GitBox
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-488129264 Hi @garydgregory , I don't know, but the patch file downloaded from GitHub seems to make problems. I found an

[jira] [Comment Edited] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x

2019-04-30 Thread Woonsan Ko (JIRA)
[ https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830723#comment-16830723 ] Woonsan Ko edited comment on VFS-686 at 4/30/19 9:53 PM: - Hi [~garydgregory], For

[jira] [Commented] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x

2019-04-30 Thread Woonsan Ko (JIRA)
[ https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830723#comment-16830723 ] Woonsan Ko commented on VFS-686: Hi [~garydgregory], For some reason, the patch file downloaded from GitHub

[jira] [Updated] (VFS-686) Upgrade Jackrabbit dependency to the latest 2.x

2019-04-30 Thread Woonsan Ko (JIRA)
[ https://issues.apache.org/jira/browse/VFS-686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Woonsan Ko updated VFS-686: --- Attachment: feature-VFS-686.patch > Upgrade Jackrabbit dependency to the latest 2.x >

[jira] [Created] (COMPRESS-484) Update optional library zstd-jni from 1.3.3-3 to 1.4.0-1

2019-04-30 Thread Gary Gregory (JIRA)
Gary Gregory created COMPRESS-484: - Summary: Update optional library zstd-jni from 1.3.3-3 to 1.4.0-1 Key: COMPRESS-484 URL: https://issues.apache.org/jira/browse/COMPRESS-484 Project: Commons

[jira] [Closed] (COMPRESS-484) Update optional library zstd-jni from 1.3.3-3 to 1.4.0-1

2019-04-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/COMPRESS-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed COMPRESS-484. - Resolution: Fixed Fix Version/s: 1.19 In git master. > Update optional library

[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x

2019-04-30 Thread GitBox
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-488096381 @woonsan Thank you. WRT the patch. could there might still be conflicts: ``` C:\git\commons-vfs>git apply

[GitHub] [commons-vfs] woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x

2019-04-30 Thread GitBox
woonsan commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-487989859 Hi @garydgregory , I've just merged mater. It's great to see greens even for JVM11! Great work! Woonsan

[GitHub] [commons-dbutils] garydgregory commented on issue #8: Added jdk versions in travis

2019-04-30 Thread GitBox
garydgregory commented on issue #8: Added jdk versions in travis URL: https://github.com/apache/commons-dbutils/pull/8#issuecomment-487980176 -1: Since Java 9 and 10 are not supported long term, I think we test on Java 8, 11 and up.

[GitHub] [commons-dbutils] visruth opened a new pull request #8: Added jdk versions in travis

2019-04-30 Thread GitBox
visruth opened a new pull request #8: Added jdk versions in travis URL: https://github.com/apache/commons-dbutils/pull/8 openjdk9, openjdk10 and oraclejdk9 are added This is an automated message from the Apache Git Service.

[jira] [Closed] (POOL-366) Update optional library cglib from 3.2.10 to 3.2.11

2019-04-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/POOL-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed POOL-366. - Resolution: Fixed Fix Version/s: 2.7.0 In git master. > Update optional library cglib from 3.2.10

[jira] [Created] (POOL-366) Update optional library cglib from 3.2.10 to 3.2.11

2019-04-30 Thread Gary Gregory (JIRA)
Gary Gregory created POOL-366: - Summary: Update optional library cglib from 3.2.10 to 3.2.11 Key: POOL-366 URL: https://issues.apache.org/jira/browse/POOL-366 Project: Commons Pool Issue Type:

[jira] [Commented] (LANG-1451) Should there be a better implementation of substring that deals with Unicode surrogate pairs correctly?

2019-04-30 Thread Rob Tompkins (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830303#comment-16830303 ] Rob Tompkins commented on LANG-1451: If so, then we'd clearly want separate methods I would think >

[GitHub] [commons-vfs] abashev commented on issue #62: Don’t fail on openjdk-ea builds

2019-04-30 Thread GitBox
abashev commented on issue #62: Don’t fail on openjdk-ea builds URL: https://github.com/apache/commons-vfs/pull/62#issuecomment-487948405 Because of this one https://github.com/apache/commons-vfs/pull/62/commits/44700e19bdb03e3d38c43f2b361fdb9661ccfc9a

[jira] [Commented] (LANG-1451) Should there be a better implementation of substring that deals with Unicode surrogate pairs correctly?

2019-04-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830278#comment-16830278 ] Gary Gregory commented on LANG-1451: Would there be negative performance consequences worth

[GitHub] [commons-vfs] garydgregory edited a comment on issue #62: Don’t fail on openjdk-ea builds

2019-04-30 Thread GitBox
garydgregory edited a comment on issue #62: Don’t fail on openjdk-ea builds URL: https://github.com/apache/commons-vfs/pull/62#issuecomment-487944561 I'd like to understand why the PR build passes: https://travis-ci.org/apache/commons-vfs/builds/526143774 AND that EA build actually

[GitHub] [commons-vfs] garydgregory commented on issue #62: Don’t fail on openjdk-ea builds

2019-04-30 Thread GitBox
garydgregory commented on issue #62: Don’t fail on openjdk-ea builds URL: https://github.com/apache/commons-vfs/pull/62#issuecomment-487944561 I'd like to understand why the PR build passes: https://travis-ci.org/apache/commons-vfs/builds/526143774 AND that build actually ran.

[jira] [Comment Edited] (LANG-1451) Should there be a better implementation of substring that deals with Unicode surrogate pairs correctly?

2019-04-30 Thread Rob Tompkins (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830275#comment-16830275 ] Rob Tompkins edited comment on LANG-1451 at 4/30/19 1:02 PM: - maybe rename the

[GitHub] [commons-vfs] abashev commented on issue #62: Don’t fail on openjdk-ea builds

2019-04-30 Thread GitBox
abashev commented on issue #62: Don’t fail on openjdk-ea builds URL: https://github.com/apache/commons-vfs/pull/62#issuecomment-487943312 @garydgregory I'm not sure how do you mean.

[jira] [Commented] (LANG-1451) Should there be a better implementation of substring that deals with Unicode surrogate pairs correctly?

2019-04-30 Thread Rob Tompkins (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830275#comment-16830275 ] Rob Tompkins commented on LANG-1451: maybe rename the variables to {{startOffsetByCodePoints}} >

[jira] [Commented] (LANG-1451) Should there be a better implementation of substring that deals with Unicode surrogate pairs correctly?

2019-04-30 Thread Rob Tompkins (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830274#comment-16830274 ] Rob Tompkins commented on LANG-1451: Actuallyif we make our {{substring}} method the following:

[GitHub] [commons-vfs] garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x

2019-04-30 Thread GitBox
garydgregory commented on issue #52: VFS-686: webdav4 provider based on the latest Jackrabbit 2.x URL: https://github.com/apache/commons-vfs/pull/52#issuecomment-487942620 Hi @woonsan, So sorry I got side tracked. May you please rebase on master so we can get a fresh set of Travis

[jira] [Closed] (VFS-705) Add ability to specify the buffer size of input/output streams

2019-04-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/VFS-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed VFS-705. Resolution: Fixed Oops, I created [VFS-706] and committed with that ticket reference instead of this one. I

[jira] [Updated] (VFS-706) Add ability to specify buffer sizes #59

2019-04-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/VFS-706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated VFS-706: - Description: Add ability to specify buffer sizes #59. "FileContent.getInputStream"'s documentation

[jira] [Closed] (VFS-706) Add ability to specify buffer sizes #59

2019-04-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/VFS-706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed VFS-706. Resolution: Fixed > Add ability to specify buffer sizes #59 > --- > >

[jira] [Reopened] (VFS-706) Add ability to specify buffer sizes #59

2019-04-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/VFS-706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory reopened VFS-706: -- > Add ability to specify buffer sizes #59 > --- > > Key:

[jira] [Commented] (LANG-1451) Should there be a better implementation of substring that deals with Unicode surrogate pairs correctly?

2019-04-30 Thread Gary Gregory (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830262#comment-16830262 ] Gary Gregory commented on LANG-1451: Or we could have a new class {{CodePointStringUtils}} (or another

[jira] [Commented] (LANG-1451) Should there be a better implementation of substring that deals with Unicode surrogate pairs correctly?

2019-04-30 Thread Rob Tompkins (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830256#comment-16830256 ] Rob Tompkins commented on LANG-1451: Do we want to call these methods {{codePointSubstring}} and

[GitHub] [commons-vfs] garydgregory edited a comment on issue #36: fix for VFS-662: SftpFileSystem has Thread-safe issue about idleChannel

2019-04-30 Thread GitBox
garydgregory edited a comment on issue #36: fix for VFS-662: SftpFileSystem has Thread-safe issue about idleChannel URL: https://github.com/apache/commons-vfs/pull/36#issuecomment-487937541 @abashev BTW, welcome aboard the Apache Commons project :-)

[GitHub] [commons-vfs] garydgregory commented on issue #36: fix for VFS-662: SftpFileSystem has Thread-safe issue about idleChannel

2019-04-30 Thread GitBox
garydgregory commented on issue #36: fix for VFS-662: SftpFileSystem has Thread-safe issue about idleChannel URL: https://github.com/apache/commons-vfs/pull/36#issuecomment-487937541 BTW, welcome aboard the Apache Commons project :-)

[GitHub] [commons-vfs] garydgregory commented on issue #62: Don’t fail on openjdk-ea builds

2019-04-30 Thread GitBox
garydgregory commented on issue #62: Don’t fail on openjdk-ea builds URL: https://github.com/apache/commons-vfs/pull/62#issuecomment-487937038 Hi @abashev: I am kinda -1 on openjdk-ea as allowing to fail since we know it always fails. What I was trying to say, unsuccessfully ;-) is

[jira] [Commented] (LANG-1451) Should there be a better implementation of substring that deals with Unicode surrogate pairs correctly?

2019-04-30 Thread Rob Tompkins (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830242#comment-16830242 ] Rob Tompkins commented on LANG-1451: [~Sebastiaan83] - when I try to even instantiate a string like