[GitHub] [commons-collections] kinow commented on issue #114: Fix Javadoc code example in BulkTest

2020-01-08 Thread GitBox
kinow commented on issue #114: Fix Javadoc code example in BulkTest URL: https://github.com/apache/commons-collections/pull/114#issuecomment-572434399 @dota17 I've updated the title, hope that's OK. This is an automated

[GitHub] [commons-collections] kinow commented on issue #114: Modified the error in the comments of BulkTest.java

2020-01-08 Thread GitBox
kinow commented on issue #114: Modified the error in the comments of BulkTest.java URL: https://github.com/apache/commons-collections/pull/114#issuecomment-572434260 I think this is a Javadoc change @garydgregory . At first also thought it was a code change. Then looked at the IDE, and

[jira] [Work logged] (COLLECTIONS-737) The test FluentIterableTest.size should be split

2020-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-737?focusedWorklogId=368833=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368833 ] ASF GitHub Bot logged work on COLLECTIONS-737: -- Author: ASF

[jira] [Work logged] (COLLECTIONS-737) The test FluentIterableTest.size should be split

2020-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-737?focusedWorklogId=368834=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368834 ] ASF GitHub Bot logged work on COLLECTIONS-737: -- Author: ASF

[GitHub] [commons-collections] kinow commented on a change in pull request #120: [COLLECTIONS-737] The test FluentIterableTest.size should be splitted

2020-01-08 Thread GitBox
kinow commented on a change in pull request #120: [COLLECTIONS-737] The test FluentIterableTest.size should be splitted URL: https://github.com/apache/commons-collections/pull/120#discussion_r364591671 ## File path: src/main/java/org/apache/commons/collections4/IterableUtils.java

[GitHub] [commons-collections] kinow commented on a change in pull request #120: [COLLECTIONS-737] The test FluentIterableTest.size should be splitted

2020-01-08 Thread GitBox
kinow commented on a change in pull request #120: [COLLECTIONS-737] The test FluentIterableTest.size should be splitted URL: https://github.com/apache/commons-collections/pull/120#discussion_r364592914 ## File path:

[GitHub] [commons-collections] kinow commented on a change in pull request #118: Fixed the typo and deal the NPE with Objects.requireNonNull

2020-01-08 Thread GitBox
kinow commented on a change in pull request #118: Fixed the typo and deal the NPE with Objects.requireNonNull URL: https://github.com/apache/commons-collections/pull/118#discussion_r364589526 ## File path:

[GitHub] [commons-collections] kinow commented on a change in pull request #126: Improve MapUtils with the null checks, add JUnit for it and add Javadoc for the parameter indent.

2020-01-08 Thread GitBox
kinow commented on a change in pull request #126: Improve MapUtils with the null checks, add JUnit for it and add Javadoc for the parameter indent. URL: https://github.com/apache/commons-collections/pull/126#discussion_r364588721 ## File path:

[jira] [Updated] (COLLECTIONS-738) The last assertNull in IterableUtilsTest.find is redundant

2020-01-08 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated COLLECTIONS-738: --- Fix Version/s: 4.5 > The last assertNull in IterableUtilsTest.find is

[jira] [Updated] (COLLECTIONS-738) The last assertNull in IterableUtilsTest.find is redundant

2020-01-08 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated COLLECTIONS-738: --- Affects Version/s: 4.4 > The last assertNull in IterableUtilsTest.find

[jira] [Resolved] (COLLECTIONS-738) The last assertNull in IterableUtilsTest.find is redundant

2020-01-08 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita resolved COLLECTIONS-738. Resolution: Fixed > The last assertNull in IterableUtilsTest.find is

[jira] [Work logged] (COLLECTIONS-738) The last assertNull in IterableUtilsTest.find is redundant

2020-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-738?focusedWorklogId=368825=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368825 ] ASF GitHub Bot logged work on COLLECTIONS-738: -- Author: ASF

[GitHub] [commons-collections] kinow closed pull request #121: [COLLECTIONS-738] Remove the redundant assertNull in IterableUtilsTest.find

2020-01-08 Thread GitBox
kinow closed pull request #121: [COLLECTIONS-738] Remove the redundant assertNull in IterableUtilsTest.find URL: https://github.com/apache/commons-collections/pull/121 This is an automated message from the Apache Git

[GitHub] [commons-collections] kinow commented on a change in pull request #121: [COLLECTIONS-738] Remove the redundant assertNull in IterableUtilsTest.find

2020-01-08 Thread GitBox
kinow commented on a change in pull request #121: [COLLECTIONS-738] Remove the redundant assertNull in IterableUtilsTest.find URL: https://github.com/apache/commons-collections/pull/121#discussion_r364586865 ## File path:

[jira] [Work logged] (COLLECTIONS-738) The last assertNull in IterableUtilsTest.find is redundant

2020-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-738?focusedWorklogId=368822=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368822 ] ASF GitHub Bot logged work on COLLECTIONS-738: -- Author: ASF

[jira] [Updated] (COLLECTIONS-738) The last assertNull in IterableUtilsTest.find is redundant

2020-01-08 Thread Bruno P. Kinoshita (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno P. Kinoshita updated COLLECTIONS-738: --- Assignee: Bruno P. Kinoshita > The last assertNull in

[jira] [Resolved] (DBUTILS-143) Don't close connection if provided

2020-01-08 Thread Carl Franklin Hall (Jira)
[ https://issues.apache.org/jira/browse/DBUTILS-143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Franklin Hall resolved DBUTILS-143. Resolution: Fixed > Don't close connection if provided >

[jira] [Created] (DBUTILS-143) Don't close connection if provided

2020-01-08 Thread Carl Franklin Hall (Jira)
Carl Franklin Hall created DBUTILS-143: -- Summary: Don't close connection if provided Key: DBUTILS-143 URL: https://issues.apache.org/jira/browse/DBUTILS-143 Project: Commons DbUtils

[jira] [Commented] (GEOMETRY-71) Investigate Spherical Barycenter Accuracy

2020-01-08 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011397#comment-17011397 ] Matt Juntunen commented on GEOMETRY-71: --- Here are a few more notes on this: - When performing the

[GitHub] [commons-collections] kinow commented on a change in pull request #83: Initial bloom filter code contribution

2020-01-08 Thread GitBox
kinow commented on a change in pull request #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r364541589 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/SetOperations.java ## @@ -0,0

[GitHub] [commons-collections] kinow commented on a change in pull request #83: Initial bloom filter code contribution

2020-01-08 Thread GitBox
kinow commented on a change in pull request #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r364541269 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunction.java ## @@

[GitHub] [commons-collections] kinow commented on a change in pull request #83: Initial bloom filter code contribution

2020-01-08 Thread GitBox
kinow commented on a change in pull request #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r364541994 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/Hasher.java ## @@ -0,0 +1,100

[GitHub] [commons-collections] kinow commented on a change in pull request #83: Initial bloom filter code contribution

2020-01-08 Thread GitBox
kinow commented on a change in pull request #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r364541184 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/hasher/HashFunctionIdentity.java

[GitHub] [commons-collections] kinow commented on a change in pull request #83: Initial bloom filter code contribution

2020-01-08 Thread GitBox
kinow commented on a change in pull request #83: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r364541471 ## File path: src/main/java/org/apache/commons/collections4/bloomfilter/SetOperations.java ## @@ -0,0

[jira] [Work logged] (TEXT-175) WordUtils.capitalizeFully(String) only splits by spaces, instead of any whitespace

2020-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TEXT-175?focusedWorklogId=368311=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368311 ] ASF GitHub Bot logged work on TEXT-175: --- Author: ASF GitHub Bot

[GitHub] [commons-text] dlavati commented on a change in pull request #127: TEXT-175: WordUtils.capitalizeFully should use all whitespaces if del…

2020-01-08 Thread GitBox
dlavati commented on a change in pull request #127: TEXT-175: WordUtils.capitalizeFully should use all whitespaces if del… URL: https://github.com/apache/commons-text/pull/127#discussion_r364366094 ## File path: src/main/java/org/apache/commons/text/WordUtils.java ## @@

[jira] [Work logged] (TEXT-175) WordUtils.capitalizeFully(String) only splits by spaces, instead of any whitespace

2020-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TEXT-175?focusedWorklogId=368310=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368310 ] ASF GitHub Bot logged work on TEXT-175: --- Author: ASF GitHub Bot

[GitHub] [commons-text] dlavati commented on a change in pull request #127: TEXT-175: WordUtils.capitalizeFully should use all whitespaces if del…

2020-01-08 Thread GitBox
dlavati commented on a change in pull request #127: TEXT-175: WordUtils.capitalizeFully should use all whitespaces if del… URL: https://github.com/apache/commons-text/pull/127#discussion_r364366094 ## File path: src/main/java/org/apache/commons/text/WordUtils.java ## @@

[GitHub] [commons-text] garydgregory commented on a change in pull request #127: TEXT-175: WordUtils.capitalizeFully should use all whitespaces if del…

2020-01-08 Thread GitBox
garydgregory commented on a change in pull request #127: TEXT-175: WordUtils.capitalizeFully should use all whitespaces if del… URL: https://github.com/apache/commons-text/pull/127#discussion_r364354913 ## File path: src/main/java/org/apache/commons/text/WordUtils.java ##

[jira] [Work logged] (TEXT-175) WordUtils.capitalizeFully(String) only splits by spaces, instead of any whitespace

2020-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TEXT-175?focusedWorklogId=368298=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368298 ] ASF GitHub Bot logged work on TEXT-175: --- Author: ASF GitHub Bot

[jira] [Commented] (VFS-752) AbstractFileProvider close should close all fileSystems before clearing the cache

2020-01-08 Thread Bernd Eckenfels (Jira)
[ https://issues.apache.org/jira/browse/VFS-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010810#comment-17010810 ] Bernd Eckenfels commented on VFS-752: - (And i think the File Provider does close all of it's components,

[jira] [Commented] (VFS-752) AbstractFileProvider close should close all fileSystems before clearing the cache

2020-01-08 Thread Bernd Eckenfels (Jira)
[ https://issues.apache.org/jira/browse/VFS-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010803#comment-17010803 ] Bernd Eckenfels commented on VFS-752: - We might also need a different close method on FileObject,

[jira] [Commented] (GEOMETRY-71) Investigate Spherical Barycenter Accuracy

2020-01-08 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010805#comment-17010805 ] Gilles Sadowski commented on GEOMETRY-71: - bq. Fixed the Checkstyle issues. Thanks. bq. The

[jira] [Created] (CRYPTO-145) Apache Commons Crypto apidocs index.html

2020-01-08 Thread ZHANGLEIJIE (Jira)
ZHANGLEIJIE created CRYPTO-145: -- Summary: Apache Commons Crypto apidocs index.html Key: CRYPTO-145 URL: https://issues.apache.org/jira/browse/CRYPTO-145 Project: Commons Crypto Issue Type: Bug

[GitHub] [commons-text] dlavati opened a new pull request #127: TEXT-175: WordUtils.capitalizeFully should use all whitespaces if del…

2020-01-08 Thread GitBox
dlavati opened a new pull request #127: TEXT-175: WordUtils.capitalizeFully should use all whitespaces if del… URL: https://github.com/apache/commons-text/pull/127 …imiters is null This is an automated message from the

[jira] [Work logged] (TEXT-175) WordUtils.capitalizeFully(String) only splits by spaces, instead of any whitespace

2020-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/TEXT-175?focusedWorklogId=368209=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368209 ] ASF GitHub Bot logged work on TEXT-175: --- Author: ASF GitHub Bot

[jira] [Comment Edited] (GEOMETRY-71) Investigate Spherical Barycenter Accuracy

2020-01-08 Thread Baljit Singh (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010716#comment-17010716 ] Baljit Singh edited comment on GEOMETRY-71 at 1/8/20 2:42 PM: -- Fixed the

[jira] [Commented] (GEOMETRY-71) Investigate Spherical Barycenter Accuracy

2020-01-08 Thread Baljit Singh (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010716#comment-17010716 ] Baljit Singh commented on GEOMETRY-71: -- Fixed the Checkstyle issues. > Investigate Spherical

[jira] [Resolved] (GEOMETRY-81) Rename ConvexSubPlane to Facet

2020-01-08 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Juntunen resolved GEOMETRY-81. --- Resolution: Done > Rename ConvexSubPlane to Facet > -- > >

[jira] [Closed] (GEOMETRY-81) Rename ConvexSubPlane to Facet

2020-01-08 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Juntunen closed GEOMETRY-81. - > Rename ConvexSubPlane to Facet > -- > > Key:

[jira] [Commented] (GEOMETRY-71) Investigate Spherical Barycenter Accuracy

2020-01-08 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010702#comment-17010702 ] Gilles Sadowski commented on GEOMETRY-71: - The build fails for PR #51 because of [CheckStyle

[jira] [Updated] (GEOMETRY-86) Point2S.antipodal() or Point2S.from() is incorrect.

2020-01-08 Thread Baljit Singh (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Baljit Singh updated GEOMETRY-86: - Description: {code:java} @Test public void testAntipodal() { Point2S point =

[GitHub] [commons-geometry] singhbaljit commented on a change in pull request #51: [GEOMETRY-71] Add test for RegionBSPTree2S barycenter

2020-01-08 Thread GitBox
singhbaljit commented on a change in pull request #51: [GEOMETRY-71] Add test for RegionBSPTree2S barycenter URL: https://github.com/apache/commons-geometry/pull/51#discussion_r364236321 ## File path:

[GitHub] [commons-geometry] singhbaljit commented on issue #51: [GEOMETRY-71] Add test for RegionBSPTree2S barycenter

2020-01-08 Thread GitBox
singhbaljit commented on issue #51: [GEOMETRY-71] Add test for RegionBSPTree2S barycenter URL: https://github.com/apache/commons-geometry/pull/51#issuecomment-572056894 Rebased it from the latest master, including the fix in https://github.com/apache/commons-geometry/pull/53.

[GitHub] [commons-geometry] asfgit closed pull request #53: GEOMETRY-86: Point2S.antipodal() Fix

2020-01-08 Thread GitBox
asfgit closed pull request #53: GEOMETRY-86: Point2S.antipodal() Fix URL: https://github.com/apache/commons-geometry/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (VFS-752) AbstractFileProvider close should close all fileSystems before clearing the cache

2020-01-08 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VFS-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010651#comment-17010651 ] Gary D. Gregory commented on VFS-752: - [~harald.k...@gmail.com] Feel free to provide a PR on GitHub

[GitHub] [commons-geometry] asfgit merged pull request #52: GEOMETRY-81: Renaming ConvexSubPlane to Facet

2020-01-08 Thread GitBox
asfgit merged pull request #52: GEOMETRY-81: Renaming ConvexSubPlane to Facet URL: https://github.com/apache/commons-geometry/pull/52 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (VFS-752) AbstractFileProvider close should close all fileSystems before clearing the cache

2020-01-08 Thread Harald Kuhn (Jira)
[ https://issues.apache.org/jira/browse/VFS-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010563#comment-17010563 ] Harald Kuhn commented on VFS-752: - A possible fix would be to call closeFileSystem for every FileSystem in

[jira] [Created] (VFS-752) AbstractFileProvider close should close all fileSystems before clearing the cache

2020-01-08 Thread Harald Kuhn (Jira)
Harald Kuhn created VFS-752: --- Summary: AbstractFileProvider close should close all fileSystems before clearing the cache Key: VFS-752 URL: https://issues.apache.org/jira/browse/VFS-752 Project: Commons VFS

[jira] [Work logged] (LANG-1513) ObjectUtils: Get first non-null supplier value

2020-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1513?focusedWorklogId=368053=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368053 ] ASF GitHub Bot logged work on LANG-1513: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1513) ObjectUtils: Get first non-null supplier value

2020-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1513?focusedWorklogId=368054=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368054 ] ASF GitHub Bot logged work on LANG-1513: Author: ASF GitHub Bot

[GitHub] [commons-lang] bonii-xx closed pull request #484: LANG-1513 ObjectUtils: Get first non-null supplier value

2020-01-08 Thread GitBox
bonii-xx closed pull request #484: LANG-1513 ObjectUtils: Get first non-null supplier value URL: https://github.com/apache/commons-lang/pull/484 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (LANG-1513) ObjectUtils: Get first non-null supplier value

2020-01-08 Thread Bernhard Bonigl (Jira)
[ https://issues.apache.org/jira/browse/LANG-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010455#comment-17010455 ] Bernhard Bonigl commented on LANG-1513: --- Verified it, thanks! > ObjectUtils: Get first non-null

[jira] [Closed] (LANG-1513) ObjectUtils: Get first non-null supplier value

2020-01-08 Thread Bernhard Bonigl (Jira)
[ https://issues.apache.org/jira/browse/LANG-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernhard Bonigl closed LANG-1513. - > ObjectUtils: Get first non-null supplier value > -- > >

[GitHub] [commons-lang] bonii-xx commented on issue #484: LANG-1513 ObjectUtils: Get first non-null supplier value

2020-01-08 Thread GitBox
bonii-xx commented on issue #484: LANG-1513 ObjectUtils: Get first non-null supplier value URL: https://github.com/apache/commons-lang/pull/484#issuecomment-571938496 Merged with https://github.com/apache/commons-lang/commit/a606a0328ba4b3061c5bc810a31418fa4251ea16