[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=561318=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561318
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
arturobernalg edited a comment on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-791194290
Hi @aherbert
So, according with you the function should only work only in NumberUtils
libs. All the idea of have a commons lib, used by anyone for any
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=561317=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561317
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
arturobernalg edited a comment on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-791194290
Hi @aherbert
So, according with you the function should only work only in NumberUtils
libs. All the idea of have a commons lib, used by anyone for any
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=561316=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561316
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
coveralls edited a comment on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-789980845
[](https://coveralls.io/builds/37678592)
Coverage decreased (-0.002%) to 94.912% when
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=561307=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561307
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
coveralls edited a comment on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-789980845
[](https://coveralls.io/builds/37677908)
Coverage increased (+0.005%) to 94.919% when
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=561306=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561306
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
arturobernalg edited a comment on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-791194290
Hi @aherbert
So, basically the function only work in NumberUtils libs. All the idea of
have a commons lib it will broke. Or make the private function.
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=561305=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561305
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
arturobernalg commented on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-791194290
Hi @aherbert
This is an automated message from the Apache Git Service.
To respond to the message,
garydgregory merged pull request #79:
URL: https://github.com/apache/commons-beanutils/pull/79
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
garydgregory merged pull request #78:
URL: https://github.com/apache/commons-beanutils/pull/78
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
garydgregory merged pull request #77:
URL: https://github.com/apache/commons-beanutils/pull/77
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
garydgregory merged pull request #76:
URL: https://github.com/apache/commons-beanutils/pull/76
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
garydgregory closed pull request #80:
URL: https://github.com/apache/commons-beanutils/pull/80
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
garydgregory commented on pull request #80:
URL: https://github.com/apache/commons-beanutils/pull/80#issuecomment-791019813
Closing, -1 above, see discussion.
This is an automated message from the Apache Git Service.
To
@arturobernalg
If you are looking to help this component, may I suggest my email "[lang]
Failing test on Java 16-EA."
Gary
On Wed, Mar 3, 2021, 12:52 ASF GitHub Bot (Jira) wrote:
>
> [
>
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=561107=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561107
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
aherbert commented on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-790912955
The value `5D0` may be valid hex digits but what are you going to do with
that fact? If you want to create a number with it then nothing in NumberUtils
or the Java language
[
https://issues.apache.org/jira/browse/COLLECTIONS-785?focusedWorklogId=561094=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561094
]
ASF GitHub Bot logged work on COLLECTIONS-785:
--
Author: ASF
kinow closed pull request #217:
URL: https://github.com/apache/commons-collections/pull/217
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/COLLECTIONS-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita resolved COLLECTIONS-785.
Resolution: Fixed
> Add constant variable
> -
>
>
[
https://issues.apache.org/jira/browse/COLLECTIONS-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated COLLECTIONS-785:
---
Fix Version/s: 4.5
> Add constant variable
> -
>
>
[
https://issues.apache.org/jira/browse/COLLECTIONS-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated COLLECTIONS-785:
---
Affects Version/s: 4.4
> Add constant variable
> -
[
https://issues.apache.org/jira/browse/COLLECTIONS-785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno P. Kinoshita updated COLLECTIONS-785:
---
Assignee: Bruno P. Kinoshita
> Add constant variable
>
[
https://issues.apache.org/jira/browse/COLLECTIONS-785?focusedWorklogId=561083=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561083
]
ASF GitHub Bot logged work on COLLECTIONS-785:
--
Author: ASF
arturobernalg commented on pull request #217:
URL:
https://github.com/apache/commons-collections/pull/217#issuecomment-790868691
> That was quick! I couldn't even finish my coffee ☕ . Thanks @arturobernalg
, let me update the JIRA/changes.xml and merge it.
hahaha , take your time,
[
https://issues.apache.org/jira/browse/COLLECTIONS-785?focusedWorklogId=561081=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561081
]
ASF GitHub Bot logged work on COLLECTIONS-785:
--
Author: ASF
kinow commented on pull request #217:
URL:
https://github.com/apache/commons-collections/pull/217#issuecomment-790867789
That was quick! I couldn't even finish my coffee :coffee: . Thanks
@arturobernalg , let me update the JIRA/changes.xml and merge it.
arturobernalg commented on pull request #217:
URL:
https://github.com/apache/commons-collections/pull/217#issuecomment-790862656
Hi @kinow
Jira created COLLECTIONS-785
This is an automated message from the Apache
Arturo Bernal created COLLECTIONS-785:
-
Summary: Add constant variable
Key: COLLECTIONS-785
URL: https://issues.apache.org/jira/browse/COLLECTIONS-785
Project: Commons Collections
Issue
Arturo Bernal created COLLECTIONS-784:
-
Summary: Add constant variable
Key: COLLECTIONS-784
URL: https://issues.apache.org/jira/browse/COLLECTIONS-784
Project: Commons Collections
Issue
kinow commented on pull request #217:
URL:
https://github.com/apache/commons-collections/pull/217#issuecomment-790860511
> Hi @kinow
>
> should i change something?
Hi @arturobernalg sorry, I left it open to give time to others to review it,
but also because I was going to
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=561053=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561053
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
arturobernalg commented on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-790832106
> Regarding `0x1L` the NumberUtils.createNumber and NumberUtils.isCreatable
only supports the preferred type suffix on decimal numbers. You cannot specify
a preferred
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=561039=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561039
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
coveralls edited a comment on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-789980845
[](https://coveralls.io/builds/37661177)
Coverage decreased (-0.001%) to 94.913% when
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=561032=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561032
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
aherbert commented on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-790806626
Regarding `0x1L` the NumberUtils.createNumber and NumberUtils.isCreatable
only supports the preferred type suffix on decimal numbers. You cannot specify
a preferred `L` for
arturobernalg commented on pull request #217:
URL:
https://github.com/apache/commons-collections/pull/217#issuecomment-790800098
Hi @kinow
should i change something?
This is an automated message from the Apache Git
coveralls commented on pull request #78:
URL: https://github.com/apache/commons-codec/pull/78#issuecomment-790787679
[](https://coveralls.io/builds/37660050)
Coverage increased (+0.001%) to 94.51% when pulling
arturobernalg opened a new pull request #78:
URL: https://github.com/apache/commons-codec/pull/78
Create a method to validate if a CharSequence is empty ("") or null
Make public BinaryCodec.isEmpty in order to reuse and avoid duplicate
validations
garydgregory merged pull request #721:
URL: https://github.com/apache/commons-lang/pull/721
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
garydgregory merged pull request #722:
URL: https://github.com/apache/commons-lang/pull/722
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
garydgregory merged pull request #726:
URL: https://github.com/apache/commons-lang/pull/726
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/COMPRESS-565?focusedWorklogId=561008=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561008
]
ASF GitHub Bot logged work on COMPRESS-565:
---
Author: ASF GitHub Bot
bodewig commented on pull request #169:
URL: https://github.com/apache/commons-compress/pull/169#issuecomment-790729399
I'd say it depends on which parts of Compress you use. If you are only using
code that hasn't changed or has only seen bugfixes, you should be pretty safe.
Usually we do
[
https://issues.apache.org/jira/browse/LANG-1645?focusedWorklogId=561000=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-561000
]
ASF GitHub Bot logged work on LANG-1645:
Author: ASF GitHub Bot
coveralls commented on pull request #728:
URL: https://github.com/apache/commons-lang/pull/728#issuecomment-790699472
[](https://coveralls.io/builds/37656121)
Coverage increased (+0.002%) to 94.916% when pulling
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560995=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560995
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
coveralls edited a comment on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-789980845
[](https://coveralls.io/builds/37655940)
Coverage increased (+0.005%) to 94.919% when
[
https://issues.apache.org/jira/browse/LANG-1645?focusedWorklogId=560991=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560991
]
ASF GitHub Bot logged work on LANG-1645:
Author: ASF GitHub Bot
aherbert opened a new pull request #728:
URL: https://github.com/apache/commons-lang/pull/728
Address the issue that NumberUtils.isCreatable("+0xF") is true but
NumberUtils.createNumber("+0xF") fails.
Also added support for the optional + prefix in NumberUtils.createBigInteger.
[
https://issues.apache.org/jira/browse/COMPRESS-565?focusedWorklogId=560988=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560988
]
ASF GitHub Bot logged work on COMPRESS-565:
---
Author: ASF GitHub Bot
missingdays commented on pull request #169:
URL: https://github.com/apache/commons-compress/pull/169#issuecomment-790681610
> If you want to release the software on your own, and especially if you
plan on pushing it out to the world through Maven Central or elsewhere, you
must change the
Alex Herbert created LANG-1645:
--
Summary: NumberUtils.createNumber/createBigInteger fails on
hexidecimal integers prefixed with +
Key: LANG-1645
URL: https://issues.apache.org/jira/browse/LANG-1645
[
https://issues.apache.org/jira/browse/COMPRESS-565?focusedWorklogId=560987=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560987
]
ASF GitHub Bot logged work on COMPRESS-565:
---
Author: ASF GitHub Bot
garydgregory commented on pull request #169:
URL: https://github.com/apache/commons-compress/pull/169#issuecomment-790678150
> > I'm sorry but the master branch isn't quite ready for a new release
>
> Ok, but if I build the jar from this branch, is this ok to use in release?
[
https://issues.apache.org/jira/browse/COMPRESS-565?focusedWorklogId=560986=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560986
]
ASF GitHub Bot logged work on COMPRESS-565:
---
Author: ASF GitHub Bot
missingdays commented on pull request #169:
URL: https://github.com/apache/commons-compress/pull/169#issuecomment-790675280
> I'm sorry but the master branch isn't quite ready for a new release
Ok, but if I build the jar from this branch, is this ok to use in release?
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560985=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560985
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560984=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560984
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
arturobernalg commented on a change in pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#discussion_r587531376
##
File path: src/main/java/org/apache/commons/lang3/math/NumberUtils.java
##
@@ -1715,6 +1715,50 @@ public static boolean isCreatable(final
arturobernalg commented on a change in pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#discussion_r587531376
##
File path: src/main/java/org/apache/commons/lang3/math/NumberUtils.java
##
@@ -1715,6 +1715,50 @@ public static boolean isCreatable(final
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560983=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560983
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
arturobernalg commented on a change in pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#discussion_r587531376
##
File path: src/main/java/org/apache/commons/lang3/math/NumberUtils.java
##
@@ -1715,6 +1715,50 @@ public static boolean isCreatable(final
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560980=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560980
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
arturobernalg commented on a change in pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#discussion_r587306048
##
File path: src/main/java/org/apache/commons/lang3/math/NumberUtils.java
##
@@ -1715,6 +1715,50 @@ public static boolean isCreatable(final
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560915=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560915
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
coveralls edited a comment on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-789980845
[](https://coveralls.io/builds/37648699)
Coverage increased (+0.006%) to 94.921% when
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560899=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560899
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
arturobernalg commented on a change in pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#discussion_r587306048
##
File path: src/main/java/org/apache/commons/lang3/math/NumberUtils.java
##
@@ -1715,6 +1715,50 @@ public static boolean isCreatable(final
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560876=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560876
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
coveralls edited a comment on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-789980845
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560869=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560869
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
coveralls edited a comment on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-789980845
[](https://coveralls.io/builds/37644604)
Coverage increased (+0.005%) to 94.919% when
78 matches
Mail list logo
