[jira] [Commented] (IO-487) ValidatingObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018147#comment-15018147 ] Adrian Crum commented on IO-487: Or create static ClassNameMatcher members for common class categories. The

[jira] [Commented] (IO-487) ValidatingObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013889#comment-15013889 ] Adrian Crum commented on IO-487: Without the class name, the exception is not useful to the developer. What

[jira] [Updated] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated IO-487: --- Attachment: IO-487.patch Updated patch with Niall's changes. The biggest problem I see with this issue is we

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005557#comment-15005557 ] Adrian Crum commented on IO-487: Niall - That is what the IntersectionClassAcceptor is used for. >

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005493#comment-15005493 ] Adrian Crum commented on IO-487: I agree Include/Exclude sounds better. I will spend some time building out

[jira] [Updated] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated IO-487: --- Attachment: IO-487.patch Latest patch with the new class names. I'm still working on the unit tests. I can't get

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005590#comment-15005590 ] Adrian Crum commented on IO-487: Agreed, but I think UnsupportedOperationException describes things better.

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005668#comment-15005668 ] Adrian Crum commented on IO-487: That sounds great! I will make those changes and wrap this up tomorrow. >

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004571#comment-15004571 ] Adrian Crum commented on IO-487: Gary - right now I think we are trying to settle on an API. If there is

[jira] [Updated] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated IO-487: --- Attachment: IO-487.patch Improved patch attached. Added missing @Overrides, added missing JavaDocs, added more

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004415#comment-15004415 ] Adrian Crum commented on IO-487: Some suggestions: 1. Use UnsupportedOperationException instead of custom

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004453#comment-15004453 ] Adrian Crum commented on IO-487: If you don't mind, I would like to make a few improvements to your patch. >

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004657#comment-15004657 ] Adrian Crum commented on IO-487: Agreed. > SafeObjectInputStream contribution - restrict which classes can be

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15004788#comment-15004788 ] Adrian Crum commented on IO-487: I just noticed my patch utility is creating duplicates within the patch. Let

[jira] [Updated] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated IO-487: --- Attachment: IO-487.patch Updated patch that includes the suggestions made so far. I think the latest API is

[jira] [Commented] (POOL-306) BaseGenericObjectPool IdentityWrapper equals violates Java spec

[ https://issues.apache.org/jira/browse/POOL-306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14974321#comment-14974321 ] Adrian Crum commented on POOL-306: -- That sounds like a case of premature optimization. >

[jira] [Updated] (VALIDATOR-375) UrlValidator fails on IPv6 URL

[ https://issues.apache.org/jira/browse/VALIDATOR-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated VALIDATOR-375: -- Attachment: UrlValidatorTest.java.patch Unit test patch that demonstrates the problem. >

[jira] [Commented] (VALIDATOR-375) UrlValidator fails on IPv6 URL

[ https://issues.apache.org/jira/browse/VALIDATOR-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908627#comment-14908627 ] Adrian Crum commented on VALIDATOR-375: --- Btw, if you remove the square brackets, the URL will

[jira] [Updated] (VALIDATOR-375) UrlValidator fails on IPv6 URL

[ https://issues.apache.org/jira/browse/VALIDATOR-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated VALIDATOR-375: -- Attachment: (was: UrlValidatorTest.java.patch) > UrlValidator fails on IPv6 URL >

[jira] [Updated] (VALIDATOR-375) UrlValidator fails on IPv6 URL

[ https://issues.apache.org/jira/browse/VALIDATOR-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated VALIDATOR-375: -- Attachment: UrlValidatorTest.java.patch Improved patch with example taken from RFC. >

[jira] [Commented] (VALIDATOR-375) UrlValidator fails on IPv6 URL

[ https://issues.apache.org/jira/browse/VALIDATOR-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908672#comment-14908672 ] Adrian Crum commented on VALIDATOR-375: --- The IPv6 validator works correctly. The problem is with

[jira] [Commented] (VALIDATOR-375) UrlValidator fails on IPv6 URL

[ https://issues.apache.org/jira/browse/VALIDATOR-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908620#comment-14908620 ] Adrian Crum commented on VALIDATOR-375: --- This line is generating an empty host name string when

[jira] [Comment Edited] (VALIDATOR-375) UrlValidator fails on IPv6 URL

[ https://issues.apache.org/jira/browse/VALIDATOR-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908620#comment-14908620 ] Adrian Crum edited comment on VALIDATOR-375 at 9/25/15 8:38 PM: This

[jira] [Commented] (COLLECTIONS-577) PatriciaTrie bugs when only a few bits change

[ https://issues.apache.org/jira/browse/COLLECTIONS-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908813#comment-14908813 ] Adrian Crum commented on COLLECTIONS-577: - That would be helpful, thanks. I tried doing that

[jira] [Commented] (COLLECTIONS-577) PatriciaTrie bugs when only a few bits change

[ https://issues.apache.org/jira/browse/COLLECTIONS-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908800#comment-14908800 ] Adrian Crum commented on COLLECTIONS-577: - (Copied from original description) Take the

[jira] [Issue Comment Deleted] (COLLECTIONS-577) PatriciaTrie bugs when only a few bits change

[ https://issues.apache.org/jira/browse/COLLECTIONS-577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated COLLECTIONS-577: Comment: was deleted (was: (Copied from original description) Take the following code

[jira] [Commented] (COLLECTIONS-577) PatriciaTrie bugs when only a few bits change

[ https://issues.apache.org/jira/browse/COLLECTIONS-577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14908803#comment-14908803 ] Adrian Crum commented on COLLECTIONS-577: - Please don't put pages of text in the issue

[jira] [Commented] (JEXL-177) Unified expressions to be used in String literals in Jexl scripts

[ https://issues.apache.org/jira/browse/JEXL-177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14709484#comment-14709484 ] Adrian Crum commented on JEXL-177: -- Actually, in Freemarker your expression would look like

[jira] [Commented] (DBCP-438) Nested connections in a transaction (local) throws null pointer

[ https://issues.apache.org/jira/browse/DBCP-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14521304#comment-14521304 ] Adrian Crum commented on DBCP-438: -- We are having a similar problem in OFBiz:

[jira] [Commented] (DBCP-432) BasicDataSource createDataSource can return partially initialized DataSource

[ https://issues.apache.org/jira/browse/DBCP-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14299968#comment-14299968 ] Adrian Crum commented on DBCP-432: -- Why not use AtomicReference? BasicDataSource

[jira] [Updated] (DBCP-432) BasicDataSource createDataSource can return partially initialized DataSource

[ https://issues.apache.org/jira/browse/DBCP-432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated DBCP-432: - Attachment: DBCP-432-AtomicReference.patch I'm not a DBCP expert, but maybe the attached patch will be of

[jira] [Commented] (SANDBOX-487) Human name parser

[ https://issues.apache.org/jira/browse/SANDBOX-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264070#comment-14264070 ] Adrian Crum commented on SANDBOX-487: - Keep in mind different cultures construct

[jira] [Commented] (VALIDATOR-341) Make TLD list configurable

[ https://issues.apache.org/jira/browse/VALIDATOR-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14262264#comment-14262264 ] Adrian Crum commented on VALIDATOR-341: --- I agree, an external file would be best.

[jira] [Commented] (VALIDATOR-341) Make TLD list configurable

[ https://issues.apache.org/jira/browse/VALIDATOR-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14261556#comment-14261556 ] Adrian Crum commented on VALIDATOR-341: --- I suggest we include in the library the

[jira] [Commented] (VALIDATOR-341) Make TLD list configurable

[ https://issues.apache.org/jira/browse/VALIDATOR-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14261631#comment-14261631 ] Adrian Crum commented on VALIDATOR-341: --- I would imagine the information is in

[jira] [Commented] (VALIDATOR-341) Make TLD list configurable

[ https://issues.apache.org/jira/browse/VALIDATOR-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14261659#comment-14261659 ] Adrian Crum commented on VALIDATOR-341: --- Maybe I wasn't clear. 1. There is a

[jira] [Commented] (VALIDATOR-307) isValid checks if the given address is only IPV4 address and not IPV6

[ https://issues.apache.org/jira/browse/VALIDATOR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259773#comment-14259773 ] Adrian Crum commented on VALIDATOR-307: --- Fixed in rev 1648274. isValid checks

[jira] [Commented] (CSV-131) Save positions of records to enable random access

[ https://issues.apache.org/jira/browse/CSV-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188076#comment-14188076 ] Adrian Crum commented on CSV-131: - It seems to me this could be made a bit more elegant if

[jira] [Commented] (LANG-796) DateUtils.addDays does not work properly with daylight saving time (DST)

[ https://issues.apache.org/jira/browse/LANG-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14150489#comment-14150489 ] Adrian Crum commented on LANG-796: -- I repeat: The current behavior is correct. The result

[jira] [Commented] (POOL-271) Make standard use of NullPoinerException instead of IllegalArgumentException

[ https://issues.apache.org/jira/browse/POOL-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14106068#comment-14106068 ] Adrian Crum commented on POOL-271: -- Here's the link:

[jira] [Commented] (VALIDATOR-340) Add new TLDs

[ https://issues.apache.org/jira/browse/VALIDATOR-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14102351#comment-14102351 ] Adrian Crum commented on VALIDATOR-340: --- A suggestion I made in one of the (many)

[jira] [Commented] (MATH-1098) Add annotations to mark certain characteristics of classes

[ https://issues.apache.org/jira/browse/MATH-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899216#comment-13899216 ] Adrian Crum commented on MATH-1098: --- I recommend using @Retention(RetentionPolicy.SOURCE)

[jira] [Updated] (CSV-104) Split CSVRecord with a subclass for mapping ops.

[ https://issues.apache.org/jira/browse/CSV-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated CSV-104: Attachment: CSV-104.patch I attached an improved Map implementation. The patch also exposes the toList()

[jira] [Updated] (CSV-104) Split CSVRecord with a subclass for mapping ops.

[ https://issues.apache.org/jira/browse/CSV-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated CSV-104: Attachment: CSV-104.patch Simplified version of my previous patch. Split CSVRecord with a subclass for

[jira] [Updated] (CSV-104) Split CSVRecord with a subclass for mapping ops.

[ https://issues.apache.org/jira/browse/CSV-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated CSV-104: Attachment: (was: CSV-104.patch) Split CSVRecord with a subclass for mapping ops.

[jira] [Commented] (SCXML-186) Groovy expression evaluator

[ https://issues.apache.org/jira/browse/SCXML-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867761#comment-13867761 ] Adrian Crum commented on SCXML-186: --- We solved the XML logical expression problem in

[jira] [Commented] (SCXML-186) Groovy expression evaluator

[ https://issues.apache.org/jira/browse/SCXML-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13862094#comment-13862094 ] Adrian Crum commented on SCXML-186: --- Another option is UEL. Take a look at JUEL. One

[jira] [Commented] (COMMONSSITE-76) Static Source Code security scanning of multiple Commons components

[ https://issues.apache.org/jira/browse/COMMONSSITE-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852847#comment-13852847 ] Adrian Crum commented on COMMONSSITE-76: http://www.apache.org/security/

[jira] [Commented] (LANG-935) Possible performance improvement on string escape functions

[ https://issues.apache.org/jira/browse/LANG-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848596#comment-13848596 ] Adrian Crum commented on LANG-935: -- The LGPL license is incompatible with the ASL 2

[jira] [Comment Edited] (LANG-935) Possible performance improvement on string escape functions

[ https://issues.apache.org/jira/browse/LANG-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848596#comment-13848596 ] Adrian Crum edited comment on LANG-935 at 12/15/13 12:53 PM: -

[jira] [Commented] (LANG-781) Null-Check to variable Object parameters - ObjectUtils.isAnyNull

[ https://issues.apache.org/jira/browse/LANG-781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799393#comment-13799393 ] Adrian Crum commented on LANG-781: -- A varargs method will unintentionally check to see if

[jira] [Commented] (VALIDATOR-324) Validation on API docs example, nobody@noplace.somedog, returns false

[ https://issues.apache.org/jira/browse/VALIDATOR-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13795779#comment-13795779 ] Adrian Crum commented on VALIDATOR-324: --- Unfortunately, the email validator

[jira] [Closed] (SANDBOX-461) FloatToString

[ https://issues.apache.org/jira/browse/SANDBOX-461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed SANDBOX-461. --- Resolution: Fixed Fixed in revision 1530794. If you want to change converter behavior, then you

[jira] [Comment Edited] (VALIDATOR-307) isValid checks if the given address is only IPV4 address and not IPV6

[ https://issues.apache.org/jira/browse/VALIDATOR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13785221#comment-13785221 ] Adrian Crum edited comment on VALIDATOR-307 at 10/3/13 2:10 PM:

[jira] [Updated] (VALIDATOR-307) isValid checks if the given address is only IPV4 address and not IPV6

[ https://issues.apache.org/jira/browse/VALIDATOR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated VALIDATOR-307: -- Attachment: VALIDATOR-307.patch Attached patch add IPv6 validation. No unit tests.

[jira] [Commented] (POOL-236) Replace JMX notifications with an event listener

[ https://issues.apache.org/jira/browse/POOL-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13722564#comment-13722564 ] Adrian Crum commented on POOL-236: -- Why are exceptions swallowed? Replace

[jira] [Commented] (LANG-843) Providing new class BigDecimalUtils

[ https://issues.apache.org/jira/browse/LANG-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13594858#comment-13594858 ] Adrian Crum commented on LANG-843: -- I don't understand the point of this. The BigDecimal

[jira] [Commented] (COLLECTIONS-366) A light-weighted list of integers

[ https://issues.apache.org/jira/browse/COLLECTIONS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591686#comment-13591686 ] Adrian Crum commented on COLLECTIONS-366: - Commons has a Range class too.

[jira] [Commented] (COLLECTIONS-366) A light-weighted list of integers

[ https://issues.apache.org/jira/browse/COLLECTIONS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591806#comment-13591806 ] Adrian Crum commented on COLLECTIONS-366: - I don't see its use. What is the

[jira] [Commented] (COLLECTIONS-366) A light-weighted list of integers

[ https://issues.apache.org/jira/browse/COLLECTIONS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591840#comment-13591840 ] Adrian Crum commented on COLLECTIONS-366: - Someone wanting to iterate over a

[jira] [Commented] (OGNL-24) Support visitor pattern on AST

[ https://issues.apache.org/jira/browse/OGNL-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114482#comment-13114482 ] Adrian Crum commented on OGNL-24: - Agreed - the extra parameter would be needed for flyweight

[jira] [Commented] (OGNL-24) Support visitor pattern on AST

[ https://issues.apache.org/jira/browse/OGNL-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114461#comment-13114461 ] Adrian Crum commented on OGNL-24: - If the object doing the visiting isn't going to do

[jira] [Commented] (OGNL-24) Support visitor pattern on AST

[ https://issues.apache.org/jira/browse/OGNL-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13114462#comment-13114462 ] Adrian Crum commented on OGNL-24: - Also, there is no need to include the public keyword in

[jira] [Commented] (OGNL-20) Performance - Replace synchronized blocks with ReentrantReadWriteLock

[ https://issues.apache.org/jira/browse/OGNL-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13109372#comment-13109372 ] Adrian Crum commented on OGNL-20: - Daniel, Keep in mind that somewhere down the road you

[jira] [Commented] (OGNL-20) Performance - Replace synchronized blocks with ReentrantReadWriteLock

[ https://issues.apache.org/jira/browse/OGNL-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107962#comment-13107962 ] Adrian Crum commented on OGNL-20: - Two of the approaches in the patch will have concurrency

[jira] [Commented] (OGNL-20) Performance - Replace synchronized blocks with ReentrantReadWriteLock

[ https://issues.apache.org/jira/browse/OGNL-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108027#comment-13108027 ] Adrian Crum commented on OGNL-20: - Daniel: It appears that you are trying to implement a

[jira] [Commented] (OGNL-20) Performance - Replace synchronized blocks with ReentrantReadWriteLock

[ https://issues.apache.org/jira/browse/OGNL-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108134#comment-13108134 ] Adrian Crum commented on OGNL-20: - Daniel: The DCL design pattern does not enforce a

[jira] [Commented] (OGNL-20) Performance - Replace synchronized blocks with ReentrantReadWriteLock

[ https://issues.apache.org/jira/browse/OGNL-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13108221#comment-13108221 ] Adrian Crum commented on OGNL-20: - That pattern (DCL) should not be used:

[jira] [Commented] (OGNL-20) Performance - Replace synchronized blocks with ReentrantReadWriteLock

[ https://issues.apache.org/jira/browse/OGNL-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13097868#comment-13097868 ] Adrian Crum commented on OGNL-20: - I highly recommend reading Java Concurrency In Practice

[jira] Created: (LANG-620) Convert Range To An Interface

Convert Range To An Interface - Key: LANG-620 URL: https://issues.apache.org/jira/browse/LANG-620 Project: Commons Lang Issue Type: Improvement Components: lang.* Affects Versions: 3.0

[jira] Commented: (LANG-618) Add an Assert class to simplify programming.

[ https://issues.apache.org/jira/browse/LANG-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12857304#action_12857304 ] Adrian Crum commented on LANG-618: -- A wrapper won't work. Let's say the bar argument is

[jira] Commented: (LANG-618) Add an Assert class to simplify programming.

[ https://issues.apache.org/jira/browse/LANG-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12857317#action_12857317 ] Adrian Crum commented on LANG-618: -- If I use the wrapper method, then I end up with this:

[jira] Updated: (LANG-616) New Value Objects For Date/Time

[ https://issues.apache.org/jira/browse/LANG-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated LANG-616: - Attachment: (was: lang.patch) New Value Objects For Date/Time ---

[jira] Updated: (LANG-616) New Value Objects For Date/Time

[ https://issues.apache.org/jira/browse/LANG-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated LANG-616: - Attachment: LANG-616.patch New Value Objects For Date/Time ---

[jira] Updated: (LANG-616) New Value Objects For Date/Time

[ https://issues.apache.org/jira/browse/LANG-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated LANG-616: - Attachment: LANG-616.patch New Value Objects For Date/Time ---

[jira] Updated: (LANG-616) New Value Objects For Date/Time

[ https://issues.apache.org/jira/browse/LANG-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated LANG-616: - Attachment: (was: LANG-616.patch) New Value Objects For Date/Time ---

[jira] Commented: (LANG-616) New Value Objects For Date/Time

[ https://issues.apache.org/jira/browse/LANG-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12857559#action_12857559 ] Adrian Crum commented on LANG-616: -- Very nice - thanks for the link! New Value Objects

[jira] Created: (LANG-618) Add an Assert class to simplify programming.

Add an Assert class to simplify programming. Key: LANG-618 URL: https://issues.apache.org/jira/browse/LANG-618 Project: Commons Lang Issue Type: New Feature Components: lang.*

[jira] Updated: (LANG-618) Add an Assert class to simplify programming.

[ https://issues.apache.org/jira/browse/LANG-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated LANG-618: - Attachment: LANG-618.patch Add an Assert class to simplify programming.

[jira] Closed: (LANG-618) Add an Assert class to simplify programming.

[ https://issues.apache.org/jira/browse/LANG-618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum closed LANG-618. Resolution: Fixed Thanks! I didn't notice that. Add an Assert class to simplify programming.

[jira] Commented: (LANG-618) Add an Assert class to simplify programming.

[ https://issues.apache.org/jira/browse/LANG-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12857111#action_12857111 ] Adrian Crum commented on LANG-618: -- I prefer my syntax though: Assert.argumentsNotNull(foo,

[jira] Commented: (LANG-370) Document thread safety of classes

[ https://issues.apache.org/jira/browse/LANG-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12856414#action_12856414 ] Adrian Crum commented on LANG-370: -- Why not create our own thread safety Annotation

[jira] Created: (LANG-616) New Value Objects For Date/Time

New Value Objects For Date/Time --- Key: LANG-616 URL: https://issues.apache.org/jira/browse/LANG-616 Project: Commons Lang Issue Type: New Feature Components: lang.time.* Affects Versions: 3.1

[jira] Updated: (LANG-616) New Value Objects For Date/Time

[ https://issues.apache.org/jira/browse/LANG-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated LANG-616: - Attachment: lang.patch The attached patch contains some basic code to give you the idea. If there is any