[jira] [Updated] (LANG-1012) Add Validate.isFalse, Validate.largerThan and Validate.smallerThan

2014-08-04 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-1012: --- Fix Version/s: (was: Patch Needed) Discussion Discussed at

[jira] [Commented] (LANG-1030) StringUtils.same opposite method to StringUtils.differ

2014-07-24 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072903#comment-14072903 ] Duncan Jones commented on LANG-1030: I'm not convinced this is a method we should be

[jira] [Commented] (LANG-1030) StringUtils.same opposite method to StringUtils.differ

2014-07-24 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072906#comment-14072906 ] Duncan Jones commented on LANG-1030: [~britter]: Should we use the review patch label

[jira] [Updated] (LANG-1012) Add Validate.isFalse, Validate.largerThan and Validate.smallerThan

2014-05-13 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-1012: --- Fix Version/s: Patch Needed Add Validate.isFalse, Validate.largerThan and Validate.smallerThan

[jira] [Created] (LANG-1012) Add Validate.isFalse, Validate.largerThan and Validate.smallerThan

2014-05-13 Thread Duncan Jones (JIRA)
Duncan Jones created LANG-1012: -- Summary: Add Validate.isFalse, Validate.largerThan and Validate.smallerThan Key: LANG-1012 URL: https://issues.apache.org/jira/browse/LANG-1012 Project: Commons Lang

[jira] [Commented] (LANG-997) NumberUtil#isNumber() returns false for 012345678 but not for 12345678

2014-05-06 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13991149#comment-13991149 ] Duncan Jones commented on LANG-997: --- [~juanpablo]: have you considered {{isDigits()}}?

[jira] [Resolved] (LANG-731) Better Javadoc for BitField class

2014-05-05 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones resolved LANG-731. --- Resolution: Fixed Fix Version/s: (was: Patch Needed) 3.4

[jira] [Updated] (LANG-1006) Add wrap (with String or char) to StringUtils. Fixing NumberUtils comments. Adding methods to NumberUtils

2014-05-05 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-1006: --- Fix Version/s: Review Patch Labels: github (was: ) Add wrap (with String or char) to

[jira] [Commented] (LANG-1006) Add wrap (with String or char) to StringUtils. Fixing NumberUtils comments. Adding methods to NumberUtils

2014-05-05 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989323#comment-13989323 ] Duncan Jones commented on LANG-1006: Can you split that pull request into three? It

[jira] [Commented] (LANG-1008) Adding the maxVA and minVA methods to NumberUtils and test methods

2014-05-05 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989966#comment-13989966 ] Duncan Jones commented on LANG-1008: This was a deliberate policy in the past, check

[jira] [Updated] (LANG-341) Add number to byte array methods

2014-05-03 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-341: -- Assignee: (was: Duncan Jones) Add number to byte array methods

[jira] [Commented] (LANG-660) Add methods to insert arrays into arrays at an index

2014-05-03 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13988751#comment-13988751 ] Duncan Jones commented on LANG-660: --- Just to be clear, we plan to deprecate one method and

[jira] [Closed] (LANG-957) WordUtils.wrap(String, int) doesn't behave according to JavaDoc

2014-05-03 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones closed LANG-957. - Resolution: Duplicate Fix Version/s: (was: Patch Needed) A later bug was opened for this issue

[jira] [Resolved] (LANG-988) Where's the user guide?

2014-04-21 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones resolved LANG-988. --- Resolution: Not a Problem Fix Version/s: (was: Discussion) I think this issue can be closed

[jira] [Updated] (LANG-996) FastDateFormat is case sensitive

2014-04-16 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-996: -- Description: It seems that {{FastDateFormat}} is case sensitive. But it claims to be mostly compatible

[jira] [Commented] (LANG-990) Avoid String allocation in StrBuilder.append(CharSequence)

2014-03-30 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954637#comment-13954637 ] Duncan Jones commented on LANG-990: --- I wanted to benchmark the patch before committing but

[jira] [Updated] (LANG-992) NumberUtils#isNumber() returns false for 0.0, 0.4790, et al

2014-03-27 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-992: -- Description: After upgraded from 3.1 to 3.3.1 it seems that {{isNumber(String str)}} returns false

[jira] [Commented] (LANG-992) NumberUtils#isNumber() returns false for 0.0, 0.4790, et al

2014-03-27 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13948961#comment-13948961 ] Duncan Jones commented on LANG-992: --- [~niallp]: your patch looks good. I see no reason to

[jira] [Created] (LANG-991) Release notes cannot display special characters

2014-03-26 Thread Duncan Jones (JIRA)
Duncan Jones created LANG-991: - Summary: Release notes cannot display special characters Key: LANG-991 URL: https://issues.apache.org/jira/browse/LANG-991 Project: Commons Lang Issue Type: Bug

[jira] [Updated] (LANG-991) Release notes cannot display special characters

2014-03-26 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-991: -- Fix Version/s: Patch Needed Release notes cannot display special characters

[jira] [Updated] (LANG-990) Avoid String allocation in StrBuilder.append(CharSequence)

2014-03-21 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-990: -- Fix Version/s: Patch Needed Avoid String allocation in StrBuilder.append(CharSequence)

[jira] [Commented] (LANG-990) Avoid String allocation in StrBuilder.append(CharSequence)

2014-03-21 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13943152#comment-13943152 ] Duncan Jones commented on LANG-990: --- Patches welcome. It would be interesting to benchmark

[jira] [Updated] (LANG-947) WordUtils delimiters should be strings, not char varargs

2014-03-21 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-947: -- Component/s: (was: General) lang.text.* WordUtils delimiters should be strings,

[jira] [Commented] (LANG-988) Where's the user guide?

2014-03-14 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13934999#comment-13934999 ] Duncan Jones commented on LANG-988: --- Yes, the user guide is now contained within the

[jira] [Commented] (LANG-987) DateUtils.getFragmentInDays(Date, Calendar.MONTH) returns wrong days

2014-03-13 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13932977#comment-13932977 ] Duncan Jones commented on LANG-987: --- This is definitely a bug and it was introduced during

[jira] [Updated] (LANG-987) DateUtils.getFragmentInDays(Date, Calendar.MONTH) returns wrong days

2014-03-13 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-987: -- Fix Version/s: 3.x Patch Needed DateUtils.getFragmentInDays(Date, Calendar.MONTH)

[jira] [Commented] (LANG-987) DateUtils.getFragmentInDays(Date, Calendar.MONTH) returns wrong days

2014-03-13 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13933613#comment-13933613 ] Duncan Jones commented on LANG-987: --- Patches are always welcome :-)

[jira] [Updated] (LANG-987) DateUtils.getFragmentInDays(Date, Calendar.MONTH) returns wrong days

2014-03-13 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-987: -- Fix Version/s: (was: 3.x) 3.4 DateUtils.getFragmentInDays(Date, Calendar.MONTH)

[jira] [Resolved] (LANG-987) DateUtils.getFragmentInDays(Date, Calendar.MONTH) returns wrong days

2014-03-13 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones resolved LANG-987. --- Resolution: Fixed Fix Version/s: (was: Patch Needed) Assignee: Duncan Jones Found

[jira] [Created] (IO-427) New TrailerInputStream class

2014-03-05 Thread Duncan Jones (JIRA)
Duncan Jones created IO-427: --- Summary: New TrailerInputStream class Key: IO-427 URL: https://issues.apache.org/jira/browse/IO-427 Project: Commons IO Issue Type: New Feature Components:

[jira] [Updated] (IO-427) New TrailerInputStream class

2014-03-05 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/IO-427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated IO-427: Attachment: TrailerInputStreamTest.java TrailerInputStream.java New TrailerInputStream class

[jira] [Commented] (LANG-901) endsWithAny is case sensitive - documented as case insensitive

2014-02-18 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13904549#comment-13904549 ] Duncan Jones commented on LANG-901: --- I would be in favour of an IAE as [~s...@apache.org]

[jira] [Updated] (LANG-341) Add number to byte array methods

2014-02-03 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-341: -- Component/s: (was: lang.math.*) Fix Version/s: (was: 3.3) Summary: Add number to

[jira] [Updated] (LANG-341) [NumberUtils] Please add number byte[] methods

2014-01-31 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-341: -- Fix Version/s: 3.3 [NumberUtils] Please add number byte[] methods

[jira] [Commented] (LANG-341) [NumberUtils] Please add number byte[] methods

2014-01-31 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887605#comment-13887605 ] Duncan Jones commented on LANG-341: --- Based on [this mail

[jira] [Resolved] (LANG-341) [NumberUtils] Please add number byte[] methods

2014-01-31 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones resolved LANG-341. --- Resolution: Fixed Fix Version/s: (was: Review Patch) URL: http://svn.apache.org/r1563259

[jira] [Reopened] (LANG-341) [NumberUtils] Please add number byte[] methods

2014-01-31 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones reopened LANG-341: --- Issue reopened - discussion to be had on ML over correct place for this functionality.

[jira] [Commented] (LANG-948) Exception while using ExtendedMessageFormat and escaping braces

2014-01-29 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13885667#comment-13885667 ] Duncan Jones commented on LANG-948: --- I think the problem lies with the

[jira] [Updated] (LANG-806) RandomStringUtils can enter infinite loop if chosen char does not meet letter/digit requirements

2014-01-28 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-806: -- Description: An infinite loop can result if the selection process never returns a char that passes the

[jira] [Updated] (LANG-701) StringUtils join with var args

2014-01-28 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-701: -- Description: {code:java} final String apple = apple; final String banana = banana; final String orange =

[jira] [Commented] (LANG-955) StringEscapeUtils.escapeXml doesn't remove invalid characters

2014-01-28 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884726#comment-13884726 ] Duncan Jones commented on LANG-955: --- Looking at the comments and source of {{escapeXml}},

[jira] [Commented] (LANG-417) New class ClassPathUtils with methods for turning FQN into resource path

2014-01-27 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882906#comment-13882906 ] Duncan Jones commented on LANG-417: --- To avoid raw types in post Java 1.5 code? New class

[jira] [Comment Edited] (LANG-417) New class ClassPathUtils with methods for turning FQN into resource path

2014-01-27 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882906#comment-13882906 ] Duncan Jones edited comment on LANG-417 at 1/27/14 3:54 PM: To

[jira] [Commented] (LANG-417) New class ClassPathUtils with methods for turning FQN into resource path

2014-01-27 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882892#comment-13882892 ] Duncan Jones commented on LANG-417: --- I would suggest we add a type parameter to the

[jira] [Commented] (LANG-341) [NumberUtils] Please add number byte[] methods

2014-01-26 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13882429#comment-13882429 ] Duncan Jones commented on LANG-341: --- The patch looks good, thank for submitting and

[jira] [Commented] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2014-01-24 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881511#comment-13881511 ] Duncan Jones commented on LANG-637: --- URL: http://svn.apache.org/r1561215 Log: LANG-637:

[jira] [Resolved] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2014-01-24 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones resolved LANG-637. --- Resolution: Fixed Fix Version/s: (was: Review Patch) There should be a DifferenceBuilder

[jira] [Commented] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2014-01-24 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13881526#comment-13881526 ] Duncan Jones commented on LANG-637: --- URL: http://svn.apache.org/r1561225 Log: Renamed

[jira] [Commented] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2014-01-17 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13874867#comment-13874867 ] Duncan Jones commented on LANG-637: --- I think {{Iterable}} is a good choice. There should

[jira] [Commented] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2013-12-29 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858293#comment-13858293 ] Duncan Jones commented on LANG-637: --- Hi Matt, if you are willing to make the change that

[jira] [Commented] (LANG-842) Lack of consistency in comparaison api

2013-10-16 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13796556#comment-13796556 ] Duncan Jones commented on LANG-842: --- I'm not convinced there is any inconsistency. Or at

[jira] [Commented] (LANG-874) appendSuper is broken if different ToStringStyle are used

2013-06-18 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13686942#comment-13686942 ] Duncan Jones commented on LANG-874: --- This appears to be by design. The

[jira] [Created] (LANG-900) New RandomUtils class

2013-06-15 Thread Duncan Jones (JIRA)
Duncan Jones created LANG-900: - Summary: New RandomUtils class Key: LANG-900 URL: https://issues.apache.org/jira/browse/LANG-900 Project: Commons Lang Issue Type: New Feature

[jira] [Updated] (LANG-900) New RandomUtils class

2013-06-15 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-900: -- Attachment: RandomUtilsTest.java RandomUtils.java New RandomUtils class

[jira] [Updated] (LANG-900) New RandomUtils class

2013-06-15 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-900: -- Attachment: (was: RandomUtils.java) New RandomUtils class -

[jira] [Updated] (LANG-900) New RandomUtils class

2013-06-15 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-900: -- Attachment: (was: RandomUtilsTest.java) New RandomUtils class -

[jira] [Updated] (LANG-900) New RandomUtils class

2013-06-15 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-900: -- Attachment: RandomUtilsTest.java RandomUtils.java New RandomUtils class

[jira] [Commented] (LANG-900) New RandomUtils class

2013-06-15 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13684236#comment-13684236 ] Duncan Jones commented on LANG-900: --- Might be a nice idea. I nearly put that in the first

[jira] [Commented] (LANG-872) EqualsBuilder methods append(Object[],Object[]) and append(Object,Object) treats array class dirrerently

2013-02-23 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585068#comment-13585068 ] Duncan Jones commented on LANG-872: --- {quote} So {{append(Object, Object)}} should be fixed

[jira] [Updated] (LANG-872) EqualsBuilder methods append(Object[],Object[]) and append(Object,Object) treats array class dirrerently

2013-02-22 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-872: -- Attachment: commons-lang3-LANG-872.patch Looks like a bug to me. Attached is a patch that incorporates

[jira] [Commented] (LANG-872) EqualsBuilder methods append(Object[],Object[]) and append(Object,Object) treats array class dirrerently

2013-02-22 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13584692#comment-13584692 ] Duncan Jones commented on LANG-872: --- Having said that... {{java.util.Arrays.deepEquals()}}

[jira] [Commented] (CLI-224) OptionBuilder only has static methods, yet many return an OptionBuilder instance

2013-02-16 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/CLI-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13580012#comment-13580012 ] Duncan Jones commented on CLI-224: -- {quote} What about a static factory method, as always

[jira] [Created] (CLI-231) Remove DoubleCheckedLocking from checkstyle configuration

2013-02-16 Thread Duncan Jones (JIRA)
Duncan Jones created CLI-231: Summary: Remove DoubleCheckedLocking from checkstyle configuration Key: CLI-231 URL: https://issues.apache.org/jira/browse/CLI-231 Project: Commons CLI Issue Type:

[jira] [Updated] (CLI-231) Remove DoubleCheckedLocking from checkstyle configuration

2013-02-16 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/CLI-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated CLI-231: - Attachment: cli-231.patch Patch file to remove check. Remove DoubleCheckedLocking from

[jira] [Commented] (LANG-864) Collection wrappers to for unmodifiable / nonnull-safe collections

2013-01-22 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559710#comment-13559710 ] Duncan Jones commented on LANG-864: --- I completely agree. There was talk recently on the

[jira] [Comment Edited] (LANG-757) StringEscapeUtils.unescapeHtml: handle HTML escapes without semicolon

2012-11-14 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491494#comment-13491494 ] Duncan Jones edited comment on LANG-757 at 11/14/12 4:14 PM: -

[jira] [Commented] (LANG-757) StringEscapeUtils.unescapeHtml: handle HTML escapes without semicolon

2012-11-14 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497200#comment-13497200 ] Duncan Jones commented on LANG-757: --- As a quick test, I confirmed that Firefox 16.0.2

[jira] [Updated] (LANG-757) StringEscapeUtils.unescapeHtml: handle HTML escapes without semicolon

2012-11-14 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-757: -- Attachment: (was: commons-lang3-LANG-757.patch) StringEscapeUtils.unescapeHtml: handle HTML

[jira] [Updated] (LANG-757) StringEscapeUtils.unescapeHtml: handle HTML escapes without semicolon

2012-11-14 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-757: -- Attachment: commons-lang3-LANG-757.patch New patch reverts public method to private and adds comment

[jira] [Commented] (LANG-757) StringEscapeUtils.unescapeHtml: handle HTML escapes without semicolon

2012-11-06 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491494#comment-13491494 ] Duncan Jones commented on LANG-757: --- It was intentional, but indeed should have been

[jira] [Commented] (LANG-842) Lack of consistency in comparaison api

2012-10-08 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13471433#comment-13471433 ] Duncan Jones commented on LANG-842: --- The {{equals}} methods must return {{false}}, [by

[jira] [Commented] (LANG-841) Add StringUtils API to call String.replaceAll in DOTALL a.k.a. single-line mode

2012-10-08 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13471435#comment-13471435 ] Duncan Jones commented on LANG-841: --- bq. I am still looking for better API names. How

[jira] [Commented] (LANG-841) Add StringUtils API to call String.replaceAll in DOTALL a.k.a. single-line mode

2012-10-08 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13471627#comment-13471627 ] Duncan Jones commented on LANG-841: --- {quote}So we already have: replace(String, String,

[jira] [Updated] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2012-09-30 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-637: -- Attachment: commons-lang3-LANG-637-complete.patch Now attached is

[jira] [Comment Edited] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2012-09-30 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466563#comment-13466563 ] Duncan Jones edited comment on LANG-637 at 10/1/12 7:35 AM: Now

[jira] [Updated] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2012-09-29 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-637: -- Attachment: (was: DifferenceBuilder.java) There should be a DifferenceBuilder with a

[jira] [Updated] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2012-09-29 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-637: -- Attachment: (was: DifferenceBuilderTest.java) There should be a DifferenceBuilder with a

[jira] [Updated] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2012-09-29 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-637: -- Attachment: (was: Differentiable.java) There should be a DifferenceBuilder with a

[jira] [Updated] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2012-09-29 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-637: -- Attachment: commons-lang3-LANG-637.patch DiffList.java DiffBuilder.java

[jira] [Commented] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2012-09-29 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13466266#comment-13466266 ] Duncan Jones commented on LANG-637: --- Note: a few Javadoc comments need tidying. Also, I'm

[jira] [Commented] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2012-09-24 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461634#comment-13461634 ] Duncan Jones commented on LANG-637: --- bq. I think it would be nice to have an actual

[jira] [Commented] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2012-09-24 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13462048#comment-13462048 ] Duncan Jones commented on LANG-637: --- After some consideration, I'm struggling to imagine

[jira] [Updated] (LANG-637) There should be a DifferenceBuilder with a ReflectionDifferenceBuilder implementation

2012-09-23 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-637: -- Attachment: DifferenceBuilderTest.java Differentiable.java

[jira] [Commented] (LANG-815) DurationFormatUtils.formatPeriod() miss-calculation

2012-09-22 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461101#comment-13461101 ] Duncan Jones commented on LANG-815: --- I don't believe this is a bug. Below is a test case

[jira] [Commented] (LANG-796) DateUtils.addDays does not work properly with daylight saving time (DST)

2012-09-22 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461108#comment-13461108 ] Duncan Jones commented on LANG-796: --- I agree with Nicola. A class that intends to work

[jira] [Commented] (LANG-799) DateUtils#parseDate uses default locale; add Locale support

2012-09-22 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461157#comment-13461157 ] Duncan Jones commented on LANG-799: --- That last commit now breaks the build, as my test

[jira] [Commented] (LANG-799) DateUtils#parseDate uses default locale; add Locale support

2012-09-22 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461160#comment-13461160 ] Duncan Jones commented on LANG-799: --- Also, we should now remove {{testParseBadLocale()}}

[jira] [Commented] (LANG-809) Encapsulate trival equal test into a method to avoid repeating over and over.....

2012-09-22 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461233#comment-13461233 ] Duncan Jones commented on LANG-809: --- Having given this some thought, I'm not sure there is

[jira] [Updated] (LANG-757) StringEscapeUtils.unescapeHtml: handle HTML escapes without semicolon

2012-09-22 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated LANG-757: -- Attachment: commons-lang3-LANG-757.patch Attached is a patch that adds overloaded unescapeHtml3 and

[jira] [Updated] (CLI-224) OptionBuilder only has static methods, yet many return an OptionBuilder instance

2012-09-21 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/CLI-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated CLI-224: - Attachment: (was: commons-cli-CLI-224.patch) OptionBuilder only has static methods, yet many

[jira] [Updated] (CLI-224) OptionBuilder only has static methods, yet many return an OptionBuilder instance

2012-09-21 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/CLI-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated CLI-224: - Attachment: commons-cli-CLI-224.patch Corrected patch (missed Apache licence statement in new unit test).

[jira] [Updated] (CLI-227) Convert to JUnit4 tests

2012-09-21 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/CLI-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated CLI-227: - Component/s: (was: CLI-2.x) CLI-1.x Convert to JUnit4 tests

[jira] [Updated] (CLI-224) OptionBuilder only has static methods, yet many return an OptionBuilder instance

2012-09-20 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/CLI-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated CLI-224: - Attachment: commons-cli-CLI-224.patch Attached is an alternative patch, based on my suggestion of a nested

[jira] [Comment Edited] (CLI-224) OptionBuilder only has static methods, yet many return an OptionBuilder instance

2012-09-20 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/CLI-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459929#comment-13459929 ] Duncan Jones edited comment on CLI-224 at 9/21/12 7:42 AM: ---

[jira] [Created] (CLI-227) Convert to JUnit4 tests

2012-09-19 Thread Duncan Jones (JIRA)
Duncan Jones created CLI-227: Summary: Convert to JUnit4 tests Key: CLI-227 URL: https://issues.apache.org/jira/browse/CLI-227 Project: Commons CLI Issue Type: Test Components: CLI-2.x

[jira] [Updated] (CLI-227) Convert to JUnit4 tests

2012-09-19 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/CLI-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duncan Jones updated CLI-227: - Attachment: commons-cli-CLI-227.patch Attached is a patch that converts all existing unit tests to 4.x

[jira] [Commented] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

2012-09-18 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13457626#comment-13457626 ] Duncan Jones commented on LANG-824: --- Well, I believe so. My patch was based on revision

[jira] [Commented] (LANG-824) Conversion of 3.x JUnit tests to 4.x.

2012-09-18 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/LANG-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458136#comment-13458136 ] Duncan Jones commented on LANG-824: --- I just reverted my changes and updated afresh: svn

[jira] [Commented] (CLI-224) OptionBuilder only has static methods, yet many return an OptionBuilder instance

2012-09-18 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/CLI-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458190#comment-13458190 ] Duncan Jones commented on CLI-224: -- How about embedding a Builder class within Option and

[jira] [Comment Edited] (CLI-224) OptionBuilder only has static methods, yet many return an OptionBuilder instance

2012-09-18 Thread Duncan Jones (JIRA)
[ https://issues.apache.org/jira/browse/CLI-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13458190#comment-13458190 ] Duncan Jones edited comment on CLI-224 at 9/19/12 8:25 AM: --- How

<    1   2   3   4   >