[GitHub] commons-lang pull request #113: LANG-1184: StringUtils#normalizeSpace no lon...

2016-09-18 Thread PascalSchumacher
Github user PascalSchumacher closed the pull request at: https://github.com/apache/commons-lang/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-lang issue #184: Correct replacing 160 in normalizeSpace

2016-09-18 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/184 Thanks for the information. I did not know that `normalizeSpace` replaces non-breaking spaces with normal whitespace. Both these test succeed: ```java

[GitHub] commons-lang issue #190: Lang 1134

2016-09-15 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/190 Merged. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection (unfinished)

2016-09-12 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/163 O.k. I will finish this in a few days. This can be merged into the next version. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...

2016-09-12 Thread PascalSchumacher
GitHub user PascalSchumacher reopened a pull request: https://github.com/apache/commons-lang/pull/163 LANG-1197: Prepare Java 9 detection (unfinished) Not complete: `JavaVersion` expects the `java.version` system property to return `1.x` but for java 9 it will return `9*`. Not sure

[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection (unfinished)

2016-09-12 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/163 For the next few days I will probably not have time to finish this and I do not want to hold up the release. Doesn't https://github.com/apache/commons-lang/pull/187/files pull request

[GitHub] commons-lang issue #163: LANG-1197: Prepare Java 9 detection (unfinished)

2016-09-11 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/163 @britter I closing this and let you handle the complete java 9 issue(s). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...

2016-09-11 Thread PascalSchumacher
Github user PascalSchumacher closed the pull request at: https://github.com/apache/commons-lang/pull/163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-lang pull request #187: LANG-1263 Add possibility to retrieve the cu...

2016-09-11 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/187#discussion_r78299605 --- Diff: src/test/java/org/apache/commons/lang3/JavaVersionTest.java --- @@ -72,4 +73,28 @@ public void testToString

[GitHub] commons-lang issue #184: Correct replacing 160 in normalizeSpace

2016-09-11 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/184 @phoenix384 The problem is that starting with 3.4 StringUtils#normalizeSpace no longer normalizes unicode non-breaking spaces. I reported this as a bug and argued for reverting

[GitHub] commons-lang pull request #183: LANG-1261: ArrayUtils#contains ArrayUtils#in...

2016-08-23 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/183 LANG-1261: ArrayUtils#contains ArrayUtils#indexOf should compare obje… …cts with different types You can merge this pull request into a Git repository by running: $ git pull

[GitHub] commons-lang issue #143: LANG-1230 Remove unnecessary synchronization

2016-08-21 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/143 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] commons-lang issue #101: random length strings within range

2016-08-21 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/101 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] commons-lang issue #155: LANG-1214 Handle "void" in ClassUtils.getClass()

2016-08-21 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/155 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] commons-lang issue #174: [LANG-1250] SerializationUtils::deserialize has unn...

2016-08-20 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/174 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] commons-lang issue #182: Add maven dependency for JMH framework.

2016-08-20 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/182 @C0rWin The OpenJDK 7 Build did not finish: https://travis-ci.org/apache/commons-lang/jobs/151969189 maybe that caused the change. Or there is a random element in the existing test

[GitHub] commons-lang issue #180: LANG-1251: SerializationUtils.ClassLoaderAwareObjec...

2016-07-31 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/180 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] commons-lang pull request #:

2016-07-31 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/1d1883f0e20215720eb583fd43eee088808c616b#commitcomment-18464298 @garydgregory It would be very nice if you could rebase your local repository (e.g. `pull --rebase upstream master

[GitHub] commons-lang issue #175: Removing test redundant for org.apache.commons.lang...

2016-07-31 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/175 Thanks for identifying the redundant tests. Dead code should be removed, so I deleted the tests. --- If your project is set up for it, you can reply to this email and have

[GitHub] commons-lang issue #181: Adding test cases for StringUtils.equals methods to...

2016-07-31 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/181 Hi RamAnvesh, thanks for the pull request. There are already a lot of test for `StringUtils#equals` here https://github.com/RamAnvesh/commons-lang/blob/master/src

[GitHub] commons-lang issue #166: Fix typo in documentation of Range#isEndedBy

2016-06-16 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/166 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] commons-lang issue #156: LANG-1018: Fix precision loss on NumberUtils.create...

2016-06-12 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/156 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] commons-lang issue #9: Lang 4 x

2016-06-12 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/9 I tried but failed to extract the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] commons-lang issue #93: fix StringUtils.ordinalIndexOf("aaaaaa", "aa", 2) ==...

2016-06-10 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/93 I guess this pull request can be closed, now that https://github.com/apache/commons-lang/commit/e5a3039f7a1e727fca40db7357a9191b6a7cf41d has been reverted with https://github.com

[GitHub] commons-lang issue #142: LANG-1229 Performance regression in HashCodeBuilder

2016-06-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/142 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] commons-lang issue #164: Fixing testTSVEmpty to use getTSVInstance instead o...

2016-06-07 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/164 Thanks for spotting and fixing this! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang issue #95: Implementations of the circuit breaker pattern relat...

2016-06-07 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/95 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] commons-lang issue #156: LANG-1018: Fix precision loss on NumberUtils.create...

2016-06-06 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/156 @NickManley Not sure if you checking jira, so I thought I let you know there is some feedback on your pull request there: https://issues.apache.org/jira/browse/LANG-1018

[GitHub] commons-lang issue #137: Adding to StringUtils truncate method and test case...

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/137 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] commons-lang issue #141: Lang 1195: Enhance MethodUtils to allow invocation ...

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/141 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] commons-lang pull request #163: LANG-1197: Prepare Java 9 detection (unfinis...

2016-06-05 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/163 LANG-1197: Prepare Java 9 detection (unfinished) Not complete: `JavaVersion` expects the `java.version` system property to return `1.x` but for java 9 it will return `9*`. Not sure

[GitHub] commons-lang pull request #148: LANG-1199: Incorrect implementation of Strin...

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher closed the pull request at: https://github.com/apache/commons-lang/pull/148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-lang issue #148: LANG-1199: Incorrect implementation of StringUtils#...

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/148 merged: https://github.com/apache/commons-lang/commit/c35a04102274b330aa833030c15f722b00062812 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] commons-lang issue #141: Lang 1195: Enhance MethodUtils to allow invocation ...

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/141 You are right. I missed that. It is impossible to use the parameter order I suggested, because it would clash with the existing `invokeMethod` signature. Sorry. --- If your project

[GitHub] commons-lang issue #142: LANG-1229 Performance regression in HashCodeBuilder

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/142 To keep the code clean the pull request should also undo the other additions to `HashCodeBuilderTest` done with https://github.com/apache/commons-lang/commit

[GitHub] commons-lang issue #141: Lang 1195: Enhance MethodUtils to allow invocation ...

2016-06-05 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/141 Hi Derek, sorry for the delay. I took another look at the code and compared it with `FieldUitls`. Maybe it is a good idea to change the method parameter order

[GitHub] commons-lang issue #141: Lang 1195: Enhance MethodUtils to allow invocation ...

2016-06-03 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/141 Hi Derek, you should be able to rebase this pull request by following these steps: * `git remote add upstream https://github.com/apache/commons-lang.git` * `git

[GitHub] commons-lang issue #160: Eliminate redundant calculation of isDecimalPoint.

2016-06-03 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/160 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] commons-lang issue #141: Lang 1195: Enhance MethodUtils to allow invocation ...

2016-06-03 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/141 Thanks for updating the pull request. :+1: It would be nice if you could rebase on current master. Thanks, Pascal --- If your project is set up for it, you can

[GitHub] commons-lang pull request #141: Lang 1195: Enhance MethodUtils to allow invo...

2016-06-03 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/141#discussion_r65721245 --- Diff: src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java --- @@ -142,21 +193,57 @@ public static Object invokeMethod(final

[GitHub] commons-lang pull request #141: Lang 1195: Enhance MethodUtils to allow invo...

2016-06-03 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/141#discussion_r65720267 --- Diff: src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java --- @@ -92,6 +92,29 @@ public static Object invokeMethod(final

[GitHub] commons-lang pull request #141: Lang 1195: Enhance MethodUtils to allow invo...

2016-06-03 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/141#discussion_r65720235 --- Diff: src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java --- @@ -126,13 +149,41 @@ public static Object invokeMethod(final

[GitHub] commons-lang pull request #141: Lang 1195: Enhance MethodUtils to allow invo...

2016-06-03 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/141#discussion_r65719370 --- Diff: src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java --- @@ -126,13 +149,41 @@ public static Object invokeMethod(final

[GitHub] commons-lang pull request #141: Lang 1195: Enhance MethodUtils to allow invo...

2016-06-03 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/141#discussion_r65719281 --- Diff: src/main/java/org/apache/commons/lang3/reflect/MethodUtils.java --- @@ -92,6 +92,29 @@ public static Object invokeMethod(final

[GitHub] commons-lang issue #137: Adding to StringUtils truncate method and test case...

2016-06-03 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/137 Thanks for updating the pull request. It looks good. :) Just two small issues: * javadoc examples have to be updated for the `IllegalArgumentException` for negative

[GitHub] commons-lang pull request #137: Adding to StringUtils truncate method and te...

2016-06-03 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/137#discussion_r65716762 --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java --- @@ -460,6 +460,118 @@ public static String trimToEmpty(final String str

[GitHub] commons-lang issue #159: Fix commented out nsub in EntityArray

2016-06-02 Thread PascalSchumacher
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/159 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] commons-lang pull request: Optimize the code.

2016-05-30 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/119#issuecomment-222550560 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: Fix commented out nsub in EntityArray

2016-05-30 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/159#issuecomment-222541510 jira issue for this fix: https://issues.apache.org/jira/browse/LANG-1242 --- If your project is set up for it, you can reply to this email and have your

[GitHub] commons-lang pull request: LANG-1190: TypeUtils.isAssignable throw...

2016-05-29 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/158 LANG-1190: TypeUtils.isAssignable throws NullPointerException when fr… …omType has type variables and toType generic superclass specifies type variable Not sure

[GitHub] commons-lang pull request: LANG-1224: Extend RandomStringUtils wit...

2016-05-29 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/157 LANG-1224: Extend RandomStringUtils with methods that generate string… …s between a min and max length This is (the second) part of #101 You can merge this pull request

[GitHub] commons-lang pull request: LANG-1225: Add RandomStringUtils#random...

2016-05-29 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/154#issuecomment-222347825 Merged: https://github.com/apache/commons-lang/commit/1a002c67f2d3c198411a62165e53b31d6b414aa3 --- If your project is set up for it, you can reply

[GitHub] commons-lang pull request: LANG-1225: Add RandomStringUtils#random...

2016-05-29 Thread PascalSchumacher
Github user PascalSchumacher closed the pull request at: https://github.com/apache/commons-lang/pull/154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-lang pull request: Ability to throw checked exceptions wit...

2016-05-28 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/98#issuecomment-222303424 @gzak Can you please close the issue? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] commons-lang pull request: Adding to StringUtils truncate method a...

2016-05-27 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/137#discussion_r64923777 --- Diff: src/main/java/org/apache/commons/lang3/StringUtils.java --- @@ -460,6 +460,108 @@ public static String trimToEmpty(final String str

[GitHub] commons-lang pull request: Adding to StringUtils truncate method a...

2016-05-27 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/137#issuecomment-222178901 Hi Thiago, thanks for the pull request. :+1: As I understand the discussion in the ticket and the old pull request is, a negative

[GitHub] commons-lang pull request: LANG-1223: Add StopWatch#getTime(TimeUn...

2016-05-27 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/152#issuecomment-222094283 Thanks for updating the pull request. Yes, the `StopWatch` implementation is not really testable. :( I think the best approach would

[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...

2016-05-26 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/108#issuecomment-221952053 Thanks! :+1: For each loop won the discussion, so I merged only the first commit. @vanta Sorry for telling you to refactor to use

[GitHub] commons-lang pull request: Implementations of the circuit breaker ...

2016-05-26 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/95#issuecomment-221935689 I guess this is ready to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] commons-lang pull request: Lang 1195: Enhance MethodUtils to allow...

2016-05-26 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/141#issuecomment-221935416 I agree. FieldUtils supports accessing private fields, so MethodUtils should support accessing private methods. --- If your project is set up

[GitHub] commons-lang pull request: [LANG-1228] Prefer Throwable.getCause()...

2016-05-24 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/139#issuecomment-221358056 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: LANG-1223: Add StopWatch#getTime(TimeUn...

2016-05-24 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/152#issuecomment-221348587 Hi Nick, thanks for the pull request. :) I think for completeness there should be at least one unit test. --- If your project is set

[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...

2016-05-22 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/122#issuecomment-220845360 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: LANG-1233: DiffBuilder add method to al...

2016-05-22 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/151#issuecomment-220845353 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: LANG-1233: DiffBuilder add method to al...

2016-05-22 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/151#issuecomment-220844854 Hi Nick, sorry I did not mean to merge the pull request before giving you a change to update. I will merge this one now. Sorry

[GitHub] commons-lang pull request: LANG-1225: Add RandomStringUtils#random...

2016-05-22 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/154 LANG-1225: Add RandomStringUtils#randomGraph and #randomPrint which m… …atch corresponding regular expression class These are useful over randomAscii because they do

[GitHub] commons-lang pull request: [LANG-1228] Prefer Throwable.getCause()...

2016-05-22 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/139#issuecomment-220824801 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] commons-lang pull request: LANG-1233: DiffBuilder add method to al...

2016-05-22 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/151#discussion_r64146221 --- Diff: src/main/java/org/apache/commons/lang3/builder/DiffBuilder.java --- @@ -942,6 +942,59 @@ public DiffBuilder append(final String

[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...

2016-05-21 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/122#issuecomment-220791899 Thanks for opening a new pull request :) and sorry again :(. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] commons-lang pull request: DiffBuilder: Add null check on fieldNam...

2016-05-21 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/121#issuecomment-220791849 Thanks Nick! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: LANG-1226: StringUtils#normalizeSpace d...

2016-05-21 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/150 LANG-1226: StringUtils#normalizeSpace does not trim the string anymore You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] commons-lang pull request: Ends with any

2016-05-21 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/149 Ends with any You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons-lang endsWithAny Alternatively you can

[GitHub] commons-lang pull request: Optimization of getLevenshteinDistance ...

2016-05-21 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/118#issuecomment-220781809 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: LANG-1199: Incorrect implementation of ...

2016-05-20 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/148 LANG-1199: Incorrect implementation of StringUtils#getJaroWinklerDist… …ance() replace current implementation with Jaro-Winkler distance implementation of Apache Lucene

[GitHub] commons-lang pull request: LANG-1206: improve CharSetUtils.squeeze...

2016-05-20 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/147 LANG-1206: improve CharSetUtils.squeeze() performace patch by Mohammed Alfallaj You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] commons-lang pull request: LANG-1168: Add SystemUtils.IS_OS_WINDOW...

2016-05-20 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/145#issuecomment-220675876 merged: https://github.com/apache/commons-lang/commit/031f6b082ff21cf1138907a7c666d6ff391bfd72 --- If your project is set up for it, you can reply

[GitHub] commons-lang pull request: LANG-1168: Add SystemUtils.IS_OS_WINDOW...

2016-05-20 Thread PascalSchumacher
Github user PascalSchumacher closed the pull request at: https://github.com/apache/commons-lang/pull/145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-lang pull request: LANG-787: Add StringUtils#removeIgnoreC...

2016-05-20 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/146 LANG-787: Add StringUtils#removeIgnoreCase Patch by Gokul Nanthakumar C You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] commons-lang pull request: LANG-1168: Add SystemUtils.IS_OS_WINDOW...

2016-05-20 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/145 LANG-1168: Add SystemUtils.IS_OS_WINDOWS_10 property You can merge this pull request into a Git repository by running: $ git pull https://github.com/PascalSchumacher/commons

[GitHub] commons-lang pull request: LANG-1176: Improve ArrayUtils removeEle...

2016-05-20 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/144#issuecomment-220645637 pull request updated to include the other `removeElements()` methods as suggested by Sebb --- If your project is set up for it, you can reply

[GitHub] commons-lang pull request: LANG-1176: Improve ArrayUtils removeEle...

2016-05-19 Thread PascalSchumacher
GitHub user PascalSchumacher opened a pull request: https://github.com/apache/commons-lang/pull/144 LANG-1176: Improve ArrayUtils removeElements time complexity to O(n) patch submitted by Jeffery Yuan You can merge this pull request into a Git repository by running: $ git pull

[GitHub] commons-lang pull request: Optimize the code.

2016-05-19 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/119#issuecomment-220426234 Travis Build failure seems unrelated to the change. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] commons-lang pull request: Optimization of getLevenshteinDistance ...

2016-05-19 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/118#issuecomment-220425741 I created a jira issue to track this: https://issues.apache.org/jira/browse/LANG-1234 --- If your project is set up for it, you can reply to this email

[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...

2016-05-19 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/122#issuecomment-220405242 Issue to track this enhancement: https://issues.apache.org/jira/browse/LANG-1233 --- If your project is set up for it, you can reply to this email

[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...

2016-05-19 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/122#issuecomment-220404644 @NickManley Sorry I closed the wrong pull request. I meant to close #121 instead of this one. Can you please reopen this one and close #121

[GitHub] commons-lang pull request: DiffBuilder: Add null check on fieldNam...

2016-05-19 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/121#issuecomment-220402340 Merged. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: DiffBuilder: Add null check on fieldNam...

2016-05-19 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/121#issuecomment-220398409 I created a issue to track this: https://issues.apache.org/jira/browse/LANG-1232 --- If your project is set up for it, you can reply to this email

[GitHub] commons-lang pull request: Adding unwrap and unwrapFull methods to...

2016-05-18 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/136#issuecomment-220150294 I was thinking about suggesting `unwrapFully`, but I'm not a native speaker, so let's go with Garys suggestion. --- If your project is set up

[GitHub] commons-lang pull request: Moving the clone inside removeAll(Objec...

2016-05-12 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/116#issuecomment-218834119 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request:

2016-05-12 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/commit/5eae0a646469672d1cc5385bd7bd6aedc4aed19b#commitcomment-17454538 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] commons-lang pull request: fix LANG-1151

2016-05-11 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/99#issuecomment-218569505 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: [LANG-1120] Bugfix: StringUtils#stripAc...

2016-05-10 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/105#issuecomment-218262780 Thanks! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] commons-lang pull request: random length strings within range

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/101#issuecomment-217736263 To quote Gary Gregory from https://issues.apache.org/jira/browse/LANG-1224 >It seems really confusing that some new APIs would use an inclus

[GitHub] commons-lang pull request: random length strings within range

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/101#discussion_r62435581 --- Diff: src/main/java/org/apache/commons/lang3/RandomStringUtils.java --- @@ -81,6 +81,20 @@ public static String random(final int count

[GitHub] commons-lang pull request: DiffBuilder: Add null check on fieldNam...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/121#issuecomment-217722238 @NickManley Thanks for the pull request. It would be very nice if you would create a jira issue for this at: https://issues.apache.org/jira

[GitHub] commons-lang pull request: Add method to DiffBuilder to allow appe...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/122#issuecomment-217722232 @NickManley Thanks for the pull request. It would be very nice if you would create a jira issue for this at: https://issues.apache.org/jira

[GitHub] commons-lang pull request: Adding unwrap and unwrapFull methods to...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/25#issuecomment-217721641 @thiagoh I guess this can be closed, as it is superseded by https://github.com/apache/commons-lang/pull/136 ? --- If your project is set up for it, you

[GitHub] commons-lang pull request: Adding to StringUtils truncate method a...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/24#issuecomment-217721614 @thiagoh I guess this can be closed as it is superseded by https://github.com/apache/commons-lang/issues/137 ? --- If your project is set up for it, you

[GitHub] commons-lang pull request: Adding unwrap and unwrapFull methods to...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/136#issuecomment-217721352 Jira: https://issues.apache.org/jira/browse/LANG-1014 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] commons-lang pull request: Adding to StringUtils truncate method a...

2016-05-08 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/commons-lang/pull/137#issuecomment-217721209 JIRA https://issues.apache.org/jira/browse/LANG-1013 --- If your project is set up for it, you can reply to this email and have your reply appear

<    1   2   3   4   >