[GitHub] [commons-lang] verhas commented on a change in pull request #448: Lang 1482

2019-11-06 Thread GitBox
verhas commented on a change in pull request #448: Lang 1482 URL: https://github.com/apache/commons-lang/pull/448#discussion_r343465751 ## File path: src/test/java/org/apache/commons/lang3/FunctionsTest.java ## @@ -414,8 +412,8 @@ public void testAsPredicate() {

[GitHub] [commons-lang] verhas commented on a change in pull request #448: Lang 1482

2019-08-26 Thread GitBox
verhas commented on a change in pull request #448: Lang 1482 URL: https://github.com/apache/commons-lang/pull/448#discussion_r317709154 ## File path: src/main/java/org/apache/commons/lang3/Functions.java ## @@ -143,164 +151,141 @@ } /** - * Converts the

[GitHub] [commons-lang] verhas commented on a change in pull request #448: Lang 1482

2019-08-26 Thread GitBox
verhas commented on a change in pull request #448: Lang 1482 URL: https://github.com/apache/commons-lang/pull/448#discussion_r317708414 ## File path: src/main/java/org/apache/commons/lang3/Functions.java ## @@ -549,10 +584,26 @@ public static RuntimeException

[GitHub] [commons-lang] verhas commented on a change in pull request #448: Lang 1482

2019-08-26 Thread GitBox
verhas commented on a change in pull request #448: Lang 1482 URL: https://github.com/apache/commons-lang/pull/448#discussion_r317707283 ## File path: src/test/java/org/apache/commons/lang3/FunctionsTest.java ## @@ -434,4 +492,9 @@ public void testTryWithResources() {