[GitHub] commons-lang issue #171: Removing test redundant for org.apache.commons.lang...

2016-07-15 Thread TestSuiteReductionResearch
Github user TestSuiteReductionResearch commented on the issue: https://github.com/apache/commons-lang/pull/171 Thank you again for providing more feedback. I believe our analysis did find some other tests that do seem to be covering the same scenarios, and we will be sending them as s

[GitHub] commons-lang issue #171: Removing test redundant for org.apache.commons.lang...

2016-07-15 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/171 @august782, thanks for being understanding. I think finding redundant tests, and simplifying it is a good idea, just not in the case of tests covering many different scenarios. I think m

[GitHub] commons-lang issue #171: Removing test redundant for org.apache.commons.lang...

2016-07-15 Thread TestSuiteReductionResearch
Github user TestSuiteReductionResearch commented on the issue: https://github.com/apache/commons-lang/pull/171 Thank you very much for the feedback! It does make sense that you want to keep tests for different scenarios even if they do have the same coverage. Besides these two

[GitHub] commons-lang issue #171: Removing test redundant for org.apache.commons.lang...

2016-07-15 Thread august782
Github user august782 commented on the issue: https://github.com/apache/commons-lang/pull/171 Thank you very much for the feedback! It does make sense that you want to keep tests for different scenarios even if they do have the same coverage. Besides these two tests, our analy

[GitHub] commons-lang issue #171: Removing test redundant for org.apache.commons.lang...

2016-07-15 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/commons-lang/pull/171 I agree, -1 to remove the test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] commons-lang issue #171: Removing test redundant for org.apache.commons.lang...

2016-07-15 Thread kinow
Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/171 Both tests use ClassUtils#wrapperToPrimitive. One passes a String.class, and the other a null value. Then the method looks at a map, created and filled in a static constructor. Since St

[GitHub] commons-lang issue #171: Removing test redundant for org.apache.commons.lang...

2016-07-15 Thread coveralls
Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/171 [![Coverage Status](https://coveralls.io/builds/7027718/badge)](https://coveralls.io/builds/7027718) Coverage increased (+0.03%) to 93.468% when pulling **ed27ea4132fbe36d0aec80