[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496199#comment-13496199
]
Gilles commented on MATH-894:
-
Methods getInternalVelues and start deprecated in revision
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496224#comment-13496224
]
Gilles commented on MATH-894:
-
In revision 1408735, I removed the array allocation in clear().
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496237#comment-13496237
]
Phil Steitz commented on MATH-894:
--
I am sorry but I just realized (thanks to the unit test
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496253#comment-13496253
]
Gilles commented on MATH-894:
-
bq. Removing the reallocation leaves the internal array at
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496267#comment-13496267
]
Gilles commented on MATH-894:
-
New enum type (ExpansionMode) created in revision 1408797.
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496320#comment-13496320
]
Gilles commented on MATH-894:
-
Revision 1408830: Constructor call chain.
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496326#comment-13496326
]
Gilles commented on MATH-894:
-
I think that the initialCapacity field and the protected method
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495255#comment-13495255
]
Gilles commented on MATH-894:
-
Added getCapacity in revision 1408280.
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495276#comment-13495276
]
Gilles commented on MATH-894:
-
IMO, there is an unnecessary reallocation when calling the
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495283#comment-13495283
]
Gilles commented on MATH-894:
-
ADDITIVE_MODE and MULTIPLICATIVE_MODE are represented by integers
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495695#comment-13495695
]
Phil Steitz commented on MATH-894:
--
I agree that getInternalValues should be deprecated;
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495734#comment-13495734
]
Gilles commented on MATH-894:
-
That's a neat improvement.
I just don't like the name :). apply
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495793#comment-13495793
]
Phil Steitz commented on MATH-894:
--
I never liked apply as a name. IIRC it goes back to
[
https://issues.apache.org/jira/browse/MATH-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13494054#comment-13494054
]
Gilles commented on MATH-894:
-
Removed call to contract() in revision 1407485.
As part of this
14 matches
Mail list logo