[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154119#comment-16154119 ] ASF GitHub Bot commented on TEXT-97: Github user asfgit closed the pull request at:

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153887#comment-16153887 ] ASF GitHub Bot commented on TEXT-97: Github user ameyjadiye commented on the issue:

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153873#comment-16153873 ] ASF GitHub Bot commented on TEXT-97: Github user chtompki commented on the issue:

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153865#comment-16153865 ] ASF GitHub Bot commented on TEXT-97: Github user chtompki commented on the issue:

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-09-05 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16153772#comment-16153772 ] ASF GitHub Bot commented on TEXT-97: Github user ameyjadiye commented on the issue:

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-07 Thread Amey Jadiye (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078527#comment-16078527 ] Amey Jadiye commented on TEXT-97: - In that case we have {{.selectFrom()}} API, All I'm expecting is to have

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-07 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078079#comment-16078079 ] Gilles commented on TEXT-97: What if the wanted selection of characters is not represented by range(s)? >

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-07 Thread Rob Tompkins (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078058#comment-16078058 ] Rob Tompkins commented on TEXT-97: -- Ohno strong opinions here...the input validation is the only point

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-07 Thread Rob Tompkins (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078054#comment-16078054 ] Rob Tompkins commented on TEXT-97: -- Based on what [~erans] said above, it almost makes sense to have

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078033#comment-16078033 ] ASF GitHub Bot commented on TEXT-97: Github user ameyjadiye commented on the issue:

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16078030#comment-16078030 ] ASF GitHub Bot commented on TEXT-97: Github user jbduncan commented on the issue:

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077995#comment-16077995 ] ASF GitHub Bot commented on TEXT-97: Github user chtompki commented on the issue:

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077156#comment-16077156 ] ASF GitHub Bot commented on TEXT-97: Github user jbduncan commented on the issue:

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077137#comment-16077137 ] ASF GitHub Bot commented on TEXT-97: Github user chtompki commented on the issue:

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077099#comment-16077099 ] ASF GitHub Bot commented on TEXT-97: Github user ameyjadiye commented on the issue:

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-02 Thread Amey Jadiye (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071550#comment-16071550 ] Amey Jadiye commented on TEXT-97: - Hmm, lets have extra opinions. [~chtompki], [~britter],

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-01 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071427#comment-16071427 ] Gilles commented on TEXT-97: bq. those should call .withinRange(char[] ...) I don't think so, unless you have an

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-01 Thread Amey Jadiye (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071366#comment-16071366 ] Amey Jadiye commented on TEXT-97: - Agree, usual use cases are numeric, alphabetic and alphanumeric and we can

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-01 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071338#comment-16071338 ] Gilles commented on TEXT-97: bq. single API which will return random string with given multiple ranges I know,

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-01 Thread Amey Jadiye (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071334#comment-16071334 ] Amey Jadiye commented on TEXT-97: - Hi, Primary motivation to write this method was to have single API which

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-01 Thread Gilles (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071331#comment-16071331 ] Gilles commented on TEXT-97: I'm contradicting myself but I'm not so happy with {code} withinRange(char[] ...

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071287#comment-16071287 ] ASF GitHub Bot commented on TEXT-97: Github user coveralls commented on the issue:

[jira] [Commented] (TEXT-97) RandomStringGenerator should be able to pass multiple ranges to .withinRange()

2017-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEXT-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16071285#comment-16071285 ] ASF GitHub Bot commented on TEXT-97: GitHub user ameyjadiye opened a pull request: