[GitHub] [commons-fileupload] codecracker2014 commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-21 Thread GitBox
codecracker2014 commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22#discussion_r326854899 ## File path:

[GitHub] [commons-fileupload] codecracker2014 commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-21 Thread GitBox
codecracker2014 commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22#discussion_r326854928 ## File path:

[jira] [Commented] (POOL-376) invalidateObject should not return NullPointerException

2019-09-21 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935066#comment-16935066 ] Phil Steitz commented on POOL-376: -- This is a regression caused by the fix for Pool-356.   >

[GitHub] [commons-fileupload] Stzx commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-21 Thread GitBox
Stzx commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22#discussion_r326854509 ## File path: src/main/java/org/apache/commons/fileupload/FileUploadBase.java

[jira] [Commented] (GEOMETRY-32) BSPTree Updates

2019-09-21 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935037#comment-16935037 ] Matt Juntunen commented on GEOMETRY-32: --- {quote}Wrong link. {quote} Oops. Here it is:

[jira] [Commented] (GEOMETRY-32) BSPTree Updates

2019-09-21 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935038#comment-16935038 ] Matt Juntunen commented on GEOMETRY-32: --- Here is another useful link for this discussion:

[jira] [Commented] (GEOMETRY-32) BSPTree Updates

2019-09-21 Thread Gilles (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934983#comment-16934983 ] Gilles commented on GEOMETRY-32: bq. see here Wrong link. bq. [...] just a requirement of how we're

[jira] [Commented] (POOL-376) invalidateObject should not return NullPointerException

2019-09-21 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935067#comment-16935067 ] Phil Steitz commented on POOL-376: -- Thanks for reporting this.  The patch in the PR would fix the

[GitHub] [commons-fileupload] codecracker2014 commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-21 Thread GitBox
codecracker2014 commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22#discussion_r326853601 ## File path: pom.xml ## @@ -26,7 +26,7 @@

[GitHub] [commons-fileupload] codecracker2014 commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-21 Thread GitBox
codecracker2014 commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22#discussion_r326855041 ## File path:

[GitHub] [commons-fileupload] codecracker2014 commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-21 Thread GitBox
codecracker2014 commented on a change in pull request #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22#discussion_r326855027 ## File path:

[jira] [Created] (POOL-376) invalidateObject should not return NullPointerException

2019-09-21 Thread M Sazzadul Hoque (Jira)
M Sazzadul Hoque created POOL-376: - Summary: invalidateObject should not return NullPointerException Key: POOL-376 URL: https://issues.apache.org/jira/browse/POOL-376 Project: Commons Pool

[jira] [Updated] (POOL-376) invalidateObject should not return NullPointerException

2019-09-21 Thread M Sazzadul Hoque (Jira)
[ https://issues.apache.org/jira/browse/POOL-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] M Sazzadul Hoque updated POOL-376: -- Description: {{GenericObjectPool.invalidateObject(T obj)}} should not return

[jira] [Updated] (POOL-376) invalidateObject should not return NullPointerException

2019-09-21 Thread M Sazzadul Hoque (Jira)
[ https://issues.apache.org/jira/browse/POOL-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] M Sazzadul Hoque updated POOL-376: -- Description: {{GenericObjectPool.invalidateObject(T obj)}} should not return

[jira] [Work logged] (POOL-376) invalidateObject should not return NullPointerException

2019-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/POOL-376?focusedWorklogId=316077=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316077 ] ASF GitHub Bot logged work on POOL-376: --- Author: ASF GitHub Bot

[GitHub] [commons-pool] sazzad16 opened a new pull request #24: POOL-376 invalidateObject should not throw NPE

2019-09-21 Thread GitBox
sazzad16 opened a new pull request #24: POOL-376 invalidateObject should not throw NPE URL: https://github.com/apache/commons-pool/pull/24 `GenericObjectPool.invalidateObject(T obj)` and/or `GenericObjectPool.destroy(PooledObject toDestroy)` should not throw NullPointerException when

[jira] [Work logged] (POOL-376) invalidateObject should not return NullPointerException

2019-09-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/POOL-376?focusedWorklogId=316080=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316080 ] ASF GitHub Bot logged work on POOL-376: --- Author: ASF GitHub Bot

[GitHub] [commons-pool] coveralls commented on issue #24: POOL-376 invalidateObject should not throw NPE

2019-09-21 Thread GitBox
coveralls commented on issue #24: POOL-376 invalidateObject should not throw NPE URL: https://github.com/apache/commons-pool/pull/24#issuecomment-533776196 [![Coverage Status](https://coveralls.io/builds/25845625/badge)](https://coveralls.io/builds/25845625) Coverage increased

[jira] [Comment Edited] (GEOMETRY-32) BSPTree Updates

2019-09-21 Thread Gilles (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935038#comment-16935038 ] Gilles edited comment on GEOMETRY-32 at 9/21/19 4:54 PM: - Here is another useful

[jira] [Commented] (GEOMETRY-32) BSPTree Updates

2019-09-21 Thread Gilles (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935087#comment-16935087 ] Gilles commented on GEOMETRY-32: The previous examples look nice. ;) > BSPTree Updates >

[GitHub] [commons-fileupload] jochenw commented on issue #22: Adding capability to take max upload size per request.Fileupload 1 3 1

2019-09-21 Thread GitBox
jochenw commented on issue #22: Adding capability to take max upload size per request.Fileupload 1 3 1 URL: https://github.com/apache/commons-fileupload/pull/22#issuecomment-533821094 1. I'd support Gary's request, that you provide a PR for the current master, and not the stable branch.