[jira] [Commented] (GEOMETRY-46) Additional UnitVector methods

2019-09-25 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938173#comment-16938173 ] Matt Juntunen commented on GEOMETRY-46: --- {quote}How? {quote} The [original VALJO

[jira] [Commented] (GEOMETRY-46) Additional UnitVector methods

2019-09-25 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938138#comment-16938138 ] Gilles Sadowski commented on GEOMETRY-46: - {quote}breaks ValJO specification {quote} How?

[jira] [Comment Edited] (GEOMETRY-46) Additional UnitVector methods

2019-09-25 Thread Gilles Sadowski (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938138#comment-16938138 ] Gilles Sadowski edited comment on GEOMETRY-46 at 9/25/19 11:47 PM: ---

[jira] [Closed] (BCEL-328) java.util.EmptyStackException at org.apache.bcel.classfile.DescendingVisitor.visitModule (DescendingVisitor.java:592)

2019-09-25 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/BCEL-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory closed BCEL-328. Resolution: Fixed In git master. > java.util.EmptyStackException at >

[jira] [Created] (BCEL-328) java.util.EmptyStackException at org.apache.bcel.classfile.DescendingVisitor.visitModule (DescendingVisitor.java:592)

2019-09-25 Thread Gary D. Gregory (Jira)
Gary D. Gregory created BCEL-328: Summary: java.util.EmptyStackException at org.apache.bcel.classfile.DescendingVisitor.visitModule (DescendingVisitor.java:592) Key: BCEL-328 URL:

[jira] [Work logged] (POOL-356) deadlock if borrowObject gets called to fast and maxIdle is 0

2019-09-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/POOL-356?focusedWorklogId=318139=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318139 ] ASF GitHub Bot logged work on POOL-356: --- Author: ASF GitHub Bot

[jira] [Commented] (POOL-356) deadlock if borrowObject gets called to fast and maxIdle is 0

2019-09-25 Thread Mark Struberg (Jira)
[ https://issues.apache.org/jira/browse/POOL-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937440#comment-16937440 ] Mark Struberg commented on POOL-356: Afair this is for ensuring some of our configuration. In pool you

[GitHub] [commons-pool] sazzad16 commented on issue #25: POOL-356 and POOL-376

2019-09-25 Thread GitBox
sazzad16 commented on issue #25: POOL-356 and POOL-376 URL: https://github.com/apache/commons-pool/pull/25#issuecomment-534910688 @psteitz Thank you for merging. Please make this patch available for `2.6.x`. Thanks again!

[jira] [Updated] (GEOMETRY-46) Additional UnitVector methods

2019-09-25 Thread Gilles (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gilles updated GEOMETRY-46: --- Attachment: GEOMETRY-46.patch > Additional UnitVector methods > - > >

[GitHub] [commons-rng] coveralls edited a comment on issue #67: RNG-116: RandomSource to expose supported interfaces.

2019-09-25 Thread GitBox
coveralls edited a comment on issue #67: RNG-116: RandomSource to expose supported interfaces. URL: https://github.com/apache/commons-rng/pull/67#issuecomment-534260653 [![Coverage Status](https://coveralls.io/builds/25920300/badge)](https://coveralls.io/builds/25920300)

[jira] [Resolved] (LANG-1426) JavaDoc issue on StringUtils.truncate

2019-09-25 Thread Gary Gregory (Jira)
[ https://issues.apache.org/jira/browse/LANG-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LANG-1426. Fix Version/s: 3.10 Resolution: Fixed In git master. Please verify and close. > JavaDoc

[jira] [Reopened] (COLLECTIONS-679) MultiValuedMap JavaDoc Typo

2019-09-25 Thread Gary Gregory (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory reopened COLLECTIONS-679: -- > MultiValuedMap JavaDoc Typo > --- > > Key:

[jira] [Resolved] (COLLECTIONS-679) MultiValuedMap JavaDoc Typo

2019-09-25 Thread Gary Gregory (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved COLLECTIONS-679. -- Resolution: Fixed In git master. Please verify and close. > MultiValuedMap

[GitHub] [commons-collections] garydgregory merged pull request #85: [COLLECTIONS-679] Using existing class in example given in Javadocs.

2019-09-25 Thread GitBox
garydgregory merged pull request #85: [COLLECTIONS-679] Using existing class in example given in Javadocs. URL: https://github.com/apache/commons-collections/pull/85 This is an automated message from the Apache Git Service.

[jira] [Work logged] (COLLECTIONS-679) MultiValuedMap JavaDoc Typo

2019-09-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-679?focusedWorklogId=318372=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318372 ] ASF GitHub Bot logged work on COLLECTIONS-679: -- Author: ASF

[GitHub] [commons-collections] garydgregory commented on a change in pull request #84: [COLLECTIONS 708] Add hashCode method to CollectionUtils

2019-09-25 Thread GitBox
garydgregory commented on a change in pull request #84: [COLLECTIONS 708] Add hashCode method to CollectionUtils URL: https://github.com/apache/commons-collections/pull/84#discussion_r328175439 ## File path: src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #84: [COLLECTIONS 708] Add hashCode method to CollectionUtils

2019-09-25 Thread GitBox
garydgregory commented on a change in pull request #84: [COLLECTIONS 708] Add hashCode method to CollectionUtils URL: https://github.com/apache/commons-collections/pull/84#discussion_r328171684 ## File path: src/main/java/org/apache/commons/collections4/CollectionUtils.java

[GitHub] [commons-collections] garydgregory commented on a change in pull request #84: [COLLECTIONS 708] Add hashCode method to CollectionUtils

2019-09-25 Thread GitBox
garydgregory commented on a change in pull request #84: [COLLECTIONS 708] Add hashCode method to CollectionUtils URL: https://github.com/apache/commons-collections/pull/84#discussion_r328175537 ## File path: src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java

[GitHub] [commons-rng] aherbert opened a new pull request #68: RNG-117: RandomSource to support creating byte[] seed for implementing class.

2019-09-25 Thread GitBox
aherbert opened a new pull request #68: RNG-117: RandomSource to support creating byte[] seed for implementing class. URL: https://github.com/apache/commons-rng/pull/68 Added methods: ``` public byte[] createSeed(); public byte[] createSeed(UniformRandomProvider); ```

[jira] [Commented] (GEOMETRY-60) JDK 13 Build Fails

2019-09-25 Thread Gilles (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937773#comment-16937773 ] Gilles commented on GEOMETRY-60: Fixed? > JDK 13 Build Fails > -- > >

[GitHub] [commons-lang] garydgregory commented on issue #458: [LANG-1426] Corrected usage examples in Javadocs

2019-09-25 Thread GitBox
garydgregory commented on issue #458: [LANG-1426] Corrected usage examples in Javadocs URL: https://github.com/apache/commons-lang/pull/458#issuecomment-535051721 https://issues.apache.org/jira/browse/LANG-1426 This is an

[GitHub] [commons-lang] garydgregory merged pull request #458: [LANG-1426] Corrected usage examples in Javadocs

2019-09-25 Thread GitBox
garydgregory merged pull request #458: [LANG-1426] Corrected usage examples in Javadocs URL: https://github.com/apache/commons-lang/pull/458 This is an automated message from the Apache Git Service. To respond to the

[jira] [Closed] (COLLECTIONS-679) MultiValuedMap JavaDoc Typo

2019-09-25 Thread Gary Gregory (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory closed COLLECTIONS-679. Fix Version/s: 4.5 Resolution: Fixed In git master. > MultiValuedMap JavaDoc

[GitHub] [commons-cli] garydgregory merged pull request #30: Docs: Replace OptionBuilder in usage page

2019-09-25 Thread GitBox
garydgregory merged pull request #30: Docs: Replace OptionBuilder in usage page URL: https://github.com/apache/commons-cli/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Work logged] (LANG-1426) JavaDoc issue on StringUtils.truncate

2019-09-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1426?focusedWorklogId=318364=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318364 ] ASF GitHub Bot logged work on LANG-1426: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1426) JavaDoc issue on StringUtils.truncate

2019-09-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1426?focusedWorklogId=318363=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318363 ] ASF GitHub Bot logged work on LANG-1426: Author: ASF GitHub Bot

[jira] [Commented] (GEOMETRY-46) Additional UnitVector methods

2019-09-25 Thread Gilles (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937556#comment-16937556 ] Gilles commented on GEOMETRY-46: In the unit tests, the tolerance should be set to 0 (since the purpose

[jira] [Commented] (GEOMETRY-46) Additional UnitVector methods

2019-09-25 Thread Gilles (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937584#comment-16937584 ] Gilles commented on GEOMETRY-46: Surprised by this use of {{super}}, I couldn't find any link on the web

[GitHub] [commons-validator] jeff-schram opened a new pull request #18: Update pom.xml

2019-09-25 Thread GitBox
jeff-schram opened a new pull request #18: Update pom.xml URL: https://github.com/apache/commons-validator/pull/18 Update beanutils dependency to address CVE-2019-10086 (web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2019-10086)

[jira] [Commented] (RNG-116) RandomSource to expose supported functionality and seed size

2019-09-25 Thread Alex D Herbert (Jira)
[ https://issues.apache.org/jira/browse/RNG-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937643#comment-16937643 ] Alex D Herbert commented on RNG-116: Exposure of the number of bytes required for a RandomSource may

[jira] [Commented] (DAEMON-408) PROCRUN 1.2.x x64 crash on Windows Server 2008 R2

2019-09-25 Thread Mark Thomas (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937644#comment-16937644 ] Mark Thomas commented on DAEMON-408: This looks to be the same as 

[jira] [Resolved] (RNG-116) RandomSource to expose supported functionality and seed size

2019-09-25 Thread Alex D Herbert (Jira)
[ https://issues.apache.org/jira/browse/RNG-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex D Herbert resolved RNG-116. Fix Version/s: 1.3 Resolution: Implemented In git master. > RandomSource to expose supported

[GitHub] [commons-geometry] aherbert commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods

2019-09-25 Thread GitBox
aherbert commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39#discussion_r328060239 ## File path:

[jira] [Resolved] (DAEMON-408) PROCRUN 1.2.x x64 crash on Windows Server 2008 R2

2019-09-25 Thread Mark Thomas (Jira)
[ https://issues.apache.org/jira/browse/DAEMON-408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Thomas resolved DAEMON-408. Fix Version/s: 1.2.2 Resolution: Fixed > PROCRUN 1.2.x x64 crash on Windows Server 2008 R2

[GitHub] [commons-rng] asfgit merged pull request #67: RNG-116: RandomSource to expose supported interfaces.

2019-09-25 Thread GitBox
asfgit merged pull request #67: RNG-116: RandomSource to expose supported interfaces. URL: https://github.com/apache/commons-rng/pull/67 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [commons-lang] coveralls edited a comment on issue #416: Add support of lazy default value evaluation for defaulting methods

2019-09-25 Thread GitBox
coveralls edited a comment on issue #416: Add support of lazy default value evaluation for defaulting methods URL: https://github.com/apache/commons-lang/pull/416#issuecomment-481641411 [![Coverage

[jira] [Commented] (COLLECTIONS-714) PatriciaTrie ignores trailing null characters in keys

2019-09-25 Thread Chen (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937640#comment-16937640 ] Chen commented on COLLECTIONS-714: -- Because 0=‘\u’ we can't fix this problem, we need to add

[jira] [Created] (RNG-117) RandomSource to support creating byte[] seed for implementing class.

2019-09-25 Thread Alex D Herbert (Jira)
Alex D Herbert created RNG-117: -- Summary: RandomSource to support creating byte[] seed for implementing class. Key: RNG-117 URL: https://issues.apache.org/jira/browse/RNG-117 Project: Commons RNG

[jira] [Commented] (COLLECTIONS-714) PatriciaTrie ignores trailing null characters in keys

2019-09-25 Thread Rohan Padhye (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937868#comment-16937868 ] Rohan Padhye commented on COLLECTIONS-714: -- If there is no fix, then silently failing (with

[GitHub] [commons-collections] garydgregory commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
garydgregory commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535097993 This is large PR, it will take more time to digest... ;-)

[GitHub] [commons-collections] Claudenw commented on a change in pull request #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
Claudenw commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r328257838 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/BloomFilter.java ##

[jira] [Updated] (POOL-376) invalidateObject should not return NullPointerException

2019-09-25 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated POOL-376: - Affects Version/s: 2.6.1 2.7.0 > invalidateObject should not return

[GitHub] [commons-geometry] darkma773r commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods

2019-09-25 Thread GitBox
darkma773r commented on a change in pull request #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39#discussion_r328272818 ## File path:

[GitHub] [commons-collections] garydgregory commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
garydgregory commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535094163 I brought this patch into Eclipse to make it easier to grok and the first thing that stands out is the package

[GitHub] [commons-collections] garydgregory commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
garydgregory commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535095730 @Claudenw Enum names in `org.apache.commons.collections4.bloomfilter.collection.CollectionStatistics.Change` should be in

[GitHub] [commons-collections] garydgregory commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
garydgregory commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535098662 @Claudenw WRT `org.apache.commons.collections4.bloomfilter.ProtoBloomFilter.hashCode()` This looks like a recipe

[jira] [Resolved] (POOL-356) deadlock if borrowObject gets called to fast and maxIdle is 0

2019-09-25 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved POOL-356. -- Resolution: Fixed The regression was fixed in 0cdff0ade7e6a6ae2a48356e55d7549353535043 The liveness

[GitHub] [commons-rng] coveralls commented on issue #68: RNG-117: RandomSource to support creating byte[] seed for implementing class.

2019-09-25 Thread GitBox
coveralls commented on issue #68: RNG-117: RandomSource to support creating byte[] seed for implementing class. URL: https://github.com/apache/commons-rng/pull/68#issuecomment-535085876 [![Coverage

[jira] [Commented] (BCEL-303) AssertionViolatedException in Pass 3A Verification of invoke instructions

2019-09-25 Thread Rohan Padhye (Jira)
[ https://issues.apache.org/jira/browse/BCEL-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937872#comment-16937872 ] Rohan Padhye commented on BCEL-303: --- The class files attached with this bug report and similar ones that

[GitHub] [commons-collections] garydgregory commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
garydgregory commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535095481 @Claudenw In `org.apache.commons.collections4.bloomfilter.StandardBloomFilter.hashCode()`, if you override hashCode(),

[GitHub] [commons-collections] garydgregory commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
garydgregory commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535099649 @Claudenw WRT `org.apache.commons.collections4.bloomfilter.collection.CollectionStatistics.getTxnCount()` I am never

[GitHub] [commons-collections] garydgregory commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
garydgregory commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535103947 On Wed, Sep 25, 2019 at 12:28 PM Claude Warren wrote: > I must be losing my mind. I thought i did all of those

[GitHub] [commons-collections] Claudenw commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
Claudenw commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535106644 If it makes it easier i can host a zoom session or we can do a discussion on slack. I should be home in 45 mi or so. On

[jira] [Resolved] (POOL-376) invalidateObject should not return NullPointerException

2019-09-25 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/POOL-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz resolved POOL-376. -- Resolution: Fixed Fixed in 0cdff0ade7e6a6ae2a48356e55d7549353535043 > invalidateObject should not

[GitHub] [commons-cli] mincong-h commented on issue #30: Docs: Replace OptionBuilder in usage page

2019-09-25 Thread GitBox
mincong-h commented on issue #30: Docs: Replace OptionBuilder in usage page URL: https://github.com/apache/commons-cli/pull/30#issuecomment-535086761 Thank you @garydgregory  This is an automated message from the Apache Git

[GitHub] [commons-collections] garydgregory commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
garydgregory commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535097815 @Claudenw Unless classes like `CollectionConfiguration` are going to be made to apply to all of Commons Collection, it

[GitHub] [commons-collections] Claudenw commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
Claudenw commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535103173 I must be losing my mind. I thought i did all of those changes. :'( I will review and try to get them right this evening.

[GitHub] [commons-collections] Claudenw commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
Claudenw commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535128279 Equals is overridden in StandardBloomFilter. On Wed, Sep 25, 2019 at 5:08 PM Gary Gregory wrote: > @Claudenw

[GitHub] [commons-collections] Claudenw commented on a change in pull request #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
Claudenw commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r328258674 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/ProtoBloomFilter.java

[GitHub] [commons-collections] Claudenw commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
Claudenw commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535147325 resolves COLLECTIONS-728 This is an automated message from the

[GitHub] [commons-collections] garydgregory commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
garydgregory commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535096220 All of the Javadoc _should_ be in the form "Gets...", "Checks..." instead of "Get...", "Check", and so on.

[GitHub] [commons-collections] Claudenw commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
Claudenw commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535104377 The protobloomfilter should be immutable so the hash could be generated at construction. Noyt in front of my computer at the

[GitHub] [commons-collections] Claudenw commented on issue #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
Claudenw commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535131864 The classes/interfaces in bloomfilter are the core of the bloomfilter code. The bloomfilters.collections package contains

[GitHub] [commons-collections] Claudenw commented on a change in pull request #83: WIP: Initial bloom filter code contribution

2019-09-25 Thread GitBox
Claudenw commented on a change in pull request #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#discussion_r328258159 ## File path: src/main/java/org/apache/commons/collections4/bloomfilters/FilterConfig.java ##

[jira] [Created] (COLLECTIONS-728) BloomFilter contribution

2019-09-25 Thread Claude Warren (Jira)
Claude Warren created COLLECTIONS-728: - Summary: BloomFilter contribution Key: COLLECTIONS-728 URL: https://issues.apache.org/jira/browse/COLLECTIONS-728 Project: Commons Collections

[GitHub] [commons-geometry] darkma773r commented on issue #39: GEOMETRY-46: Add additional UnitVector methods

2019-09-25 Thread GitBox
darkma773r commented on issue #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39#issuecomment-535155019 I'm not sure if you're watching the issue on JIRA as well

[jira] [Closed] (GEOMETRY-60) JDK 13 Build Fails

2019-09-25 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Juntunen closed GEOMETRY-60. - > JDK 13 Build Fails > -- > > Key: GEOMETRY-60 >

[jira] [Resolved] (GEOMETRY-60) JDK 13 Build Fails

2019-09-25 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Juntunen resolved GEOMETRY-60. --- Resolution: Fixed > JDK 13 Build Fails > -- > > Key:

[jira] [Commented] (GEOMETRY-60) JDK 13 Build Fails

2019-09-25 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937997#comment-16937997 ] Matt Juntunen commented on GEOMETRY-60: --- Yes! Hooray! Now I'll be able to sleep tonight :) > JDK

[GitHub] [commons-lang] garydgregory commented on issue #460: Lang-1465: Fix the ZZ time zone format

2019-09-25 Thread GitBox
garydgregory commented on issue #460: Lang-1465: Fix the ZZ time zone format URL: https://github.com/apache/commons-lang/pull/460#issuecomment-535191001 -1. Please see the test failures https://travis-ci.org/apache/commons-lang/jobs/589618913

[jira] [Commented] (POOL-356) deadlock if borrowObject gets called to fast and maxIdle is 0

2019-09-25 Thread Gary Gregory (Jira)
[ https://issues.apache.org/jira/browse/POOL-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938031#comment-16938031 ] Gary Gregory commented on POOL-356: --- [~psteitz]  Please update {{changes.xml}}.   > deadlock if

[jira] [Commented] (GEOMETRY-46) Additional UnitVector methods

2019-09-25 Thread Matt Juntunen (Jira)
[ https://issues.apache.org/jira/browse/GEOMETRY-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937996#comment-16937996 ] Matt Juntunen commented on GEOMETRY-46: --- I commented on the usage of {{super}} as well :). I've

[GitHub] [commons-lang] SElab2019 opened a new pull request #460: Lang-1465: Fix the ZZ time zone format

2019-09-25 Thread GitBox
SElab2019 opened a new pull request #460: Lang-1465: Fix the ZZ time zone format URL: https://github.com/apache/commons-lang/pull/460 Try to fix ZZ time zone format. Issue link: https://issues.apache.org/jira/projects/LANG/issues/LANG-1465. Thanks.

[jira] [Updated] (COLLECTIONS-728) BloomFilter contribution

2019-09-25 Thread Gary Gregory (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory updated COLLECTIONS-728: - External issue ID: 83 External issue URL:

[jira] [Work logged] (LANG-1435) ObjectUtils.defaultIfNull for slow default values

2019-09-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1435?focusedWorklogId=318506=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318506 ] ASF GitHub Bot logged work on LANG-1435: Author: ASF GitHub Bot

[GitHub] [commons-lang] mikkomaunu commented on issue #408: LANG-1435: Implemented defaultIfNull method that uses a supplier for default value

2019-09-25 Thread GitBox
mikkomaunu commented on issue #408: LANG-1435: Implemented defaultIfNull method that uses a supplier for default value URL: https://github.com/apache/commons-lang/pull/408#issuecomment-535156071 Method suggested here serves slightly different use case and cannot always be substituted by

[GitHub] [commons-geometry] acid1103 commented on issue #39: GEOMETRY-46: Add additional UnitVector methods

2019-09-25 Thread GitBox
acid1103 commented on issue #39: GEOMETRY-46: Add additional UnitVector methods URL: https://github.com/apache/commons-geometry/pull/39#issuecomment-535157348 I have been keeping an eye on it. I just pushed two commits which address the issues above, as well as the issues mentioned on

[GitHub] [commons-geometry] darkma773r closed pull request #38: GEOMETRY-60: Bumping Jacoco Version

2019-09-25 Thread GitBox
darkma773r closed pull request #38: GEOMETRY-60: Bumping Jacoco Version URL: https://github.com/apache/commons-geometry/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [commons-geometry] darkma773r commented on issue #38: GEOMETRY-60: Bumping Jacoco Version

2019-09-25 Thread GitBox
darkma773r commented on issue #38: GEOMETRY-60: Bumping Jacoco Version URL: https://github.com/apache/commons-geometry/pull/38#issuecomment-535175318 Fixed in commit 687412e982d4d088716090a310159c782f0c09be This is an

[GitHub] [commons-lang] garydgregory commented on issue #416: Add support of lazy default value evaluation for defaulting methods

2019-09-25 Thread GitBox
garydgregory commented on issue #416: Add support of lazy default value evaluation for defaulting methods URL: https://github.com/apache/commons-lang/pull/416#issuecomment-535246337 I am really not a fan of the "lazy" method name prefix. It does not convey the correct meaning of the