arturobernalg commented on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-789942178
> You should really run a local build before creating the PR as this PR
fails the build.
Yep, my mistake. Sorry.
garydgregory commented on a change in pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#discussion_r586658202
##
File path: src/main/java/org/apache/commons/lang3/math/NumberUtils.java
##
@@ -1715,6 +1715,50 @@ public static boolean isCreatable(final
chrismaeda commented on pull request #80:
URL: https://github.com/apache/commons-beanutils/pull/80#issuecomment-789945687
> > > > Yep I have done this before with other libraries and put in Maven
Central in my `com.melloware` artifact but was really hoping not to have to do
that with an
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560582=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560582
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
coveralls commented on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-789980845
[](https://coveralls.io/builds/37627057)
Coverage increased (+0.004%) to 94.918% when pulling
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560601=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560601
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560579=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560579
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560576=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560576
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
arturobernalg commented on a change in pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#discussion_r586668513
##
File path: src/main/java/org/apache/commons/lang3/math/NumberUtils.java
##
@@ -1715,6 +1715,50 @@ public static boolean isCreatable(final
mturk opened a new pull request #26:
URL: https://github.com/apache/commons-daemon/pull/26
This is minor update that allows to use
nmake WINVER=0x602 instead the set of predefined versions ((WINXP, WIN2003,
VISTA, WIN7)
aherbert commented on a change in pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#discussion_r586910342
##
File path: src/main/java/org/apache/commons/lang3/math/NumberUtils.java
##
@@ -1715,6 +1715,50 @@ public static boolean isCreatable(final String
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560753=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560753
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
aherbert commented on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-790185530
Is the intention that this should match `isCreateable(String)` for all valid
hex numbers and return `true` for all hex cases where a `Number` is returned
from
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560758=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560758
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
I am not convinced this belong in Lang. Maybe in a Math module? Maybe in
Text?
Gary
On Wed, Mar 3, 2021, 19:29 GitBox wrote:
>
> aherbert commented on pull request #727:
> URL:
> https://github.com/apache/commons-lang/pull/727#issuecomment-790185530
>
>
>Is the intention that this should
It also makes me ask if we are adding this then why not methods to query
the other Java formats for literals:
Binary = 0b...
Octal = 0...
Hex = 0x...
isBinaryLiteral()
isOctalLiteral()
isHexLiteral()
It also assumes that the number is an integer. But the binary literal
formats cover floating
Sorry, the previous simple regex was incorrect. It should have at least 1
character after the x:
0[xX][0-9a-fA-F]{1,16}
Anyway, parsing a number by code or regex has a lot of cases to consider
and the intent should be documented.
On Thu, 4 Mar 2021 at 00:47, Alex Herbert wrote:
> It also makes
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560839=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560839
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
arturobernalg commented on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-790332374
> BigInteger
Hi @aherbert
Thank you for your comment. I've fix those cases that you mentioned and i've
add more test.
Just one think about -->
[
https://issues.apache.org/jira/browse/POOL-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shichao Yuan updated POOL-393:
--
Description:
When creating may pools, I find that it tasks too much time to register jmx.
In the
[
https://issues.apache.org/jira/browse/POOL-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shichao Yuan updated POOL-393:
--
Description:
When creating may pools, I find that it tasks too much time to register jmx.
In the
Shichao Yuan created POOL-393:
-
Summary: BaseGenericObjectPool.jmxRegister may cost too much time
when creating many pools
Key: POOL-393
URL: https://issues.apache.org/jira/browse/POOL-393
Project:
[
https://issues.apache.org/jira/browse/POOL-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shichao Yuan updated POOL-393:
--
Summary: BaseGenericObjectPool.jmxRegister may cost too much time (was:
[
https://issues.apache.org/jira/browse/POOL-393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shichao Yuan updated POOL-393:
--
Description:
When creating may pools, I find that it tasks too much time to register jmx.
In the
[
https://issues.apache.org/jira/browse/LANG-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arturo Bernal updated LANG-1644:
Description:
IMO would be fine have a method that given a String tell you if is a valid
garydgregory commented on pull request #80:
URL: https://github.com/apache/commons-beanutils/pull/80#issuecomment-78920
-1 due to binary compatibility.
This is an automated message from the Apache Git Service.
To
melloware commented on pull request #80:
URL: https://github.com/apache/commons-beanutils/pull/80#issuecomment-789672352
-1 also would prefer a BeanUtils2 2.0.0 official release in Maven Central
instead.
This is an
Arturo Bernal created LANG-1644:
---
Summary: Check if number is hexadecimal
Key: LANG-1644
URL: https://issues.apache.org/jira/browse/LANG-1644
Project: Commons Lang
Issue Type: Improvement
garydgregory commented on pull request #117:
URL: https://github.com/apache/commons-vfs/pull/117#issuecomment-789670462
> This PR is still valid, since we are setting authdata instead of proxyauth
data, it is for both htt5fileprovider and http4fileprovider
>
garydgregory commented on pull request #53:
URL: https://github.com/apache/commons-validator/pull/53#issuecomment-789668068
-1 due to binary compatibility. Also the POM changes are invalid.
This is an automated message from
satish-csi commented on pull request #117:
URL: https://github.com/apache/commons-vfs/pull/117#issuecomment-789755221
Hi @garydgregory
I had look at master files
```
dependabot[bot] closed pull request #135:
URL: https://github.com/apache/commons-vfs/pull/135
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dependabot[bot] closed pull request #126:
URL: https://github.com/apache/commons-vfs/pull/126
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dependabot[bot] opened a new pull request #162:
URL: https://github.com/apache/commons-vfs/pull/162
Bumps `slf4j.version` from 1.7.26 to 1.7.30.
Updates `slf4j-api` from 1.7.26 to 1.7.30
Commits
Change the GID and AID would be best for your own release to avoid ANY
confusion.
Gary
On Wed, Mar 3, 2021, 10:28 GitBox wrote:
>
> XenoAmess commented on pull request #80:
> URL:
> https://github.com/apache/commons-beanutils/pull/80#issuecomment-789798150
>
>
>I suggest you fork and
garydgregory commented on pull request #117:
URL: https://github.com/apache/commons-vfs/pull/117#issuecomment-789817950
> Hi @garydgregory
> I had look at master files
>
> ```
>
melloware commented on pull request #80:
URL: https://github.com/apache/commons-beanutils/pull/80#issuecomment-789820136
Yep I have done this before with other libraries and put in Maven Central in
my `com.melloware` artifact but was really hoping not to have to do that with
an Apache
dependabot[bot] commented on pull request #135:
URL: https://github.com/apache/commons-vfs/pull/135#issuecomment-789749372
Looks like org.slf4j:jcl-over-slf4j is updatable in another way, so this is
no longer needed.
This
dependabot[bot] commented on pull request #126:
URL: https://github.com/apache/commons-vfs/pull/126#issuecomment-789749370
Looks like org.slf4j:slf4j-api is updatable in another way, so this is no
longer needed.
This is an
XenoAmess commented on pull request #80:
URL: https://github.com/apache/commons-beanutils/pull/80#issuecomment-789798150
I suggest you fork and release on your host...
Just changing group ID will be fine...
After all this is apache2 license, right...
And ossrh is free..
XenoAmess commented on pull request #80:
URL: https://github.com/apache/commons-beanutils/pull/80#issuecomment-789851331
> Yep I have done this before with other libraries and put in Maven Central
in my `com.melloware` artifact but was really hoping not to have to do that
with an Apache
satish-csi commented on pull request #117:
URL: https://github.com/apache/commons-vfs/pull/117#issuecomment-789865939
Hi @garydgregory ,
I have rebased PR, resolved conflict,
If I pass some dummy proxy URI http://test:t...@squid-test.com:3128, without
my PR changes
then it fails
garydgregory merged pull request #66:
URL: https://github.com/apache/commons-pool/pull/66
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
garydgregory commented on pull request #727:
URL: https://github.com/apache/commons-lang/pull/727#issuecomment-789936882
You should really run a local build before creating the PR as this PR fails
the build.
This is an
chrismaeda commented on pull request #80:
URL: https://github.com/apache/commons-beanutils/pull/80#issuecomment-789868132
> > Yep I have done this before with other libraries and put in Maven
Central in my `com.melloware` artifact but was really hoping not to have to do
that with an
garydgregory commented on pull request #117:
URL: https://github.com/apache/commons-vfs/pull/117#issuecomment-789910792
> Hi @garydgregory ,
> I have rebased PR, resolved conflict,
> If I pass some dummy proxy URI http://test:t...@squid-test.com:3128,
without my PR changes
> then
satish-csi commented on pull request #117:
URL: https://github.com/apache/commons-vfs/pull/117#issuecomment-789914504
> > Hi @garydgregory ,
> > I have rebased PR, resolved conflict,
> > If I pass some dummy proxy URI http://test:t...@squid-test.com:3128,
without my PR changes
> >
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560570=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560570
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
chrismaeda edited a comment on pull request #80:
URL: https://github.com/apache/commons-beanutils/pull/80#issuecomment-789868132
> > Yep I have done this before with other libraries and put in Maven
Central in my `com.melloware` artifact but was really hoping not to have to do
that with
arturobernalg opened a new pull request #727:
URL: https://github.com/apache/commons-lang/pull/727
Checks whether the given String is a hex number.
* NumberUtils.isHexNumber(null)) = false
* NumberUtils.isHexNumber("")) = false
*
garydgregory merged pull request #68:
URL: https://github.com/apache/commons-pool/pull/68
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
garydgregory commented on pull request #80:
URL: https://github.com/apache/commons-beanutils/pull/80#issuecomment-789907176
> > > Yep I have done this before with other libraries and put in Maven
Central in my `com.melloware` artifact but was really hoping not to have to do
that with an
garydgregory edited a comment on pull request #80:
URL: https://github.com/apache/commons-beanutils/pull/80#issuecomment-789907176
> > > Yep I have done this before with other libraries and put in Maven
Central in my `com.melloware` artifact but was really hoping not to have to do
that
[
https://issues.apache.org/jira/browse/LANG-1644?focusedWorklogId=560571=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-560571
]
ASF GitHub Bot logged work on LANG-1644:
Author: ASF GitHub Bot
54 matches
Mail list logo
