[jira] [Created] (CSV-272) Support fixed-width format

2021-02-26 Thread Holger Brandl (Jira)
Holger Brandl created CSV-272: - Summary: Support fixed-width format Key: CSV-272 URL: https://issues.apache.org/jira/browse/CSV-272 Project: Commons CSV Issue Type: Improvement

[jira] [Commented] (IO-714) ReaderInputStream does not call CharsetEncoder.flush(...)

2021-02-26 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292018#comment-17292018 ] Gary D. Gregory commented on IO-714: IANAL but I see this as: * Part of the issue is on whose behalf you

[jira] [Commented] (IO-714) ReaderInputStream does not call CharsetEncoder.flush(...)

2021-02-26 Thread Marcono1234 (Jira)
[ https://issues.apache.org/jira/browse/IO-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292009#comment-17292009 ] Marcono1234 commented on IO-714: What exactly is a "simple" PR? I am not very keen on signing the CLA; but

[jira] [Work logged] (COLLECTIONS-783) Checks if any value in the given Collections is null or empty.

2021-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-783?focusedWorklogId=558736=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558736 ] ASF GitHub Bot logged work on COLLECTIONS-783: -- Author: ASF

[GitHub] [commons-collections] arturobernalg commented on pull request #216: feature/COLLECTIONS-783 Checks if any value in the given Collections is null or empty.

2021-02-26 Thread GitBox
arturobernalg commented on pull request #216: URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786891734 CollectionUtils.containsAny check bjects.requireNonNull and throw NPE. IMO this will break the binary. I keep checking `IterableUtils.matchesAny`

[jira] [Commented] (IO-295) FileUtils.isSymlinks misses symlink folders on Windows

2021-02-26 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291916#comment-17291916 ] Gary D. Gregory commented on IO-295: Yeah... checking for "something that is both a directory AND is

[jira] [Commented] (IO-714) ReaderInputStream does not call CharsetEncoder.flush(...)

2021-02-26 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291913#comment-17291913 ] Gary D. Gregory commented on IO-714: You do not need an CLA for a "simple" PR, but if you plan on

[GitHub] [commons-collections] arturobernalg commented on pull request #217: Add constant variable

2021-02-26 Thread GitBox
arturobernalg commented on pull request #217: URL: https://github.com/apache/commons-collections/pull/217#issuecomment-786863415 > Looks good to me. Following the pattern of the exiting `CollectionUtils.INDEX_NOT_FOUND`.  Thank you @kinow

[jira] [Work logged] (COLLECTIONS-783) Checks if any value in the given Collections is null or empty.

2021-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/COLLECTIONS-783?focusedWorklogId=558709=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558709 ] ASF GitHub Bot logged work on COLLECTIONS-783: -- Author: ASF

[GitHub] [commons-collections] arturobernalg commented on pull request #216: feature/COLLECTIONS-783 Checks if any value in the given Collections is null or empty.

2021-02-26 Thread GitBox
arturobernalg commented on pull request #216: URL: https://github.com/apache/commons-collections/pull/216#issuecomment-786860741 > Code looks OK. I think we just need to consider whether we want a new method for this, or if existing ways to use the code for this are better alternatives

[jira] [Created] (COLLECTIONS-783) Checks if any value in the given Collections is null or empty.

2021-02-26 Thread Arturo Bernal (Jira)
Arturo Bernal created COLLECTIONS-783: - Summary: Checks if any value in the given Collections is null or empty. Key: COLLECTIONS-783 URL: https://issues.apache.org/jira/browse/COLLECTIONS-783

[jira] [Updated] (DBCP-572) timed out connections remain active in the pool

2021-02-26 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated DBCP-572: - Assignee: (was: Phil Steitz) > timed out connections remain active in the pool >

[jira] [Commented] (IO-714) ReaderInputStream does not call CharsetEncoder.flush(...)

2021-02-26 Thread Marcono1234 (Jira)
[ https://issues.apache.org/jira/browse/IO-714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291878#comment-17291878 ] Marcono1234 commented on IO-714: [~ggregory], I _might_ give it a try, though not sure how soon. Will that

[GitHub] [commons-pool] garydgregory commented on a change in pull request #67: Implement AbandonedConfig for GenericKeyedObjectPool

2021-02-26 Thread GitBox
garydgregory commented on a change in pull request #67: URL: https://github.com/apache/commons-pool/pull/67#discussion_r583830801 ## File path: src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolMXBean.java ## @@ -91,6 +91,12 @@ */ boolean getLifo();

[jira] [Resolved] (VFS-794) Fix file resource leak in CombinedResources (properties file) which keeps the Commons VFS jar file open.

2021-02-26 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VFS-794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary D. Gregory resolved VFS-794. - Resolution: Fixed > Fix file resource leak in CombinedResources (properties file) which keeps the

[jira] [Created] (VFS-794) Fix file resource leak in CombinedResources (properties file) which keeps the Commons VFS jar file open.

2021-02-26 Thread Gary D. Gregory (Jira)
Gary D. Gregory created VFS-794: --- Summary: Fix file resource leak in CombinedResources (properties file) which keeps the Commons VFS jar file open. Key: VFS-794 URL: https://issues.apache.org/jira/browse/VFS-794

[jira] [Commented] (VFS-592) ftp IPV6 URI always throws 550 Failed to change directory to Remote Root Directory

2021-02-26 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VFS-592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291832#comment-17291832 ] Gary D. Gregory commented on VFS-592: - Please try Commons VFS 2.7.0.   > ftp IPV6 URI always throws

[jira] [Commented] (DBCP-572) timed out connections remain active in the pool

2021-02-26 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291763#comment-17291763 ] Phil Steitz commented on DBCP-572: -- This is not a bug.  By default, the pool does not try to keep

[jira] [Updated] (DBCP-572) timed out connections remain active in the pool

2021-02-26 Thread Phil Steitz (Jira)
[ https://issues.apache.org/jira/browse/DBCP-572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phil Steitz updated DBCP-572: - Assignee: Phil Steitz > timed out connections remain active in the pool >

[jira] [Commented] (COMPRESS-567) IllegalArgumentException in ZipFile.positionAtCentralDirectory

2021-02-26 Thread Stefan Bodewig (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291742#comment-17291742 ] Stefan Bodewig commented on COMPRESS-567: - most likely we should be throwing {{IOExceptions}}

[jira] [Commented] (IO-295) FileUtils.isSymlinks misses symlink folders on Windows

2021-02-26 Thread Jira
[ https://issues.apache.org/jira/browse/IO-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291737#comment-17291737 ] Miłosz S commented on IO-295: - Please also note that on Windows there are symlinks AND "junctions":

[GitHub] [commons-pool] coveralls edited a comment on pull request #67: Implement AbandonedConfig for GenericKeyedObjectPool

2021-02-26 Thread GitBox
coveralls edited a comment on pull request #67: URL: https://github.com/apache/commons-pool/pull/67#issuecomment-786557207 [![Coverage Status](https://coveralls.io/builds/37483368/badge)](https://coveralls.io/builds/37483368) Coverage increased (+0.05%) to 84.201% when pulling

[GitHub] [commons-pool] JSurf commented on a change in pull request #67: Implement AbandonedConfig for GenericKeyedObjectPool

2021-02-26 Thread GitBox
JSurf commented on a change in pull request #67: URL: https://github.com/apache/commons-pool/pull/67#discussion_r583686761 ## File path: src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java ## @@ -267,6 +272,25 @@ public GenericKeyedObjectPool(final

[GitHub] [commons-pool] JSurf commented on a change in pull request #67: Implement AbandonedConfig for GenericKeyedObjectPool

2021-02-26 Thread GitBox
JSurf commented on a change in pull request #67: URL: https://github.com/apache/commons-pool/pull/67#discussion_r583686761 ## File path: src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java ## @@ -267,6 +272,25 @@ public GenericKeyedObjectPool(final

[GitHub] [commons-pool] JSurf commented on a change in pull request #67: Implement AbandonedConfig for GenericKeyedObjectPool

2021-02-26 Thread GitBox
JSurf commented on a change in pull request #67: URL: https://github.com/apache/commons-pool/pull/67#discussion_r583672713 ## File path: src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolMXBean.java ## @@ -91,6 +91,12 @@ */ boolean getLifo(); +

[GitHub] [commons-pool] JSurf commented on a change in pull request #67: Implement AbandonedConfig for GenericKeyedObjectPool

2021-02-26 Thread GitBox
JSurf commented on a change in pull request #67: URL: https://github.com/apache/commons-pool/pull/67#discussion_r583672713 ## File path: src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPoolMXBean.java ## @@ -91,6 +91,12 @@ */ boolean getLifo(); +

[GitHub] [commons-pool] coveralls edited a comment on pull request #67: Implement AbandonedConfig for GenericKeyedObjectPool

2021-02-26 Thread GitBox
coveralls edited a comment on pull request #67: URL: https://github.com/apache/commons-pool/pull/67#issuecomment-786557207 [![Coverage Status](https://coveralls.io/builds/37481680/badge)](https://coveralls.io/builds/37481680) Coverage decreased (-0.04%) to 84.106% when pulling

[jira] [Commented] (IO-663) FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows

2021-02-26 Thread Melloware (Jira)
[ https://issues.apache.org/jira/browse/IO-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291666#comment-17291666 ] Melloware commented on IO-663: -- [~ggregory] Yes it does.  Which would explain in the previous version our

[jira] [Commented] (IO-663) FileUtils.copyDirectory(File srcDir, File destDir) fails on Windows

2021-02-26 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/IO-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291662#comment-17291662 ] Gary D. Gregory commented on IO-663: [~melloware] This is starting to sounds like an access rights

[jira] [Commented] (DBCP-572) timed out connections remain active in the pool

2021-02-26 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/DBCP-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291653#comment-17291653 ] Gary D. Gregory commented on DBCP-572: -- May you provide a unit test PR on GitHub on top of git master?

[jira] [Commented] (VFS-793) GenericFileName.getURI() returns invalid URI.

2021-02-26 Thread Gary D. Gregory (Jira)
[ https://issues.apache.org/jira/browse/VFS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291651#comment-17291651 ] Gary D. Gregory commented on VFS-793: - Hi [~vnashkev] May you please try with git master to verify if

[jira] [Commented] (VFS-793) GenericFileName.getURI() returns invalid URI.

2021-02-26 Thread Woonsan Ko (Jira)
[ https://issues.apache.org/jira/browse/VFS-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291652#comment-17291652 ] Woonsan Ko commented on VFS-793: It looks like related to

[GitHub] [commons-pool] garydgregory commented on a change in pull request #67: Implement AbandonedConfig for GenericKeyedObjectPool

2021-02-26 Thread GitBox
garydgregory commented on a change in pull request #67: URL: https://github.com/apache/commons-pool/pull/67#discussion_r583644635 ## File path: src/main/java/org/apache/commons/pool2/impl/GenericKeyedObjectPool.java ## @@ -267,6 +272,25 @@ public GenericKeyedObjectPool(final

[jira] [Commented] (COMPRESS-565) Regression - Corrupted headers when using 64 bit ZipArchiveOutputStream

2021-02-26 Thread Evgenii Bovykin (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291585#comment-17291585 ] Evgenii Bovykin commented on COMPRESS-565: -- Any estimate on when this fix will be released?

[jira] [Work logged] (LANG-1444) NumberUtils.createNumber() does not create BigDecimal for decimal fractions tending to zero

2021-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1444?focusedWorklogId=558511=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558511 ] ASF GitHub Bot logged work on LANG-1444: Author: ASF GitHub Bot

[GitHub] [commons-lang] bndhanush commented on pull request #675: [LANG-1444] NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero

2021-02-26 Thread GitBox
bndhanush commented on pull request #675: URL: https://github.com/apache/commons-lang/pull/675#issuecomment-786579783 hi @garydgregory Thanks for the input. I added test case to ensure that precision is not lost and we maintain the value. Please validate the PR.

[GitHub] [commons-pool] coveralls commented on pull request #67: Implement AbandonedConfig for GenericKeyedObjectPool

2021-02-26 Thread GitBox
coveralls commented on pull request #67: URL: https://github.com/apache/commons-pool/pull/67#issuecomment-786557207 [![Coverage Status](https://coveralls.io/builds/37476495/badge)](https://coveralls.io/builds/37476495) Coverage decreased (-0.08%) to 84.066% when pulling

[jira] [Work logged] (LANG-1444) NumberUtils.createNumber() does not create BigDecimal for decimal fractions tending to zero

2021-02-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/LANG-1444?focusedWorklogId=558490=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-558490 ] ASF GitHub Bot logged work on LANG-1444: Author: ASF GitHub Bot

[GitHub] [commons-lang] coveralls edited a comment on pull request #675: [LANG-1444] NumberUtils.createNumber(), BigDecimal for decimal fractions tending to zero

2021-02-26 Thread GitBox
coveralls edited a comment on pull request #675: URL: https://github.com/apache/commons-lang/pull/675#issuecomment-745948308 [![Coverage Status](https://coveralls.io/builds/37476042/badge)](https://coveralls.io/builds/37476042) Coverage decreased (-0.1%) to 94.915% when pulling

[jira] [Created] (VFS-793) GenericFileName.getURI() returns invalid URI.

2021-02-26 Thread Vitali Nashkevich (Jira)
Vitali Nashkevich created VFS-793: - Summary: GenericFileName.getURI() returns invalid URI. Key: VFS-793 URL: https://issues.apache.org/jira/browse/VFS-793 Project: Commons VFS Issue Type:

[jira] [Commented] (COMPRESS-567) IllegalArgumentException in ZipFile.positionAtCentralDirectory

2021-02-26 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291491#comment-17291491 ] Peter Lee commented on COMPRESS-567: I see. Thank you for you explanation. >

[jira] [Commented] (COMPRESS-567) IllegalArgumentException in ZipFile.positionAtCentralDirectory

2021-02-26 Thread Fabian Meumertzheim (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291490#comment-17291490 ] Fabian Meumertzheim commented on COMPRESS-567: -- I found these bugs using

[jira] [Commented] (COMPRESS-567) IllegalArgumentException in ZipFile.positionAtCentralDirectory

2021-02-26 Thread Peter Lee (Jira)
[ https://issues.apache.org/jira/browse/COMPRESS-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291474#comment-17291474 ] Peter Lee commented on COMPRESS-567: Just curious about the test : how is the test file