[GitHub] commons-lang issue #282: SwappedPair constructed as Pair.of(rhs,lhs)

[namannigam]

Github user namannigam commented on the issue:

https://github.com/apache/commons-lang/pull/282
  
@kinow @garydgregory Sure would try to come back soon with a unit test for 
the use-case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request #282: SwappedPair constructed as Pair.of(rhs,lhs)

[namannigam]

GitHub user namannigam opened a pull request:

https://github.com/apache/commons-lang/pull/282

SwappedPair constructed as Pair.of(rhs,lhs)

There seems to be a bug in the current implementation of the `isRegistered` 
implementation, where the `swappedPair` is constructed similarly to the 
existing `pair` to check their existence in registry.

Source of finding - 
[StackOverflow#45603317](https://stackoverflow.com/questions/45603317/)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/namannigam/commons-lang master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-lang/pull/282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #282


commit 9cf2568f2429ad84469a09f2480effc47c0467ec
Author: namannigam <namanniga...@gmail.com>
Date:   2017-08-10T03:15:27Z

SwappedPair constructed as Pair.of(rhs,lhs)

commit 17bb505f2ab99f61b9fe99fb549df3dbdda957ff
Author: namannigam <namanniga...@gmail.com>
Date:   2017-08-10T03:19:37Z

Revert import format




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang issue #299: Add module-info for Java 9

[namannigam]

Github user namannigam commented on the issue:

https://github.com/apache/commons-lang/pull/299
  
@jodastephen What's the error that you get with site? Any links to the 
build?


---

[GitHub] commons-lang pull request #299: Add module-info for Java 9

[namannigam]

Github user namannigam commented on a diff in the pull request:

https://github.com/apache/commons-lang/pull/299#discussion_r147422522
  
--- Diff: src/main/java/module-info.java ---
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/**
+ * Apache Commons Lang provides utility classes for the core of Java.
+ */
+module org.apache.commons.lang3 {
+
+// see AbstractCircuitBreaker
+requires static java.desktop;
--- End diff --

a small difference and I am just curious to know, why is this not 
`transitive` which was what I saw using `jdeps --generate-module-info`?


---