[GitHub] commons-lang issue #189: new impl of LevenshteinDistance

Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/189 @yufcuy: Thanks for the pull request. :+1: @kinow: Thanks for the review. I have added the link and replaced tabs with spaces after merging. Feel free to change/improve

[GitHub] commons-lang issue #189: new impl of LevenshteinDistance

Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/189 Ack @PascalSchumacher after @yufcuy 's feedback we can merge it and include in 3.x releases, and then think where, and if, we should move text-related code :-) Thanks! --- If your

[GitHub] commons-lang issue #189: new impl of LevenshteinDistance

Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-lang/pull/189 @kinow I think this has to stay in lang. At least until lang 4. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] commons-lang issue #189: new impl of LevenshteinDistance

Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/189 Hi @yufcuy, Sorry for the delay to look into this. I looked at the first two implements this morning to refresh my memory. The first one creating the whole comparison table, and

[GitHub] commons-lang issue #189: new impl of LevenshteinDistance

Github user britter commented on the issue: https://github.com/apache/commons-lang/pull/189 @kinow can you take the lead in reviewing this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] commons-lang issue #189: new impl of LevenshteinDistance

Github user yufcuy commented on the issue: https://github.com/apache/commons-lang/pull/189 Hello, @britter @kinow The details of Levenshtein distance can be find at https://en.wikipedia.org/wiki/Levenshtein_distance, as it describe, the algorithm is compute a matrix to hold

[GitHub] commons-lang issue #189: new impl of LevenshteinDistance

Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/189 Though I also agree with @britter that some better description would help reviewing it :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] commons-lang issue #189: new impl of LevenshteinDistance

Github user kinow commented on the issue: https://github.com/apache/commons-lang/pull/189 I think string distances were the one of the first things we thought about moving to [text]. Might be interesting to discuss implementing - if it makes sense - this change there. --- If your

[GitHub] commons-lang issue #189: new impl of LevenshteinDistance

Github user britter commented on the issue: https://github.com/apache/commons-lang/pull/189 Hello @yufcuy, can you provide more information as to why you think this change is necessary? Does it improve performance properties? Do you have benchmarked the new implementation

[GitHub] commons-lang issue #189: new impl of LevenshteinDistance

Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/189 [](https://coveralls.io/builds/7859475) Coverage increased (+0.02%) to 93.592% when pulling

[GitHub] commons-lang issue #189: new impl of LevenshteinDistance

Github user coveralls commented on the issue: https://github.com/apache/commons-lang/pull/189 [](https://coveralls.io/builds/7859475) Coverage increased (+0.02%) to 93.592% when pulling