[GitHub] commons-lang pull request #299: Add module-info for Java 9

2018-09-29 Thread lploom
Github user lploom commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/299#discussion_r221431119 --- Diff: src/main/java/module-info.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] commons-lang pull request #299: Add module-info for Java 9

2017-10-30 Thread jodastephen
Github user jodastephen commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/299#discussion_r147859782 --- Diff: .travis.yml --- @@ -21,8 +21,19 @@ jdk: - oraclejdk8 - oraclejdk9 +cache: + directories: +-

[GitHub] commons-lang pull request #299: Add module-info for Java 9

2017-10-28 Thread PascalSchumacher
Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/299#discussion_r147560886 --- Diff: .travis.yml --- @@ -21,8 +21,19 @@ jdk: - oraclejdk8 - oraclejdk9 +cache: + directories: +-

[GitHub] commons-lang pull request #299: Add module-info for Java 9

2017-10-27 Thread jodastephen
Github user jodastephen commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/299#discussion_r147424665 --- Diff: src/main/java/module-info.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] commons-lang pull request #299: Add module-info for Java 9

2017-10-27 Thread namannigam
Github user namannigam commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/299#discussion_r147422522 --- Diff: src/main/java/module-info.java --- @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] commons-lang pull request #299: Add module-info for Java 9

2017-10-14 Thread britter
Github user britter commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/299#discussion_r144693421 --- Diff: .travis.yml --- @@ -17,12 +17,10 @@ language: java sudo: false jdk: - - openjdk7 --- End diff -- I think we

[GitHub] commons-lang pull request #299: Add module-info for Java 9

2017-10-11 Thread stokito
Github user stokito commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/299#discussion_r144134867 --- Diff: .travis.yml --- @@ -17,12 +17,10 @@ language: java sudo: false jdk: - - openjdk7 --- End diff -- Sounds sad

[GitHub] commons-lang pull request #299: Add module-info for Java 9

2017-10-11 Thread jodastephen
Github user jodastephen commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/299#discussion_r144119796 --- Diff: .travis.yml --- @@ -17,12 +17,10 @@ language: java sudo: false jdk: - - openjdk7 --- End diff -- With

[GitHub] commons-lang pull request #299: Add module-info for Java 9

2017-10-10 Thread stokito
Github user stokito commented on a diff in the pull request: https://github.com/apache/commons-lang/pull/299#discussion_r143869192 --- Diff: .travis.yml --- @@ -17,12 +17,10 @@ language: java sudo: false jdk: - - openjdk7 --- End diff -- Why did

[GitHub] commons-lang pull request #299: Add module-info for Java 9

2017-10-10 Thread jodastephen
GitHub user jodastephen opened a pull request: https://github.com/apache/commons-lang/pull/299 Add module-info for Java 9 Add the module-info.java file Make the appropriate changes to pom.xml You can merge this pull request into a Git repository by running: $ git pull