[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523007#comment-14523007
]
Thomas Neidhart commented on MATH-1153:
---
Thanks for the patch and your patience!
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523005#comment-14523005
]
Thomas Neidhart commented on MATH-1153:
---
Commited to 3.6 in commit
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14521084#comment-14521084
]
Thomas Neidhart commented on MATH-1153:
---
I was probably not very clear in my comment,
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522242#comment-14522242
]
Sergei Lebedev commented on MATH-1153:
--
Interesting, can you provide benchmark results
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522216#comment-14522216
]
Thomas Neidhart commented on MATH-1153:
---
Looking at the wikipedia page I found
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14522272#comment-14522272
]
Thomas Neidhart commented on MATH-1153:
---
I did not write a jmh benchmark yet, but it
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520038#comment-14520038
]
Thomas Neidhart commented on MATH-1153:
---
After fixing the KS inference tests the
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14520632#comment-14520632
]
Phil Steitz commented on MATH-1153:
---
See my comment above on the testNextInversionDeviate
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14297031#comment-14297031
]
Sergei Lebedev commented on MATH-1153:
--
I think KS-test failures might be related to
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249664#comment-14249664
]
Luc Maisonobe commented on MATH-1153:
-
In fact, I started incorporating the patch as an
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248928#comment-14248928
]
Luc Maisonobe commented on MATH-1153:
-
I have reworked the patch in order to integrate
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249095#comment-14249095
]
Thomas Neidhart commented on MATH-1153:
---
The same failures appear when using the
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249101#comment-14249101
]
Thomas Neidhart commented on MATH-1153:
---
btw. if the two method algorithmBB and
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249116#comment-14249116
]
Phil Steitz commented on MATH-1153:
---
The test failure is due to the fact that after the
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249124#comment-14249124
]
Phil Steitz commented on MATH-1153:
---
Sorry I did not comment on the goodness of fit
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156715#comment-14156715
]
Sergei Lebedev commented on MATH-1153:
--
Is the paper available online somewhere?
I've
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154567#comment-14154567
]
Sergei Lebedev commented on MATH-1153:
--
Is it alright if I submit a patch via a PR to
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154572#comment-14154572
]
Luc Maisonobe commented on MATH-1153:
-
There is a problem with the GitHub mirror
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153620#comment-14153620
]
Thomas Neidhart commented on MATH-1153:
---
Hi Sergei,
yes, please attach the patch so
[
https://issues.apache.org/jira/browse/MATH-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14153640#comment-14153640
]
Phil Steitz commented on MATH-1153:
---
Definitely looks like a big performance improvement.
20 matches
Mail list logo