[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=555440=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-555440 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 21/Feb/21 16:24 Start Date: 21/Feb/21 16:24 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/37305077) Coverage increased (+0.005%) to 94.962% when pulling **d9be6a31d523ecd6764951d961ab63c002e08640 on xenoamess-fork:split_regionMatches_for_better_performance** into **e233ab6b1464601341cc77ac489e9358aa45fbed on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 555440) Time Spent: 4h 40m (was: 4.5h) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Major > Time Spent: 4h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=555437=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-555437 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 21/Feb/21 16:17 Start Date: 21/Feb/21 16:17 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-782882822 @garydgregory rebased. please find some time to review. thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 555437) Time Spent: 4.5h (was: 4h 20m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Major > Time Spent: 4.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=451865=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-451865 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 27/Jun/20 11:22 Start Date: 27/Jun/20 11:22 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31722439) Coverage increased (+0.003%) to 94.678% when pulling **d1202c2b4ed43a1ab15f8ff669739455e1d10e38 on XenoAmess:split_regionMatches_for_better_performance** into **1621a23d2bd99df845abae0beea0add84135a49d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 451865) Time Spent: 4h 20m (was: 4h 10m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Major > Time Spent: 4h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=451862=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-451862 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 27/Jun/20 10:44 Start Date: 27/Jun/20 10:44 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31722292) Coverage increased (+0.005%) to 94.68% when pulling **d1202c2b4ed43a1ab15f8ff669739455e1d10e38 on XenoAmess:split_regionMatches_for_better_performance** into **1621a23d2bd99df845abae0beea0add84135a49d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 451862) Time Spent: 4h 10m (was: 4h) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Sub-task >Reporter: Jin Xu >Priority: Major > Time Spent: 4h 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=445556=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445556 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 14/Jun/20 10:11 Start Date: 14/Jun/20 10:11 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31440001) Coverage increased (+0.005%) to 95.033% when pulling **f0df6daaa0646264dd02229b47fb2f33b87d5fad on XenoAmess:split_regionMatches_for_better_performance** into **9fcd9c86edc05a0bd25f8eb73cf840400e5e6b95 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445556) Time Spent: 4h (was: 3h 50m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 4h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=445411=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445411 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 13/Jun/20 18:52 Start Date: 13/Jun/20 18:52 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31435229) Coverage decreased (-0.001%) to 95.021% when pulling **8603778f6d2f81bebb064ca97492bfcae0b5417a on XenoAmess:split_regionMatches_for_better_performance** into **496eb10372c0161eac4729e758d789357adfcc0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445411) Time Spent: 3h 50m (was: 3h 40m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 3h 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=445409=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445409 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 13/Jun/20 18:44 Start Date: 13/Jun/20 18:44 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-643661277 I have no idea why the travis-ci got "pending" here(for several days already). I will try to retrigger it, using some force-push things. `--` done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445409) Time Spent: 3h 40m (was: 3.5h) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=445407=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445407 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 13/Jun/20 18:43 Start Date: 13/Jun/20 18:43 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31435207) Coverage increased (+0.005%) to 95.027% when pulling **8603778f6d2f81bebb064ca97492bfcae0b5417a on XenoAmess:split_regionMatches_for_better_performance** into **496eb10372c0161eac4729e758d789357adfcc0f on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445407) Time Spent: 3h 20m (was: 3h 10m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=445408=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445408 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 13/Jun/20 18:43 Start Date: 13/Jun/20 18:43 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-643661277 I have no idea why the travis-ci got "pending" here(for several days already). I will try to retrigger it, using some force-push things. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445408) Time Spent: 3.5h (was: 3h 20m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=445405=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-445405 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 13/Jun/20 18:37 Start Date: 13/Jun/20 18:37 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-643661277 I have no idea why the travis-ci got "pending" here. I will try to retrigger it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 445405) Time Spent: 3h 10m (was: 3h) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: Jin Xu >Priority: Major > Time Spent: 3h 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=441876=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441876 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 05/Jun/20 15:14 Start Date: 05/Jun/20 15:14 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31265488) Coverage decreased (-0.001%) to 95.039% when pulling **2a1df0d0f7c3f754380f76b7157296eaca5e1a35 on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 441876) Time Spent: 3h (was: 2h 50m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 3h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[
https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=441844=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441844
]
ASF GitHub Bot logged work on LANG-1548:
Author: ASF GitHub Bot
Created on: 05/Jun/20 14:49
Start Date: 05/Jun/20 14:49
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#discussion_r435717449
##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -252,17 +252,58 @@ static int lastIndexOf(final CharSequence cs, final
CharSequence searchChar, fin
* Green implementation of regionMatches.
*
* @param cs the {@code CharSequence} to be processed
- * @param ignoreCase whether or not to be case insensitive
* @param thisStart the index to start on the {@code cs} CharSequence
* @param substring the {@code CharSequence} to be looked for
* @param start the index to start on the {@code substring} CharSequence
* @param length character length of the region
* @return whether the region matched
*/
-static boolean regionMatches(final CharSequence cs, final boolean
ignoreCase, final int thisStart,
-final CharSequence substring, final int start, final int length)
{
+static boolean regionMatches(final CharSequence cs, final int thisStart,
+ final CharSequence substring, final int
start, final int length){
+if (cs instanceof String && substring instanceof String) {
+return ((String) cs).regionMatches(thisStart, (String) substring,
start, length);
+}
+int index1 = thisStart;
+int index2 = start;
+int tmpLen = length;
+
+// Extract these first so we detect NPEs the same as the
java.lang.String version
+final int srcLen = cs.length() - thisStart;
+final int otherLen = substring.length() - start;
+
+// Check for invalid parameters
+if (thisStart < 0 || start < 0 || length < 0) {
+return false;
+}
+
+// Check that the regions are long enough
+if (srcLen < length || otherLen < length) {
+return false;
+}
+
+while (tmpLen-- > 0) {
Review comment:
@dota17
the `while (tmpLen-- > 0) {` is same as it in original codes.
I just want to make as less changes as possible.
If you think we should reformat the codes I feel like agreed, but lets' do
that after this pr, or at least, when merging this pr.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441844)
Time Spent: 2h 50m (was: 2h 40m)
> split regionMatches for better performance
> --
>
> Key: LANG-1548
> URL: https://issues.apache.org/jira/browse/LANG-1548
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: JIN XU
>Priority: Minor
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/534/files]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[
https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=441838=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441838
]
ASF GitHub Bot logged work on LANG-1548:
Author: ASF GitHub Bot
Created on: 05/Jun/20 14:41
Start Date: 05/Jun/20 14:41
Worklog Time Spent: 10m
Work Description: XenoAmess commented on pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#issuecomment-639538491
result json:
```
[
{
"jmhVersion" : "1.21",
"benchmark" :
"org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0New",
"mode" : "avgt",
"threads" : 1,
"forks" : 5,
"jvm" : "C:\\jdk-13.0.2+8\\bin\\java.exe",
"jvmArgs" : [
],
"jdkVersion" : "13.0.2",
"vmName" : "OpenJDK 64-Bit Server VM",
"vmVersion" : "13.0.2+8",
"warmupIterations" : 5,
"warmupTime" : "10 s",
"warmupBatchSize" : 1,
"measurementIterations" : 5,
"measurementTime" : "10 s",
"measurementBatchSize" : 1,
"primaryMetric" : {
"score" : 2455031.50487269,
"scoreError" : 82596.43118906298,
"scoreConfidence" : [
2372435.073683627,
2537627.936061753
],
"scorePercentiles" : {
"0.0" : 2299801.7932858127,
"50.0" : 2442310.061050061,
"90.0" : 2638215.5304203783,
"95.0" : 2652540.041246207,
"99.0" : 2653839.453435925,
"99.9" : 2653839.453435925,
"99.99" : 2653839.453435925,
"99.999" : 2653839.453435925,
"99." : 2653839.453435925,
"100.0" : 2653839.453435925
},
"scoreUnit" : "ns/op",
"rawData" : [
[
2461469.0622692592,
2442310.061050061,
2427010.385828682,
2421185.7661583154,
2419471.335268505
],
[
2451503.3578431373,
2598355.2091452326,
2466372.503082614,
2653839.453435925,
2618707.4083769633
],
[
2476611.1906412477,
2419733.68037745,
2508645.0714823175,
2410321.065075922,
2649508.0794701986
],
[
2305189.6752707995,
2347030.7604411077,
2299801.7932858127,
235.214766659,
2303393.0234860694
],
[
2320520.784040826,
2630687.1643871646,
2464871.97044335,
2541760.457433291,
2415263.148756339
]
]
},
"secondaryMetrics" : {
}
},
{
"jmhVersion" : "1.21",
"benchmark" :
"org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0NewInline",
"mode" : "avgt",
"threads" : 1,
"forks" : 5,
"jvm" : "C:\\jdk-13.0.2+8\\bin\\java.exe",
"jvmArgs" : [
],
"jdkVersion" : "13.0.2",
"vmName" : "OpenJDK 64-Bit Server VM",
"vmVersion" : "13.0.2+8",
"warmupIterations" : 5,
"warmupTime" : "10 s",
"warmupBatchSize" : 1,
"measurementIterations" : 5,
"measurementTime" : "10 s",
"measurementBatchSize" : 1,
"primaryMetric" : {
"score" : 2210111.711287217,
"scoreError" : 61020.04598156867,
"scoreConfidence" : [
2149091.6653056485,
2271131.757268786
],
"scorePercentiles" : {
"0.0" : 2087501.3358380296,
"50.0" : 2180778.613472858,
"90.0" : 2341613.3640486645,
"95.0" : 2410693.9690793087,
"99.0" : 2411927.9893924785,
"99.9" : 2411927.9893924785,
"99.99" : 2411927.9893924785,
"99.999" : 2411927.9893924785,
"99." : 2411927.9893924785,
"100.0" : 2411927.9893924785
},
"scoreUnit" : "ns/op",
"rawData" : [
[
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=441837=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441837 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 05/Jun/20 14:40 Start Date: 05/Jun/20 14:40 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-639537791 I refined the test source, and give it a retest. **result:** ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjd k/jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0New # Run progress: 0.00% complete, ETA 01:15:00 # Fork: 1 of 5 # Warmup Iteration 1: 2891811.998 ns/op # Warmup Iteration 2: 2416673.665 ns/op # Warmup Iteration 3: 2446011.030 ns/op # Warmup Iteration 4: 2449321.915 ns/op # Warmup Iteration 5: 2447740.822 ns/op Iteration 1: 2461469.062 ns/op Iteration 2: 2442310.061 ns/op Iteration 3: 2427010.386 ns/op Iteration 4: 2421185.766 ns/op Iteration 5: 2419471.335 ns/op # Run progress: 2.22% complete, ETA 01:13:53 # Fork: 2 of 5 # Warmup Iteration 1: 2273738.841 ns/op # Warmup Iteration 2: 2401915.102 ns/op # Warmup Iteration 3: 2480256.930 ns/op # Warmup Iteration 4: 2456014.980 ns/op # Warmup Iteration 5: 2500686.453 ns/op Iteration 1: 2451503.358 ns/op Iteration 2: 2598355.209 ns/op Iteration 3: 2466372.503 ns/op Iteration 4: 2653839.453 ns/op Iteration 5: 2618707.408 ns/op # Run progress: 4.44% complete, ETA 01:12:09 # Fork: 3 of 5 # Warmup Iteration 1: 2280302.941 ns/op # Warmup Iteration 2: 2384730.465 ns/op # Warmup Iteration 3: 2482601.067 ns/op # Warmup Iteration 4: 2622762.795 ns/op # Warmup Iteration 5: 2478504.832 ns/op Iteration 1: 2476611.191 ns/op Iteration 2: 2419733.680 ns/op Iteration 3: 2508645.071 ns/op Iteration 4: 2410321.065 ns/op Iteration 5: 2649508.079 ns/op # Run progress: 6.67% complete, ETA 01:10:25 # Fork: 4 of 5 # Warmup Iteration 1: 2305637.137 ns/op # Warmup Iteration 2: 2450478.780 ns/op # Warmup Iteration 3: 2397859.012 ns/op # Warmup Iteration 4: 2389567.344 ns/op # Warmup Iteration 5: 2431105.348 ns/op Iteration 1: 2305189.675 ns/op Iteration 2: 2347030.760 ns/op Iteration 3: 2299801.793 ns/op Iteration 4: 235.215 ns/op Iteration 5: 2303393.023 ns/op # Run progress: 8.89% complete, ETA 01:08:45 # Fork: 5 of 5 # Warmup Iteration 1: 2160220.039 ns/op # Warmup Iteration 2: 2265527.588 ns/op # Warmup Iteration 3: 2314211.754 ns/op # Warmup Iteration 4: 2296356.211 ns/op # Warmup Iteration 5: 2309983.141 ns/op Iteration 1: 2320520.784 ns/op Iteration 2: 2630687.164 ns/op Iteration 3: 2464871.970 ns/op Iteration 4: 2541760.457 ns/op Iteration 5: 2415263.149 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0New": 2455031.505 ?99.9%) 82596.431 ns/op [Average] (min, avg, max) = (2299801.793, 2455031.505, 2653839.453), stdev = 110263.873 CI (99.9%): [2372435.074, 2537627.936] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.test0NewInline # Run progress: 11.11% complete, ETA 01:07:03 # Fork: 1 of 5 # Warmup Iteration 1: 2033885.418 ns/op # Warmup Iteration 2: 2050448.032 ns/op # Warmup Iteration 3:
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[
https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=441705=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441705
]
ASF GitHub Bot logged work on LANG-1548:
Author: ASF GitHub Bot
Created on: 05/Jun/20 06:37
Start Date: 05/Jun/20 06:37
Worklog Time Spent: 10m
Work Description: XenoAmess commented on a change in pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#discussion_r435717449
##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -252,17 +252,58 @@ static int lastIndexOf(final CharSequence cs, final
CharSequence searchChar, fin
* Green implementation of regionMatches.
*
* @param cs the {@code CharSequence} to be processed
- * @param ignoreCase whether or not to be case insensitive
* @param thisStart the index to start on the {@code cs} CharSequence
* @param substring the {@code CharSequence} to be looked for
* @param start the index to start on the {@code substring} CharSequence
* @param length character length of the region
* @return whether the region matched
*/
-static boolean regionMatches(final CharSequence cs, final boolean
ignoreCase, final int thisStart,
-final CharSequence substring, final int start, final int length)
{
+static boolean regionMatches(final CharSequence cs, final int thisStart,
+ final CharSequence substring, final int
start, final int length){
+if (cs instanceof String && substring instanceof String) {
+return ((String) cs).regionMatches(thisStart, (String) substring,
start, length);
+}
+int index1 = thisStart;
+int index2 = start;
+int tmpLen = length;
+
+// Extract these first so we detect NPEs the same as the
java.lang.String version
+final int srcLen = cs.length() - thisStart;
+final int otherLen = substring.length() - start;
+
+// Check for invalid parameters
+if (thisStart < 0 || start < 0 || length < 0) {
+return false;
+}
+
+// Check that the regions are long enough
+if (srcLen < length || otherLen < length) {
+return false;
+}
+
+while (tmpLen-- > 0) {
Review comment:
the `while (tmpLen-- > 0) {` is same as it in original codes.
I just want to make as less changes as possible.
If you think we should reformat the codes I feel like agreed, but lets' do
that after this pr, or at least, when merging this pr.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441705)
Time Spent: 2h 20m (was: 2h 10m)
> split regionMatches for better performance
> --
>
> Key: LANG-1548
> URL: https://issues.apache.org/jira/browse/LANG-1548
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: JIN XU
>Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/534/files]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[
https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=441627=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-441627
]
ASF GitHub Bot logged work on LANG-1548:
Author: ASF GitHub Bot
Created on: 05/Jun/20 01:39
Start Date: 05/Jun/20 01:39
Worklog Time Spent: 10m
Work Description: dota17 commented on a change in pull request #534:
URL: https://github.com/apache/commons-lang/pull/534#discussion_r435644787
##
File path: src/main/java/org/apache/commons/lang3/CharSequenceUtils.java
##
@@ -252,17 +252,58 @@ static int lastIndexOf(final CharSequence cs, final
CharSequence searchChar, fin
* Green implementation of regionMatches.
*
* @param cs the {@code CharSequence} to be processed
- * @param ignoreCase whether or not to be case insensitive
* @param thisStart the index to start on the {@code cs} CharSequence
* @param substring the {@code CharSequence} to be looked for
* @param start the index to start on the {@code substring} CharSequence
* @param length character length of the region
* @return whether the region matched
*/
-static boolean regionMatches(final CharSequence cs, final boolean
ignoreCase, final int thisStart,
-final CharSequence substring, final int start, final int length)
{
+static boolean regionMatches(final CharSequence cs, final int thisStart,
+ final CharSequence substring, final int
start, final int length){
+if (cs instanceof String && substring instanceof String) {
+return ((String) cs).regionMatches(thisStart, (String) substring,
start, length);
+}
+int index1 = thisStart;
+int index2 = start;
+int tmpLen = length;
+
+// Extract these first so we detect NPEs the same as the
java.lang.String version
+final int srcLen = cs.length() - thisStart;
+final int otherLen = substring.length() - start;
+
+// Check for invalid parameters
+if (thisStart < 0 || start < 0 || length < 0) {
+return false;
+}
+
+// Check that the regions are long enough
+if (srcLen < length || otherLen < length) {
+return false;
+}
+
+while (tmpLen-- > 0) {
Review comment:
while (tmpLen -- > 0) {
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 441627)
Time Spent: 2h 10m (was: 2h)
> split regionMatches for better performance
> --
>
> Key: LANG-1548
> URL: https://issues.apache.org/jira/browse/LANG-1548
> Project: Commons Lang
> Issue Type: Improvement
>Reporter: JIN XU
>Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/534/files]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439889=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439889 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 04:41 Start Date: 02/Jun/20 04:41 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31176899) Coverage increased (+0.005%) to 95.046% when pulling **2a1dc56c6a2c77fc1e26e1962da787d7b0dc48e4 on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439889) Time Spent: 2h (was: 1h 50m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 2h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439871=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439871 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 03:27 Start Date: 02/Jun/20 03:27 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31175823) Coverage decreased (-0.02%) to 95.02% when pulling **d53bb278a576521ccc800c0303f459978b25dbee on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439871) Time Spent: 1h 50m (was: 1h 40m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1h 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439866=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439866 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 02:56 Start Date: 02/Jun/20 02:56 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 @garydgregory **Conclusion:** after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark:
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439861=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439861 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 02:48 Start Date: 02/Jun/20 02:48 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 solution: after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testOld
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439862=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439862 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 02:48 Start Date: 02/Jun/20 02:48 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 @garydgregory solution: after doing the splition, it can speed up around 25%. ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark:
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439860=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439860 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 02:46 Start Date: 02/Jun/20 02:46 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-637236609 ``` [INFO] --- exec-maven-plugin:1.6.0:exec (benchmark) @ commons-lang3 --- WARNING: An illegal reflective access operation has occurred WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/C:/Users/xenoa/.m2/repository/org/openjdk /jmh/jmh-core/1.21/jmh-core-1.21.jar) to field java.io.PrintStream.charOut WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations WARNING: All illegal access operations will be denied in a future release # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew # Run progress: 0.00% complete, ETA 00:50:00 # Fork: 1 of 5 # Warmup Iteration 1: 1676780966.667 ns/op # Warmup Iteration 2: 1771491016.667 ns/op # Warmup Iteration 3: 1581506185.714 ns/op # Warmup Iteration 4: 2056147750.000 ns/op # Warmup Iteration 5: 1432607457.143 ns/op Iteration 1: 1810178866.667 ns/op Iteration 2: 1446362657.143 ns/op Iteration 3: 1748144866.667 ns/op Iteration 4: 1605476071.429 ns/op Iteration 5: 1794209950.000 ns/op # Run progress: 3.33% complete, ETA 00:52:22 # Fork: 2 of 5 # Warmup Iteration 1: 1511623771.429 ns/op # Warmup Iteration 2: 1495295371.429 ns/op # Warmup Iteration 3: 1495742928.571 ns/op # Warmup Iteration 4: 1722803700.000 ns/op # Warmup Iteration 5: 1482953414.286 ns/op Iteration 1: 1745675116.667 ns/op Iteration 2: 1611334828.571 ns/op Iteration 3: 1673340485.714 ns/op Iteration 4: 1357552837.500 ns/op Iteration 5: 1564756800.000 ns/op # Run progress: 6.67% complete, ETA 00:50:36 # Fork: 3 of 5 # Warmup Iteration 1: 1717714433.333 ns/op # Warmup Iteration 2: 1775668516.667 ns/op # Warmup Iteration 3: 1762111866.667 ns/op # Warmup Iteration 4: 2135332980.000 ns/op # Warmup Iteration 5: 1715229116.667 ns/op Iteration 1: 1966963233.333 ns/op Iteration 2: 2031982040.000 ns/op Iteration 3: 1813285066.667 ns/op Iteration 4: 1934091583.333 ns/op Iteration 5: 1990891316.667 ns/op # Run progress: 10.00% complete, ETA 00:49:03 # Fork: 4 of 5 # Warmup Iteration 1: 1637729900.000 ns/op # Warmup Iteration 2: 2080932760.000 ns/op # Warmup Iteration 3: 1770361200.000 ns/op # Warmup Iteration 4: 1370627400.000 ns/op # Warmup Iteration 5: 1629913900.000 ns/op Iteration 1: 2002821900.000 ns/op Iteration 2: 1841407766.667 ns/op Iteration 3: 1609561685.714 ns/op Iteration 4: 1557553557.143 ns/op Iteration 5: 1677166966.667 ns/op # Run progress: 13.33% complete, ETA 00:47:13 # Fork: 5 of 5 # Warmup Iteration 1: 1319836937.500 ns/op # Warmup Iteration 2: 1540287771.429 ns/op # Warmup Iteration 3: 1593160257.143 ns/op # Warmup Iteration 4: 1546483685.714 ns/op # Warmup Iteration 5: 1543815542.857 ns/op Iteration 1: 1682335566.667 ns/op Iteration 2: 1566039728.571 ns/op Iteration 3: 1694355566.667 ns/op Iteration 4: 1599394871.429 ns/op Iteration 5: 1757485850.000 ns/op Result "org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testNew": 1723294767.195 ?99.9%) 131123557.188 ns/op [Average] (min, avg, max) = (1357552837.500, 1723294767.195, 2031982040.000), stdev = 175046197.369 CI (99.9%): [1592171210.007, 1854418324.383] (assumes normal distribution) # JMH version: 1.21 # VM version: JDK 13.0.2, OpenJDK 64-Bit Server VM, 13.0.2+8 # VM invoker: C:\jdk-13.0.2+8\bin\java.exe # VM options: # Warmup: 5 iterations, 10 s each # Measurement: 5 iterations, 10 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Average time, time/op # Benchmark: org.apache.commons.lang3.CharSequenceUtilsRegionMatchesTest.testOld # Run progress: 16.67% complete, ETA 00:45:19 # Fork: 1 of 5 # Warmup
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439857=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439857 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 02/Jun/20 02:24 Start Date: 02/Jun/20 02:24 Worklog Time Spent: 10m Work Description: coveralls edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31174768) Coverage decreased (-0.008%) to 95.033% when pulling **28d71a13d15420eb268bd86bf3610433a9e9bf80 on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439857) Time Spent: 1h (was: 50m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 1h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439585=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439585 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 01/Jun/20 16:15 Start Date: 01/Jun/20 16:15 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636959596 Hi. According to `72 Hour Lazy Consensus` rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means spliting more functions in StringUtils including startsWith, endsWith and so on. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439585) Time Spent: 50m (was: 40m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 50m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439584=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439584 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 01/Jun/20 16:15 Start Date: 01/Jun/20 16:15 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636959596 Hi. According to 72 Hour Lazy Consensus rule, if nobody against this pr, I will continue developing codes about this pr in 50 hours later, means spliting more functions in StringUtils including startsWith, endsWith and so on. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439584) Time Spent: 40m (was: 0.5h) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439297=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439297 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 31/May/20 22:26 Start Date: 31/May/20 22:26 Worklog Time Spent: 10m Work Description: XenoAmess commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636539583 also want to split StringUtils.startswith, endwith, prependIfMissing... now the call flow is like this: 1. user call startsWith(final CharSequence str, final CharSequence prefix) 2. give an additional boolean, and invoke startsWith(final CharSequence str, final CharSequence prefix, final boolean ignoreCase) 3. invoke CharSequenceUtils.regionMatches(str, ignoreCase, 0, prefix, 0, prefix.length()); 4. in CharSequenceUtils.regionMatches(str, ignoreCase, 0, prefix, 0, prefix.length()) we detect that boolean. That is, actually weird, as when we call startsWith(final CharSequence str, final CharSequence prefix) we know the boolean is false, and we still fill a false boolean and let it detect at runtime. But, detecting a boolean is not a big performance issue (if not in a loop and perform tons of times) So I leave it unchanged for next pr. We can discuss whether should split regionMatches first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439297) Time Spent: 20m (was: 10m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439298=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439298 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 31/May/20 22:26 Start Date: 31/May/20 22:26 Worklog Time Spent: 10m Work Description: XenoAmess edited a comment on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636539583 also want to split StringUtils.startswith, endwith, prependIfMissing... now the call flow is like this: 1. user call startsWith(final CharSequence str, final CharSequence prefix) 2. give an additional boolean, and invoke startsWith(final CharSequence str, final CharSequence prefix, final boolean ignoreCase) 3. invoke CharSequenceUtils.regionMatches(str, ignoreCase, 0, prefix, 0, prefix.length()); 4. in CharSequenceUtils.regionMatches(str, ignoreCase, 0, prefix, 0, prefix.length()) we detect that boolean. That is, actually weird, as when we call startsWith(final CharSequence str, final CharSequence prefix) we know the boolean is false, and we still fill a false boolean and let it detect at runtime. But, detecting a boolean is not a big performance issue (if not in a loop and perform tons of times) So I leave it unchanged for next pr. We can discuss whether should split regionMatches first. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439298) Time Spent: 0.5h (was: 20m) > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 0.5h > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (LANG-1548) split regionMatches for better performance
[ https://issues.apache.org/jira/browse/LANG-1548?focusedWorklogId=439292=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439292 ] ASF GitHub Bot logged work on LANG-1548: Author: ASF GitHub Bot Created on: 31/May/20 21:15 Start Date: 31/May/20 21:15 Worklog Time Spent: 10m Work Description: coveralls commented on pull request #534: URL: https://github.com/apache/commons-lang/pull/534#issuecomment-636531146 [](https://coveralls.io/builds/31146797) Coverage decreased (-0.008%) to 95.033% when pulling **52e35c872c7fa0a58afcd8c7738bdbba98ae4e7d on XenoAmess:split_regionMatches_for_better_performance** into **3d4ed4a8ac63db1e51601ffc31fed44dccbb276c on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 439292) Remaining Estimate: 0h Time Spent: 10m > split regionMatches for better performance > -- > > Key: LANG-1548 > URL: https://issues.apache.org/jira/browse/LANG-1548 > Project: Commons Lang > Issue Type: Improvement >Reporter: JIN XU >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > [https://github.com/apache/commons-lang/pull/534/files] -- This message was sent by Atlassian Jira (v8.3.4#803005)
