[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338767#comment-16338767
 ] 

ASF GitHub Bot commented on CB-13415:
-

alpesh12 commented on issue #309: CB-13415 (android)(iOS) Importing corrupt 
images using the Camera plugin c…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/309#issuecomment-360368900
 
 
   @jcesarmobile 
   Removed iOS code from this PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Importing corrupt images using the Camera plugin crashes the app
> 
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>Reporter: Shemrick Flannigan
>Priority: Critical
>  Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the 
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the 
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error 
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app | 
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner 
> class to prevent an app crash | 
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] 
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera 
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338392#comment-16338392
 ] 

ASF GitHub Bot commented on CB-13392:
-

purplecabbage commented on issue #148: CB-13392(Android & iOS): Display app 
version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-360305086
 
 
   This is how you attach an image to a comment ...
   
   
![35361925-1c20836a-0118-11e8-86e0-21b04057f5f1](https://user-images.githubusercontent.com/46134/35361964-48f332e8-0118-11e8-927d-33ff23a5e29f.png)
   
   Please remove the file from your pr.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338357#comment-16338357
 ] 

ASF GitHub Bot commented on CB-13415:
-

jcesarmobile commented on issue #309: CB-13415 (android)(iOS) Importing corrupt 
images using the Camera plugin c…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/309#issuecomment-360297347
 
 
   I would keep the iOS and the Android parts separated (i.e. creating a new 
issue for iOS and removing the iOS code from this PR, and then send a new PR 
with the iOS code)
   I don't really like the iOS approach, there are probably better solutions 
than using ALAssetsLibrary. Also the possible errors are just being logged, but 
not returned to the user.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Importing corrupt images using the Camera plugin crashes the app
> 
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>Reporter: Shemrick Flannigan
>Priority: Critical
>  Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the 
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the 
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error 
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app | 
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner 
> class to prevent an app crash | 
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] 
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera 
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338352#comment-16338352
 ] 

ASF GitHub Bot commented on CB-13392:
-

purplecabbage commented on issue #148: CB-13392(Android & iOS): Display app 
version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-360296648
 
 
   github will let you add an image to the pr discussion thread
   
   
   @purplecabbage
   risingj.com
   
   On Wed, Jan 24, 2018 at 2:25 PM, Jonathan Corral 
   wrote:
   
   > *@johnlejardinnier* commented on this pull request.
   > --
   >
   > In README.md
   > 

   > :
   >
   > > +
   > +Now just configure your app version into the widget version attribute, 
like that :
   > +```xml
   > +...
   > +```
   > +
   > +
   > +## Prefix app version
   > +To set a prefix version add the following preference to `config.xml`:
   > +```xml
   > +
   > +```
   > +In this case you'll have `v1.0`
   > +
   > +
   > +## Customize app version
   >
   > For the screenshot, could i commit picture into the repo ?
   > Or i need to upload file on the web ?
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338338#comment-16338338
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163698117
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
+```xml
+...
+```
+
+
+## Prefix app version
+To set a prefix version add the following preference to `config.xml`:
+```xml
+
+```
+In this case you'll have `v1.0`
+
+
+## Customize app version
 
 Review comment:
   For the screenshot, could i commit picture into the repo ?
   Or i need to upload file on the web ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338339#comment-16338339
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163698117
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
+```xml
+...
+```
+
+
+## Prefix app version
+To set a prefix version add the following preference to `config.xml`:
+```xml
+
+```
+In this case you'll have `v1.0`
+
+
+## Customize app version
 
 Review comment:
   For the screenshot, could i commit picture into the repo ?
   Or do i need to upload file on the web ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338315#comment-16338315
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163695000
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
 
 Review comment:
   okay, thanks


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13826) Plugins Release Jan 24, 2018

2018-01-24 Thread Suraj Pindoria (JIRA) 
Suraj Pindoria created CB-13826:
---

 Summary: Plugins Release Jan 24, 2018
 Key: CB-13826
 URL: https://issues.apache.org/jira/browse/CB-13826
 Project: Apache Cordova
  Issue Type: Task
Reporter: Suraj Pindoria
Assignee: Suraj Pindoria


Following steps at 
[https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338282#comment-16338282
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163688650
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
 
 Review comment:
   Sorry, I was not very clear:
   You write as if it was optional to configure the `version` attribute in 
`widget`, but as you wrote in your answer yourself this is required anyway - so 
you should reword your text so this matches this reality.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338276#comment-16338276
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163687942
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
 
 Review comment:
   Sorry, I was not very clear:


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338277#comment-16338277
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163687942
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
 
 Review comment:
   Sorry, I was not very clear:


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338272#comment-16338272
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163686411
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
 
 Review comment:
   I'm not sure to understand this part : `Is there a way to not do that?`
   
   The widget `version` attribute is required (cf. 
https://cordova.apache.org/docs/en/latest/config_ref/index.html).
   
   So, if i remove preference `ShowSplashScreenAppVersion`, the app version 
will be always displayed on splashscreen.
   Some users don't want this behaviour.
   
   What would i mean in the doc is that you need to add this preference to 
enable display app version.
   
   If i'm wrong, do not hesitate to be more explicit ;)
   Sorry, i need to improve my english.
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338212#comment-16338212
 ] 

ASF GitHub Bot commented on CB-13392:
-

johnlejardinnier commented on issue #148: CB-13392(Android & iOS): Display app 
version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-360272175
 
 
   Thanks all for your time and reviews :)
   For the moment i will update docs, following @janpio suggestions.
   So you will be able to merge this PR.
   Then when i will have some time, i will try to improve compatibility for 
Windows as asked.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Closed] (CB-13791) Add Android support for a footer close button.

2018-01-24 Thread Joe Bowser (JIRA) 

 [ 
https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser closed CB-13791.
---
Resolution: Fixed

> Add Android support for a footer close button.
> --
>
> Key: CB-13791
> URL: https://issues.apache.org/jira/browse/CB-13791
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: Android
>Reporter: Dave Alden
>Priority: Minor
>  Labels: features, newbie
>
> Extending the work done in [PR 
> #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under 
> CB-13409, this adds support to Android for a footer close button similar to 
> the "Done" button on iOS.
> The following options are added for Android:
>  * *footer* - set to "yes" to show a close button in the footer similar to 
> the iOS "Done" button.
>  The close button will appear the same as for the header hence use 
> _closebuttoncaption_ and _closebuttoncolor_ to set its properties.
>  * *footercolor* - set to a valid hex color string, for example #00ff00 or 
> #CC00ff00 (#aarrggbb) , and it will change the footer color from default. 
> Only has effect if user has _footer_ set to "yes".
> Here are some example screenshots with the relevant options:
> _location=yes,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300!
> _location=no,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300!
> _location=yes,footer=yes,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300!
> _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300!
> _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300!
> _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300!
> _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_
>  
> !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13791) Add Android support for a footer close button.

2018-01-24 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337969#comment-16337969
 ] 

ASF subversion and git services commented on CB-13791:
--

Commit b73ba93884dcaa88429aae6e4ea6d117effae7d2 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=b73ba93 
]

CB-13791: Add Android support for a footer close button


> Add Android support for a footer close button.
> --
>
> Key: CB-13791
> URL: https://issues.apache.org/jira/browse/CB-13791
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: Android
>Reporter: Dave Alden
>Priority: Minor
>  Labels: features, newbie
>
> Extending the work done in [PR 
> #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under 
> CB-13409, this adds support to Android for a footer close button similar to 
> the "Done" button on iOS.
> The following options are added for Android:
>  * *footer* - set to "yes" to show a close button in the footer similar to 
> the iOS "Done" button.
>  The close button will appear the same as for the header hence use 
> _closebuttoncaption_ and _closebuttoncolor_ to set its properties.
>  * *footercolor* - set to a valid hex color string, for example #00ff00 or 
> #CC00ff00 (#aarrggbb) , and it will change the footer color from default. 
> Only has effect if user has _footer_ set to "yes".
> Here are some example screenshots with the relevant options:
> _location=yes,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300!
> _location=no,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300!
> _location=yes,footer=yes,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300!
> _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300!
> _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300!
> _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300!
> _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_
>  
> !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13791) Add Android support for a footer close button.

2018-01-24 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337970#comment-16337970
 ] 

ASF subversion and git services commented on CB-13791:
--

Commit 98ee2e148cd98a6e0b627b9b92f2e03efd9e00c5 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~bowserj]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=98ee2e1 
]

Merge pull request #258 from dpa99c/CB-13791

CB-13791: (android) Add Android support for a footer close button

> Add Android support for a footer close button.
> --
>
> Key: CB-13791
> URL: https://issues.apache.org/jira/browse/CB-13791
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: Android
>Reporter: Dave Alden
>Priority: Minor
>  Labels: features, newbie
>
> Extending the work done in [PR 
> #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under 
> CB-13409, this adds support to Android for a footer close button similar to 
> the "Done" button on iOS.
> The following options are added for Android:
>  * *footer* - set to "yes" to show a close button in the footer similar to 
> the iOS "Done" button.
>  The close button will appear the same as for the header hence use 
> _closebuttoncaption_ and _closebuttoncolor_ to set its properties.
>  * *footercolor* - set to a valid hex color string, for example #00ff00 or 
> #CC00ff00 (#aarrggbb) , and it will change the footer color from default. 
> Only has effect if user has _footer_ set to "yes".
> Here are some example screenshots with the relevant options:
> _location=yes,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300!
> _location=no,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300!
> _location=yes,footer=yes,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300!
> _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300!
> _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300!
> _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300!
> _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_
>  
> !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13791) Add Android support for a footer close button.

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337968#comment-16337968
 ] 

ASF GitHub Bot commented on CB-13791:
-

infil00p closed pull request #258: CB-13791: (android) Add Android support for 
a footer close button
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/258
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 7a2ec96a..936f1dce 100644
--- a/README.md
+++ b/README.md
@@ -112,9 +112,13 @@ instance, or the system browser.
 - __hidden__: set to `yes` to create the browser and load the page, but 
not show it. The loadstop event fires when loading is complete. Omit or set to 
`no` (default) to have the browser open and load normally.
 - __clearcache__: set to `yes` to have the browser's cookie cache cleared 
before the new window is opened
 - __clearsessioncache__: set to `yes` to have the session cookie cache 
cleared before the new window is opened
-- __closebuttoncaption__: set to a string to use as the close buttons 
caption instead of a X. Note that you need to localize this value yourself.
+- __closebuttoncaption__: set to a string to use as the close button's 
caption instead of a X. Note that you need to localize this value yourself.
 - __closebuttoncolor__: set to a valid hex color string, for example: 
`#00ff00`, and it will change the
 close button color from default, regardless of being a text or default X. 
Only has effect if user has location set to `yes`.
+- __footer__: set to `yes` to show a close button in the footer similar to 
the iOS __Done__ button. 
+The close button will appear the same as for the header hence use 
__closebuttoncaption__ and __closebuttoncolor__ to set its properties.
+- __footercolor__: set to a valid hex color string, for example `#00ff00` 
or `#CC00ff00` (`#aarrggbb`) , and it will change the footer color from default.
+Only has effect if user has __footer__ set to `yes`.
 - __hardwareback__: set to `yes` to use the hardware back button to 
navigate backwards through the `InAppBrowser`'s history. If there is no 
previous page, the `InAppBrowser` will close.  The default value is `yes`, so 
you must set it to `no` if you want the back button to simply close the 
InAppBrowser.
 - __hidenavigationbuttons__: set to `yes` to hide the navigation buttons 
on the location toolbar, only has effect if user has location set to `yes`. The 
default value is `no`.
 - __hideurlbar__: set to `yes` to hide the url bar on the location 
toolbar, only has effect if user has location set to `yes`. The default value 
is `no`.
diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index 8f937fb7..2b0dbe0f 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -103,8 +103,10 @@ Licensed to the Apache Software Foundation (ASF) under one
 private static final String HIDE_NAVIGATION = "hidenavigationbuttons";
 private static final String NAVIGATION_COLOR = "navigationbuttoncolor";
 private static final String HIDE_URL = "hideurlbar";
+private static final String FOOTER = "footer";
+private static final String FOOTER_COLOR = "footercolor";
 
-private static final List customizableOptions = 
Arrays.asList(CLOSE_BUTTON_CAPTION, TOOLBAR_COLOR, NAVIGATION_COLOR, 
CLOSE_BUTTON_COLOR);
+private static final List customizableOptions = 
Arrays.asList(CLOSE_BUTTON_CAPTION, TOOLBAR_COLOR, NAVIGATION_COLOR, 
CLOSE_BUTTON_COLOR, FOOTER_COLOR);
 
 private InAppBrowserDialog dialog;
 private WebView inAppWebView;
@@ -129,6 +131,8 @@ Licensed to the Apache Software Foundation (ASF) under one
 private boolean hideNavigationButtons = false;
 private String navigationButtonColor = "";
 private boolean hideUrlBar = false;
+private boolean showFooter = false;
+private String footerColor = "";
 
 /**
  * Executes the request and returns PluginResult.
@@ -397,11 +401,9 @@ public void run() {
 option = new StringTokenizer(features.nextToken(), "=");
 if (option.hasMoreElements()) {
 String key = option.nextToken();
-String value = null;
-if (customizableOptions.contains(key)) value = 
option.nextToken();
-else {
-  String token = option.nextToken();
-  value = token.equals("yes") || token.equals("no") ? 
token : "yes";
+String value = option.nextToken();
+if (!customizableOptions.contains(key)){
+value = value.equals("yes") ||

[jira] [Commented] (CB-13791) Add Android support for a footer close button.

2018-01-24 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337971#comment-16337971
 ] 

ASF subversion and git services commented on CB-13791:
--

Commit 98ee2e148cd98a6e0b627b9b92f2e03efd9e00c5 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~bowserj]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=98ee2e1 
]

Merge pull request #258 from dpa99c/CB-13791

CB-13791: (android) Add Android support for a footer close button

> Add Android support for a footer close button.
> --
>
> Key: CB-13791
> URL: https://issues.apache.org/jira/browse/CB-13791
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
> Environment: Android
>Reporter: Dave Alden
>Priority: Minor
>  Labels: features, newbie
>
> Extending the work done in [PR 
> #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under 
> CB-13409, this adds support to Android for a footer close button similar to 
> the "Done" button on iOS.
> The following options are added for Android:
>  * *footer* - set to "yes" to show a close button in the footer similar to 
> the iOS "Done" button.
>  The close button will appear the same as for the header hence use 
> _closebuttoncaption_ and _closebuttoncolor_ to set its properties.
>  * *footercolor* - set to a valid hex color string, for example #00ff00 or 
> #CC00ff00 (#aarrggbb) , and it will change the footer color from default. 
> Only has effect if user has _footer_ set to "yes".
> Here are some example screenshots with the relevant options:
> _location=yes,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300!
> _location=no,footer=yes_
>  
> !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300!
> _location=yes,footer=yes,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300!
> _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300!
> _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_
>  
> !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300!
> _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_
>  
> !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300!
> _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_
>  
> !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13825) Outdated node_modules

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337908#comment-16337908
 ] 

ASF GitHub Bot commented on CB-13825:
-

tripodsan commented on issue #46: CB-13825: (osx) Update node dependencies
URL: https://github.com/apache/cordova-osx/pull/46#issuecomment-360206884
 
 
   thanks for the PR. I will look into it by end of this week.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Outdated node_modules
> -
>
> Key: CB-13825
> URL: https://issues.apache.org/jira/browse/CB-13825
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Affects Versions: 4.1.0
>Reporter: Alberto Lalama
>Assignee: Tobias Bocanegra
>Priority: Major
>
> Commit  [f7db769af|https://github.com/apache/cordova-osx/pull/43] updated 
> cordova-common to v2.1.0 without updating node_modules. This means that 
> pinning cordova-osx to the github repo in config.xml fails to install plugins 
> with the following error:
> Installing "cordova-plugin-whitelist" for osx
>  Failed to install 'cordova-plugin-whitelist':TypeError: Cannot read property 
> 'get' of undefined
>  at Api.addPlugin (platforms/osx/cordova/Api.js:187:25)
>  at handleInstall (cordova-lib/src/plugman/install.js:611:6)
>  at node_modules/cordova-lib/src/plugman/install.js:407:28
>  at _fulfilled (node_modules/cordova-lib/node_modules/q/q.js:787:54)
>  at self.promiseDispatch.done 
> (node_modules/cordova-lib/node_modules/q/q.js:816:30)
>  at Promise.promise.promiseDispatch 
> (node_modules/cordova-lib/node_modules/q/q.js:749:13)
>  at node_modules/cordova-lib/node_modules/q/q.js:509:49
>  at flush (node_modules/cordova-lib/node_modules/q/q.js:108:17)
>  at _combinedTickCallback (internal/process/next_tick.js:131:7)
>  at process._tickCallback (internal/process/next_tick.js:180:9)
>  Failed to restore plugin "cordova-plugin-whitelist" from config.xml. You 
> might need to try adding it again. Error: TypeError: Cannot read property 
> 'get' of undefined
>  
> A straightforward solution would be to update node_modules (cordova-ios seems 
> to do this regularly). Could we use a dependency manager (e.g. yarn)? Any 
> other suggestions?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13825) Outdated node_modules

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337900#comment-16337900
 ] 

ASF GitHub Bot commented on CB-13825:
-

albertolalama opened a new pull request #46: CB-13825: (osx) Update node 
dependencies
URL: https://github.com/apache/cordova-osx/pull/46
 
 
   ### Platforms affected
   OSX
   
   ### What does this PR do?
   Updates node_modules by running `npm install --only=production` in order to 
fix a bug that prevented plugins from being installed/removed.
   
   ### What testing has been done on this change?
   Plugin management by pinning cordova-osx to this branch.
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Outdated node_modules
> -
>
> Key: CB-13825
> URL: https://issues.apache.org/jira/browse/CB-13825
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-osx
>Affects Versions: 4.1.0
>Reporter: Alberto Lalama
>Assignee: Tobias Bocanegra
>Priority: Major
>
> Commit  [f7db769af|https://github.com/apache/cordova-osx/pull/43] updated 
> cordova-common to v2.1.0 without updating node_modules. This means that 
> pinning cordova-osx to the github repo in config.xml fails to install plugins 
> with the following error:
> Installing "cordova-plugin-whitelist" for osx
>  Failed to install 'cordova-plugin-whitelist':TypeError: Cannot read property 
> 'get' of undefined
>  at Api.addPlugin (platforms/osx/cordova/Api.js:187:25)
>  at handleInstall (cordova-lib/src/plugman/install.js:611:6)
>  at node_modules/cordova-lib/src/plugman/install.js:407:28
>  at _fulfilled (node_modules/cordova-lib/node_modules/q/q.js:787:54)
>  at self.promiseDispatch.done 
> (node_modules/cordova-lib/node_modules/q/q.js:816:30)
>  at Promise.promise.promiseDispatch 
> (node_modules/cordova-lib/node_modules/q/q.js:749:13)
>  at node_modules/cordova-lib/node_modules/q/q.js:509:49
>  at flush (node_modules/cordova-lib/node_modules/q/q.js:108:17)
>  at _combinedTickCallback (internal/process/next_tick.js:131:7)
>  at process._tickCallback (internal/process/next_tick.js:180:9)
>  Failed to restore plugin "cordova-plugin-whitelist" from config.xml. You 
> might need to try adding it again. Error: TypeError: Cannot read property 
> 'get' of undefined
>  
> A straightforward solution would be to update node_modules (cordova-ios seems 
> to do this regularly). Could we use a dependency manager (e.g. yarn)? Any 
> other suggestions?
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11968) add support to config.xml

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337498#comment-16337498
 ] 

ASF GitHub Bot commented on CB-11968:
-

janpio commented on issue #235: CB-11968: Add support for config-file in 
config.xml
URL: https://github.com/apache/cordova-windows/pull/235#issuecomment-360113052
 
 
   I revertet that commit because it was part of the release process of 5.1.0 
which I canceled. Would the correct way to "fix" this be to actually update 
`node_modules` in this PR? I am not sure how this is usually done :/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> add  support to config.xml
> ---
>
> Key: CB-11968
> URL: https://issues.apache.org/jira/browse/CB-11968
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Nikita Matrosov
>Priority: Major
>  Labels: tools-next
>
> Need a way for users to add new settings to config files from config.xml. 
> Lets add  support to config.xml. Right now,  only 
> works in plugin.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11968) add support to config.xml

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337497#comment-16337497
 ] 

ASF GitHub Bot commented on CB-11968:
-

janpio commented on issue #235: CB-11968: Add support for config-file in 
config.xml
URL: https://github.com/apache/cordova-windows/pull/235#issuecomment-360113052
 
 
   I revertet that commit because it was part of the release process of 5.1.0 
which I canceled. Would the correct way to "fix" this be to actually update 
`node_modules` in this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> add  support to config.xml
> ---
>
> Key: CB-11968
> URL: https://issues.apache.org/jira/browse/CB-11968
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Nikita Matrosov
>Priority: Major
>  Labels: tools-next
>
> Need a way for users to add new settings to config files from config.xml. 
> Lets add  support to config.xml. Right now,  only 
> works in plugin.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11968) add support to config.xml

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337461#comment-16337461
 ] 

ASF GitHub Bot commented on CB-11968:
-

matrosov-nikita commented on issue #235: CB-11968: Add support for config-file 
in config.xml
URL: https://github.com/apache/cordova-windows/pull/235#issuecomment-360107173
 
 
   @janpio @shazron 
   I've made [PR](https://github.com/apache/cordova-docs/pull/783)  to 
`cordova-docs`  and added test, but it's failed since we [reverted updating of 
node_modules](https://github.com/apache/cordova-windows/commit/18eb64389700667608c0186da1e5112afc67e23e).
   
   This PR requires `cordova-common >= 2.1.0`
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> add  support to config.xml
> ---
>
> Key: CB-11968
> URL: https://issues.apache.org/jira/browse/CB-11968
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Nikita Matrosov
>Priority: Major
>  Labels: tools-next
>
> Need a way for users to add new settings to config files from config.xml. 
> Lets add  support to config.xml. Right now,  only 
> works in plugin.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11968) add support to config.xml

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337459#comment-16337459
 ] 

ASF GitHub Bot commented on CB-11968:
-

matrosov-nikita commented on issue #235: CB-11968: Add support for config-file 
in config.xml
URL: https://github.com/apache/cordova-windows/pull/235#issuecomment-360107173
 
 
   @janpio @shazron 
   I've made [PR](https://github.com/apache/cordova-docs/pull/783)  to 
`cordova-docs`  and added test, but it's failed since we [reverted updating of 
node_modules](https://github.com/apache/cordova-windows/commit/18eb64389700667608c0186da1e5112afc67e23e).
   
   This PR requires `cordova-common@2.1.0`
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> add  support to config.xml
> ---
>
> Key: CB-11968
> URL: https://issues.apache.org/jira/browse/CB-11968
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-lib
>Reporter: Steve Gill
>Assignee: Nikita Matrosov
>Priority: Major
>  Labels: tools-next
>
> Need a way for users to add new settings to config files from config.xml. 
> Lets add  support to config.xml. Right now,  only 
> works in plugin.xml



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13823) Document `config-file` usage in `config.xml`

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337396#comment-16337396
 ] 

ASF GitHub Bot commented on CB-13823:
-

matrosov-nikita opened a new pull request #783: CB-13823 Add support for 
config-file in config.xml
URL: https://github.com/apache/cordova-docs/pull/783
 
 
   
   
   ### Platforms affected
   all
   
   ### What does this PR do?
   Adds docs for config-file in config-xml
   https://github.com/apache/cordova-windows/pull/235
   https://github.com/apache/cordova-common/pull/2
   
   ### Checklist
   - [x] Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Document `config-file` usage in `config.xml`
> 
>
> Key: CB-13823
> URL: https://issues.apache.org/jira/browse/CB-13823
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-docs
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> Implementation: https://github.com/apache/cordova-common/pull/2
> Implementation Windows: 
> https://github.com/apache/cordova-windows/pull/235#issuecomment-359737771
> Could be as simple as this: 
> https://cordova.apache.org/docs/en/latest/config_ref/index.html#edit-config



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337377#comment-16337377
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on issue #148: CB-13392(Android & iOS): Display app version on 
splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-360093045
 
 
   Very nice feature and a good addition to the splashscreen functionality. I 
left some comment on the docs part of it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337378#comment-16337378
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on issue #148: CB-13392(Android & iOS): Display app version on 
splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-360093045
 
 
   Very nice feature and a good addition to the splashscreen functionality 
@johnlejardinnier. 
   I left some comment on the docs part of it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337370#comment-16337370
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163512040
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
+```xml
+...
+```
+
+
+## Prefix app version
+To set a prefix version add the following preference to `config.xml`:
+```xml
+
+```
+In this case you'll have `v1.0`
+
+
+## Customize app version
 
 Review comment:
   What font will be used? Maybe add an example screenshot here so one can 
visualize what it will look like.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337369#comment-16337369
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163511948
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
+```xml
+...
+```
+
+
+## Prefix app version
+To set a prefix version add the following preference to `config.xml`:
+```xml
+
+```
+In this case you'll have `v1.0`
+
+
+## Customize app version
+To customise the version color, size and horizontal position add the following 
preference to `config.xml`:
+```xml
+
+
+
 
 Review comment:
   How does this work - is it all the way left and right or with a padding? 
Should probably be documented.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337368#comment-16337368
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163511788
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
+```xml
+...
+```
+
+
+## Prefix app version
+To set a prefix version add the following preference to `config.xml`:
+```xml
+
+```
+In this case you'll have `v1.0`
+
+
+## Customize app version
+To customise the version color, size and horizontal position add the following 
preference to `config.xml`:
 
 Review comment:
   ... the color, size and horizontal position of your version add ...
   preference => preferences


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337365#comment-16337365
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163511563
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
+```xml
+...
+```
+
+
+## Prefix app version
+To set a prefix version add the following preference to `config.xml`:
+```xml
+
+```
+In this case you'll have `v1.0`
 
 Review comment:
   Suggestion:
   This will be combined with your `version` value to e.g. `v1.0`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337360#comment-16337360
 ] 

ASF GitHub Bot commented on CB-13392:
-

janpio commented on a change in pull request #148: CB-13392(Android & iOS): 
Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163511315
 
 

 ##
 File path: README.md
 ##
 @@ -376,6 +376,36 @@ To disable the splashscreen add the following preference 
to `config.xml`:
 
 ```
 
+# Display app version (Android, iOS)
+
+To display your app version on splashscreen add the following preference to 
`config.xml`:
+```xml
+
+```
+
+Now just configure your app version into the widget version attribute, like 
that : 
 
 Review comment:
   Is there a way to _not_ do that? I always thought the version was required - 
which would make calling this out a bit unnecessary. You could of course change 
the text in a way that just explains where it will be taking this value from.
   (Also: superfluous space before `:` at the end of the line)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12380) [windows] backgroundMediaPlayback: need to be prefixed with uap

2018-01-24 Thread JIRA 

[ 
https://issues.apache.org/jira/browse/CB-12380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337302#comment-16337302
 ] 

Sebastián Katzer commented on CB-12380:
---

Hi [~Sujan12], what I did is setting the capability via plugin.xml with the 
result that the manifest becomes invalid because of the missing namespace.

Then I browsed through the code because other capabilities that require these 
namespace do work and found the point of code I mentioned here in the ticket.

I think its enough to just add it to the list. I haven't tried by myself.

> [windows] backgroundMediaPlayback: need to be prefixed with uap
> ---
>
> Key: CB-12380
> URL: https://issues.apache.org/jira/browse/CB-12380
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
> Environment: Windows 10 Anniversary Update (version 14393)
>Reporter: Sebastián Katzer
>Priority: Major
>
> Please add support for the new capability called "backgroundMediaPlayback".
> As the cap requires the uap-ns, please add it to the list.
> https://github.com/apache/cordova-windows/blob/e4e9573bd9be43b37dbd0c53b5c39c14ef2130da/template/cordova/lib/AppxManifest.js#L32
> The cap has been introduced with the Windows 10 Anniversary Update (version 
> 14393)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337295#comment-16337295
 ] 

ASF GitHub Bot commented on CB-13392:
-

purplecabbage commented on issue #148: CB-13392(Android & iOS): Display app 
version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#issuecomment-360078697
 
 
   I think this is a nice feature, thanks for contributing! 
   I agree with @kerrishotts that windows support should be there for 
consistency.  That is, if this feature is going into the splashscreen plugin 
... I also see no reason why this could not be its own plugin that depends on 
the splashscreen plugin ... and just adds this feature.
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13392) Display app version on splashscreen

2018-01-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337285#comment-16337285
 ] 

ASF GitHub Bot commented on CB-13392:
-

purplecabbage commented on a change in pull request #148: CB-13392(Android & 
iOS): Display app version on splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/148#discussion_r163496852
 
 

 ##
 File path: src/ios/CDVSplashScreen.m
 ##
 @@ -60,6 +60,63 @@ - (void)observeValueForKeyPath:(NSString*)keyPath 
ofObject:(id)object change:(NS
 [self updateImage];
 }
 
+- (UIColor *)colorFromHexString:(NSString *)hexString {
 
 Review comment:
   Statusbar handles all of this in js here: 
https://github.com/apache/cordova-plugin-statusbar/blob/master/www/statusbar.js#L75
   including shortcut css, like #345 => #334455


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Display app version on splashscreen
> ---
>
> Key: CB-13392
> URL: https://issues.apache.org/jira/browse/CB-13392
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
>Affects Versions: Master
> Environment: Available on Android and iOS.
>Reporter: Jonathan Corral
>Priority: Minor
>  Labels: beginner, features
>   Original Estimate: 14h
>  Remaining Estimate: 14h
>
> This feature allows you to display the app version number at splashscreen's 
> bottom.
> You could configure the color, size and position (left, center, right) with 
> preferences into config.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org