[jira] [Commented] (CB-13787) Cordova plugin screen orientation iOS not locking view correctly

2018-02-08 Thread Adrian Jarc (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357969#comment-16357969
 ] 

Adrian Jarc commented on CB-13787:
--

Ye I would try to fix it but I am too busy with the project I am working on in 
my firm. So I hope one of you guys is going to fix it.

> Cordova plugin screen orientation iOS not locking view correctly
> 
>
> Key: CB-13787
> URL: https://issues.apache.org/jira/browse/CB-13787
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-screen-orientation
> Environment: iPhone 6S iOS 11.2.1
> cordova-plugin-screen-orientation@3.0.1 and lower
> Ionic v1.7.16
>  Cordova v6.5.0
>  
>  
>  
>Reporter: Adrian Jarc
>Priority: Blocker
> Attachments: ScreenOrientation Bug.mp4
>
>
> Bug happens if you have an app that is locked to portrait mode and have a 
> component that temporarily turns the app into landscape. While iPhone is 
> turned to portrait mode it works normally but once you turn it to landscape 
> (from view that is locked to portrait) and fire the component that is 
> supposed to turn the app to landscape the app doesn't turn. Similar bug 
> happens when turning the app back to portrait.
> See the video for full bug replication demonstration.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-13856) cordova plugin list prints helper message to STDOUT instead of STDERR

2018-02-08 Thread Ryan Williams (JIRA) 
Ryan Williams created CB-13856:
--

 Summary: cordova plugin list prints helper message to STDOUT 
instead of STDERR
 Key: CB-13856
 URL: https://issues.apache.org/jira/browse/CB-13856
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-cli
Affects Versions: Master
Reporter: Ryan Williams


The message "No plugins added. Use `cordova plugin add `." is printed 
to STDOUT when running the command "cordova plugin list" when there are no 
plugins installed.

It should be printed to STDERR instead to be consistent with other linux 
programs.

 

Ryans-Mac:MyApp ryan$ cordova plugin list 2>/dev/null
No plugins added. Use `cordova plugin add `.



Ryans-Mac:MyApp ryan$ cordova plugin list 2>/dev/null | wc -l
1



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-11893) CocoaPods support: Provide a way to add use_frameworks! on the Podfile

2018-02-08 Thread Shazron Abdullah (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357835#comment-16357835
 ] 

Shazron Abdullah edited comment on CB-11893 at 2/9/18 2:06 AM:
---

[~swinx] MyPluginThatUsesADynamicFrameworkCocoaPod is just a name. This is how 
you specify a CocoaPod in a plugin's plugin.xml. If that plugin needs 
use_frameworks, we need to know about it, thus overloading the type. It's still 
a "podspec", it just has this extra annotation.

If a plugin's cocoapod has this type and annotation, we flag it if other 
plugins install other cocoapods *without* it.

We don't have resources to work on everything, especially this, so this is the 
easiest proposal considering long Apache release rules and testing, but if you 
want to submit a PR and do everything, and test it, that will be appreciated as 
well. No backports.


was (Author: shazron):
[~swinx] MyPluginThatUsesADynamicFrameworkCocoaPod is just a name. This is how 
you specify a CocoaPod in a plugin's plugin.xml. If that plugin needs 
use_frameworks, we need to know about it, thus overloading the type. It's still 
a "podspec", it just has this extra annotation.

If a plugin's framework has this type and annotation, we flag it if other 
plugins install other cocoapods *without* it.

We don't have resources to work on everything, especially this, so this is the 
easiest proposal considering long Apache release rules and testing, but if you 
want to submit a PR and do everything, and test it, that will be appreciated as 
well. No backports.

> CocoaPods support: Provide a way to add use_frameworks! on the Podfile
> --
>
> Key: CB-11893
> URL: https://issues.apache.org/jira/browse/CB-11893
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-ios
>Reporter: jcesarmobile
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@5.0.0
>
> Attachments: Integrating Static Library With Cocoapods 
> Use_frameworks.pdf
>
>
> If the library you want to use on the plugin uses Swift or you want to use 
> dynamic frameworks you have to add use_frameworks! on the Podfile
> I don't think there is a way of adding it right now.
> We should provide a way of adding it 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11893) CocoaPods support: Provide a way to add use_frameworks! on the Podfile

2018-02-08 Thread Shazron Abdullah (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357835#comment-16357835
 ] 

Shazron Abdullah commented on CB-11893:
---

[~swinx] MyPluginThatUsesADynamicFrameworkCocoaPod is just a name. This is how 
you specify a CocoaPod in a plugin's plugin.xml. If that plugin needs 
use_frameworks, we need to know about it, thus overloading the type. It's still 
a "podspec", it just has this extra annotation.

If a plugin's framework has this type and annotation, we flag it if other 
plugins install other cocoapods *without* it.

We don't have resources to work on everything, especially this, so this is the 
easiest proposal considering long Apache release rules and testing, but if you 
want to submit a PR and do everything, and test it, that will be appreciated as 
well. No backports.

> CocoaPods support: Provide a way to add use_frameworks! on the Podfile
> --
>
> Key: CB-11893
> URL: https://issues.apache.org/jira/browse/CB-11893
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-ios
>Reporter: jcesarmobile
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@5.0.0
>
> Attachments: Integrating Static Library With Cocoapods 
> Use_frameworks.pdf
>
>
> If the library you want to use on the plugin uses Swift or you want to use 
> dynamic frameworks you have to add use_frameworks! on the Podfile
> I don't think there is a way of adding it right now.
> We should provide a way of adding it 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11893) CocoaPods support: Provide a way to add use_frameworks! on the Podfile

2018-02-08 Thread Ilya Isupov (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357822#comment-16357822
 ] 

Ilya Isupov commented on CB-11893:
--

[~shazron] not sure how are you going to make dynamic frameworks only 
dependencies which require it when CocoaPods missing this feature. Are you 
going to contribute to CocoaPods repo?

Regarding this example code:
{code:xml}

{code}
Not sure I understand why do we connecting here 
`MyPluginThatUsesADynamicFrameworkCocoaPod` since this is a declaration for a 
pod dependency in a plugin, not a cordova app depending on a plugin.
About declaring use_frameworks - seems it will be not really consistent and 
intuitive to have this declaration as overloaded `type` attribute because other 
settings using their own specific attributes. Why do you see here problem? The 
`type=podspec` framework is a uniq type of the framework, it's logical for it 
to have specific attributes. Or you think that blocker is requirement to 
release a new version of cordova-lib to fully support this with new attribute? 
How about backport to earlier versions in this case? 

> CocoaPods support: Provide a way to add use_frameworks! on the Podfile
> --
>
> Key: CB-11893
> URL: https://issues.apache.org/jira/browse/CB-11893
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-ios
>Reporter: jcesarmobile
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@5.0.0
>
> Attachments: Integrating Static Library With Cocoapods 
> Use_frameworks.pdf
>
>
> If the library you want to use on the plugin uses Swift or you want to use 
> dynamic frameworks you have to add use_frameworks! on the Podfile
> I don't think there is a way of adding it right now.
> We should provide a way of adding it 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13797) Fetch failing to install plugin dependencies

2018-02-08 Thread Steve Gill (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357754#comment-16357754
 ] 

Steve Gill commented on CB-13797:
-

I can't reproduce this. I tried with cordova@8 from npm and my local dev. 

I added cordova-android and installed code-push. No issues. Than I tried 
restoring code-push via config.xml/package.json. No issue.

> Fetch failing to install plugin dependencies
> 
>
> Key: CB-13797
> URL: https://issues.apache.org/jira/browse/CB-13797
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-fetch
> Environment: cordova@8.0.0
> cordova-common@2.2.1
> cordova-lib@8.0.0
> cordova-fetch@1.3.0
> npm@5.6.0
> node@9.4.0
>  
>Reporter: Darryl Pogue
>Priority: Critical
>
> I'm currently unable to install Microsoft's cordova-plugin-code-push due to 
> some incredibly confusing errors when installing the plugin dependencies.
> The plugin [lists 3 
> dependencies|https://github.com/Microsoft/cordova-plugin-code-push/blob/e828a5eacd42dcd81bacf121a3e62735c3500227/plugin.xml#L10-L12]
>  in plugin.xml.
> Cordova successfully installs the first (code-push) dependency.
> Cordova attempts to install the second (cordova-plugin-device) dependency. It 
> appears that the npm install is successful.
> At the end of the npm install, cordova-fetch [attempts to 
> discover|https://github.com/apache/cordova-fetch/blob/master/index.js#L100] 
> what was just installed. Rather than finding "cordova-plugin-device", it 
> finds "code-push" for a second time.
> Then it fails with the following confusing error message:
> {noformat}
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".{noformat}
> The full verbose output from {{cordova prepare}} is below:
> {noformat}
> Discovered plugin "cordova-plugin-code-push" in config.xml. Adding it to the 
> project
> No scripts found for hook "before_plugin_add".
> Calling plugman.fetch on plugin "cordova-plugin-code-push@^1.11.2"
> Running command: npm install cordova-plugin-code-push@^1.11.2 --production 
> --no-save
> Command finished with error code 0: npm 
> install,cordova-plugin-code-push@^1.11.2,--production,--no-save
> Copying plugin "/PROJECT/node_modules/cordova-plugin-code-push" => 
> "/PROJECT/plugins/cordova-plugin-code-push"
> Calling plugman.install on plugin "/PROJECT/plugins/cordova-plugin-code-push" 
> for platform "android
> Installing "cordova-plugin-code-push" for android
> Running command: /PROJECT/platforms/android/cordova/version 
> Command finished with error code 0: 
> /PROJECT/platforms/android/cordova/version 
> Dependencies detected, iterating through them...
> Requesting plugin "code-push@2.0.4".
> Plugin dependency "code-push" not fetched, retrieving then installing.
> Running command: npm install code-push@2.0.4 --production --no-save
> Command finished with error code 0: npm 
> install,code-push@2.0.4,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" => 
> "/PROJECT/plugins/code-push"
> Installing "code-push" for android
> Finding scripts for "before_plugin_install" hook from plugin code-push on 
> android platform only.
> No scripts found for hook "before_plugin_install".
> Install start for "code-push" on android.
> Beginning processing of action stack for android project...
> Action stack processing complete.
> Install complete for code-push on android.
> Finding scripts for "after_plugin_install" hook from plugin code-push on 
> android platform only.
> No scripts found for hook "after_plugin_install".
> Requesting plugin "cordova-plugin-dialogs@>=1.1.1".
> Plugin dependency "cordova-plugin-dialogs" not fetched, retrieving then 
> installing.
> Running command: npm install cordova-plugin-dialogs@>=1.1.1 --production 
> --no-save
> Command finished with error code 0: npm 
> install,cordova-plugin-dialogs@>=1.1.1,--production,--no-save
> Copying plugin "/PROJECT/node_modules/code-push" => 
> "/PROJECT/plugins/code-push"
> Failed to install 'cordova-plugin-code-push': Error: Expected plugin to have 
> ID "cordova-plugin-dialogs" but got "code-push".
> at checkID (/PROJECT/node_modules/cordova-lib/src/plugman/fetch.js:215:15)
> at /PROJECT/node_modules/cordova-lib/src/plugman/fetch.js:199:9
> at _fulfilled (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done 
> (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch 
> (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at /PROJECT/node_modules/cordova-lib/node_modules/q/q.js:557:44
> at flush (/PROJECT/node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at process._tickCallback (internal/process/next_tick.js:150:11)
> Failed to restore plugin

[jira] [Commented] (CB-13834) Fix tests failure with VS17 caused by CB-12499

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357672#comment-16357672
 ] 

ASF GitHub Bot commented on CB-13834:
-

janpio commented on a change in pull request #248: CB-13834 TEST WIP FOR 
DISCUSSION DO NOT MERGE
URL: https://github.com/apache/cordova-windows/pull/248#discussion_r167090025
 
 

 ##
 File path: spec/e2e/endtoend.spec.js
 ##
 @@ -203,7 +213,7 @@ describe('Cordova create and build', function () {
 
 // here be 6a
 
-it('spec.6b should generate appxupload and appxbundle for Windows 10 
project bundle release build', function () {
+it('spec.6b should generate appxupload and appxbundle for Windows Phone 
8.1 project bundle release build (all target platforms)', function () {
 
 Review comment:
   ah interesting, missed that before


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests failure with VS17 caused by CB-12499
> --
>
> Key: CB-13834
> URL: https://issues.apache.org/jira/browse/CB-13834
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> The file `Default.rd.xml` introduced by CB-12499 is unfortunately causing 
> test failures on AppVeyor when Visual Studio 2017 is used to build with 
> params `--release --bundle --archs="x64 x86 arm"`. 
>  
> {code:java}
> Started
> Creating Cordova Windows Project:
>   Path: testcreate 応用
>   Namespace: com.test.app
>   Name: 応用
> Windows project created with cordova-windows@5.1.0-dev
> Building project: C:\projects\cordova-windows\testcreate 
> 応用\CordovaApp.Windows10.jsproj
>   Configuration : release
>   Platform  : x64
>   Patching 10 in prebuild event...
>   Injected base.js reference to the www/index.html
>   Removing /( 
> *)(\s*<\/script>)(\s*)/
>  from www/index.html
>   Removing /( 
> *)(\s*<\/script>)(\s*)/
>  from www/index.html
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\build\windows\release\x64\win10\CordovaApp.Windows10_1.0.0.0_x64.appx
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\build\windows\release\x64\win10\Upload\CordovaApp.Windows10_1.0.0.0_x64.appx
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0_Test\CordovaApp.Windows10_1.0.0.0_x64.appxbundle
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0\CordovaApp.Windows10_1.0.0.0_x64.appxbundle
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0_x64_bundle.appxupload
>   Your package has been successfully created.
> Building project: C:\projects\cordova-windows\testcreate 
> 応用\CordovaApp.Windows10.jsproj
>   Configuration : release
>   Platform  : x86
>   Patching 10 in prebuild event...
> C:\Program Files 
> (x86)\MSBuild\Microsoft\VisualStudio\v14.0\AppxPackage\Microsoft.AppXPackage.Targets(2975,5):
>  error MSB3231: Unable to remove directory 
> "build\windows\bld\PackageUploadLayout\". The process cannot access the file 
> 'Default.rd.xml' because it is being used by another process. 
> [C:\projects\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj]
> C:\projects\cordova-windows\testcreate 応用\cordova\node_modules\q\q.js:155
> throw e;
> ^
> Error: C:\Program Files (x86)\MSBuild\14.0\bin\msbuild.exe: Command failed 
> with exit code 1
> at ChildProcess.whenDone (C:\projects\cordova-windows\testcreate 
> 応用\cordova\node_modules\cordova-common\src\superspawn.js:169:23)
> at emitTwo (events.js:106:13)
> at ChildProcess.emit (events.js:191:7)
> at maybeClose (internal/child_process.js:920:16)
> at Process.ChildProcess._handle.onexit 
> (internal/child_process.js:230:5){code}
> Afaik this is the only test that is "touching" that file (--release and 
> Windows 10), so this might be a general problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13852) cordova-plugin-media getPosition audio failed

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357484#comment-16357484
 ] 

ASF GitHub Bot commented on CB-13852:
-

jsdussanc commented on issue #165: CB-13852: (iOS) Fix bug prevent error on 
getPosition
URL: 
https://github.com/apache/cordova-plugin-media/pull/165#issuecomment-364228321
 
 
   ready, rebase to master


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-media getPosition audio failed
> -
>
> Key: CB-13852
> URL: https://issues.apache.org/jira/browse/CB-13852
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-media
>Affects Versions: cordova-ios 4.5.0
> Environment: iOS all versions
>Reporter: Juan Sebastian Dussan Cubides
>Priority: Minor
>
> (iOS)
> When I try to get the position of an audio that had an error while loading, 
> the crash appose exponentially because it can not cast the time = none



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13445) Streaming media in iOS has long load times

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357452#comment-16357452
 ] 

ASF GitHub Bot commented on CB-13445:
-

pbirsinger commented on issue #149: CB-13445: (ios) Streaming media can take up 
to 8-10 seconds to start - fixed!
URL: 
https://github.com/apache/cordova-plugin-media/pull/149#issuecomment-364221381
 
 
   Any updates here? This would be great to have


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Streaming media in iOS has long load times
> --
>
> Key: CB-13445
> URL: https://issues.apache.org/jira/browse/CB-13445
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-media
> Environment: iOS platform within cordova 
>Reporter: Ashish Mehra
>Priority: Major
>
> Using the plugin, cordova-plugin-media, one can stream audio/video media. On 
> the iOS front, streaming media can take anywhere from 8-10 seconds to start 
> playing, even if the length of the media is < 10 mins. 
> The culprit here is `automaticallyWaitsToMinimizeStalling` property, that 
> seems to buffer a more than required amount of the media causing load time 
> delays. In some cases, it actually downloads the entire media file before 
> starting and on slow internet connections this can mean load times of > 15 
> seconds.
> Disabling this property should make iOS media load times to almost instant as 
> it will only buffer a default/set amount.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13834) Fix tests failure with VS17 caused by CB-12499

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357453#comment-16357453
 ] 

ASF GitHub Bot commented on CB-13834:
-

brodybits opened a new pull request #248: CB-13834 TEST WIP FOR DISCUSSION DO 
NOT MERGE
URL: https://github.com/apache/cordova-windows/pull/248
 
 
   
   
   ### Platforms affected
   
   Windows
   
   ### What does this PR do?
   
   Further testing to help narrow down the cause of CB-13834 
() test failures
   
   OBSERVATION: For some reason it would only generate x64 build for UWP bundle 
in case of VS 2017 on AppVeyor build
   
   Output on my fork is available at: 

 (same results are expected to show up for this PR)
   
   NOTICE: This PR is for investigation and discussion only. PLEASE DO NOT 
MERGE.
   
   ### What testing has been done on this change?
   
   - appveyor.yml replace Node 4 with Node 8 to rule out possible effect of 
outdated Node.js version
   - additional logs (commented out) used to get a better understanding of 
actual output
   - fixed related test descriptions
   - added test of UWP bundle for x64 only (seems to pass on AppVeyor)
   - add extra expectation to spec.6a to check for generated bundle for x64 only
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database (reported by someone else): 

   ~~Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.~~ not done here (raised for investigation and discussion only)
   - [x] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix tests failure with VS17 caused by CB-12499
> --
>
> Key: CB-13834
> URL: https://issues.apache.org/jira/browse/CB-13834
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Jan Piotrowski (Sujan)
>Priority: Major
>
> The file `Default.rd.xml` introduced by CB-12499 is unfortunately causing 
> test failures on AppVeyor when Visual Studio 2017 is used to build with 
> params `--release --bundle --archs="x64 x86 arm"`. 
>  
> {code:java}
> Started
> Creating Cordova Windows Project:
>   Path: testcreate 応用
>   Namespace: com.test.app
>   Name: 応用
> Windows project created with cordova-windows@5.1.0-dev
> Building project: C:\projects\cordova-windows\testcreate 
> 応用\CordovaApp.Windows10.jsproj
>   Configuration : release
>   Platform  : x64
>   Patching 10 in prebuild event...
>   Injected base.js reference to the www/index.html
>   Removing /( 
> *)(\s*<\/script>)(\s*)/
>  from www/index.html
>   Removing /( 
> *)(\s*<\/script>)(\s*)/
>  from www/index.html
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\build\windows\release\x64\win10\CordovaApp.Windows10_1.0.0.0_x64.appx
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\build\windows\release\x64\win10\Upload\CordovaApp.Windows10_1.0.0.0_x64.appx
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0_Test\CordovaApp.Windows10_1.0.0.0_x64.appxbundle
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0\CordovaApp.Windows10_1.0.0.0_x64.appxbundle
>   CordovaApp.Windows10 -> C:\projects\cordova-windows\testcreate 
> ??\AppPackages\CordovaApp.Windows10_1.0.0.0_x64_bundle.appxupload
>   Your package has been successfully created.
> Building project: C:\projects\cordova-windows\testcreate 
> 応用\CordovaApp.Windows10.jsproj
>   Configuration : release
>   Platform  : x86
>   Patching 10 in prebuild event...
> C:\Program Files 
> (x86)\MSBuild\Microsoft\VisualStudio\v14.0\AppxPackage\Microsoft.AppXPackage.Targets(2975,5):
>  error MSB3231: Unable to remove directory 
> "build\windows\bld\PackageUploadLayout\". The process cannot access the file 
> 'Default.rd.xml' because it is being used by another process. 
> [C:\projects\cordova-windows\testcreate ??\CordovaApp.Windows10.jsproj]
>

[jira] [Commented] (CB-12074) Cookies are ignored on first application execution

2018-02-08 Thread Stephen Warren (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357057#comment-16357057
 ] 

Stephen Warren commented on CB-12074:
-

why hasn't this issue been fixed yet?  this is a showstopper. we can't use 
wkwebview until this is resolved.

> Cookies are ignored on first application execution
> --
>
> Key: CB-12074
> URL: https://issues.apache.org/jira/browse/CB-12074
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-wkwebview-engine
> Environment: Cordova 5.4.0, iOS 9.3.5
>Reporter: Maxim
>Assignee: Shazron Abdullah
>Priority: Major
>  Labels: wkwebview-known-issues
>
> Our application authenticates to the server. The server sets a 'JSESSIONID' 
> cookie. The cookie is used by the server for session management. 
> The issue is WKWebView does not send this cookie back to the server on 
> subsequent requests. However, this only happens on first execution of the 
> application, after its installation. Once the application closed and 
> re-opened, the cookies are properly sent and authentication completes 
> successfully. 
> The problematic behavior is consistent, and was observed on several devices. 
> On the other hand, there are no such issues with UIWebView. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13584) app gets rejected with invalid image path for AppIcon83.5x83.5 error while uploading to appstore

2018-02-08 Thread Christian Cook (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356950#comment-16356950
 ] 

Christian Cook commented on CB-13584:
-

[~rockneverdies] did you ever resolve this issue? I'm experiencing the same 
problem as you here. Running an iPhone only app on an iPad Pro and the icon is 
not present - it shows the missing icon graphic. Inside the IPA the 
[8...@2x.png|mailto:8...@2x.png] never gets copied across, even though it is in 
Images.xcassets/AppIcon.appiconset correctly.

> app gets rejected with invalid image path for AppIcon83.5x83.5 error while 
> uploading to appstore
> 
>
> Key: CB-13584
> URL: https://issues.apache.org/jira/browse/CB-13584
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Reporter: Khalid Salman
>Assignee: Suraj Pindoria
>Priority: Minor
>
> Hi there,
> I cannot get around an icon problem for a week now. Please help I cannot 
> upload my app to app store.
> Everything is fine till I try to upload it. Means I can build it, run it in 
> simulator, etc... but can't push to app store.
> It doesn't give up on this weird error message no matter what I do: _ERROR 
> ITMS-90032: "Invalid Image Path - No image found at the path referenced under 
> key 'CFBundleIcons': 'AppIcon83.5.x83.5'"_
> Here is my icon settings in config.xml file:
> {code:xml}
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 
> {code}
> Please let me know what am I missing about this AppIcon83.5x83.5 icon that 
> nobody else is complaining about in any forms as far as I can see while it's 
> killing me here...
> I'm using the current latest version of cordova cli (7.1.0) and cordova-ios 
> (4.5.3) in the project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Comment Edited] (CB-6079) Android video mediaplayer error

2018-02-08 Thread johns madina (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356939#comment-16356939
 ] 

johns madina edited comment on CB-6079 at 2/8/18 1:32 PM:
--

Some times I got this error message still not resolve. So do you have any 
information about this error inform to me. New app contains lots of video 
streams on Chromecast 
[http://androidpcapps.com/mobdro-chromecast-download-install-premium-apk/]

some the media player also show the video not found error.


was (Author: johnsmadina11):
Some times I got this error message still not resolve. So do you have any 
information about this error inform to me. New app contains lots of video 
streams http://androidpcapps.com/mobdro-chromecast-download-install-premium-apk/

> Android video mediaplayer error
> ---
>
> Key: CB-6079
> URL: https://issues.apache.org/jira/browse/CB-6079
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 3.3.0
> Environment: OSX 10.8.5, Android Developer Tools
>Reporter: Arnout
>Priority: Major
>  Labels: Android, Video
> Fix For: 3.3.0
>
>
> I have a project with HTML5 video playback.
> On iOS everything works great, but if I build the same project for Android 
> the video doesn't want to play.
> This is the error I get in LogCat: "Mediaplayer Error (1, -2147483648)".
> I tried to play the video with another plugin but without result.
> Installed platforms: android 3.3.0, ios 3.3.0
> Installed plugins:
> jaeger.Html5Video',
> 'org.apache.cordova.device',
> 'org.apache.cordova.file',
> 'org.apache.cordova.inappbrowser'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-6079) Android video mediaplayer error

2018-02-08 Thread johns madina (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-6079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356939#comment-16356939
 ] 

johns madina commented on CB-6079:
--

Some times I got this error message still not resolve. So do you have any 
information about this error inform to me. New app contains lots of video 
streams http://androidpcapps.com/mobdro-chromecast-download-install-premium-apk/

> Android video mediaplayer error
> ---
>
> Key: CB-6079
> URL: https://issues.apache.org/jira/browse/CB-6079
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 3.3.0
> Environment: OSX 10.8.5, Android Developer Tools
>Reporter: Arnout
>Priority: Major
>  Labels: Android, Video
> Fix For: 3.3.0
>
>
> I have a project with HTML5 video playback.
> On iOS everything works great, but if I build the same project for Android 
> the video doesn't want to play.
> This is the error I get in LogCat: "Mediaplayer Error (1, -2147483648)".
> I tried to play the video with another plugin but without result.
> Installed platforms: android 3.3.0, ios 3.3.0
> Installed plugins:
> jaeger.Html5Video',
> 'org.apache.cordova.device',
> 'org.apache.cordova.file',
> 'org.apache.cordova.inappbrowser'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356866#comment-16356866
 ] 

ASF GitHub Bot commented on CB-13415:
-

jcesarmobile closed pull request #309: CB-13415 (android) Importing corrupt 
images using the Camera plugin c…
URL: https://github.com/apache/cordova-plugin-camera/pull/309
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/android/CameraLauncher.java b/src/android/CameraLauncher.java
index a8e6fc43..fbe8470e 100644
--- a/src/android/CameraLauncher.java
+++ b/src/android/CameraLauncher.java
@@ -943,7 +943,12 @@ private Bitmap getScaledAndRotatedBitmap(String imageUrl) 
throws IOException {
 try {
 fileStream = FileHelper.getInputStreamFromUriString(imageUrl, 
cordova);
 image = BitmapFactory.decodeStream(fileStream);
-} finally {
+}  catch (OutOfMemoryError e) {
+callbackContext.error(e.getLocalizedMessage());
+} catch (Exception e){
+callbackContext.error(e.getLocalizedMessage());
+}
+finally {
 if (fileStream != null) {
 try {
 fileStream.close();


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Importing corrupt images using the Camera plugin crashes the app
> 
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>Reporter: Shemrick Flannigan
>Priority: Critical
>  Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the 
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the 
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error 
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app | 
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner 
> class to prevent an app crash | 
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] 
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera 
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app

2018-02-08 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356867#comment-16356867
 ] 

ASF subversion and git services commented on CB-13415:
--

Commit bf935dfbd2c2a991f6632424243a26858584821b in cordova-plugin-camera's 
branch refs/heads/master from [~alpeshster]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=bf935df ]

CB-13415 (android) Importing corrupt images using the Camera plugin c… (#309)

* CB-13415 (android) Importing corrupt images using the Camera plugin crashes 
the app


> Importing corrupt images using the Camera plugin crashes the app
> 
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>Reporter: Shemrick Flannigan
>Priority: Critical
>  Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the 
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the 
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error 
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app | 
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner 
> class to prevent an app crash | 
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] 
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera 
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356869#comment-16356869
 ] 

ASF GitHub Bot commented on CB-13415:
-

jcesarmobile commented on issue #309: CB-13415 (android) Importing corrupt 
images using the Camera plugin c…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/309#issuecomment-364093770
 
 
   Merged, thanks!
   
   Will try to take a look into the iOS one this weekend, but no promises  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Importing corrupt images using the Camera plugin crashes the app
> 
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>Reporter: Shemrick Flannigan
>Priority: Critical
>  Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the 
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the 
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error 
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app | 
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner 
> class to prevent an app crash | 
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] 
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera 
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app

2018-02-08 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356868#comment-16356868
 ] 

ASF subversion and git services commented on CB-13415:
--

Commit bf935dfbd2c2a991f6632424243a26858584821b in cordova-plugin-camera's 
branch refs/heads/master from [~alpeshster]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=bf935df ]

CB-13415 (android) Importing corrupt images using the Camera plugin c… (#309)

* CB-13415 (android) Importing corrupt images using the Camera plugin crashes 
the app


> Importing corrupt images using the Camera plugin crashes the app
> 
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>Reporter: Shemrick Flannigan
>Priority: Critical
>  Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the 
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the 
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error 
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app | 
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner 
> class to prevent an app crash | 
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] 
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera 
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356843#comment-16356843
 ] 

ASF GitHub Bot commented on CB-10893:
-

janpio commented on issue #124: CB-10893: (android) Allow setting status bar 
color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#issuecomment-364088680
 
 
   Ok thanks @TimothyFehr. Some minor code fixes (indentation) and maybe some 
documentation and this should be good to merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356840#comment-16356840
 ] 

ASF GitHub Bot commented on CB-10893:
-

janpio commented on a change in pull request #124: CB-10893: (android) Allow 
setting status bar color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r166910844
 
 

 ##
 File path: src/android/SplashScreen.java
 ##
 @@ -283,7 +286,7 @@ public void run() {
 // Get reference to display
 Display display = 
cordova.getActivity().getWindowManager().getDefaultDisplay();
 Context context = webView.getContext();
-
+   Window splashWindow;
 
 Review comment:
   indentation


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356841#comment-16356841
 ] 

ASF GitHub Bot commented on CB-10893:
-

janpio commented on a change in pull request #124: CB-10893: (android) Allow 
setting status bar color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r166910928
 
 

 ##
 File path: src/android/SplashScreen.java
 ##
 @@ -307,12 +310,29 @@ public void run() {
 
 // Create and show the dialog
 splashDialog = new Dialog(context, 
android.R.style.Theme_Translucent_NoTitleBar);
-// check to see if the splash screen should be full screen
+splashWindow = splashDialog.getWindow();
+   // check to see if the splash screen should be full screen
 if ((cordova.getActivity().getWindow().getAttributes().flags & 
WindowManager.LayoutParams.FLAG_FULLSCREEN)
 == WindowManager.LayoutParams.FLAG_FULLSCREEN) {
-
splashDialog.getWindow().setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
+
splashWindow.setFlags(WindowManager.LayoutParams.FLAG_FULLSCREEN,
 WindowManager.LayoutParams.FLAG_FULLSCREEN);
 }
+
+// Status bar color just like cordova-plugin.statusbar
+String statusBarColor = 
preferences.getString("StatusBarBackgroundColor", "#00");
 
 Review comment:
   This should probably be added to the README as well, right?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356839#comment-16356839
 ] 

ASF GitHub Bot commented on CB-10893:
-

janpio commented on a change in pull request #124: CB-10893: (android) Allow 
setting status bar color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r166910720
 
 

 ##
 File path: src/android/SplashScreen.java
 ##
 @@ -307,12 +310,29 @@ public void run() {
 
 // Create and show the dialog
 splashDialog = new Dialog(context, 
android.R.style.Theme_Translucent_NoTitleBar);
-// check to see if the splash screen should be full screen
+splashWindow = splashDialog.getWindow();
+   // check to see if the splash screen should be full screen
 
 Review comment:
   fix indentation here please (space instead of tabs)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356733#comment-16356733
 ] 

ASF GitHub Bot commented on CB-10893:
-

TimothyFehr commented on issue #124: CB-10893: (android) Allow setting status 
bar color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#issuecomment-364056358
 
 
   I can confirm that it works as intended by the author and that the code 
quality is ok (i can see no big issue there)
   
   It is in our production app implemented like the author suggests and we have 
no issues so far.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10893) Allow setting status bar color on Android splashscreen

2018-02-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356731#comment-16356731
 ] 

ASF GitHub Bot commented on CB-10893:
-

TimothyFehr commented on issue #124: CB-10893: (android) Allow setting status 
bar color on Android splashscreen
URL: 
https://github.com/apache/cordova-plugin-splashscreen/pull/124#issuecomment-364056358
 
 
   I can confirm that it works as intended by the author and that the code 
quality is ok (i can see no big issue there)
   
   It is in our production app implemented like in the author suggests and we 
have no issues so far.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Allow setting status bar color on Android splashscreen
> --
>
> Key: CB-10893
> URL: https://issues.apache.org/jira/browse/CB-10893
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-splashscreen
> Environment: Android
>Reporter: Martin Buchalik
>Priority: Major
>
> When creating a custom Android theme, you can also set a status bar 
> background color.
> The splash screen doesn't seem to use the application's theme - the status 
> bar becomes black while displaying the splash screen image (no matter which 
> color I specify in android:colorPrimaryDark).
> Please add an option to set the status bar background color while the splash 
> screen image is displayed. Alternatively, inherit the application's status 
> bar settings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11893) CocoaPods support: Provide a way to add use_frameworks! on the Podfile

2018-02-08 Thread Shazron Abdullah (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356678#comment-16356678
 ] 

Shazron Abdullah commented on CB-11893:
---

[~swinx] yeah we were going for one kind of scenario (the most general case, 
with a restriction), but now as a workaround we should consider an "only 
dynamic frameworks" scenario. So when one plugin uses it, we print out a 
warning if other plugins that use CocoaPods don't use it. It will complicate 
things however, detecting this scenario.

So, if your plugin uses a dynamic framework in a CocoaPod, you *must* specify a 
flag. We can either overload the `type` or spec attribute. I prefer the `type` 
attribute. Here's a `type` attribute example:
{code:java}

 {code}
I don't want to create another attribute since that requires changes in 
cordova-lib, and not just cordova-ios. I'm just using the CocoaPods podfile 
option name directly, instead of creating a new name (easy to remember)

> CocoaPods support: Provide a way to add use_frameworks! on the Podfile
> --
>
> Key: CB-11893
> URL: https://issues.apache.org/jira/browse/CB-11893
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-ios
>Reporter: jcesarmobile
>Priority: Major
>  Labels: backlog
> Fix For: cordova-ios@5.0.0
>
> Attachments: Integrating Static Library With Cocoapods 
> Use_frameworks.pdf
>
>
> If the library you want to use on the plugin uses Swift or you want to use 
> dynamic frameworks you have to add use_frameworks! on the Podfile
> I don't think there is a way of adding it right now.
> We should provide a way of adding it 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org