[jira] [Commented] (CB-14031) iOS cancel action throws "has no access to assets" instead of "No Image Selected" error

[Adam Szmyd (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436774#comment-16436774
 ] 

Adam Szmyd commented on CB-14031:
-

It seems like the message is being manually generated inside 
"imagePickerControllerDidCancel" method: 
[https://github.com/apache/cordova-plugin-camera/blob/7c90555bd4bfbbdfe23f357f130eb1bbb7e4fce6/src/ios/CDVCamera.m#L561]

Not sure what was the use case of checking permissions out there but according 
to Apple docs 
([https://developer.apple.com/documentation/uikit/uiimagepickercontrollerdelegate/1619133-imagepickercontrollerdidcancel)]
 the delegate itself is always fired when user cancels the selection so maybe 
all the method should do is to send "No Images Selected" error always.

Also XCode alerts about some depreactions since iOS9 which might be the case 
here 
([https://developer.apple.com/documentation/assetslibrary/alassetslibrary|https://developer.apple.com/documentation/assetslibrary/alassetslibrary):]):

!deprecations.png|width=938,height=303!

> iOS cancel action throws "has no access to assets" instead of "No Image 
> Selected" error
> ---
>
> Key: CB-14031
> URL: https://issues.apache.org/jira/browse/CB-14031
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: iOS
>Reporter: Adam Szmyd
>Priority: Minor
> Attachments: deprecations.png
>
>
> When cancelling action of getting image from photo library, an error "has no 
> access to assets" is being returned instead of "No Image Selected"
> Using simple call like that:
> {code:java}
> navigator.camera.getPicture(function () {
> console.log('Success');
> }, function (error) {
>     console.error(error);
> }, {
>     sourceType: Camera.PictureSourceType.PHOTOLIBRARY
> });
> {code}
>  *This works properly using Camera capturing*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14031) iOS cancel action throws "has no access to assets" instead of "No Image Selected" error

[Adam Szmyd (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adam Szmyd updated CB-14031:

Attachment: deprecations.png

> iOS cancel action throws "has no access to assets" instead of "No Image 
> Selected" error
> ---
>
> Key: CB-14031
> URL: https://issues.apache.org/jira/browse/CB-14031
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: iOS
>Reporter: Adam Szmyd
>Priority: Minor
> Attachments: deprecations.png
>
>
> When cancelling action of getting image from photo library, an error "has no 
> access to assets" is being returned instead of "No Image Selected"
> Using simple call like that:
> {code:java}
> navigator.camera.getPicture(function () {
> console.log('Success');
> }, function (error) {
>     console.error(error);
> }, {
>     sourceType: Camera.PictureSourceType.PHOTOLIBRARY
> });
> {code}
>  *This works properly using Camera capturing*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14031) iOS cancel action throws "has no access to assets" instead of "No Image Selected" error

[Adam Szmyd (JIRA)]

Adam Szmyd created CB-14031:
---

 Summary: iOS cancel action throws "has no access to assets" 
instead of "No Image Selected" error
 Key: CB-14031
 URL: https://issues.apache.org/jira/browse/CB-14031
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-plugin-camera
 Environment: iOS
Reporter: Adam Szmyd


When cancelling action of getting image from photo library, an error "has no 
access to assets" is being returned instead of "No Image Selected"

Using simple call like that:
{code:java}
navigator.camera.getPicture(function () {
console.log('Success');
}, function (error) {
    console.error(error);
}, {
    sourceType: Camera.PictureSourceType.PHOTOLIBRARY
});
{code}
 *This works properly using Camera capturing*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436651#comment-16436651
 ] 

ASF GitHub Bot commented on CB-14030:
-

stevengill opened a new pull request #812: CB-14030: added plugins release blog 
post
URL: https://github.com/apache/cordova-docs/pull/812
 
 
   
   
   ### Platforms affected
   
   
   ### What does this PR do?
   
   
   ### What testing has been done on this change?
   
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[Steve Gill (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436634#comment-16436634
 ] 

Steve Gill commented on CB-14030:
-

vibration@3.1.0
statusbar@2.4.2
media-capture@3.0.2
inappbrowser@3.0.0
globalization@1.11.0
device@2.0.2
camera@4.0.3
battery-status@2.0.2

> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436632#comment-16436632
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit aebf1a1445bb0b5daa92634a0f245976e729045e in 
cordova-plugin-battery-status's branch refs/heads/master from [~stevegill]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=aebf1a1
 ]

CB-14030 Updated version and RELEASENOTES.md for release 2.0.2 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13764) Add build-tools-26.0.2 to travis for cordova-plugin-battery-status

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436628#comment-16436628
 ] 

ASF subversion and git services commented on CB-13764:
--

Commit 91010ae97c4d1561ab490443fe941162848d55d1 in 
cordova-plugin-battery-status's branch refs/heads/2.0.x from [~jcesarmobile]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=91010ae
 ]

Merge pull request #64 from jcesarmobile/CB-13764

CB-13764: Add build-tools-26.0.2 to travis

> Add build-tools-26.0.2 to travis for cordova-plugin-battery-status
> --
>
> Key: CB-13764
> URL: https://issues.apache.org/jira/browse/CB-13764
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436630#comment-16436630
 ] 

ASF subversion and git services commented on CB-10645:
--

Commit c2a526e673a793f07a5a5341bcc1b03c0121f476 in 
cordova-plugin-battery-status's branch refs/heads/2.0.x from [~jcesarmobile]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=c2a526e
 ]

Merge pull request #31 from Geotab/CB-10645cordova-plugin-battery-status

CB-10645 The battery status handler doesn't reinitialize on Android after 
window.location.reload()

> The battery status handler doesn't reinitialize on Android after 
> window.location.reload()
> -
>
> Key: CB-10645
> URL: https://issues.apache.org/jira/browse/CB-10645
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-battery-status
> Environment: Android
>Reporter: Aaron Toth
>Priority: Minor
>  Labels: android, reload, triaged
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Instead of throwing an error, rather remove the status handler and 
> re-initialize.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436625#comment-16436625
 ] 

ASF subversion and git services commented on CB-10645:
--

Commit 7d04d6dbaa0b67686facd460458f42a991b66ffb in 
cordova-plugin-battery-status's branch refs/heads/2.0.x from [~aaront]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=7d04d6d
 ]

CB-10645 The battery status handler doesn't reinitialize on Android after 
window.location.reload(). Instead of throwing an error, rather remove the 
status handler and re-initialize.


> The battery status handler doesn't reinitialize on Android after 
> window.location.reload()
> -
>
> Key: CB-10645
> URL: https://issues.apache.org/jira/browse/CB-10645
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-battery-status
> Environment: Android
>Reporter: Aaron Toth
>Priority: Minor
>  Labels: android, reload, triaged
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Instead of throwing an error, rather remove the status handler and 
> re-initialize.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436631#comment-16436631
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit aebf1a1445bb0b5daa92634a0f245976e729045e in 
cordova-plugin-battery-status's branch refs/heads/2.0.x from [~stevegill]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=aebf1a1
 ]

CB-14030 Updated version and RELEASENOTES.md for release 2.0.2 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10645) The battery status handler doesn't reinitialize on Android after window.location.reload()

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436629#comment-16436629
 ] 

ASF subversion and git services commented on CB-10645:
--

Commit c2a526e673a793f07a5a5341bcc1b03c0121f476 in 
cordova-plugin-battery-status's branch refs/heads/2.0.x from [~jcesarmobile]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=c2a526e
 ]

Merge pull request #31 from Geotab/CB-10645cordova-plugin-battery-status

CB-10645 The battery status handler doesn't reinitialize on Android after 
window.location.reload()

> The battery status handler doesn't reinitialize on Android after 
> window.location.reload()
> -
>
> Key: CB-10645
> URL: https://issues.apache.org/jira/browse/CB-10645
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-battery-status
> Environment: Android
>Reporter: Aaron Toth
>Priority: Minor
>  Labels: android, reload, triaged
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Instead of throwing an error, rather remove the status handler and 
> re-initialize.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13764) Add build-tools-26.0.2 to travis for cordova-plugin-battery-status

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436626#comment-16436626
 ] 

ASF subversion and git services commented on CB-13764:
--

Commit f5a77afc7acc7695e78ea4f6bb75515a72e89ff2 in 
cordova-plugin-battery-status's branch refs/heads/2.0.x from [~jcesarmobile]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=f5a77af
 ]

CB-13764: Add build-tools-26.0.2 to travis


> Add build-tools-26.0.2 to travis for cordova-plugin-battery-status
> --
>
> Key: CB-13764
> URL: https://issues.apache.org/jira/browse/CB-13764
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13764) Add build-tools-26.0.2 to travis for cordova-plugin-battery-status

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436627#comment-16436627
 ] 

ASF subversion and git services commented on CB-13764:
--

Commit 91010ae97c4d1561ab490443fe941162848d55d1 in 
cordova-plugin-battery-status's branch refs/heads/2.0.x from [~jcesarmobile]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-battery-status.git;h=91010ae
 ]

Merge pull request #64 from jcesarmobile/CB-13764

CB-13764: Add build-tools-26.0.2 to travis

> Add build-tools-26.0.2 to travis for cordova-plugin-battery-status
> --
>
> Key: CB-13764
> URL: https://issues.apache.org/jira/browse/CB-13764
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436604#comment-16436604
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit 9d05a1e58fc869d3f58102724bfe377f56a4067c in cordova-plugin-camera's 
branch refs/heads/4.0.x from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=9d05a1e ]

CB-14030 Updated version and RELEASENOTES.md for release 4.0.3 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12593) FileProvider conflict in the camera plugin

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436597#comment-16436597
 ] 

ASF subversion and git services commented on CB-12593:
--

Commit cfefa53272d48c0067bd4a71345f1d6b328ff96f in cordova-plugin-camera's 
branch refs/heads/4.0.x from [~cjpearson]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=cfefa53 ]

CB-12593: (android) Fix potential FileProvider conflicts


> FileProvider conflict in the camera plugin
> --
>
> Key: CB-12593
> URL: https://issues.apache.org/jira/browse/CB-12593
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: Connor Pearson
>Priority: Major
>  Labels: android-next
>
> Version 2.3.1 of the camera plugin adds a FileProvider to the 
> AndroidManifest. I already have a plugin that is doing this, so the duplicate 
> entries cause a build error.
> {code}
> Element provider#android.support.v4.content.FileProvider at 
> AndroidManifest.xml:19:9-21:20 duplicated with element declared at 
> AndroidManifest.xml:16:9-18:20
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13826) Plugins Release Jan 24, 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436598#comment-16436598
 ] 

ASF subversion and git services commented on CB-13826:
--

Commit 4b276ee5349528758d32737a54eeb67a1891fef7 in cordova-plugin-camera's 
branch refs/heads/4.0.x from [~surajpindoria]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=4b276ee ]

CB-13826 Updated version and RELEASENOTES.md for release 4.0.2


> Plugins Release Jan 24, 2018
> 
>
> Key: CB-13826
> URL: https://issues.apache.org/jira/browse/CB-13826
> Project: Apache Cordova
>  Issue Type: Task
>Reporter: Suraj Pindoria
>Assignee: Suraj Pindoria
>Priority: Major
>
> Following steps at 
> [https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12593) FileProvider conflict in the camera plugin

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436603#comment-16436603
 ] 

ASF subversion and git services commented on CB-12593:
--

Commit c8581ba2c9b057987b890483c22c09bb17414077 in cordova-plugin-camera's 
branch refs/heads/4.0.x from [~bowserj]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=c8581ba ]

Merge pull request #275 from cjpearson/CB12953

CB-12593: (android) Fix potential FileProvider conflicts

> FileProvider conflict in the camera plugin
> --
>
> Key: CB-12593
> URL: https://issues.apache.org/jira/browse/CB-12593
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: Connor Pearson
>Priority: Major
>  Labels: android-next
>
> Version 2.3.1 of the camera plugin adds a FileProvider to the 
> AndroidManifest. I already have a plugin that is doing this, so the duplicate 
> entries cause a build error.
> {code}
> Element provider#android.support.v4.content.FileProvider at 
> AndroidManifest.xml:19:9-21:20 duplicated with element declared at 
> AndroidManifest.xml:16:9-18:20
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436600#comment-16436600
 ] 

ASF subversion and git services commented on CB-13415:
--

Commit bf935dfbd2c2a991f6632424243a26858584821b in cordova-plugin-camera's 
branch refs/heads/4.0.x from [~alpeshster]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=bf935df ]

CB-13415 (android) Importing corrupt images using the Camera plugin c… (#309)

* CB-13415 (android) Importing corrupt images using the Camera plugin crashes 
the app


> Importing corrupt images using the Camera plugin crashes the app
> 
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>Reporter: Shemrick Flannigan
>Priority: Critical
>  Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the 
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the 
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error 
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app | 
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner 
> class to prevent an app crash | 
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] 
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera 
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436601#comment-16436601
 ] 

ASF subversion and git services commented on CB-13415:
--

Commit bf935dfbd2c2a991f6632424243a26858584821b in cordova-plugin-camera's 
branch refs/heads/4.0.x from [~alpeshster]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=bf935df ]

CB-13415 (android) Importing corrupt images using the Camera plugin c… (#309)

* CB-13415 (android) Importing corrupt images using the Camera plugin crashes 
the app


> Importing corrupt images using the Camera plugin crashes the app
> 
>
> Key: CB-13415
> URL: https://issues.apache.org/jira/browse/CB-13415
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
> Environment: Android: OS 7.0, Phone Model: Moto G5 Plus
> iOS: OS 10.1.1 (14B150)
>Reporter: Shemrick Flannigan
>Priority: Critical
>  Labels: android, camera, cameraui, ios
>
> ISSUE
> Importing corrupt images using the Camera plugin crashes the app
> Current Behavior
> # Importing a corrupt image using the Cordova Camera plugin crashes the 
> Cordova app which uses the plugin
> Expected Behavior
> # Importing a corrupt image using the Cordova Camera plugin:
> #* Throws an exception which can be caught by the Cordova app which uses the 
> plugin
> #* Does not crash the Cordova app which uses the plugin
> #* Allows the Cordova app which uses the plugin to render a Toast error 
> message relaying the error
> # # Platforms affected
> #* Android
> #* iOS
> REFERENCES
> # [Sample corrupt image which crashes the app | 
> https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0]
> # [Technique used to wrap the call in a Try/Catch block in a callable inner 
> class to prevent an app crash | 
> https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] 
> ADDITIONAL INFORMATION
> # Importing corrupt images does not crash apps which do not use the Camera 
> plugin, such as:
> #* Yelp mobile app
> #* Slack mobile app



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13854) Camera opens in portrait orientation on iphones

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436602#comment-16436602
 ] 

ASF subversion and git services commented on CB-13854:
--

Commit 7c90555bd4bfbbdfe23f357f130eb1bbb7e4fce6 in cordova-plugin-camera's 
branch refs/heads/4.0.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=7c90555 ]

CB-13854(ios): fix Camera opens in portrait orientation on iphones


> Camera opens in portrait orientation on iphones
> ---
>
> Key: CB-13854
> URL: https://issues.apache.org/jira/browse/CB-13854
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios, cordova-plugin-camera
>Affects Versions: cordova-ios 4.5.0
> Environment: Cordova 7.1.0, Cordova 8.0.0
> iOS 9, 10, 11
> cordova-ios 4.5.x
>  
>Reporter: Damian Ibbotson
>Assignee: jcesarmobile
>Priority: Major
>
> Using app in landscape on iphone and open the camera using a plugin 
> (cordova-plugin-camera).  The camera opens in portrait mode.  Dialogs to 
> request permissions are therefore rotated, as is button text.
> Replicated with HelloCordova app with addition of cordova-plugin-camera.
> Using cordova-plugin-screen-orientation, we can see that an event to change 
> the orientation to portrait-primary is fired when the camera is opened.
>  
> Does not affect ipads.
>  
>  
>    



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13826) Plugins Release Jan 24, 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436599#comment-16436599
 ] 

ASF subversion and git services commented on CB-13826:
--

Commit ad8788a5e6acc9984029baf0f937fb73d999bc39 in cordova-plugin-camera's 
branch refs/heads/4.0.x from [~surajpindoria]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=ad8788a ]

CB-13826 Incremented plugin version.


> Plugins Release Jan 24, 2018
> 
>
> Key: CB-13826
> URL: https://issues.apache.org/jira/browse/CB-13826
> Project: Apache Cordova
>  Issue Type: Task
>Reporter: Suraj Pindoria
>Assignee: Suraj Pindoria
>Priority: Major
>
> Following steps at 
> [https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436594#comment-16436594
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit 9d05a1e58fc869d3f58102724bfe377f56a4067c in cordova-plugin-camera's 
branch refs/heads/master from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=9d05a1e ]

CB-14030 Updated version and RELEASENOTES.md for release 4.0.3 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13893) delete libz.tbd from device plugin

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436589#comment-16436589
 ] 

ASF subversion and git services commented on CB-13893:
--

Commit 34260f62da5bfecbb28ca69d1578777b0656c009 in cordova-plugin-device's 
branch refs/heads/2.0.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-device.git;h=34260f6 ]

CB-13893: (ios) delete libz.tbd from device plugin


> delete libz.tbd from device plugin
> --
>
> Key: CB-13893
> URL: https://issues.apache.org/jira/browse/CB-13893
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-device
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>
> Looks like it was added by mistake and it works fine without it.
> [https://github.com/apache/cordova-plugin-device/blob/master/plugin.xml#L59]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13752) Add build-tools-26.0.2 to travis for cordova-plugin-device

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436588#comment-16436588
 ] 

ASF subversion and git services commented on CB-13752:
--

Commit f3c62e63578f9338d5ac7c5d1442bb8948dfd7ad in cordova-plugin-device's 
branch refs/heads/2.0.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-device.git;h=f3c62e6 ]

Merge pull request #76 from jcesarmobile/CB-13752

CB-13752: Add build-tools-26.0.2 to travis

> Add build-tools-26.0.2 to travis for cordova-plugin-device
> --
>
> Key: CB-13752
> URL: https://issues.apache.org/jira/browse/CB-13752
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13893) delete libz.tbd from device plugin

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436590#comment-16436590
 ] 

ASF subversion and git services commented on CB-13893:
--

Commit 7a2af2d546e0f38553a3816c10b5363b0b3651fb in cordova-plugin-device's 
branch refs/heads/2.0.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-device.git;h=7a2af2d ]

Merge pull request #77 from jcesarmobile/CB-13893

CB-13893: (ios) delete libz.tbd from device plugin

> delete libz.tbd from device plugin
> --
>
> Key: CB-13893
> URL: https://issues.apache.org/jira/browse/CB-13893
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-device
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>
> Looks like it was added by mistake and it works fine without it.
> [https://github.com/apache/cordova-plugin-device/blob/master/plugin.xml#L59]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436592#comment-16436592
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit e83c1afd848ac05505b9b8fa11cb5061230c4463 in cordova-plugin-device's 
branch refs/heads/2.0.x from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-device.git;h=e83c1af ]

CB-14030 Updated version and RELEASENOTES.md for release 2.0.2 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13752) Add build-tools-26.0.2 to travis for cordova-plugin-device

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436587#comment-16436587
 ] 

ASF subversion and git services commented on CB-13752:
--

Commit f3c62e63578f9338d5ac7c5d1442bb8948dfd7ad in cordova-plugin-device's 
branch refs/heads/2.0.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-device.git;h=f3c62e6 ]

Merge pull request #76 from jcesarmobile/CB-13752

CB-13752: Add build-tools-26.0.2 to travis

> Add build-tools-26.0.2 to travis for cordova-plugin-device
> --
>
> Key: CB-13752
> URL: https://issues.apache.org/jira/browse/CB-13752
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13752) Add build-tools-26.0.2 to travis for cordova-plugin-device

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436586#comment-16436586
 ] 

ASF subversion and git services commented on CB-13752:
--

Commit 4c2d3a97d05521ec51bcaa396887648de4be9d61 in cordova-plugin-device's 
branch refs/heads/2.0.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-device.git;h=4c2d3a9 ]

CB-13752: Add build-tools-26.0.2 to travis


> Add build-tools-26.0.2 to travis for cordova-plugin-device
> --
>
> Key: CB-13752
> URL: https://issues.apache.org/jira/browse/CB-13752
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436585#comment-16436585
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit e83c1afd848ac05505b9b8fa11cb5061230c4463 in cordova-plugin-device's 
branch refs/heads/master from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-device.git;h=e83c1af ]

CB-14030 Updated version and RELEASENOTES.md for release 2.0.2 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13893) delete libz.tbd from device plugin

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436591#comment-16436591
 ] 

ASF subversion and git services commented on CB-13893:
--

Commit 7a2af2d546e0f38553a3816c10b5363b0b3651fb in cordova-plugin-device's 
branch refs/heads/2.0.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-device.git;h=7a2af2d ]

Merge pull request #77 from jcesarmobile/CB-13893

CB-13893: (ios) delete libz.tbd from device plugin

> delete libz.tbd from device plugin
> --
>
> Key: CB-13893
> URL: https://issues.apache.org/jira/browse/CB-13893
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-device
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>
> Looks like it was added by mistake and it works fine without it.
> [https://github.com/apache/cordova-plugin-device/blob/master/plugin.xml#L59]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436581#comment-16436581
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit 65331146ca90d92d4fcb47c58937a7fcb8933797 in 
cordova-plugin-globalization's branch refs/heads/master from [~stevegill]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-globalization.git;h=6533114
 ]

CB-14030 Updated version and RELEASENOTES.md for release 1.11.0 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13866) Camera opens in portrait orientation on iphones

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436575#comment-16436575
 ] 

ASF subversion and git services commented on CB-13866:
--

Commit a07323b94faf46ca6f9aae08213aaac614218b34 in 
cordova-plugin-media-capture's branch refs/heads/3.0.x from [~jcesarmobile]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=a07323b
 ]

CB-13866(ios): fix Camera opens in portrait orientation on iphones


> Camera opens in portrait orientation on iphones
> ---
>
> Key: CB-13866
> URL: https://issues.apache.org/jira/browse/CB-13866
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios, cordova-plugin-media-capture
>Affects Versions: cordova-ios 4.5.0
> Environment: Cordova 7.1.0, Cordova 8.0.0
> iOS 9, 10, 11
> cordova-ios 4.5.x
>  
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>
> Using app in landscape on iphone and open the camera using a plugin 
> (cordova-plugin-media-capture).  The camera opens in portrait mode.  Dialogs 
> to request permissions are therefore rotated, as is button text.
> Replicated with HelloCordova app with addition of 
> cordova-plugin-media-capture.
> Using cordova-plugin-screen-orientation, we can see that an event to change 
> the orientation to portrait-primary is fired when the camera is opened.
>  
> Does not affect ipads.
>  
>  
>    



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13866) Camera opens in portrait orientation on iphones

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436578#comment-16436578
 ] 

ASF subversion and git services commented on CB-13866:
--

Commit 9b360841266567f262c5da73b4cef45805f600f8 in 
cordova-plugin-media-capture's branch refs/heads/3.0.x from [~jcesarmobile]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=9b36084
 ]

Merge pull request #93 from jcesarmobile/CB-13866

CB-13866(ios): fix Camera opens in portrait orientation on iphones

> Camera opens in portrait orientation on iphones
> ---
>
> Key: CB-13866
> URL: https://issues.apache.org/jira/browse/CB-13866
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios, cordova-plugin-media-capture
>Affects Versions: cordova-ios 4.5.0
> Environment: Cordova 7.1.0, Cordova 8.0.0
> iOS 9, 10, 11
> cordova-ios 4.5.x
>  
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>
> Using app in landscape on iphone and open the camera using a plugin 
> (cordova-plugin-media-capture).  The camera opens in portrait mode.  Dialogs 
> to request permissions are therefore rotated, as is button text.
> Replicated with HelloCordova app with addition of 
> cordova-plugin-media-capture.
> Using cordova-plugin-screen-orientation, we can see that an event to change 
> the orientation to portrait-primary is fired when the camera is opened.
>  
> Does not affect ipads.
>  
>  
>    



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13755) Add build-tools-26.0.2 to travis for cordova-plugin-media-capture

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436572#comment-16436572
 ] 

ASF subversion and git services commented on CB-13755:
--

Commit 240afae6f66f9d1653842095398043bba1194385 in 
cordova-plugin-media-capture's branch refs/heads/3.0.x from [~jcesarmobile]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=240afae
 ]

Merge pull request #91 from jcesarmobile/CB-13755

CB-13755: Add build-tools-26.0.2 to travis

> Add build-tools-26.0.2 to travis for cordova-plugin-media-capture
> -
>
> Key: CB-13755
> URL: https://issues.apache.org/jira/browse/CB-13755
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13755) Add build-tools-26.0.2 to travis for cordova-plugin-media-capture

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436573#comment-16436573
 ] 

ASF subversion and git services commented on CB-13755:
--

Commit 240afae6f66f9d1653842095398043bba1194385 in 
cordova-plugin-media-capture's branch refs/heads/3.0.x from [~jcesarmobile]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=240afae
 ]

Merge pull request #91 from jcesarmobile/CB-13755

CB-13755: Add build-tools-26.0.2 to travis

> Add build-tools-26.0.2 to travis for cordova-plugin-media-capture
> -
>
> Key: CB-13755
> URL: https://issues.apache.org/jira/browse/CB-13755
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13866) Camera opens in portrait orientation on iphones

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436576#comment-16436576
 ] 

ASF subversion and git services commented on CB-13866:
--

Commit 9b360841266567f262c5da73b4cef45805f600f8 in 
cordova-plugin-media-capture's branch refs/heads/3.0.x from [~jcesarmobile]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=9b36084
 ]

Merge pull request #93 from jcesarmobile/CB-13866

CB-13866(ios): fix Camera opens in portrait orientation on iphones

> Camera opens in portrait orientation on iphones
> ---
>
> Key: CB-13866
> URL: https://issues.apache.org/jira/browse/CB-13866
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios, cordova-plugin-media-capture
>Affects Versions: cordova-ios 4.5.0
> Environment: Cordova 7.1.0, Cordova 8.0.0
> iOS 9, 10, 11
> cordova-ios 4.5.x
>  
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>
> Using app in landscape on iphone and open the camera using a plugin 
> (cordova-plugin-media-capture).  The camera opens in portrait mode.  Dialogs 
> to request permissions are therefore rotated, as is button text.
> Replicated with HelloCordova app with addition of 
> cordova-plugin-media-capture.
> Using cordova-plugin-screen-orientation, we can see that an event to change 
> the orientation to portrait-primary is fired when the camera is opened.
>  
> Does not affect ipads.
>  
>  
>    



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13755) Add build-tools-26.0.2 to travis for cordova-plugin-media-capture

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436571#comment-16436571
 ] 

ASF subversion and git services commented on CB-13755:
--

Commit 17122699793401aad37d8d6020192c7495cbc4fc in 
cordova-plugin-media-capture's branch refs/heads/3.0.x from [~jcesarmobile]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=1712269
 ]

CB-13755: Add build-tools-26.0.2 to travis


> Add build-tools-26.0.2 to travis for cordova-plugin-media-capture
> -
>
> Key: CB-13755
> URL: https://issues.apache.org/jira/browse/CB-13755
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436579#comment-16436579
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit 288a47eee12b8cff7c3512d87b5aa2023daa46d5 in 
cordova-plugin-media-capture's branch refs/heads/3.0.x from [~stevegill]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=288a47e
 ]

CB-14030 Updated version and RELEASENOTES.md for release 3.0.2 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13820) Report Link from git repo throwing error

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436574#comment-16436574
 ] 

ASF subversion and git services commented on CB-13820:
--

Commit ec680de70b96fc476c94c6fb51b3e7979f7a883b in 
cordova-plugin-media-capture's branch refs/heads/3.0.x from Jan Piotrowski
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=ec680de
 ]

CB-13820 fix "report issue" link

> Report Link from git repo throwing error
> 
>
> Key: CB-13820
> URL: https://issues.apache.org/jira/browse/CB-13820
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-media-capture
>Reporter: Nicolas Marseaud
>Priority: Trivial
>
> The link for submitting issues from the git repo at 
> [https://github.com/apache/cordova-plugin-media-capture] is broken
> "Report issues with this plugin on the [Apache Cordova issue 
> tracker|https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%29%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Plugin%20Media%20Capture%22%20ORDER%20BY%20priority%20DESC%2C%20summary%20ASC%2C%20updatedDate%20DESC]
>  "



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436566#comment-16436566
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit 288a47eee12b8cff7c3512d87b5aa2023daa46d5 in 
cordova-plugin-media-capture's branch refs/heads/master from [~stevegill]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-media-capture.git;h=288a47e
 ]

CB-14030 Updated version and RELEASENOTES.md for release 3.0.2 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436550#comment-16436550
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit 200f7c19235e1956458f3df58dcce07fe93ece66 in 
cordova-plugin-inappbrowser's branch refs/heads/3.0.x from [~stevegill]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=200f7c1 
]

CB-14030 Updated version and RELEASENOTES.md for release 3.0.0 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436551#comment-16436551
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit 200f7c19235e1956458f3df58dcce07fe93ece66 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~stevegill]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=200f7c1 
]

CB-14030 Updated version and RELEASENOTES.md for release 3.0.0 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436544#comment-16436544
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit fbc4862dbd0713a1eb276eb0e184a2963c08d7aa in cordova-plugin-statusbar's 
branch refs/heads/2.4.x from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=fbc4862 ]

CB-14030 Updated version and RELEASENOTES.md for release 2.4.2 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13754) Add build-tools-26.0.2 to travis for cordova-plugin-statusbar

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436539#comment-16436539
 ] 

ASF subversion and git services commented on CB-13754:
--

Commit e3138a9f085dfe1bbb1aab3b37e968b6053e8da3 in cordova-plugin-statusbar's 
branch refs/heads/2.4.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=e3138a9 ]

Merge pull request #94 from jcesarmobile/CB-13754

CB-13754: Add build-tools-26.0.2 to travis

> Add build-tools-26.0.2 to travis for cordova-plugin-statusbar
> -
>
> Key: CB-13754
> URL: https://issues.apache.org/jira/browse/CB-13754
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13754) Add build-tools-26.0.2 to travis for cordova-plugin-statusbar

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436538#comment-16436538
 ] 

ASF subversion and git services commented on CB-13754:
--

Commit f1407e7ae5e2e65d2844a06d0f657b086269bd4e in cordova-plugin-statusbar's 
branch refs/heads/2.4.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=f1407e7 ]

CB-13754: Add build-tools-26.0.2 to travis


> Add build-tools-26.0.2 to travis for cordova-plugin-statusbar
> -
>
> Key: CB-13754
> URL: https://issues.apache.org/jira/browse/CB-13754
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13754) Add build-tools-26.0.2 to travis for cordova-plugin-statusbar

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436540#comment-16436540
 ] 

ASF subversion and git services commented on CB-13754:
--

Commit e3138a9f085dfe1bbb1aab3b37e968b6053e8da3 in cordova-plugin-statusbar's 
branch refs/heads/2.4.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=e3138a9 ]

Merge pull request #94 from jcesarmobile/CB-13754

CB-13754: Add build-tools-26.0.2 to travis

> Add build-tools-26.0.2 to travis for cordova-plugin-statusbar
> -
>
> Key: CB-13754
> URL: https://issues.apache.org/jira/browse/CB-13754
> Project: Apache Cordova
>  Issue Type: Sub-task
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12679) Remove Permissions section from cordova-plugin-statusbar docs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436542#comment-16436542
 ] 

ASF subversion and git services commented on CB-12679:
--

Commit 4c1507b525e4631ad04f3adada898845da3e3cbc in cordova-plugin-statusbar's 
branch refs/heads/2.4.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=4c1507b ]

Merge pull request #95 from jcesarmobile/CB-12679

CB-12679: Remove Permissions section

> Remove Permissions section from cordova-plugin-statusbar docs
> -
>
> Key: CB-12679
> URL: https://issues.apache.org/jira/browse/CB-12679
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>  Labels: backlog, easyfix
>
> The permissions section of the cordova-plugin-statusbar doesn't make sense as 
> the feature tags are added on the platforms config.xml on plugin install
> https://github.com/apache/cordova-plugin-statusbar#permissions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12679) Remove Permissions section from cordova-plugin-statusbar docs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436543#comment-16436543
 ] 

ASF subversion and git services commented on CB-12679:
--

Commit 4c1507b525e4631ad04f3adada898845da3e3cbc in cordova-plugin-statusbar's 
branch refs/heads/2.4.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=4c1507b ]

Merge pull request #95 from jcesarmobile/CB-12679

CB-12679: Remove Permissions section

> Remove Permissions section from cordova-plugin-statusbar docs
> -
>
> Key: CB-12679
> URL: https://issues.apache.org/jira/browse/CB-12679
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>  Labels: backlog, easyfix
>
> The permissions section of the cordova-plugin-statusbar doesn't make sense as 
> the feature tags are added on the platforms config.xml on plugin install
> https://github.com/apache/cordova-plugin-statusbar#permissions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12679) Remove Permissions section from cordova-plugin-statusbar docs

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436541#comment-16436541
 ] 

ASF subversion and git services commented on CB-12679:
--

Commit 62e8a187c1ce182d53467d76b63544e7a2bac806 in cordova-plugin-statusbar's 
branch refs/heads/2.4.x from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=62e8a18 ]

CB-12679: Remove Permissions section


> Remove Permissions section from cordova-plugin-statusbar docs
> -
>
> Key: CB-12679
> URL: https://issues.apache.org/jira/browse/CB-12679
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>  Labels: backlog, easyfix
>
> The permissions section of the cordova-plugin-statusbar doesn't make sense as 
> the feature tags are added on the platforms config.xml on plugin install
> https://github.com/apache/cordova-plugin-statusbar#permissions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436536#comment-16436536
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit fbc4862dbd0713a1eb276eb0e184a2963c08d7aa in cordova-plugin-statusbar's 
branch refs/heads/master from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-statusbar.git;h=fbc4862 ]

CB-14030 Updated version and RELEASENOTES.md for release 2.4.2 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14030) Plugins Release, Thu Apr 12 2018

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436532#comment-16436532
 ] 

ASF subversion and git services commented on CB-14030:
--

Commit 0b323409f963fe4c0f3e968a2a20b593b66bde98 in cordova-plugin-vibration's 
branch refs/heads/master from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=0b32340 ]

CB-14030 Updated version and RELEASENOTES.md for release 3.1.0 (via coho)


> Plugins Release, Thu Apr 12 2018
> 
>
> Key: CB-14030
> URL: https://issues.apache.org/jira/browse/CB-14030
> Project: Apache Cordova
>  Issue Type: Task
>  Components: AllPlugins
>Reporter: Steve Gill
>Assignee: Steve Gill
>Priority: Major
>
> Following steps at 
> https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
> Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14030) Plugins Release, Thu Apr 12 2018

[Steve Gill (JIRA)]

Steve Gill created CB-14030:
---

 Summary: Plugins Release, Thu Apr 12 2018
 Key: CB-14030
 URL: https://issues.apache.org/jira/browse/CB-14030
 Project: Apache Cordova
  Issue Type: Task
  Components: AllPlugins
Reporter: Steve Gill
Assignee: Steve Gill


Following steps at 
https://github.com/apache/cordova-coho/blob/master/docs/plugins-release-process.md
Generated automatically using cordova-coho.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Resolved] (CB-14022) Vibrate plugin does not work

[Steve Gill (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Gill resolved CB-14022.
-
Resolution: Fixed

> Vibrate plugin does not work
> 
>
> Key: CB-14022
> URL: https://issues.apache.org/jira/browse/CB-14022
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova@7.0.0, cordova-android-7.0.0
>Reporter: Mahesh Kanniah
>Assignee: Joe Bowser
>Priority: Minor
> Fix For: Master
>
>
> navigator.vibrate does not work.
> Used to work in earlier versions but just fails to work.
> Tested on multiple devices running different android versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14022) Vibrate plugin does not work

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436438#comment-16436438
 ] 

ASF subversion and git services commented on CB-14022:
--

Commit 930b91d57635fb17d6c7dc38d56b74bd2171aa0c in cordova-plugin-vibration's 
branch refs/heads/master from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=930b91d ]

CB-14022: documented android quirk with vibration


> Vibrate plugin does not work
> 
>
> Key: CB-14022
> URL: https://issues.apache.org/jira/browse/CB-14022
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova@7.0.0, cordova-android-7.0.0
>Reporter: Mahesh Kanniah
>Assignee: Joe Bowser
>Priority: Minor
> Fix For: Master
>
>
> navigator.vibrate does not work.
> Used to work in earlier versions but just fails to work.
> Tested on multiple devices running different android versions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13659) InAppBrowser: Add option to disable spinner on iOS

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436160#comment-16436160
 ] 

ASF subversion and git services commented on CB-13659:
--

Commit 695e1b0f02d4d8a3ac454cffecb2a0100774abcd in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~NiklasMerz]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=695e1b0 
]

CB-13659 (iOS) Add hidespinner option

Signed-off-by: Niklas Merz 


> InAppBrowser: Add option to disable spinner on iOS
> --
>
> Key: CB-13659
> URL: https://issues.apache.org/jira/browse/CB-13659
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Reporter: Niklas Merz
>Priority: Major
>  Labels: newbie, starter
>
> Like mentioned in this pull request 
> [https://github.com/apache/cordova-plugin-inappbrowser/pull/89], the 
> inappbrowser needs flags to disable the loading spinner



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13659) InAppBrowser: Add option to disable spinner on iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436159#comment-16436159
 ] 

ASF GitHub Bot commented on CB-13659:
-

stevengill closed pull request #254: CB-13659 (iOS) Add hidespinner option
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/254
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index a4b7cd928..de4c8eef3 100644
--- a/README.md
+++ b/README.md
@@ -101,8 +101,8 @@ instance, or the system browser.
 
 - __options__: Options for the `InAppBrowser`. Optional, defaulting to: 
`location=yes`. _(String)_
 
-The `options` string must not contain any blank space, and each feature's 
name/value pairs must be separated by a comma. Feature names are case 
insensitive. 
-
+The `options` string must not contain any blank space, and each feature's 
name/value pairs must be separated by a comma. Feature names are case 
insensitive.
+
 All platforms support:
 
 - __location__: Set to `yes` or `no` to turn the `InAppBrowser`'s location 
bar on or off.
@@ -134,6 +134,7 @@ instance, or the system browser.
 - __presentationstyle__:  Set to `pagesheet`, `formsheet` or `fullscreen` 
to set the [presentation 
style](http://developer.apple.com/library/ios/documentation/UIKit/Reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/modalPresentationStyle)
 (defaults to `fullscreen`).
 - __transitionstyle__: Set to `fliphorizontal`, `crossdissolve` or 
`coververtical` to set the [transition 
style](http://developer.apple.com/library/ios/#documentation/UIKit/Reference/UIViewController_Class/Reference/Reference.html#//apple_ref/occ/instp/UIViewController/modalTransitionStyle)
 (defaults to `coververtical`).
 - __toolbarposition__: Set to `top` or `bottom` (default is `bottom`). 
Causes the toolbar to be at the top or bottom of the window.
+- __hidespinner__: Set to `yes` or `no` to change the visibility of the 
loading indicator (defaults to `no`).
 
 Windows supports these additional options:
 
diff --git a/src/ios/CDVInAppBrowser.h b/src/ios/CDVInAppBrowser.h
index d258eb09f..0ad9bd5ea 100644
--- a/src/ios/CDVInAppBrowser.h
+++ b/src/ios/CDVInAppBrowser.h
@@ -52,6 +52,7 @@
 @property (nonatomic, copy) NSString* toolbarposition;
 @property (nonatomic, assign) BOOL clearcache;
 @property (nonatomic, assign) BOOL clearsessioncache;
+@property (nonatomic, assign) BOOL hidespinner;
 
 @property (nonatomic, copy) NSString* presentationstyle;
 @property (nonatomic, copy) NSString* transitionstyle;
@@ -74,13 +75,13 @@
 NSString* _prevUserAgent;
 NSInteger _userAgentLockToken;
 CDVInAppBrowserOptions *_browserOptions;
-
+
 #ifdef __CORDOVA_4_0_0
 CDVUIWebViewDelegate* _webViewDelegate;
 #else
 CDVWebViewDelegate* _webViewDelegate;
 #endif
-
+
 }
 
 @property (nonatomic, strong) IBOutlet UIWebView* webView;
@@ -110,4 +111,3 @@
 @property (nonatomic, weak) id  
orientationDelegate;
 
 @end
-
diff --git a/src/ios/CDVInAppBrowser.m b/src/ios/CDVInAppBrowser.m
index f5d05f013..3daa86ded 100644
--- a/src/ios/CDVInAppBrowser.m
+++ b/src/ios/CDVInAppBrowser.m
@@ -887,7 +887,10 @@ - (void)webViewDidStartLoad:(UIWebView*)theWebView
 self.backButton.enabled = theWebView.canGoBack;
 self.forwardButton.enabled = theWebView.canGoForward;
 
-[self.spinner startAnimating];
+NSLog(_browserOptions.hidespinner ? @"Yes" : @"No");
+if(!_browserOptions.hidespinner) {
+[self.spinner startAnimating];
+}
 
 return [self.navigationDelegate webViewDidStartLoad:theWebView];
 }
@@ -987,6 +990,7 @@ - (id)init
 self.toolbarposition = kInAppBrowserToolbarBarPositionBottom;
 self.clearcache = NO;
 self.clearsessioncache = NO;
+self.hidespinner = NO;
 
 self.enableviewportscale = NO;
 self.mediaplaybackrequiresuseraction = NO;
@@ -1104,4 +1108,3 @@ - 
(BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interface
 
 
 @end
-


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> InAppBrowser: Add option to disable spinner on iOS
> --
>
> Key: CB-13659
> URL: https://issues.apache.org/jira/browse/CB-13659
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>  

[jira] [Commented] (CB-13659) InAppBrowser: Add option to disable spinner on iOS

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436161#comment-16436161
 ] 

ASF subversion and git services commented on CB-13659:
--

Commit 974ca3309a176c298bf421b658b4f2b0faeac42b in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~stevegill]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=974ca33 
]

Merge pull request #254 from NiklasMerz/loading-spinner

CB-13659 (iOS) Add hidespinner option

> InAppBrowser: Add option to disable spinner on iOS
> --
>
> Key: CB-13659
> URL: https://issues.apache.org/jira/browse/CB-13659
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Reporter: Niklas Merz
>Priority: Major
>  Labels: newbie, starter
>
> Like mentioned in this pull request 
> [https://github.com/apache/cordova-plugin-inappbrowser/pull/89], the 
> inappbrowser needs flags to disable the loading spinner



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14013) cordova-plugin-inappbrowser support for custom URL schemes, as needed for oAuth

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436154#comment-16436154
 ] 

ASF subversion and git services commented on CB-14013:
--

Commit 50db5c498c3760a4df9ea4ab569de2832ac19f7f in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~bowserj]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=50db5c4 
]

Merge pull request #263 from 
SailingSteve/CB-14013-InAppBrowser-AllowCustomSchemes

CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth

> cordova-plugin-inappbrowser support for custom URL schemes, as needed for 
> oAuth
> ---
>
> Key: CB-14013
> URL: https://issues.apache.org/jira/browse/CB-14013
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: cordova@7.0.0
>Reporter: Steve Podell
>Priority: Major
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> A very common usage of the inappbrowser is to open a URL to the apps server, 
> as part of the oAuth flow.  After a secure token is created, the final step 
> in the oAuth flow is to redirect back to the Cordova app, to proceed as 
> authenticated.  At the WeVote open source project we use this to authenticate 
> with Twitter and Facebook, other projects want to authenticate with Google, 
> Whatsapp, Skype, etc. 
> There is a package for React Native react-native-oauth that does this, and I 
> was able to get oAuth working for iOS with 
> cordova-plugin-safariviewcontroller, but there is nothing that is stable, 
> maintained, and working that is equivalent for Android.
> A pull request will follow that uses whitelisted schemes to allow the oAuth 
> redirect to complete through the InAppBrowser.  It is a fairly simple code 
> change, that leads to a simple end user implementation, that should be widely 
> appreciated (based on years of mostly unfulfilled Stack Overflow chatter.)
>  
> This PR builds on  
> [https://github.com/apache/cordova-plugin-inappbrowser/pull/99] and 
> [https://github.com/apache/cordova-plugin-inappbrowser/pull/261] and builds 
> on a good suggestion from *[NGumby|https://github.com/NGumby]* and comments 
> about viability from *[infil00p|https://github.com/infil00p]*
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14013) cordova-plugin-inappbrowser support for custom URL schemes, as needed for oAuth

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436153#comment-16436153
 ] 

ASF GitHub Bot commented on CB-14013:
-

infil00p closed pull request #263: CB-14013: (android) Change the InAppBrowser 
to allow custom schemes for oAuth
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/263
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index 2b0dbe0fa..9b3388ced 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -133,6 +133,7 @@ Licensed to the Apache Software Foundation (ASF) under one
 private boolean hideUrlBar = false;
 private boolean showFooter = false;
 private String footerColor = "";
+private String[] allowedSchemes;
 
 /**
  * Executes the request and returns PluginResult.
@@ -1110,6 +,29 @@ else if (url.startsWith("sms:")) {
 LOG.e(LOG_TAG, "Error sending sms " + url + ":" + 
e.toString());
 }
 }
+// Test for whitelisted custom scheme names like mycoolapp:// or 
twitteroauthresponse:// (Twitter Oauth Response)
+else if (!url.startsWith("http:") && !url.startsWith("https:") && 
url.matches("^[a-z]*://.*?$")) {
+if (allowedSchemes == null) {
+String allowed = preferences.getString("AllowedSchemes", 
"");
+allowedSchemes = allowed.split(",");
+}
+if (allowedSchemes != null) {
+for (String scheme : allowedSchemes) {
+if (url.startsWith(scheme)) {
+try {
+JSONObject obj = new JSONObject();
+obj.put("type", "customscheme");
+obj.put("url", url);
+sendUpdate(obj, true);
+return true;
+} catch (JSONException ex) {
+LOG.e(LOG_TAG, "Custom Scheme URI passed in 
has caused a JSON error.");
+}
+}
+}
+}
+}
+
 return false;
 }
 
@@ -1232,4 +1256,4 @@ public void onReceivedHttpAuthRequest(WebView view, 
HttpAuthHandler handler, Str
 super.onReceivedHttpAuthRequest(view, handler, host, realm);
 }
 }
-}
+}
\ No newline at end of file
diff --git a/www/inappbrowser.js b/www/inappbrowser.js
index 7c3e749e8..3619f173f 100644
--- a/www/inappbrowser.js
+++ b/www/inappbrowser.js
@@ -36,7 +36,8 @@
 'loadstart': channel.create('loadstart'),
 'loadstop': channel.create('loadstop'),
 'loaderror': channel.create('loaderror'),
-'exit': channel.create('exit')
+'exit': channel.create('exit'),
+'customscheme': channel.create('customscheme')
 };
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser support for custom URL schemes, as needed for 
> oAuth
> ---
>
> Key: CB-14013
> URL: https://issues.apache.org/jira/browse/CB-14013
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: cordova@7.0.0
>Reporter: Steve Podell
>Priority: Major
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> A very common usage of the inappbrowser is to open a URL to the apps server, 
> as part of the oAuth flow.  After a secure token is created, the final step 
> in the oAuth flow is to redirect back to the Cordova app, to proceed as 
> authenticated.  At the WeVote open source project we use this to authenticate 
> with Twitter and Facebook, other projects want to authenticate with Google, 
> Whatsapp, Skype, etc. 
> There is a package for React Native react-native-oauth that does this, and I 
> was able to get oAuth working for iOS with 
> cordova-plugin-safariviewcontroller, but there is nothing that is stable, 
> maintained, and working that is equivalent for Android.
> A pull request will follow that uses whitelisted schemes to allow the oAuth 
> redirect to complete through 

[jira] [Commented] (CB-14013) cordova-plugin-inappbrowser support for custom URL schemes, as needed for oAuth

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436155#comment-16436155
 ] 

ASF subversion and git services commented on CB-14013:
--

Commit 50db5c498c3760a4df9ea4ab569de2832ac19f7f in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~bowserj]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=50db5c4 
]

Merge pull request #263 from 
SailingSteve/CB-14013-InAppBrowser-AllowCustomSchemes

CB-14013: (android) Change the InAppBrowser to allow custom schemes for oAuth

> cordova-plugin-inappbrowser support for custom URL schemes, as needed for 
> oAuth
> ---
>
> Key: CB-14013
> URL: https://issues.apache.org/jira/browse/CB-14013
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: cordova@7.0.0
>Reporter: Steve Podell
>Priority: Major
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> A very common usage of the inappbrowser is to open a URL to the apps server, 
> as part of the oAuth flow.  After a secure token is created, the final step 
> in the oAuth flow is to redirect back to the Cordova app, to proceed as 
> authenticated.  At the WeVote open source project we use this to authenticate 
> with Twitter and Facebook, other projects want to authenticate with Google, 
> Whatsapp, Skype, etc. 
> There is a package for React Native react-native-oauth that does this, and I 
> was able to get oAuth working for iOS with 
> cordova-plugin-safariviewcontroller, but there is nothing that is stable, 
> maintained, and working that is equivalent for Android.
> A pull request will follow that uses whitelisted schemes to allow the oAuth 
> redirect to complete through the InAppBrowser.  It is a fairly simple code 
> change, that leads to a simple end user implementation, that should be widely 
> appreciated (based on years of mostly unfulfilled Stack Overflow chatter.)
>  
> This PR builds on  
> [https://github.com/apache/cordova-plugin-inappbrowser/pull/99] and 
> [https://github.com/apache/cordova-plugin-inappbrowser/pull/261] and builds 
> on a good suggestion from *[NGumby|https://github.com/NGumby]* and comments 
> about viability from *[infil00p|https://github.com/infil00p]*
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13984) Fix issue with toolbar navigation buttons always being hidden on iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436119#comment-16436119
 ] 

ASF GitHub Bot commented on CB-13984:
-

stevengill commented on issue #264: CB-13984: (ios) Fix toolbar navigation 
buttons always being hidden
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/264#issuecomment-380904936
 
 
   Decided to merge #260 instead


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix issue with toolbar navigation buttons always being hidden on iOS
> 
>
> Key: CB-13984
> URL: https://issues.apache.org/jira/browse/CB-13984
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
>Reporter: Rasim Kanca
>Assignee: jcesarmobile
>Priority: Major
>
> In CB-13409, the functionality to hide the toolbar navigation buttons was 
> added for iOS through the *hidenavigationbuttons* property. Unfortunately, in 
> the iOS code, after checking whether the property is defined and what it is, 
> it defaults to hiding the buttons completely ignoring the value of the 
> property.
> The line in question can be viewed 
> [here|https://github.com/apache/cordova-plugin-inappbrowser/commit/8711ee3f211bf84913ae86f81e5e0e548d1c8015#diff-aa3201a8ef3df73e28e8979eaa6e228eR657].
>  There is a pull request that contains a commit with a fix in [this pull 
> request|https://github.com/apache/cordova-plugin-inappbrowser/pull/260].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13984) Fix issue with toolbar navigation buttons always being hidden on iOS

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436120#comment-16436120
 ] 

ASF GitHub Bot commented on CB-13984:
-

stevengill closed pull request #264: CB-13984: (ios) Fix toolbar navigation 
buttons always being hidden
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/264
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/ios/CDVInAppBrowser.m b/src/ios/CDVInAppBrowser.m
index a581472dd..56d227b72 100644
--- a/src/ios/CDVInAppBrowser.m
+++ b/src/ios/CDVInAppBrowser.m
@@ -654,7 +654,6 @@ - (void)createViews
 } else {
   [self.toolbar setItems:@[self.closeButton, flexibleSpaceButton, 
self.backButton, fixedSpaceButton, self.forwardButton]];
 }
-[self.toolbar setItems:@[self.closeButton, flexibleSpaceButton]];
 
 self.view.backgroundColor = [UIColor grayColor];
 [self.view addSubview:self.toolbar];


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Fix issue with toolbar navigation buttons always being hidden on iOS
> 
>
> Key: CB-13984
> URL: https://issues.apache.org/jira/browse/CB-13984
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
>Reporter: Rasim Kanca
>Assignee: jcesarmobile
>Priority: Major
>
> In CB-13409, the functionality to hide the toolbar navigation buttons was 
> added for iOS through the *hidenavigationbuttons* property. Unfortunately, in 
> the iOS code, after checking whether the property is defined and what it is, 
> it defaults to hiding the buttons completely ignoring the value of the 
> property.
> The line in question can be viewed 
> [here|https://github.com/apache/cordova-plugin-inappbrowser/commit/8711ee3f211bf84913ae86f81e5e0e548d1c8015#diff-aa3201a8ef3df73e28e8979eaa6e228eR657].
>  There is a pull request that contains a commit with a fix in [this pull 
> request|https://github.com/apache/cordova-plugin-inappbrowser/pull/260].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436021#comment-16436021
 ] 

ASF subversion and git services commented on CB-13892:
--

Commit 46d7db8b0b7d62bbe267244d33388e475154aca7 in cordova-plugin-vibration's 
branch refs/heads/master from [~jcesarmobile]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=46d7db8 ]

CB-13892:(all) Remove navigator.notification


> Remove navigator.notification from vibration plugin
> ---
>
> Key: CB-13892
> URL: https://issues.apache.org/jira/browse/CB-13892
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-vibration
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>
> The navigator.notification was deprecated long time ago and also deleted from 
> the docs, but the plugin still have it as merges in the plugin.xml
> We should remove it from plugin.xml and from the manual tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436022#comment-16436022
 ] 

ASF subversion and git services commented on CB-13892:
--

Commit 06e9aa4a57aa8b368e5e402ace05776e4f2a496a in cordova-plugin-vibration's 
branch refs/heads/master from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=06e9aa4 ]

Merge pull request #67 from jcesarmobile/CB-13892

CB-13892:(all) Remove navigator.notification

> Remove navigator.notification from vibration plugin
> ---
>
> Key: CB-13892
> URL: https://issues.apache.org/jira/browse/CB-13892
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-vibration
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>
> The navigator.notification was deprecated long time ago and also deleted from 
> the docs, but the plugin still have it as merges in the plugin.xml
> We should remove it from plugin.xml and from the manual tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436020#comment-16436020
 ] 

ASF GitHub Bot commented on CB-13892:
-

stevengill closed pull request #67: CB-13892:(all) Remove navigator.notification
URL: https://github.com/apache/cordova-plugin-vibration/pull/67
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/plugin.xml b/plugin.xml
index 3f5c705..9cae7e8 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -47,7 +47,6 @@
 

 
-
 
 
 
@@ -60,7 +59,6 @@
 
 
 
-
 
 
 
@@ -71,11 +69,9 @@
 
 
 
-
 
 
 
-
 
 
 
diff --git a/tests/tests.js b/tests/tests.js
index 74ae349..675b002 100644
--- a/tests/tests.js
+++ b/tests/tests.js
@@ -41,34 +41,6 @@ exports.defineManualTests = function (contentEl, 
createActionButton) {
 // Vibrations
 // 
-
 
-// old vibrate call
-var vibrateOld = function () {
-clearLog();
-navigator.notification.vibrate(2500);
-logMessage('navigator.notification.vibrate(2500)', 'green');
-};
-
-// old vibrate with pattern call
-var vibrateWithPatternOld = function () {
-clearLog();
-navigator.notification.vibrateWithPattern([1000, 3000, 2000, 5000]);
-logMessage('navigator.notification.vibrateWithPattern([1000, 3000, 
2000, 5000])', 'green');
-};
-
-// old vibrate with pattern with repeat call
-var vibrateWithPatternOldWithRepeat = function () {
-clearLog();
-navigator.notification.vibrateWithPattern([1000, 3000, 2000, 5000], 2);
-logMessage('navigator.notification.vibrateWithPattern([1000, 3000, 
2000, 5000], 2)', 'green');
-};
-
-// old cancel vibrate call
-var cancelOld = function () {
-clearLog();
-navigator.notification.cancelVibration();
-logMessage('navigator.notification.cancelVibration()', 'green');
-};
-
 // new standard vibrate call that aligns to w3c spec with param long
 var vibrateWithInt = function () {
 clearLog();
@@ -145,16 +117,6 @@ exports.defineManualTests = function (contentEl, 
createActionButton) {
 var vibrate_tests = 'Vibrate Tests' +
 'Starred tests only work for Android and Windows. ' +
 'iOS ignores the time given for a vibrate ' +
-'' +
-'Expected result: Vibrate once for 2.5 seconds.' +
-' ' +
-'Expected result: Pause for 1s, vibrate for 3s, pause for 2s, vibrate 
for 5s.' +
-' ' +
-'Expected result: Pause for 1s, vibrate for 3s, [pause for 2s, vibrate 
for 5s.], repeat [steps]' +
-' ' +
-'Expected result: Press once to initiate vibrate for 60 seconds. Press 
again to cancel vibrate immediately.' +
-' ' +
-'Expected result: Press once to initiate vibrate with pattern for 45s. 
Press again to cancel vibrate immediately.' +
 ' ' +
 'Expected result: Vibrate once for 3 seconds.' +
 ' ' +
@@ -174,45 +136,6 @@ exports.defineManualTests = function (contentEl, 
createActionButton) {
 
 contentEl.innerHTML = '' + vibrate_tests;
 
-// standard vibrate with old call
-createActionButton('Vibrate (Old)', function () {
-vibrateOld();
-}, 'vibrate_old');
-
-// vibrate with pattern with old call
-createActionButton('* Vibrate with a pattern (Old)', function () {
-vibrateWithPatternOld();
-}, 'vibrateWithPattern_old');
-
-// vibrate with pattern with repeat with old call
-createActionButton('* Vibrate with a pattern with repeat (Old)', function 
() {
-vibrateWithPatternOldWithRepeat();
-}, 'vibrateWithPatternRepeat_old');
-
-// cancel vibrate with old call
-createActionButton('* Cancel vibration (Old)', function () {
-
-if (!vibrateOn) {
-longVibrate();
-} else {
-cancelOld();
-resetVibrateOn();
-clearTimeout(timeout); // clear the timeout since user has 
canceled the vibrate
-}
-}, 'cancelVibrate_old');
-
-// cancel vibrate with pattern with old call
-createActionButton('* Cancel vibration with pattern (Old)', function () {
-
-if (!vibrateOn) {
-longVibrateWithPattern();
-} else {
-cancelOld();
-resetVibrateOn();
-clearTimeout(timeout); // clear the timeout since user has 
canceled the vibrate
-}
-}, 'cancelVibrateWithPattern_old');
-
 // 

[jira] [Commented] (CB-13892) Remove navigator.notification from vibration plugin

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436023#comment-16436023
 ] 

ASF subversion and git services commented on CB-13892:
--

Commit 06e9aa4a57aa8b368e5e402ace05776e4f2a496a in cordova-plugin-vibration's 
branch refs/heads/master from [~stevegill]
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-vibration.git;h=06e9aa4 ]

Merge pull request #67 from jcesarmobile/CB-13892

CB-13892:(all) Remove navigator.notification

> Remove navigator.notification from vibration plugin
> ---
>
> Key: CB-13892
> URL: https://issues.apache.org/jira/browse/CB-13892
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-vibration
>Reporter: jcesarmobile
>Assignee: jcesarmobile
>Priority: Major
>
> The navigator.notification was deprecated long time ago and also deleted from 
> the docs, but the plugin still have it as merges in the plugin.xml
> We should remove it from plugin.xml and from the manual tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14029) On iPhoneX, after rotating to Landscape, a top transparent bar overlaps web content.

[Yuhang Sun (JIRA)]

Yuhang Sun created CB-14029:
---

 Summary: On iPhoneX, after rotating to Landscape, a top 
transparent bar overlaps web content.
 Key: CB-14029
 URL: https://issues.apache.org/jira/browse/CB-14029
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-plugin-inappbrowser
Affects Versions: cordova-ios 4.5.0
 Environment: On iPhoneX,

 
Reporter: Yuhang Sun
 Attachments: Simulator Screen Shot - iPhone X - 2018-04-11 at 
20.11.35.png

Open a webpage in portrait passing in _blank as its option. Rotate the phone to 
landscape. A transparent status bar appears and overlaps with the web page 
content.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Updated] (CB-14028) device.model does not behave as documented on Android

[Mathijs (JIRA)]

 [ 
https://issues.apache.org/jira/browse/CB-14028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mathijs updated CB-14028:
-
Description: 
The 
[documentation|https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-device/#android-quirks]
 states:
{quote}Gets the [product 
name|http://developer.android.com/reference/android/os/Build.html#PRODUCT] 
instead of the [model 
name|http://developer.android.com/reference/android/os/Build.html#MODEL], which 
is often the production code name. For example, the Nexus One returns 
{{Passion}}, and Motorola Droid returns {{voles}}.
{quote}
Hence, for the Samsung Galaxy S5, we would expect the production code name 
`klte`. Instead, we're getting `SM-G900F`, which is inconsistent with the 
documented example.

However, in the quirk above suggests that it is 'often' the production code 
name. Does this mean that the result can be expected to be inconsistent, that 
is, sometimes the product name and sometimes the model name?

Note that the [official device 
list|http://storage.googleapis.com/play_public/supported_devices.csv] from 
Google specifies a 'Marketing Name', a 'Device' and a 'Model - the latter two 
being `klte` and `SM-G900F`, respectively, in the provided example.

  was:
The 
[documentation|https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-device/#android-quirks]
 states:
{quote}Gets the [product 
name|http://developer.android.com/reference/android/os/Build.html#PRODUCT] 
instead of the [model 
name|http://developer.android.com/reference/android/os/Build.html#MODEL], which 
is often the production code name. For example, the Nexus One returns 
{{Passion}}, and Motorola Droid returns {{voles}}.
{quote}
Hence, for the Samsung Galaxy S5, we would expect the production code name 
`klte`. Instead, we're getting `SM-G900F`, which is inconsistent with the 
documented example.

However, in the quirk above suggests that it is 'often' the production code 
name. Does this mean that the result can be expected to be inconsistent, that 
is, sometimes the product name and sometimes the model name?


> device.model does not behave as documented on Android
> -
>
> Key: CB-14028
> URL: https://issues.apache.org/jira/browse/CB-14028
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-device
> Environment: Device: Samsung Galaxy S5
> Model: SM-G900F
> Platform: Android
>Reporter: Mathijs
>Priority: Major
>
> The 
> [documentation|https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-device/#android-quirks]
>  states:
> {quote}Gets the [product 
> name|http://developer.android.com/reference/android/os/Build.html#PRODUCT] 
> instead of the [model 
> name|http://developer.android.com/reference/android/os/Build.html#MODEL], 
> which is often the production code name. For example, the Nexus One returns 
> {{Passion}}, and Motorola Droid returns {{voles}}.
> {quote}
> Hence, for the Samsung Galaxy S5, we would expect the production code name 
> `klte`. Instead, we're getting `SM-G900F`, which is inconsistent with the 
> documented example.
> However, in the quirk above suggests that it is 'often' the production code 
> name. Does this mean that the result can be expected to be inconsistent, that 
> is, sometimes the product name and sometimes the model name?
> Note that the [official device 
> list|http://storage.googleapis.com/play_public/supported_devices.csv] from 
> Google specifies a 'Marketing Name', a 'Device' and a 'Model - the latter two 
> being `klte` and `SM-G900F`, respectively, in the provided example.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Created] (CB-14028) device.model does not behave as documented on Android

[Mathijs (JIRA)]

Mathijs created CB-14028:


 Summary: device.model does not behave as documented on Android
 Key: CB-14028
 URL: https://issues.apache.org/jira/browse/CB-14028
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-plugin-device
 Environment: Device: Samsung Galaxy S5
Model: SM-G900F
Platform: Android
Reporter: Mathijs


The 
[documentation|https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-device/#android-quirks]
 states:
{quote}Gets the [product 
name|http://developer.android.com/reference/android/os/Build.html#PRODUCT] 
instead of the [model 
name|http://developer.android.com/reference/android/os/Build.html#MODEL], which 
is often the production code name. For example, the Nexus One returns 
{{Passion}}, and Motorola Droid returns {{voles}}.
{quote}
Hence, for the Samsung Galaxy S5, we would expect the production code name 
`klte`. Instead, we're getting `SM-G900F`, which is inconsistent with the 
documented example.

However, in the quirk above suggests that it is 'often' the production code 
name. Does this mean that the result can be expected to be inconsistent, that 
is, sometimes the product name and sometimes the model name?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435269#comment-16435269
 ] 

ASF GitHub Bot commented on CB-12242:
-

janpio commented on issue #292: CB-12242 : Use yarn instead of npm
URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-380745831
 
 
   Nope sorry, I don't know anything about the `cordova-cli` codebase. Hope 
someone else who does will come along and review and merge this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use yarn js instead of npm when adding plugins
> --
>
> Key: CB-12242
> URL: https://issues.apache.org/jira/browse/CB-12242
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-cli, cordova-lib
>Reporter: Jacques de Villiers
>Priority: Major
>
> Currently it can take quite long to add certain plugins to my project (using 
> cordova plugin add), especially if I need to re-add the plugins. My 
> suggestion is to update the cordova cli to start using yarn js instead of npm 
> directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and 
> much better at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be 
> a massive win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally 
> sure how to proceed on this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-14027) cordova-plugin-statusbar default style isn't work in Huawei and 360 and some android phone

[jcesarmobile (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-14027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435257#comment-16435257
 ] 

jcesarmobile commented on CB-14027:
---

Are you using some code for the statusbar? what preferences are you using?
What's the Android version of the devices where you see the problem?

> cordova-plugin-statusbar default style isn't work in Huawei and 360 and some 
> android phone
> --
>
> Key: CB-14027
> URL: https://issues.apache.org/jira/browse/CB-14027
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
>Affects Versions: 2.4.1
>Reporter: miao
>Priority: Major
> Attachments: image-2018-04-12-12-18-38-075.png
>
>
> I used the latest version of cordova-plugin-statusbar with the default style, 
> but the in HuaWei, 360 and some android phone, the status bar's information 
> disappeared, only the black background bar here.
> !image-2018-04-12-12-18-38-075.png|width=199,height=363!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12242) Use yarn js instead of npm when adding plugins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-12242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435238#comment-16435238
 ] 

ASF GitHub Bot commented on CB-12242:
-

qkdreyer commented on issue #292: CB-12242 : Use yarn instead of npm
URL: https://github.com/apache/cordova-cli/pull/292#issuecomment-380739234
 
 
   I've just fixed the code style issue. Could you merge it @janpio ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use yarn js instead of npm when adding plugins
> --
>
> Key: CB-12242
> URL: https://issues.apache.org/jira/browse/CB-12242
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-cli, cordova-lib
>Reporter: Jacques de Villiers
>Priority: Major
>
> Currently it can take quite long to add certain plugins to my project (using 
> cordova plugin add), especially if I need to re-add the plugins. My 
> suggestion is to update the cordova cli to start using yarn js instead of npm 
> directly.
> When I looked at this page, I realised yarn was just a wrapper for npm, and 
> much better at caching packages locally.
> https://shift.infinite.red/npm-vs-yarn-cheat-sheet-8755b092e5cc#.jiz27n1hc
> I would imagine this change would be relatively straightforward, and would be 
> a massive win for the cli.
> I was thinking of creating a fork to do a PR but realised I am not totally 
> sure how to proceed on this.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org