[jira] [Commented] (CB-12551) File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2
[
https://issues.apache.org/jira/browse/CB-12551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634638#comment-16634638
]
ASF GitHub Bot commented on CB-12551:
-
janpio commented on issue #197: CB-12551: (android) Patch Security Provider to
support TLS 1.2
URL:
https://github.com/apache/cordova-plugin-file-transfer/pull/197#issuecomment-426063702
I just submitted a fix to master, if you rebase on that your tests might
pass (or at least fail less).
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> File-Transfer download/upload fails in Android 4.4 or older using TLS 1.2
> -
>
> Key: CB-12551
> URL: https://issues.apache.org/jira/browse/CB-12551
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file-transfer (DEPRECATED)
>Reporter: Dani Palou
>Priority: Major
>
> FileTransfer's download function fails when trying to download a file from a
> site using TLS 1.2. This works fine in Android 5 or higher, but it fails in
> Android 4.x.
> I searched a bit and I found that Android 4.4 should support TLS1.2 but it is
> disabled by default. I applied the solution proposed in this post and it
> worked for me:
> http://stackoverflow.com/a/33567745
> That is, I created the _MySSLSocketFactory_ class in the FileTransfer
> project, and I used it in the _trustAllHosts_ function (line 636 of
> _FileTransfer.java_):
> {noformat}
> SSLSocketFactory newFactory = new MySSLSocketFactory(sc.getSocketFactory());
> {noformat}
> I'm not sure if this can cause problems with other certificates, I don't know
> much about this. It would be nice if the Cordova team could take a look at
> this and check if it can be solved.
> This is the stacktrace:
> {noformat}
> Error getting HTTP status code from connection.
> javax.net.ssl.SSLException: Connection closed by peer
> at com.android.org.conscrypt.NativeCrypto.SSL_do_handshake(Native Method)
> at
> com.android.org.conscrypt.OpenSSLSocketImpl.startHandshake(OpenSSLSocketImpl.java:405)
> at com.android.okhttp.Connection.upgradeToTls(Connection.java:146)
> at com.android.okhttp.Connection.connect(Connection.java:107)
> at com.android.okhttp.internal.http.HttpEngine.connect(HttpEngine.java:294)
> at
> com.android.okhttp.internal.http.HttpEngine.sendSocketRequest(HttpEngine.java:255)
> at
> com.android.okhttp.internal.http.HttpEngine.sendRequest(HttpEngine.java:206)
> at
> com.android.okhttp.internal.http.HttpURLConnectionImpl.execute(HttpURLConnectionImpl.java:345)
> at
> com.android.okhttp.internal.http.HttpURLConnectionImpl.connect(HttpURLConnectionImpl.java:89)
> at
> com.android.okhttp.internal.http.HttpsURLConnectionImpl.connect(HttpsURLConnectionImpl.java:161)
> at org.apache.cordova.filetransfer.FileTransfer$4.run(FileTransfer.java:869)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
> at java.lang.Thread.run(Thread.java:841)
> {noformat}
> It can be tested with this code:
> {noformat}
> var ft = new FileTransfer(),
> path = 'squirrel.jpg',
> uri =
> 'https://prototype.moodle.net/mobile/moodle32/webservice/pluginfile.php/314/mod_resource/content/3/squirrel.jpg?forcedownload=1=616455be9f363cc9631cab89cfcfa1cd';
> ft.download(uri, path, success, error, true);
> function success() {
> console.log('Success');
> }
> function error(data) {
> console.log('Error', data);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13690) Change audio stream src in platform-browser
[ https://issues.apache.org/jira/browse/CB-13690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634619#comment-16634619 ] ASF GitHub Bot commented on CB-13690: - janpio commented on issue #159: CB-13690 : (browser) Add src change to method to Media object URL: https://github.com/apache/cordova-plugin-media/pull/159#issuecomment-426056733 Tests are now passing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Change audio stream src in platform-browser > --- > > Key: CB-13690 > URL: https://issues.apache.org/jira/browse/CB-13690 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-media >Affects Versions: 4.0.0 > Environment: Browser >Reporter: Frank Owusu >Priority: Critical > Labels: Audio, browser, easyfix, patch, stream > Fix For: 4.0.0 > > > h2. Media object change src method for Browser. > when node is released stream src is still being downloaded. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13850) Typescript: Misspelled property fileSystem
[
https://issues.apache.org/jira/browse/CB-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634576#comment-16634576
]
ASF GitHub Bot commented on CB-13850:
-
janpio closed pull request #229: CB-13850: Fix spelling in typed-file: property
name filesystem (wrong…
URL: https://github.com/apache/cordova-plugin-file/pull/229
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/types/index.d.ts b/types/index.d.ts
index c748e3da..ba17a43d 100644
--- a/types/index.d.ts
+++ b/types/index.d.ts
@@ -63,7 +63,7 @@ interface Entry {
/** The full absolute path from the root to the entry. */
fullPath: string;
/** The file system on which the entry resides. */
-fileSystem: FileSystem;
+filesystem: FileSystem;
nativeURL: string;
/**
* Look up metadata about this entry.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Typescript: Misspelled property fileSystem
> --
>
> Key: CB-13850
> URL: https://issues.apache.org/jira/browse/CB-13850
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
>Reporter: Tobias Haupenthal
>Priority: Major
>
> The Typescript file index.d.ts shows that an Entry shall have an attribute
> fileSystem.
> But in Android this property is undefined. There is only the property
> filesystem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13850) Typescript: Misspelled property fileSystem
[ https://issues.apache.org/jira/browse/CB-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634577#comment-16634577 ] ASF subversion and git services commented on CB-13850: -- Commit 4642fde47ff24f6a2a38ef5f812cca04e1c23a1a in cordova-plugin-file's branch refs/heads/master from Beutlin [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-file.git;h=4642fde ] CB-13850: Fix spelling in typed-file: property name filesystem (wrong… (#229) ### Platforms affected - ### What does this PR do? The DefinitelyTyped file has a wrong attribute for an Entry object. It is "fileSystem" but should be "filesystem". The consequence of this is that the syntax checker of an IDE might give an false warning. ### What testing has been done on this change? Looked at file www/Entry.js. Obviously the naming is here "filesystem". ### Checklist - [ x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [ x ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - Automated tests are not possible, because this bug is related to a DefinitelyTyped file, which provides only syntax checking for IDEs. > Typescript: Misspelled property fileSystem > -- > > Key: CB-13850 > URL: https://issues.apache.org/jira/browse/CB-13850 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file >Reporter: Tobias Haupenthal >Priority: Major > > The Typescript file index.d.ts shows that an Entry shall have an attribute > fileSystem. > But in Android this property is undefined. There is only the property > filesystem. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13960) Typescript: FileWriter write argument definition shall include type string
[
https://issues.apache.org/jira/browse/CB-13960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634575#comment-16634575
]
ASF subversion and git services commented on CB-13960:
--
Commit 5353b847270d55f8caedfc992393137514c59992 in cordova-plugin-file's branch
refs/heads/master from vldmr-bus
[ https://gitbox.apache.org/repos/asf?p=cordova-plugin-file.git;h=5353b84 ]
CB-13960: fix FileWriter.write argument type definition for typescript (#231)
Fix FileWriter.write argument type definition for typescript
> Typescript: FileWriter write argument definition shall include type string
> --
>
> Key: CB-13960
> URL: https://issues.apache.org/jira/browse/CB-13960
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
>Reporter: Vladimir
>Priority: Major
>
> www\FileWriter.js has the following annotation on write method:
> {code:java}
> @param data text or blob to be writte{code}
> But types\index.d.ts has the following type definition:
> {code:java}
> /**
> * Write the supplied data to the file at position.
> * @param {Blob} data The blob to write.
> */
> write(data: Blob): void;{code}
> Shall be as follows:
> {code:java}
> /**
> * Write the supplied data to the file at position.
> * @param {Blob|string} data The blob to write.
> */
> write(data: Blob|string): void;{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13960) Typescript: FileWriter write argument definition shall include type string
[
https://issues.apache.org/jira/browse/CB-13960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634574#comment-16634574
]
ASF GitHub Bot commented on CB-13960:
-
janpio closed pull request #231: CB-13960: fix FileWriter.write argument type
definition for typescript
URL: https://github.com/apache/cordova-plugin-file/pull/231
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/types/index.d.ts b/types/index.d.ts
index c748e3da..40f1a822 100644
--- a/types/index.d.ts
+++ b/types/index.d.ts
@@ -294,9 +294,9 @@ interface FileWriter extends FileSaver {
length: number;
/**
* Write the supplied data to the file at position.
- * @param {Blob} data The blob to write.
+ * @param {Blob|string} data The blob to write.
*/
-write(data: Blob): void;
+write(data: Blob|string): void;
/**
* The file position at which the next write will occur.
* @param offset If nonnegative, an absolute byte offset into the file.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Typescript: FileWriter write argument definition shall include type string
> --
>
> Key: CB-13960
> URL: https://issues.apache.org/jira/browse/CB-13960
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
>Reporter: Vladimir
>Priority: Major
>
> www\FileWriter.js has the following annotation on write method:
> {code:java}
> @param data text or blob to be writte{code}
> But types\index.d.ts has the following type definition:
> {code:java}
> /**
> * Write the supplied data to the file at position.
> * @param {Blob} data The blob to write.
> */
> write(data: Blob): void;{code}
> Shall be as follows:
> {code:java}
> /**
> * Write the supplied data to the file at position.
> * @param {Blob|string} data The blob to write.
> */
> write(data: Blob|string): void;{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11714) Camera plugin for windows does not properly set content-type when selecting JPG->PNG
[ https://issues.apache.org/jira/browse/CB-11714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634551#comment-16634551 ] ASF GitHub Bot commented on CB-11714: - janpio commented on issue #242: CB-11714: (windows) added check for encoding in savePhoto() without height/width URL: https://github.com/apache/cordova-plugin-camera/pull/242#issuecomment-426043765 Thanks @DisruptiveMind. Tests are now failing because of ``` /Users/travis/build/apache/cordova-plugin-camera/src/windows/CameraProxy.js 790:67 error Strings must use singlequote quotes ✖ 1 problem (1 error, 0 warnings) 1 error, 0 warnings potentially fixable with the `--fix` option. ``` This doesn't make too much sense to me, especially as line 790 contains no quotes at all. Can you maybe rebase on `master`? I hope this will go away with more recent test configuration. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camera plugin for windows does not properly set content-type when selecting > JPG->PNG > > > Key: CB-11714 > URL: https://issues.apache.org/jira/browse/CB-11714 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: Master > Environment: Windows 10 >Reporter: Tyler Pham >Priority: Major > Labels: easyfix, triaged, windows > > When selecting a JPG with encodingType = Camera.EncodingType.PNG, the > resizeImage() will not modify the target content type when converting > canvas.toDataURL(...) -- the content-type will still be image/jpeg but with a > .png extension which will cause the browser to not render to image and issue > an error. > Possibly related to: CB-8618 > I have created a small fix at: > https://github.com/DisruptiveMind/cordova-plugin-camera/tree/fix-windows-content-type -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634540#comment-16634540 ] ASF GitHub Bot commented on CB-7179: janpio edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425728887 Simplest answer: Because the testing setup for plugins is all messed up, see a WIP issue here: https://github.com/apache/cordova/issues/28 I am working my way through these, but it is _very_ slow going. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12035) [cordova-plugin-network-information] connection info is not reliable on Android 6
[
https://issues.apache.org/jira/browse/CB-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634526#comment-16634526
]
ASF GitHub Bot commented on CB-12035:
-
PieterVanPoyer edited a comment on issue #74: CB-12035 (android) Fix bug
[cordova-plugin-network-information] connection info is not reliable on Android
6
URL:
https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426035590
I triggered a new build. (I did change some logging for a new commit).
The travis build is now successfull!
Are there any comments, questions, remarks for this pull request?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cordova-plugin-network-information] connection info is not reliable on
> Android 6
> -
>
> Key: CB-12035
> URL: https://issues.apache.org/jira/browse/CB-12035
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-network-information
>Affects Versions: 1.3.0
> Environment: Samsung Galaxy Edge S6 / Android 6
> useragent: "Mozilla/5.0 (Linux; Android 6.0.1; SM-G925F Build/MMB29K; wv)
> AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.124
> Mobile Safari/537.36"
> reproduced with:
> cordova-plugin-network-information@1.3.0 (latest)
> cordova-plugin-network-information@1.2.0
>Reporter: jakub-g
>Priority: Major
> Labels: android
>
> I've noticed that information exposed by the plugin is not reliable. It
> happens often that I'm connected to the internet via WiFi, and the plugin
> says that there's no connection.
> It's not easy to reproduce it on-demand, but I reproduced it many times
> recently. It happens most often when in the morning, I open the Cordova app
> that was running in background throughout the night.
> Then, when I connect to Chrome Dev Tools, I can do a repl session like this:
> {code}
> > navigator.connection.type
> "none"
> > window.fetch('http://www.example.org').then(function(res)
> > {console.log(res.status)})
> Promise {[[PromiseStatus]]: "pending", [[PromiseValue]]: undefined}
> 200
> Fetch complete: GET "http://www.example.org/;.(anonymous function)
> > navigator.connection.type
> "none"
> {code}
> So, the plugin thinks I'm offline, yet any HTTP calls done within the app
> without checking if I'm offline or online, are successful (either from the
> app or devtools).
> When I disable WiFi and reenable it, after a few seconds the plugin updates
> its state and then it tells that connection type is "wifi".
> There are several possibilities here:
> - either system (or device driver) gives us incorrect information, or
> - cordova plugin is caching data and/or not listening properly to all the
> events and/or incorrectly processing it
> and most probably the issue manifests itself when the device is asleep for
> many hours (but I'm not sure about this).
> Note that I also noticed another issue, that sometimes the Chrome network
> stack thinks I'm offline (when I do an HTTP call, it fails immediately and I
> see network errors in devtools console) - and then I restart the Cordova app,
> and everything's fine, all HTTP calls are ok - but this is unrelated to this
> ticket, and perhaps a bug in Chrome.
> This ticket seems to be most likely a bug in the plugin, because as I said
> before, doing HTTP call succeeds despite the plugin telling me that I'm
> offline.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12035) [cordova-plugin-network-information] connection info is not reliable on Android 6
[
https://issues.apache.org/jira/browse/CB-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634525#comment-16634525
]
ASF GitHub Bot commented on CB-12035:
-
PieterVanPoyer commented on issue #74: CB-12035 (android) Fix bug
[cordova-plugin-network-information] connection info is not reliable on Android
6
URL:
https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426035590
I triggered a new build. (I did change some logging for a new commit).
Are there any comments, questions, remarks for this pull request?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cordova-plugin-network-information] connection info is not reliable on
> Android 6
> -
>
> Key: CB-12035
> URL: https://issues.apache.org/jira/browse/CB-12035
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-network-information
>Affects Versions: 1.3.0
> Environment: Samsung Galaxy Edge S6 / Android 6
> useragent: "Mozilla/5.0 (Linux; Android 6.0.1; SM-G925F Build/MMB29K; wv)
> AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.124
> Mobile Safari/537.36"
> reproduced with:
> cordova-plugin-network-information@1.3.0 (latest)
> cordova-plugin-network-information@1.2.0
>Reporter: jakub-g
>Priority: Major
> Labels: android
>
> I've noticed that information exposed by the plugin is not reliable. It
> happens often that I'm connected to the internet via WiFi, and the plugin
> says that there's no connection.
> It's not easy to reproduce it on-demand, but I reproduced it many times
> recently. It happens most often when in the morning, I open the Cordova app
> that was running in background throughout the night.
> Then, when I connect to Chrome Dev Tools, I can do a repl session like this:
> {code}
> > navigator.connection.type
> "none"
> > window.fetch('http://www.example.org').then(function(res)
> > {console.log(res.status)})
> Promise {[[PromiseStatus]]: "pending", [[PromiseValue]]: undefined}
> 200
> Fetch complete: GET "http://www.example.org/;.(anonymous function)
> > navigator.connection.type
> "none"
> {code}
> So, the plugin thinks I'm offline, yet any HTTP calls done within the app
> without checking if I'm offline or online, are successful (either from the
> app or devtools).
> When I disable WiFi and reenable it, after a few seconds the plugin updates
> its state and then it tells that connection type is "wifi".
> There are several possibilities here:
> - either system (or device driver) gives us incorrect information, or
> - cordova plugin is caching data and/or not listening properly to all the
> events and/or incorrectly processing it
> and most probably the issue manifests itself when the device is asleep for
> many hours (but I'm not sure about this).
> Note that I also noticed another issue, that sometimes the Chrome network
> stack thinks I'm offline (when I do an HTTP call, it fails immediately and I
> see network errors in devtools console) - and then I restart the Cordova app,
> and everything's fine, all HTTP calls are ok - but this is unrelated to this
> ticket, and perhaps a bug in Chrome.
> This ticket seems to be most likely a bug in the plugin, because as I said
> before, doing HTTP call succeeds despite the plugin telling me that I'm
> offline.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12035) [cordova-plugin-network-information] connection info is not reliable on Android 6
[
https://issues.apache.org/jira/browse/CB-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634506#comment-16634506
]
ASF GitHub Bot commented on CB-12035:
-
PieterVanPoyer removed a comment on issue #74: CB-12035 (android) Fix bug
[cordova-plugin-network-information] connection info is not reliable on Android
6
URL:
https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426029809
@janpio Hey janpio, the travis-ci build keeps failing. Can I restart the
travis build?
I 've seen that
https://github.com/apache/cordova-plugin-media-capture/issues/105 is closed
now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cordova-plugin-network-information] connection info is not reliable on
> Android 6
> -
>
> Key: CB-12035
> URL: https://issues.apache.org/jira/browse/CB-12035
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-network-information
>Affects Versions: 1.3.0
> Environment: Samsung Galaxy Edge S6 / Android 6
> useragent: "Mozilla/5.0 (Linux; Android 6.0.1; SM-G925F Build/MMB29K; wv)
> AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.124
> Mobile Safari/537.36"
> reproduced with:
> cordova-plugin-network-information@1.3.0 (latest)
> cordova-plugin-network-information@1.2.0
>Reporter: jakub-g
>Priority: Major
> Labels: android
>
> I've noticed that information exposed by the plugin is not reliable. It
> happens often that I'm connected to the internet via WiFi, and the plugin
> says that there's no connection.
> It's not easy to reproduce it on-demand, but I reproduced it many times
> recently. It happens most often when in the morning, I open the Cordova app
> that was running in background throughout the night.
> Then, when I connect to Chrome Dev Tools, I can do a repl session like this:
> {code}
> > navigator.connection.type
> "none"
> > window.fetch('http://www.example.org').then(function(res)
> > {console.log(res.status)})
> Promise {[[PromiseStatus]]: "pending", [[PromiseValue]]: undefined}
> 200
> Fetch complete: GET "http://www.example.org/;.(anonymous function)
> > navigator.connection.type
> "none"
> {code}
> So, the plugin thinks I'm offline, yet any HTTP calls done within the app
> without checking if I'm offline or online, are successful (either from the
> app or devtools).
> When I disable WiFi and reenable it, after a few seconds the plugin updates
> its state and then it tells that connection type is "wifi".
> There are several possibilities here:
> - either system (or device driver) gives us incorrect information, or
> - cordova plugin is caching data and/or not listening properly to all the
> events and/or incorrectly processing it
> and most probably the issue manifests itself when the device is asleep for
> many hours (but I'm not sure about this).
> Note that I also noticed another issue, that sometimes the Chrome network
> stack thinks I'm offline (when I do an HTTP call, it fails immediately and I
> see network errors in devtools console) - and then I restart the Cordova app,
> and everything's fine, all HTTP calls are ok - but this is unrelated to this
> ticket, and perhaps a bug in Chrome.
> This ticket seems to be most likely a bug in the plugin, because as I said
> before, doing HTTP call succeeds despite the plugin telling me that I'm
> offline.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12035) [cordova-plugin-network-information] connection info is not reliable on Android 6
[
https://issues.apache.org/jira/browse/CB-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634505#comment-16634505
]
ASF GitHub Bot commented on CB-12035:
-
PieterVanPoyer commented on issue #74: CB-12035 (android) Fix bug
[cordova-plugin-network-information] connection info is not reliable on Android
6
URL:
https://github.com/apache/cordova-plugin-network-information/pull/74#issuecomment-426029809
@janpio Hey janpio, the travis-ci build keeps failing. Can I restart the
travis build?
I 've seen that
https://github.com/apache/cordova-plugin-media-capture/issues/105 is closed
now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [cordova-plugin-network-information] connection info is not reliable on
> Android 6
> -
>
> Key: CB-12035
> URL: https://issues.apache.org/jira/browse/CB-12035
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-network-information
>Affects Versions: 1.3.0
> Environment: Samsung Galaxy Edge S6 / Android 6
> useragent: "Mozilla/5.0 (Linux; Android 6.0.1; SM-G925F Build/MMB29K; wv)
> AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/53.0.2785.124
> Mobile Safari/537.36"
> reproduced with:
> cordova-plugin-network-information@1.3.0 (latest)
> cordova-plugin-network-information@1.2.0
>Reporter: jakub-g
>Priority: Major
> Labels: android
>
> I've noticed that information exposed by the plugin is not reliable. It
> happens often that I'm connected to the internet via WiFi, and the plugin
> says that there's no connection.
> It's not easy to reproduce it on-demand, but I reproduced it many times
> recently. It happens most often when in the morning, I open the Cordova app
> that was running in background throughout the night.
> Then, when I connect to Chrome Dev Tools, I can do a repl session like this:
> {code}
> > navigator.connection.type
> "none"
> > window.fetch('http://www.example.org').then(function(res)
> > {console.log(res.status)})
> Promise {[[PromiseStatus]]: "pending", [[PromiseValue]]: undefined}
> 200
> Fetch complete: GET "http://www.example.org/;.(anonymous function)
> > navigator.connection.type
> "none"
> {code}
> So, the plugin thinks I'm offline, yet any HTTP calls done within the app
> without checking if I'm offline or online, are successful (either from the
> app or devtools).
> When I disable WiFi and reenable it, after a few seconds the plugin updates
> its state and then it tells that connection type is "wifi".
> There are several possibilities here:
> - either system (or device driver) gives us incorrect information, or
> - cordova plugin is caching data and/or not listening properly to all the
> events and/or incorrectly processing it
> and most probably the issue manifests itself when the device is asleep for
> many hours (but I'm not sure about this).
> Note that I also noticed another issue, that sometimes the Chrome network
> stack thinks I'm offline (when I do an HTTP call, it fails immediately and I
> see network errors in devtools console) - and then I restart the Cordova app,
> and everything's fine, all HTTP calls are ok - but this is unrelated to this
> ticket, and perhaps a bug in Chrome.
> This ticket seems to be most likely a bug in the plugin, because as I said
> before, doing HTTP call succeeds despite the plugin telling me that I'm
> offline.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera
[ https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634485#comment-16634485 ] ASF GitHub Bot commented on CB-13307: - janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t… URL: https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-426024101 Jippieh! I removed some unwanted changes to README that somehow made their way into this via merge/rebase. Now "only" waiting for review and merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Accessing Google Photos on Pixel from cordova-plugin-camera > --- > > Key: CB-13307 > URL: https://issues.apache.org/jira/browse/CB-13307 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: David Briglio >Priority: Major > > Currently when trying to access some photos from Google Photos, it fails to > load. Android 8.0 on Google Pixel, cordova version 6.5.0, > cordova-plugin-camera version 2.4.1. > Causes: > 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types > are considered an invalid image. The mimetype of the image I am loading gets > set to "image/*". > 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri > authority is compared against "com.google.android.apps.photos.content", where > the actual is "com.google.android.apps.photos.contentprovider". This causes > the logic to dismiss the image as not from Google Photos. > After applying fixes for these two areas, I am able to successfully load all > of my images. > Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286]. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera
[ https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634475#comment-16634475 ] ASF GitHub Bot commented on CB-13307: - DavidBriglio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t… URL: https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-426020724 @janpio Tests are now passing! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Accessing Google Photos on Pixel from cordova-plugin-camera > --- > > Key: CB-13307 > URL: https://issues.apache.org/jira/browse/CB-13307 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: David Briglio >Priority: Major > > Currently when trying to access some photos from Google Photos, it fails to > load. Android 8.0 on Google Pixel, cordova version 6.5.0, > cordova-plugin-camera version 2.4.1. > Causes: > 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types > are considered an invalid image. The mimetype of the image I am loading gets > set to "image/*". > 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri > authority is compared against "com.google.android.apps.photos.content", where > the actual is "com.google.android.apps.photos.contentprovider". This causes > the logic to dismiss the image as not from Google Photos. > After applying fixes for these two areas, I am able to successfully load all > of my images. > Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286]. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera
[ https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634379#comment-16634379 ] ASF GitHub Bot commented on CB-13307: - janpio commented on issue #286: CB-13307: (Android) Fixed issue when unable to load image with mime t… URL: https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-425996898 And another rebase/merge from `master` to get those tests passing @DavidBriglio? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Accessing Google Photos on Pixel from cordova-plugin-camera > --- > > Key: CB-13307 > URL: https://issues.apache.org/jira/browse/CB-13307 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: David Briglio >Priority: Major > > Currently when trying to access some photos from Google Photos, it fails to > load. Android 8.0 on Google Pixel, cordova version 6.5.0, > cordova-plugin-camera version 2.4.1. > Causes: > 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types > are considered an invalid image. The mimetype of the image I am loading gets > set to "image/*". > 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri > authority is compared against "com.google.android.apps.photos.content", where > the actual is "com.google.android.apps.photos.contentprovider". This causes > the logic to dismiss the image as not from Google Photos. > After applying fixes for these two areas, I am able to successfully load all > of my images. > Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286]. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12873) Options needed to customize caputure button
[ https://issues.apache.org/jira/browse/CB-12873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634353#comment-16634353 ] ASF GitHub Bot commented on CB-12873: - charlesverge commented on issue #268: CB-12873: Add customization options for caputre button, resizing of v… URL: https://github.com/apache/cordova-plugin-camera/pull/268#issuecomment-425989962 @janpio I've rebased the commit, the changes since the last rebase do not affect this code and everything looks good. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Options needed to customize caputure button > --- > > Key: CB-12873 > URL: https://issues.apache.org/jira/browse/CB-12873 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: 6.2.2 > Environment: browser >Reporter: Charles Verge >Priority: Major > Labels: browser, camera > > The browser version of the camera plugin is missing > # Options to configure > ## text for capture button > ## Class > ## Cancel button > ## zIndex > ## position > # Cancel button > # Resizing of video upon browser resize or orientation change > # Graceful activation of file selector dialog and visibility of file input -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12479) InAppBrowser: Add Loading Spinner for Android
[ https://issues.apache.org/jira/browse/CB-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634146#comment-16634146 ] ASF GitHub Bot commented on CB-12479: - cjpearson commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425937808 @janpio No problem, I had to make another change anyway. The latest commit replaces the deprecated ProgressDialog with a ProgressBar. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser: Add Loading Spinner for Android > - > > Key: CB-12479 > URL: https://issues.apache.org/jira/browse/CB-12479 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0 > Environment: Android (at least) >Reporter: jcesarmobile >Priority: Trivial > Labels: Triaged > > In CB-3750 a loader spinner was added for iOS. There was another PR for > Android but it was never merged, so I'm creating this new issue for Android. > PR https://github.com/apache/cordova-plugin-inappbrowser/pull/88 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12479) InAppBrowser: Add Loading Spinner for Android
[ https://issues.apache.org/jira/browse/CB-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634115#comment-16634115 ] ASF GitHub Bot commented on CB-12479: - janpio commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425935160 Thanks for the rebase, and sorry I didn't check what repo this PR was in before writing this: `cordova-plugin-inappbrowser` has another test problem. You can follow my progress understanding it here: https://github.com/apache/cordova-plugin-inappbrowser/issues/307 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser: Add Loading Spinner for Android > - > > Key: CB-12479 > URL: https://issues.apache.org/jira/browse/CB-12479 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0 > Environment: Android (at least) >Reporter: jcesarmobile >Priority: Trivial > Labels: Triaged > > In CB-3750 a loader spinner was added for iOS. There was another PR for > Android but it was never merged, so I'm creating this new issue for Android. > PR https://github.com/apache/cordova-plugin-inappbrowser/pull/88 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12479) InAppBrowser: Add Loading Spinner for Android
[ https://issues.apache.org/jira/browse/CB-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634051#comment-16634051 ] ASF GitHub Bot commented on CB-12479: - janpio commented on issue #88: CB-12479: Add loading spinner for android URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/88#issuecomment-425913364 Awesome. Unfortunately I have some more "work" for you: I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > InAppBrowser: Add Loading Spinner for Android > - > > Key: CB-12479 > URL: https://issues.apache.org/jira/browse/CB-12479 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser >Affects Versions: 2.5.0, 2.6.0, 2.7.0, 2.8.0 > Environment: Android (at least) >Reporter: jcesarmobile >Priority: Trivial > Labels: Triaged > > In CB-3750 a loader spinner was added for iOS. There was another PR for > Android but it was never merged, so I'm creating this new issue for Android. > PR https://github.com/apache/cordova-plugin-inappbrowser/pull/88 -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14024) Doesn't have into account statusbar height when toolbar is enabled
[
https://issues.apache.org/jira/browse/CB-14024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634050#comment-16634050
]
ASF GitHub Bot commented on CB-14024:
-
janpio commented on issue #265: CB-14024 Take into account statusbar height
when toolbar is enabled
URL:
https://github.com/apache/cordova-plugin-inappbrowser/pull/265#issuecomment-425913163
Hey, I just fixed the problem that caused Android tests to fail in `master`.
Could you rebase this PR please? This should get rid of the Android failures
and possibly fix all test failures for this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Doesn't have into account statusbar height when toolbar is enabled
> --
>
> Key: CB-14024
> URL: https://issues.apache.org/jira/browse/CB-14024
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Humberto Alfonso Díaz
>Priority: Major
> Labels: inappbrowser, ios
>
> When using the following configuration:
> {code:java}
> this.browser.create(element.url, '_blank',"toolbar=yes,toolbarposition=top");
> {code}
> the plugin doesn't takes into account he statusbar height causing the webpage
> to not show properly on the header.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.
[ https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634049#comment-16634049 ] ASF GitHub Bot commented on CB-14188: - janpio commented on issue #276: CB-14188: add beforeload event, catching navigation before it happens URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-425913068 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Callback to decide whether to open link or not. > --- > > Key: CB-14188 > URL: https://issues.apache.org/jira/browse/CB-14188 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > Several times I've found myself wanting to tell inAppBrowser whether it can > open a link in the embedded webview or using the system web browser. It would > be great if there's a callback _before_ loading a page (loadstart is too late > there), where I can tell inAppBrowser to load the page or not. > CB-14013 introduced AllowedSchemes, but excluded the use of http and https. > -It would be useful to allow intercepting http and https links, e.g. to > decide whether to open the link in the system web browser or not.- At first I > thought this mechanism could be used, but because of the asynchronous nature > of Cordova callbacks, this didn't work out, and I added a beforeload > callback. See comment for an example. > I've submitted a PR -(my approach would be to generate a regexp based on > AllowedSchemes and match the URL on that, instead of the current if logic)-. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14190) Double click `` element causes app to exit.
[ https://issues.apache.org/jira/browse/CB-14190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634048#comment-16634048 ] ASF GitHub Bot commented on CB-14190: - janpio commented on issue #275: CB-14190: (windows) Fix bug where double clicking `` exits app URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/275#issuecomment-425913000 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Double click `` element causes app to exit. > --- > > Key: CB-14190 > URL: https://issues.apache.org/jira/browse/CB-14190 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-inappbrowser, cordova-windows >Affects Versions: 3.0.0 >Reporter: Iain Connor >Assignee: Jesse MacFadyen >Priority: Minor > > In Windows, create an inappbrowser and browse somewhere with target not > `_system` or `_self` or empty. > Find a `` element and double click it. > Expected behaviour: > First click expands `` dropdown by showing ``s. > Second click is ignored or chooses `` under cursor, if there is one. > Actual behaviour: > Second click exits the inappbrowser. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12873) Options needed to customize caputure button
[ https://issues.apache.org/jira/browse/CB-12873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634046#comment-16634046 ] ASF GitHub Bot commented on CB-12873: - janpio commented on issue #268: CB-12873: Add customization options for caputre button, resizing of v… URL: https://github.com/apache/cordova-plugin-camera/pull/268#issuecomment-425912660 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Options needed to customize caputure button > --- > > Key: CB-12873 > URL: https://issues.apache.org/jira/browse/CB-12873 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Affects Versions: 6.2.2 > Environment: browser >Reporter: Charles Verge >Priority: Major > Labels: browser, camera > > The browser version of the camera plugin is missing > # Options to configure > ## text for capture button > ## Class > ## Cancel button > ## zIndex > ## position > # Cancel button > # Resizing of video upon browser resize or orientation change > # Graceful activation of file selector dialog and visibility of file input -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13245) Filereader.readAsText fails on Android with long text files when
[ https://issues.apache.org/jira/browse/CB-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634041#comment-16634041 ] ASF GitHub Bot commented on CB-13245: - janpio commented on issue #217: CB-13245: (android) Fix bug caused by negative length reported for an asset URL: https://github.com/apache/cordova-plugin-file/pull/217#issuecomment-425912429 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Filereader.readAsText fails on Android with long text files when > > > Key: CB-13245 > URL: https://issues.apache.org/jira/browse/CB-13245 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file >Affects Versions: Master > Environment: Android 7.1.1 >Reporter: Daniel Behnen >Priority: Major > > When reader.readAsText is called with an URI pointing to a local asset with a > size greater than READ_CHUNK_SIZE = 256 * 1024, loading produces corrupt > data. > The behaviour is caused by a negative length returned by > CordovaResourceApi.openForRead() when the URI is a URI_TYPE_ASSET. Given the > negative length, Filesystem.readFileAtURL() returns the whole file instead of > the desired part and FileReader.readSuccessCallback() does not check the > returned buffer size. Hence, the following chunks are attated to the buffer > regardless of whether the file was already completely read. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13208) File plugin on Windows reads entire file into memory when only a small fragment is requested on `readAsBinaryString`
[ https://issues.apache.org/jira/browse/CB-13208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634039#comment-16634039 ] ASF GitHub Bot commented on CB-13208: - janpio commented on issue #216: CB-13208: (windows) Fix `readAsBinaryString` to only read the requested range URL: https://github.com/apache/cordova-plugin-file/pull/216#issuecomment-425912291 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > File plugin on Windows reads entire file into memory when only a small > fragment is requested on `readAsBinaryString` > > > Key: CB-13208 > URL: https://issues.apache.org/jira/browse/CB-13208 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file >Affects Versions: 6.5.0 > Environment: All Windows UAP applications >Reporter: Samer Albahra >Priority: Major > > `readAsBinaryString` for `FileReader` on Windows is reading the entire file > to a buffer then slicing the requested fragment causing the app to crash due > to out of memory errors. It should instead be using a stream which seeks to > the requested start position and only reads the requested length. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13836) Windows phone correct filename
[ https://issues.apache.org/jira/browse/CB-13836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634044#comment-16634044 ] ASF GitHub Bot commented on CB-13836: - janpio commented on issue #311: CB-13836 Windows phone correct filename URL: https://github.com/apache/cordova-plugin-camera/pull/311#issuecomment-425912543 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Windows phone correct filename > -- > > Key: CB-13836 > URL: https://issues.apache.org/jira/browse/CB-13836 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-camera >Reporter: Mark de Groot >Priority: Minor > > All photos are stored as 'photo.jpg' of 'photo.png'. Change the filename to > match Android behaviour. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13849) getDirectory('') returns root path
[
https://issues.apache.org/jira/browse/CB-13849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634042#comment-16634042
]
ASF GitHub Bot commented on CB-13849:
-
janpio commented on issue #230: CB-13849: (android) getDirectory("") returns
current path instead of / path
URL:
https://github.com/apache/cordova-plugin-file/pull/230#issuecomment-425912496
Hey, I just fixed the problem that caused Android tests to fail in `master`.
Could you rebase this PR please? This should get rid of the Android failures
and possibly fix all test failures for this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> getDirectory('') returns root path
> --
>
> Key: CB-13849
> URL: https://issues.apache.org/jira/browse/CB-13849
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
>Affects Versions: cordova-android-7.0.0
> Environment: Android
>Reporter: Tobias Haupenthal
>Priority: Major
>
> At the moment the command \{someDir}.getDirectory("") with a blank argument
> returns the root-path.
> If someone works already on a subdirectory that behaviour might be a security
> flaw.
> Better would be to return the current directory.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13774) cordova-plugin-media broken recording and playback functionality
[
https://issues.apache.org/jira/browse/CB-13774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634037#comment-16634037
]
ASF GitHub Bot commented on CB-13774:
-
janpio commented on issue #164: CB-13774: repair broken recording and playback
functionality on Android
URL:
https://github.com/apache/cordova-plugin-media/pull/164#issuecomment-425912074
Hey, I just fixed the problem that caused Android tests to fail in `master`.
Could you rebase this PR please? This should get rid of the Android failures
and possibly fix all test failures for this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> cordova-plugin-media broken recording and playback functionality
> -
>
> Key: CB-13774
> URL: https://issues.apache.org/jira/browse/CB-13774
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-media
> Environment: Android
>Reporter: Mark Mitchell
>Priority: Blocker
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The problem seems to be that somehow the encoder and decoder are set to
> different encoding types and are not compatible. Additionally its assuming an
> encoder is available on the platform and since the interface to the this
> object does not allow a way to specifying encoding I feel like the default
> may have been more appropriate.
> Currently the code is as follows
> {code:java}
> this.recorder.setOutputFormat(MediaRecorder.OutputFormat.AAC_ADTS); //
> RAW_AMR);
> this.recorder.setAudioEncoder(MediaRecorder.AudioEncoder.AAC); //AMR_NB);
> {code}
> But trying to play back the recorded audio fails with a decoder error
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13633) Report info/warning events on Android
[ https://issues.apache.org/jira/browse/CB-13633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634036#comment-16634036 ] ASF GitHub Bot commented on CB-13633: - janpio commented on issue #156: CB-13633: (android) Propagate buffering start/stop events on Android. URL: https://github.com/apache/cordova-plugin-media/pull/156#issuecomment-425911924 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Report info/warning events on Android > - > > Key: CB-13633 > URL: https://issues.apache.org/jira/browse/CB-13633 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-media >Reporter: Michael Goffioul >Priority: Minor > > In order to get notified of buffering events, it is handy to report > info/warning events (MediaPlayer.OnInfoListener) up to the web application. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-6938) iOS File plugin: copyTo for file returns error when destination file exists
[
https://issues.apache.org/jira/browse/CB-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634038#comment-16634038
]
ASF GitHub Bot commented on CB-6938:
janpio commented on issue #211: CB-6938: (fix) on iOS, copyTo should overwrite
any existing file
URL:
https://github.com/apache/cordova-plugin-file/pull/211#issuecomment-425912239
Hey, I just fixed the problem that caused Android tests to fail in `master`.
Could you rebase this PR please? This should get rid of the Android failures
and possibly fix all test failures for this PR.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> iOS File plugin: copyTo for file returns error when destination file exists
> ---
>
> Key: CB-6938
> URL: https://issues.apache.org/jira/browse/CB-6938
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-file
>Affects Versions: 3.5.0
> Environment: ios
>Reporter: vldm
>Assignee: Ian Clelland
>Priority: Major
> Labels: iOS
>
> According to w3c spec:
> A copy of a file on top of an existing file must attempt to delete and
> replace that file.
> iOS version of plugin in file CDVLocalFilesystem.m contains this code for the
> case:
> {code}
> } else if (bNewExists) {
> // the full destination should NOT already exist if a copy
> errCode = PATH_EXISTS_ERR;
> {code}
> Suggested patch:
> {code}
> diff --git a/src/ios/CDVLocalFilesystem.m b/src/ios/CDVLocalFilesystem.m
> index d1576ad..f5aa508 100644
> --- a/src/ios/CDVLocalFilesystem.m
> +++ b/src/ios/CDVLocalFilesystem.m
> @@ -535,11 +535,11 @@
> if (bSrcIsDir && ![self canCopyMoveSrc:srcFullPath
> ToDestination:newFileSystemPath]) {
> // can't copy dir into self
> errCode = INVALID_MODIFICATION_ERR;
> -} else if (bNewExists) {
> -// the full destination should NOT already exist if a
> copy
> -errCode = PATH_EXISTS_ERR;
> } else {
> -bSuccess = [fileMgr copyItemAtPath:srcFullPath
> toPath:newFileSystemPath error:];
> + bSuccess = YES;
> +if (bNewExists)
> +bSuccess = [fileMgr
> removeItemAtPath:newFileSystemPath error:];
> +if (bSuccess)
> +bSuccess = [fileMgr copyItemAtPath:srcFullPath
> toPath:newFileSystemPath error:];
> }
> } else { // move
> // iOS requires that destination must not exist before
> calling moveTo
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13852) cordova-plugin-media getPosition audio failed
[ https://issues.apache.org/jira/browse/CB-13852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634035#comment-16634035 ] ASF GitHub Bot commented on CB-13852: - janpio commented on issue #165: CB-13852: (iOS) Fix bug prevent error on getPosition URL: https://github.com/apache/cordova-plugin-media/pull/165#issuecomment-425911880 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-plugin-media getPosition audio failed > - > > Key: CB-13852 > URL: https://issues.apache.org/jira/browse/CB-13852 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-media >Affects Versions: cordova-ios 4.5.0 > Environment: iOS all versions >Reporter: Juan Sebastian Dussan Cubides >Priority: Minor > > (iOS) > When I try to get the position of an audio that had an error while loading, > the crash appose exponentially because it can not cast the time = none -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13632) UDP not handled as streaming on Android
[ https://issues.apache.org/jira/browse/CB-13632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634033#comment-16634033 ] ASF GitHub Bot commented on CB-13632: - janpio commented on issue #155: CB-13632: (android) Allow UDP media streaming. URL: https://github.com/apache/cordova-plugin-media/pull/155#issuecomment-425911778 Hey, I just fixed the problem that caused Android tests to fail in `master`. Could you rebase this PR please? This should get rid of the Android failures and possibly fix all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > UDP not handled as streaming on Android > --- > > Key: CB-13632 > URL: https://issues.apache.org/jira/browse/CB-13632 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-media >Reporter: Michael Goffioul >Priority: Minor > > When using a UDP multicast URL as media source, it is not handled as a > streaming content by AudioPlayer.isStreaming(). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13460) Apply Android style to the splash screen.
[ https://issues.apache.org/jira/browse/CB-13460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634027#comment-16634027 ] ASF GitHub Bot commented on CB-13460: - janpio commented on issue #137: CB-13460: Apply Android style to the splash screen URL: https://github.com/apache/cordova-plugin-splashscreen/pull/137#issuecomment-425911395 Hey, I just fixed the problem that caused Android tests to fail. Rebasing on master should get rid of those and possibly remove all test failures for this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Apply Android style to the splash screen. > - > > Key: CB-13460 > URL: https://issues.apache.org/jira/browse/CB-13460 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-splashscreen >Reporter: Piotr Dyraga >Priority: Major > > This improvement aims at making the splash screen dialog use the > `SplashScreenStyle`, if defined. If not, it plugin should fall back to the > default style (backward compatibility). -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633973#comment-16633973 ] ASF GitHub Bot commented on CB-7179: janpio edited a comment on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425896071 The test failure was caused by a timeout - the test seemed to need a tiny bit more than the 5 minutes that were configured as timeout. As I was working on similar problems with Android, I just doubled that for now to 10 minutes. Didn't help a thing. Closer look at the tests on Saucelabs show that there is some code looping: https://saucelabs.com/beta/tests/04cc3e87441e4252af89a7587e240d73/commands#12 No idea what and why (yet). But: You could rebase (hopefully) one last time onto `master`, I have re-enabled another iOS test on Travis that was disabled for no good reason and most importantly fixed the unrelated Android test(s) that are currently failing here as well. At least those should be fixed then. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView
[ https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633954#comment-16633954 ] ASF GitHub Bot commented on CB-7179: janpio commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-425896071 The test failure was caused by a timeout - the test seemed to need a tiny bit more than the 5 minutes that were configured as timeout. As I was working on similar problems with Android, I just doubled that for now to 10 minutes. Didn't help a thing. Closer look at the tests on Saucelabs show that there is some code looping: https://saucelabs.com/beta/tests/04cc3e87441e4252af89a7587e240d73/commands#12 No idea what and why (yet). But: You could rebase (hopefully) one last time onto `master`, I have re-enabled another iOS test on Travis that was disabled for no good reason and most importantly fixed the unrelated Android test(s) that are failing here as well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [InAppBrowser][iOS 8] Update to support WKWebView > - > > Key: CB-7179 > URL: https://issues.apache.org/jira/browse/CB-7179 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-plugin-inappbrowser > Environment: iOS 8 >Reporter: Shazron Abdullah >Priority: Major > > support dual use with UIWebView -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14166) Cordova on windows fails when adding plugin
[ https://issues.apache.org/jira/browse/CB-14166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633873#comment-16633873 ] ASF subversion and git services commented on CB-14166: -- Commit 7ac19a8b086e8fa19551cbfc2e188c3bd7072da1 in cordova-lib's branch refs/heads/cross-spawn-test from Almir Kadric [ https://gitbox.apache.org/repos/asf?p=cordova-lib.git;h=7ac19a8 ] CB-14166: (cli) Fixed issue when install plugins on windows The npm package name is already wrapped in quotes to prevent special characters from being execute. However the additional win32 code was further injecting quotes around the version causing npm to return a EINVALIDTAGNAME error. The win32 code is redundant and seems to not be required. > Cordova on windows fails when adding plugin > --- > > Key: CB-14166 > URL: https://issues.apache.org/jira/browse/CB-14166 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-windows >Reporter: takuya >Assignee: Jesse MacFadyen >Priority: Blocker > Attachments: screenshot-1.png, スクリーンショット 2018-09-06 11.36.42.png > > > cordova on windows fails to add the plugin. > This error happens even when cordova-plugin-whitelist. > Therefore `cordova platform add windows` also fails. > For example, > ``` > > cordova create sample > > cd sample > > cordova platform add windows > ``` > brings following error. > ``` > ... > Check your connection and plugin name/version/URL. > Error: C:\Program Files (x86)\Nodist\bin\npm.exe: Command failed with exit > code 1 Error output: > npm ERR! code EINVALIDTAGNAME > npm ERR! Invalid tag name ""1"": Tags may not have any characters that > encodeURIComponent encodes. > ``` > This error happens for windows environment only. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13745) Add build-tools-26.0.2 to travis for Android tests
[ https://issues.apache.org/jira/browse/CB-13745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633856#comment-16633856 ] Jan Piotrowski (Sujan) commented on CB-13745: - Did you do this manually or do you have a script to make as many changes across as many repos? > Add build-tools-26.0.2 to travis for Android tests > -- > > Key: CB-13745 > URL: https://issues.apache.org/jira/browse/CB-13745 > Project: Apache Cordova > Issue Type: Bug >Reporter: jcesarmobile >Priority: Major > > Android tests are failing in plugins because of unaccepted licenses, to fix > it we have to add build-tools-26.0.2 to the travis.yml for all plugins -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
