[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-12-07 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730578#comment-15730578
 ] 

ASF subversion and git services commented on CB-11848:
--

Commit 7ae74f5385e14b1e81ed7396ba12c21782d6eac7 in cordova-plugin-file's branch 
refs/heads/4.3.x from [~Nikita Matrosov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=7ae74f5 ]

CB-11848 windows: Remove duplicate slash after file system path

 This closes #195, this closes #112


> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-10-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552057#comment-15552057
 ] 

ASF GitHub Bot commented on CB-11848:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/195


> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-10-06 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552056#comment-15552056
 ] 

ASF subversion and git services commented on CB-11848:
--

Commit 7ae74f5385e14b1e81ed7396ba12c21782d6eac7 in cordova-plugin-file's branch 
refs/heads/master from [~Nikita Matrosov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=7ae74f5 ]

CB-11848 windows: Remove duplicate slash after file system path

 This closes #195, this closes #112


> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-09-29 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533201#comment-15533201
 ] 

ASF GitHub Bot commented on CB-11848:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/195
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file/pull/195/commits/62fa66bff4daadd8297f15bfdaa931add7decb62)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/45//PLATFORM=android/artifact/)
 |
 



> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-09-29 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533147#comment-15533147
 ] 

ASF GitHub Bot commented on CB-11848:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/195
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file/pull/195/commits/b90d25c78f14bf0ca55b02f49f40278250663d5e)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/44//PLATFORM=android/artifact/)
 |
 



> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-09-29 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15532667#comment-15532667
 ] 

ASF GitHub Bot commented on CB-11848:
-

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/195
  
@vladimir-kotikov, updated


> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-09-28 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528788#comment-15528788
 ] 

ASF GitHub Bot commented on CB-11848:
-

Github user vladimir-kotikov commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/195
  
Reminder: there is another PR (#112) that fixes CB-11848


> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-09-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509662#comment-15509662
 ] 

ASF GitHub Bot commented on CB-11848:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/195
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file/pull/195/commits/35b7a25f9f1b469daca7386a85f9eb68b82110b9)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/42//PLATFORM=android/artifact/)
 |
 



> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-09-21 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509194#comment-15509194
 ] 

ASF GitHub Bot commented on CB-11848:
-

GitHub user matrosovN opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/195

CB-11848 windows: Remove duplicate slash after file system path



### Platforms affected
Windows

### What does this PR do?
As we have always trailing slash after file system path we get invalid URI, 
for example ms-appdata:///temp//myfile.file, therefore we needn't leading slash 
in path argument. This PR removes it.

### Checklist
- [x] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and 
submitted to secret...@apache.org.
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matrosovN/cordova-plugin-file CB-11848

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/195.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #195


commit 35b7a25f9f1b469daca7386a85f9eb68b82110b9
Author: Nikita Matrosov 
Date:   2016-09-20T11:07:56Z

CB-11848 windows: Remove duplicate slash after file system path

As we have always trailing slash after file system path we get invalid URI, 
for example ms-appdata:///temp//myfile.file, therefore we needn't leading slash 
in path argument




> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-11848) [Windows] File plugin, nativeUrl includes two slashes before filename

2016-09-20 Thread Maarten Manders (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-11848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15505917#comment-15505917
 ] 

Maarten Manders commented on CB-11848:
--

Resolved in https://github.com/apache/cordova-plugin-file/pull/112

> [Windows] File plugin, nativeUrl includes two slashes before filename
> -
>
> Key: CB-11848
> URL: https://issues.apache.org/jira/browse/CB-11848
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File
>Reporter: Maarten Manders
>  Labels: windows
>
> The returned FileEntry object in the getFile function of a DirectoryEntry 
> object contains an incorrect nativeUrl that contains 2 slashes before the 
> filename (ie. ms-appdata:///temp//myfile.file).
> This can seemingly be resolved by changing the following line in the getFile 
> function in FileProxy.js:
> var fspath = sanitize(dirpath +'/'+ path);
> to
> var fspath = sanitize(path);
> I am unsure if this causes any side-effects however.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org