[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730650#comment-15730650
 ] 

ASF subversion and git services commented on CB-10228:
--

Commit bf24bb63416a7961196a1ba70023c5ebdad5c955 in 
cordova-plugin-wkwebview-engine's branch refs/heads/1.1.x from kelvinho
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=bf24bb6
 ]

CB-10228:(iOS) AppendUserAgent not working with WKWebView


> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>Assignee: Shazron Abdullah
>  Labels: triaged, wkwebview-1.0.2
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723634#comment-15723634
 ] 

ASF GitHub Bot commented on CB-10228:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24


> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>Assignee: Shazron Abdullah
>  Labels: triaged, wkwebview-1.0.2
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723633#comment-15723633
 ] 

ASF subversion and git services commented on CB-10228:
--

Commit bf24bb63416a7961196a1ba70023c5ebdad5c955 in 
cordova-plugin-wkwebview-engine's branch refs/heads/master from kelvinho
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-wkwebview-engine.git;h=bf24bb6
 ]

CB-10228:(iOS) AppendUserAgent not working with WKWebView


> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>Assignee: Shazron Abdullah
>  Labels: triaged, wkwebview-1.0.2
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15723626#comment-15723626
 ] 

ASF GitHub Bot commented on CB-10228:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24
  
Pulling this in now.


> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>Assignee: Shazron Abdullah
>  Labels: triaged, wkwebview-1.0.2
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706268#comment-15706268
 ] 

ASF GitHub Bot commented on CB-10228:
-

Github user shazron commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24
  
Note: this passes tests when run locally (the CI has a known issue that it 
fails).


> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>Assignee: Shazron Abdullah
>  Labels: triaged, wkwebview-1.0.2
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704775#comment-15704775
 ] 

ASF GitHub Bot commented on CB-10228:
-

GitHub user kelvinhokk opened a pull request:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24

CB-10228:(iOS) AppendUserAgent not working with WKWebView



### Platforms affected
iOS: Currently the wkWebview users the default user agent, ignoring 
Cordova's OverrideUserAgent and AppendUserAgent in config.xml

### What does this PR do?
This attempts to set the customUserAgent property of the wkWebview to what 
is already computed in the CDVViewController

### What testing has been done on this change?
Npm tests have been run.  User agents verified changed on Cordova iOS 4.3.0 
and Cordova 6.4.0.

### Checklist
- [ X] [Reported an 
issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kelvinhokk/cordova-plugin-wkwebview-engine 
master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit 8014757681d79fc83d96bff00ca1b262f0b4b25b
Author: kelvinho 
Date:   2016-11-29T09:20:02Z

CB-10228:(iOS) AppendUserAgent not working with WKWebView




> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>Assignee: Shazron Abdullah
>  Labels: triaged, wkwebview-1.0.2
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[vB Results, LLC. (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15181965#comment-15181965
 ] 

vB Results, LLC. commented on CB-10228:
---

There is only a fix for iOS 9; for iOS 8 there is no way to set it

> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>Assignee: Shazron Abdullah
>  Labels: triaged, wkwebview-1.0.2
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[vB Results, LLC. (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110017#comment-15110017
 ] 

vB Results, LLC. commented on CB-10228:
---

[~shazron] I checked in the iPhone dev IRC and was told the only way to get it 
working in iOS 8 is to manually make the request and pipe the output into the 
WKWebView.  On the other hand, iOS 9's customUserAgent property works, so we'll 
use that for iOS 9 and a GET parameter for iOS 8-.

> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>  Labels: triaged, wkwebview-1.0.2
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[vB Results, LLC. (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15106099#comment-15106099
 ] 

vB Results, LLC. commented on CB-10228:
---

And it doesn't work for iOS 8 either, same testing devices.

> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>  Labels: triaged, wkwebview-1.0.2
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[vB Results, LLC. (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096344#comment-15096344
 ] 

vB Results, LLC. commented on CB-10228:
---

What temporary solution I can use until this is fixed?  I just need to append 
to the user agent string -- I'd love to use WKWebView and I wouldn't have to 
worry about the NSURLDOMAIN -999 error since it's not triggered here.

> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>  Labels: triaged, wkwebview-1.0.2
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[Shazron Abdullah (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067148#comment-15067148
 ] 

Shazron Abdullah commented on CB-10228:
---

Well, it's a bug that this setting does not work on iOS 9. It did, in iOS 8

> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>  Labels: wkwebview-1.0.2
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[Shazron Abdullah (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065922#comment-15065922
 ] 

Shazron Abdullah commented on CB-10228:
---

This is probably because in iOS 9 Apple finally allows us to set a custom 
UserAgent in WKWebView: 
https://developer.apple.com/library/ios/documentation/WebKit/Reference/WKWebView_Ref/#//apple_ref/occ/instp/WKWebView/customUserAgent

> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-10228) AppendUserAgent not working with WKWebView

[vB Results, LLC. (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15065948#comment-15065948
 ] 

vB Results, LLC. commented on CB-10228:
---

I'm confused; how does this translate for use in Cordova -- are the config.xml 
settings deprecated and there is a replacement?

> AppendUserAgent not working with WKWebView
> --
>
> Key: CB-10228
> URL: https://issues.apache.org/jira/browse/CB-10228
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin WKWebViewEngine
>Reporter: vB Results, LLC.
>
> Using the npm version of cordova-plugin-wkwebview-engine and cordova-ios@4 
> and AppendUserAgent is the most lightweight way to detect whether or not we 
> are in the app on a remote site.  Please fix, the lack of this means we 
> cannot benefit from using WKWebView :(



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org