[jira] [Commented] (CB-11817) audioSettings shows as unused variable and settings are not used when configuring a recorder
[ https://issues.apache.org/jira/browse/CB-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903655#comment-15903655 ] ASF GitHub Bot commented on CB-11817: - Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shazron there is an issue https://issues.apache.org/jira/browse/CB-12542, and it has a PR already > audioSettings shows as unused variable and settings are not used when > configuring a recorder > > > Key: CB-11817 > URL: https://issues.apache.org/jira/browse/CB-11817 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 2.3.0 > Environment: iOS >Reporter: Gaven Henry >Assignee: Shazron Abdullah >Priority: Minor > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > xcode shows up 2 warnings when building within CDVSound.m > 1) unused variable 'audioSettings' > 2) Null passed to a callee that requires non-null when creating an > audioFile.recorder > To resolve both of these just need to pass the autoSettings object to the > audioFile.recorder function. > This resolves both warnings and actually applies the autoSettings as expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11817) audioSettings shows as unused variable and settings are not used when configuring a recorder
[ https://issues.apache.org/jira/browse/CB-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903659#comment-15903659 ] ASF GitHub Bot commented on CB-11817: - Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @jcesarmobile great! I'll link the issues and look at the diff and integrate it, and create a proper PR > audioSettings shows as unused variable and settings are not used when > configuring a recorder > > > Key: CB-11817 > URL: https://issues.apache.org/jira/browse/CB-11817 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 2.3.0 > Environment: iOS >Reporter: Gaven Henry >Assignee: Shazron Abdullah >Priority: Minor > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > xcode shows up 2 warnings when building within CDVSound.m > 1) unused variable 'audioSettings' > 2) Null passed to a callee that requires non-null when creating an > audioFile.recorder > To resolve both of these just need to pass the autoSettings object to the > audioFile.recorder function. > This resolves both warnings and actually applies the autoSettings as expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11817) audioSettings shows as unused variable and settings are not used when configuring a recorder
[ https://issues.apache.org/jira/browse/CB-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903554#comment-15903554 ] ASF GitHub Bot commented on CB-11817: - Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shanesmith Mind filing a new issue at issues.cordova.io so we can track this? Thanks! > audioSettings shows as unused variable and settings are not used when > configuring a recorder > > > Key: CB-11817 > URL: https://issues.apache.org/jira/browse/CB-11817 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 2.3.0 > Environment: iOS >Reporter: Gaven Henry >Assignee: Shazron Abdullah >Priority: Minor > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > xcode shows up 2 warnings when building within CDVSound.m > 1) unused variable 'audioSettings' > 2) Null passed to a callee that requires non-null when creating an > audioFile.recorder > To resolve both of these just need to pass the autoSettings object to the > audioFile.recorder function. > This resolves both warnings and actually applies the autoSettings as expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11817) audioSettings shows as unused variable and settings are not used when configuring a recorder
[ https://issues.apache.org/jira/browse/CB-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902461#comment-15902461 ] ASF GitHub Bot commented on CB-11817: - Github user shanesmith commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 This change has broken recording from what I'm seeing. The plugin requires the file to have a "wav" extension, however now that the audio is being encoded as "kAudioFormatMPEG4AAC" it doesn't work, the extension needs to be "m4a" or "aac" (at least those are the two that I've tested successfully). Seems like an update here (https://github.com/apache/cordova-plugin-media/blob/master/src/ios/CDVSound.m#L41) and in the documentation would be needed to resolve this. > audioSettings shows as unused variable and settings are not used when > configuring a recorder > > > Key: CB-11817 > URL: https://issues.apache.org/jira/browse/CB-11817 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 2.3.0 > Environment: iOS >Reporter: Gaven Henry >Assignee: Shazron Abdullah >Priority: Minor > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > xcode shows up 2 warnings when building within CDVSound.m > 1) unused variable 'audioSettings' > 2) Null passed to a callee that requires non-null when creating an > audioFile.recorder > To resolve both of these just need to pass the autoSettings object to the > audioFile.recorder function. > This resolves both warnings and actually applies the autoSettings as expected. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11817) audioSettings shows as unused variable and settings are not used when configuring a recorder
[ https://issues.apache.org/jira/browse/CB-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840864#comment-15840864 ] ASF GitHub Bot commented on CB-11817: - Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shazron I just checked Jira and CB-11817 is the correct Jira issue for this issue > audioSettings shows as unused variable and settings are not used when > configuring a recorder > > > Key: CB-11817 > URL: https://issues.apache.org/jira/browse/CB-11817 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 2.3.0 > Environment: iOS >Reporter: Gaven Henry >Priority: Minor > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > xcode shows up 2 warnings when building within CDVSound.m > 1) unused variable 'audioSettings' > 2) Null passed to a callee that requires non-null when creating an > audioFile.recorder > To resolve both of these just need to pass the autoSettings object to the > audioFile.recorder function. > This resolves both warnings and actually applies the autoSettings as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11817) audioSettings shows as unused variable and settings are not used when configuring a recorder
[ https://issues.apache.org/jira/browse/CB-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840829#comment-15840829 ] ASF GitHub Bot commented on CB-11817: - Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 Which JIRA issue is this really under? it's not the right one in the title > audioSettings shows as unused variable and settings are not used when > configuring a recorder > > > Key: CB-11817 > URL: https://issues.apache.org/jira/browse/CB-11817 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 2.3.0 > Environment: iOS >Reporter: Gaven Henry >Priority: Minor > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > xcode shows up 2 warnings when building within CDVSound.m > 1) unused variable 'audioSettings' > 2) Null passed to a callee that requires non-null when creating an > audioFile.recorder > To resolve both of these just need to pass the autoSettings object to the > audioFile.recorder function. > This resolves both warnings and actually applies the autoSettings as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11817) audioSettings shows as unused variable and settings are not used when configuring a recorder
[ https://issues.apache.org/jira/browse/CB-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840822#comment-15840822 ] ASF GitHub Bot commented on CB-11817: - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/116 > audioSettings shows as unused variable and settings are not used when > configuring a recorder > > > Key: CB-11817 > URL: https://issues.apache.org/jira/browse/CB-11817 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 2.3.0 > Environment: iOS >Reporter: Gaven Henry >Priority: Minor > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > xcode shows up 2 warnings when building within CDVSound.m > 1) unused variable 'audioSettings' > 2) Null passed to a callee that requires non-null when creating an > audioFile.recorder > To resolve both of these just need to pass the autoSettings object to the > audioFile.recorder function. > This resolves both warnings and actually applies the autoSettings as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11817) audioSettings shows as unused variable and settings are not used when configuring a recorder
[ https://issues.apache.org/jira/browse/CB-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768817#comment-15768817 ] ASF GitHub Bot commented on CB-11817: - Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 This is a really trivial fix could it please get merged? > audioSettings shows as unused variable and settings are not used when > configuring a recorder > > > Key: CB-11817 > URL: https://issues.apache.org/jira/browse/CB-11817 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 2.3.0 > Environment: iOS >Reporter: Gaven Henry >Priority: Minor > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > xcode shows up 2 warnings when building within CDVSound.m > 1) unused variable 'audioSettings' > 2) Null passed to a callee that requires non-null when creating an > audioFile.recorder > To resolve both of these just need to pass the autoSettings object to the > audioFile.recorder function. > This resolves both warnings and actually applies the autoSettings as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11817) audioSettings shows as unused variable and settings are not used when configuring a recorder
[ https://issues.apache.org/jira/browse/CB-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15587364#comment-15587364 ] ASF GitHub Bot commented on CB-11817: - Github user ghenry22 commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 @shazron any chance this could get merged? It's a really small change that basically just fixes an oversight in the current version, which makes recording much more efficient and stops xcode throwing warnings all over. > audioSettings shows as unused variable and settings are not used when > configuring a recorder > > > Key: CB-11817 > URL: https://issues.apache.org/jira/browse/CB-11817 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 2.3.0 > Environment: iOS >Reporter: Gaven Henry >Priority: Minor > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > xcode shows up 2 warnings when building within CDVSound.m > 1) unused variable 'audioSettings' > 2) Null passed to a callee that requires non-null when creating an > audioFile.recorder > To resolve both of these just need to pass the autoSettings object to the > audioFile.recorder function. > This resolves both warnings and actually applies the autoSettings as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11817) audioSettings shows as unused variable and settings are not used when configuring a recorder
[ https://issues.apache.org/jira/browse/CB-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511570#comment-15511570 ] ASF GitHub Bot commented on CB-11817: - Github user hounsellal commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 This is very important. The file sizes are way smaller by this little change - I literally spent 2 days trying to compress the audio files with a lamejs library because they were so large - when such an easy fix would have saved me all that time. > audioSettings shows as unused variable and settings are not used when > configuring a recorder > > > Key: CB-11817 > URL: https://issues.apache.org/jira/browse/CB-11817 > Project: Apache Cordova > Issue Type: Bug > Components: Plugin Media >Affects Versions: 2.3.0 > Environment: iOS >Reporter: Gaven Henry >Priority: Minor > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > xcode shows up 2 warnings when building within CDVSound.m > 1) unused variable 'audioSettings' > 2) Null passed to a callee that requires non-null when creating an > audioFile.recorder > To resolve both of these just need to pass the autoSettings object to the > audioFile.recorder function. > This resolves both warnings and actually applies the autoSettings as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11817) audioSettings shows as unused variable and settings are not used when configuring a recorder
[ https://issues.apache.org/jira/browse/CB-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15469246#comment-15469246 ] ASF GitHub Bot commented on CB-11817: - Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/116 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/116/commits/642aef774aa60a34b29d451f684ffc67bf732700) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=windows-8.1-store/artifact/) | | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=windows-10-store/artifact/) | | [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=windows-8.1-phone/artifact/) | | [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=ios/artifact/) | | [Android]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/79//PLATFORM=android/artifact/) | > audioSettings shows as unused variable and settings are not used when > configuring a recorder > > > Key: CB-11817 > URL: https://issues.apache.org/jira/browse/CB-11817 > Project: Apache Cordova > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the > default.) > Components: Plugin Media >Affects Versions: 2.3.0 > Environment: iOS >Reporter: Gaven Henry >Priority: Minor > Labels: easyfix > Original Estimate: 1h > Remaining Estimate: 1h > > xcode shows up 2 warnings when building within CDVSound.m > 1) unused variable 'audioSettings' > 2) Null passed to a callee that requires non-null when creating an > audioFile.recorder > To resolve both of these just need to pass the autoSettings object to the > audioFile.recorder function. > This resolves both warnings and actually applies the autoSettings as expected. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
