[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-21 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510137#comment-15510137
 ] 

ASF subversion and git services commented on CB-11836:
--

Commit 668fc3f609403b696e76b8380deca84c1b59d999 in cordova-docs's branch 
refs/heads/master from [~daserge]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=668fc3f ]

CB-11836 Documented Windows ForegroundText preference


> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510139#comment-15510139
 ] 

ASF GitHub Bot commented on CB-11836:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/638


> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-21 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510049#comment-15510049
 ] 

ASF subversion and git services commented on CB-11836:
--

Commit 10796b28a5bf4c0963b4f2eee1e63909ab215686 in cordova-windows's branch 
refs/heads/master from [~tss]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;h=10796b2 ]

CB-11836 Allow setting of 'ForegroundText' property via config.xml

Github: close #195


> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510050#comment-15510050
 ] 

ASF GitHub Bot commented on CB-11836:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/195


> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509564#comment-15509564
 ] 

ASF GitHub Bot commented on CB-11836:
-

Github user tsschaffert commented on the issue:

https://github.com/apache/cordova-windows/pull/195
  
Good points, I updated the changes accordingly.


> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509537#comment-15509537
 ] 

ASF GitHub Bot commented on CB-11836:
-

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/195#discussion_r79804658
  
--- Diff: spec/unit/AppxManifest.spec.js ---
@@ -187,6 +187,27 @@ describe('AppxManifest', function () {
 it('refineColor should leave CSS color name as is', function () {
 expect(refineColor(CSS_COLOR_NAME)).toEqual(CSS_COLOR_NAME);
 });
+
+it('setForegroundText should change the ForegroundText property on 
non-Windows 10 platforms', function () {
+var visualElementsWindows = 
AppxManifest.get(WINDOWS_MANIFEST).getVisualElements();
+var visualElementsWindows10 = 
AppxManifest.get(WINDOWS_10_MANIFEST).getVisualElements();
+
+var foregroundTextLight = 'light';
+var foregroundTextDark = 'dark';
+
+// Set to 'light'
+visualElementsWindows.setForegroundText(foregroundTextLight);
+
expect(visualElementsWindows.getForegroundText()).toEqual(foregroundTextLight);
+
+// Set to 'dark'
+visualElementsWindows.setForegroundText(foregroundTextDark);
+
expect(visualElementsWindows.getForegroundText()).toEqual(foregroundTextDark);
+
--- End diff --

It also would be good to add a case for missing preference:
```javascript
// Simulate the absence of preference, should default to 'light'
visualElementsWindows.setForegroundText(undefined);

expect(visualElementsWindows.getForegroundText()).toEqual(foregroundTextLight);
```


> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509538#comment-15509538
 ] 

ASF GitHub Bot commented on CB-11836:
-

Github user daserge commented on a diff in the pull request:

https://github.com/apache/cordova-windows/pull/195#discussion_r79803408
  
--- Diff: template/cordova/lib/AppxManifest.js ---
@@ -390,11 +390,6 @@ AppxManifest.prototype.getVisualElements = function () 
{
 },
 setForegroundText: function (color) {
 if (color) {
--- End diff --

Instead of `if (color) { visualElements.attrib.ForegroundText = color; }` 
would it be better to use `visualElements.attrib.ForegroundText = color || 
'light'` so that ForegroundText would be reset as default `light` if we set 
`dark` via preference for example and then remove the preference from 
config.xml entirely?


> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15509460#comment-15509460
 ] 

ASF GitHub Bot commented on CB-11836:
-

Github user tsschaffert commented on the issue:

https://github.com/apache/cordova-windows/pull/195
  
1) The issue with Windows 10 should be fixed now, I handled it similarly to 
the 'ToastCapable' property.
2) The color argument is now passed to the manifest file unchecked, so 
invalid values return an error like 'App manifest validation failed.' when 
building the project. Alternatively, we could throw a TypeError for invalid 
values?
3) I added only a very basic test, as there were no comparable tests for 
the visualElement methods and I don't know enough about the internals to write 
really meaningful tests



> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-21 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508878#comment-15508878
 ] 

ASF GitHub Bot commented on CB-11836:
-

Github user tsschaffert commented on the issue:

https://github.com/apache/cordova-windows/pull/195
  
@daserge I will look into it


> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506695#comment-15506695
 ] 

ASF GitHub Bot commented on CB-11836:
-

Github user daserge commented on the issue:

https://github.com/apache/cordova-windows/pull/195
  
@tsschaffert, please let me know if you plan to address the comments.


> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11836) BackgroundColor cannot be set to white

2016-09-20 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15506472#comment-15506472
 ] 

ASF GitHub Bot commented on CB-11836:
-

GitHub user daserge opened a pull request:

https://github.com/apache/cordova-docs/pull/638

CB-11836 Documented Windows ForegroundText preference

https://issues.apache.org/jira/browse/CB-11836

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/daserge/cordova-docs CB-11836

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/638.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #638


commit 55f9dbe3657b8d2488b23f482d5f3cc942673cf1
Author: daserge 
Date:   2016-09-20T13:07:56Z

CB-11836 Documented Windows ForegroundText preference




> BackgroundColor cannot be set to white
> --
>
> Key: CB-11836
> URL: https://issues.apache.org/jira/browse/CB-11836
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Windows
> Environment: Visual Studio 2015 Update 3, Apache Cordova 6.3.1, 
> cordova-windows 4.4.2
>Reporter: Steffen Schaffert
>
> Recently, we tried to release an app version to the Windows Store (targeting 
> both Mobile and Desktop platforms)  with the BackgroundColor preference in 
> config.xml set to white (see below). 
> The build succeeded, but after submitting the app in the Windows Store, the 
> submission was declined as non-compliant, the reason being a low contrast 
> between background and foreground color. After some research, we discovered 
> the property "ForegroundText", which can be "light" or "dark", and which is 
> set to "light" per default in a Windows app. After changing this property 
> (which did not have a visible impact on our app, as we are using an image for 
> icon and splashscreen), the submission was successful. 
> As a more permanent solution, I added the functionality to change the 
> ForegroundText preference, similar to BackgroundColor, in the config.xml 
> file. I submitted this as a Pull Request 
> (https://github.com/apache/cordova-windows/pull/195).
> If there is a different solution to this problem, I would be glad to hear it, 
> otherwise I hope that the pull request can be used as a fix.
> Setting in config.xml which caused problems:
> {quote}
> 
> 
> 
> {quote}
> Solution with fix applied:
> {quote}
> 
> 
> 
> 
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org