[jira] [Commented] (CB-11962) NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets reset to empty whenever the app is built. This improves the process of adding the plugin so tha

2016-12-07 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730592#comment-15730592
 ] 

ASF subversion and git services commented on CB-11962:
--

Commit f9f7a23c57daad5514ce3d830a2defeb93ba3f78 in cordova-plugin-geolocation's 
branch refs/heads/2.4.x from obione
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=f9f7a23
 ]

CB-11962: (ios) Added variable for setting NSLocationWhenInUseUsageDescription

 This closes #83


> NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets 
> reset to empty whenever the app is built. This improves the process of adding 
> the plugin so that the value is always set
> ---
>
> Key: CB-11962
> URL: https://issues.apache.org/jira/browse/CB-11962
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Geolocation
> Environment: iOS
>Reporter: Obi Onuorah
>Priority: Trivial
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When the geolocation plugin is added using the command
> cordova plugin add cordova-plugin-geolocation
> no value is added in the plugin.xml file for the 
> NSLocationWhenInUseUsageDescription even though it is in there it is empty. 
> Updating this Key directly in the plist and it always gets reset to empty. 
> Updating it in the plugin.xml means removing and adding or updating the 
> plugins might overwrite the value.
> This fix simply adds it to the config.xml so that it can be specified on 
> installation using --variable or modified later by changing the value in the 
> config.xml, removing the plugin using cordova plugin rm and then running 
> cordova prepare which re-adds the plugin with the updated value of the key



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11962) NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets reset to empty whenever the app is built. This improves the process of adding the plugin so tha

2016-10-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562745#comment-15562745
 ] 

ASF GitHub Bot commented on CB-11962:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-geolocation/pull/83
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-geolocation/pull/83/commits/041228eac66e58a2d2e339228d87d439e831ac8e)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/26//PLATFORM=android/artifact/)
 |
 



> NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets 
> reset to empty whenever the app is built. This improves the process of adding 
> the plugin so that the value is always set
> ---
>
> Key: CB-11962
> URL: https://issues.apache.org/jira/browse/CB-11962
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Geolocation
> Environment: iOS
>Reporter: Obi Onuorah
>Priority: Trivial
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When the geolocation plugin is added using the command
> cordova plugin add cordova-plugin-geolocation
> no value is added in the plugin.xml file for the 
> NSLocationWhenInUseUsageDescription even though it is in there it is empty. 
> Updating this Key directly in the plist and it always gets reset to empty. 
> Updating it in the plugin.xml means removing and adding or updating the 
> plugins might overwrite the value.
> This fix simply adds it to the config.xml so that it can be specified on 
> installation using --variable or modified later by changing the value in the 
> config.xml, removing the plugin using cordova plugin rm and then running 
> cordova prepare which re-adds the plugin with the updated value of the key



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11962) NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets reset to empty whenever the app is built. This improves the process of adding the plugin so tha

2016-10-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15559819#comment-15559819
 ] 

ASF GitHub Bot commented on CB-11962:
-

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-geolocation/pull/83
  
I've merged the PR, but I didn't notice that your commits appear as obione 
user instead of obione86, you have something misconfigured in your computer, 
check 
https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/

I'll try to fix the history of commits to show you as the author, but you 
have to fix it too so it doesn't happen again


> NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets 
> reset to empty whenever the app is built. This improves the process of adding 
> the plugin so that the value is always set
> ---
>
> Key: CB-11962
> URL: https://issues.apache.org/jira/browse/CB-11962
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Geolocation
> Environment: iOS
>Reporter: Obi Onuorah
>Priority: Trivial
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When the geolocation plugin is added using the command
> cordova plugin add cordova-plugin-geolocation
> no value is added in the plugin.xml file for the 
> NSLocationWhenInUseUsageDescription even though it is in there it is empty. 
> Updating this Key directly in the plist and it always gets reset to empty. 
> Updating it in the plugin.xml means removing and adding or updating the 
> plugins might overwrite the value.
> This fix simply adds it to the config.xml so that it can be specified on 
> installation using --variable or modified later by changing the value in the 
> config.xml, removing the plugin using cordova plugin rm and then running 
> cordova prepare which re-adds the plugin with the updated value of the key



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11962) NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets reset to empty whenever the app is built. This improves the process of adding the plugin so tha

2016-10-09 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15559797#comment-15559797
 ] 

ASF GitHub Bot commented on CB-11962:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-geolocation/pull/83


> NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets 
> reset to empty whenever the app is built. This improves the process of adding 
> the plugin so that the value is always set
> ---
>
> Key: CB-11962
> URL: https://issues.apache.org/jira/browse/CB-11962
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Geolocation
> Environment: iOS
>Reporter: Obi Onuorah
>Priority: Trivial
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When the geolocation plugin is added using the command
> cordova plugin add cordova-plugin-geolocation
> no value is added in the plugin.xml file for the 
> NSLocationWhenInUseUsageDescription even though it is in there it is empty. 
> Updating this Key directly in the plist and it always gets reset to empty. 
> Updating it in the plugin.xml means removing and adding or updating the 
> plugins might overwrite the value.
> This fix simply adds it to the config.xml so that it can be specified on 
> installation using --variable or modified later by changing the value in the 
> config.xml, removing the plugin using cordova plugin rm and then running 
> cordova prepare which re-adds the plugin with the updated value of the key



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11962) NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets reset to empty whenever the app is built. This improves the process of adding the plugin so tha

2016-10-09 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15559796#comment-15559796
 ] 

ASF subversion and git services commented on CB-11962:
--

Commit f9f7a23c57daad5514ce3d830a2defeb93ba3f78 in cordova-plugin-geolocation's 
branch refs/heads/master from obione
[ 
https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-geolocation.git;h=f9f7a23
 ]

CB-11962: (ios) Added variable for setting NSLocationWhenInUseUsageDescription

 This closes #83


> NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets 
> reset to empty whenever the app is built. This improves the process of adding 
> the plugin so that the value is always set
> ---
>
> Key: CB-11962
> URL: https://issues.apache.org/jira/browse/CB-11962
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Geolocation
> Environment: iOS
>Reporter: Obi Onuorah
>Priority: Trivial
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When the geolocation plugin is added using the command
> cordova plugin add cordova-plugin-geolocation
> no value is added in the plugin.xml file for the 
> NSLocationWhenInUseUsageDescription even though it is in there it is empty. 
> Updating this Key directly in the plist and it always gets reset to empty. 
> Updating it in the plugin.xml means removing and adding or updating the 
> plugins might overwrite the value.
> This fix simply adds it to the config.xml so that it can be specified on 
> installation using --variable or modified later by changing the value in the 
> config.xml, removing the plugin using cordova plugin rm and then running 
> cordova prepare which re-adds the plugin with the updated value of the key



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11962) NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets reset to empty whenever the app is built. This improves the process of adding the plugin so tha

2016-10-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558183#comment-15558183
 ] 

ASF GitHub Bot commented on CB-11962:
-

Github user jcesarmobile commented on the issue:

https://github.com/apache/cordova-plugin-geolocation/pull/83
  
Hi.
Thanks for the PR.
Can you also document this on the README.md.
Something like what I did on this PR.
https://github.com/apache/cordova-plugin-contacts/pull/131/files


> NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets 
> reset to empty whenever the app is built. This improves the process of adding 
> the plugin so that the value is always set
> ---
>
> Key: CB-11962
> URL: https://issues.apache.org/jira/browse/CB-11962
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Geolocation
> Environment: iOS
>Reporter: Obi Onuorah
>Priority: Trivial
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When the geolocation plugin is added using the command
> cordova plugin add cordova-plugin-geolocation
> no value is added in the plugin.xml file for the 
> NSLocationWhenInUseUsageDescription even though it is in there it is empty. 
> Updating this Key directly in the plist and it always gets reset to empty. 
> Updating it in the plugin.xml means removing and adding or updating the 
> plugins might overwrite the value.
> This fix simply adds it to the config.xml so that it can be specified on 
> installation using --variable or modified later by changing the value in the 
> config.xml, removing the plugin using cordova plugin rm and then running 
> cordova prepare which re-adds the plugin with the updated value of the key



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11962) NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets reset to empty whenever the app is built. This improves the process of adding the plugin so tha

2016-10-06 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15551001#comment-15551001
 ] 

ASF GitHub Bot commented on CB-11962:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-geolocation/pull/83
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-geolocation/pull/83/commits/79fc000a503d07ffdf395d30f5e2731b9790df63)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-geolocation-pr/25//PLATFORM=android/artifact/)
 |
 



> NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets 
> reset to empty whenever the app is built. This improves the process of adding 
> the plugin so that the value is always set
> ---
>
> Key: CB-11962
> URL: https://issues.apache.org/jira/browse/CB-11962
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Geolocation
> Environment: iOS
>Reporter: Obi Onuorah
>Priority: Trivial
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When the geolocation plugin is added using the command
> cordova plugin add cordova-plugin-geolocation
> no value is added in the plugin.xml file for the 
> NSLocationWhenInUseUsageDescription even though it is in there it is empty. 
> Updating this Key directly in the plist and it always gets reset to empty. 
> Updating it in the plugin.xml means removing and adding or updating the 
> plugins might overwrite the value.
> This fix simply adds it to the config.xml so that it can be specified on 
> installation using --variable or modified later by changing the value in the 
> config.xml, removing the plugin using cordova plugin rm and then running 
> cordova prepare which re-adds the plugin with the updated value of the key



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-11962) NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets reset to empty whenever the app is built. This improves the process of adding the plugin so tha

2016-10-05 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-11962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15550970#comment-15550970
 ] 

ASF GitHub Bot commented on CB-11962:
-

GitHub user obione86 opened a pull request:

https://github.com/apache/cordova-plugin-geolocation/pull/83

CB-11962: (ios) Added variable NSLocationWhenInUseUsageDescription to 
Config.xml



### Platforms affected
iOS

### What does this PR do?
Modifies plugin.xml to provide the value for 
NSLocationWhenInUseUsageDescription using a variable which can then be set in 
the plugin entry in the config.xml file rather than having to physically edit 
the plugin.xml file. cordova-plugin-contacts and cordova-plugin-camera follow 
the same strategy.

### What testing has been done on this change?

```
cordova create hello com.example.hello HelloWorld
$ cd hello
$ cordova platform add ios –save
$ cordova plugin add 
https://github.com/obione86/cordova-plugin-geolocation.git --variable 
GEOLOCATION_USAGE_DESCRIPTION="Thought it might be good to have a nosey" --save
```

Navigate to plugins\cordova-plugin-geolocation\plugin.xml and check the 
bottom of the ios section and it looks like this


  $GEOLOCATION_USAGE_DESCRIPTION


Open config.xml and the plugin section should have this 
https://github.com/obione86/cordova-plugin-geolocation.git;>



`$ cordova build ios`

Open platforms\ios\HelloWorld\HelloWorld-Info.plist and it should have
NSLocationWhenInUseUsageDescription
Thought it might be good to have a nosey

### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.

CB-11962: (ios) The NSLocationWhenInUseUsageDescription is required when 
using geolocation but at the moment is always set to an empty string. This 
commits adds a variable so that this value can be set in the config.xml file.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/obione86/cordova-plugin-geolocation master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-geolocation/pull/83.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #83


commit 79fc000a503d07ffdf395d30f5e2731b9790df63
Author: obione 
Date:   2016-10-05T05:14:32Z

Added variable NSLocationWhenInUseUsageDescription
The NSLocationWhenInUseUsageDescription is required when using geolocation 
but at the moment is always set to an empty string. This commits adds a 
variable so that this value can be set in the config.xml file.




> NSLocationWhenInUseUsageDescription in Info.plist is always empty and gets 
> reset to empty whenever the app is built. This improves the process of adding 
> the plugin so that the value is always set
> ---
>
> Key: CB-11962
> URL: https://issues.apache.org/jira/browse/CB-11962
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: Plugin Geolocation
> Environment: iOS
>Reporter: Obi Onuorah
>Priority: Trivial
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
> When the geolocation plugin is added using the command
> cordova plugin add cordova-plugin-geolocation
> no value is added in the plugin.xml file for the 
> NSLocationWhenInUseUsageDescription even though it is in there it is empty. 
> Updating this Key directly in the plist and it always gets reset to empty. 
> Updating it in the plugin.xml means removing and adding or updating the 
> plugins might overwrite the value.
> This fix simply adds it to the config.xml so that it can be specified on 
> installation using --variable or modified later by changing the value in the 
> config.xml, removing the plugin using cordova plugin rm and then running 
> cordova prepare which re-adds the plugin with the updated value of the key



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org